rt2x00dev.c 29.4 KB
Newer Older
1
/*
I
Ivo van Doorn 已提交
2
	Copyright (C) 2004 - 2008 rt2x00 SourceForge Project
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
	<http://rt2x00.serialmonkey.com>

	This program is free software; you can redistribute it and/or modify
	it under the terms of the GNU General Public License as published by
	the Free Software Foundation; either version 2 of the License, or
	(at your option) any later version.

	This program is distributed in the hope that it will be useful,
	but WITHOUT ANY WARRANTY; without even the implied warranty of
	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	GNU General Public License for more details.

	You should have received a copy of the GNU General Public License
	along with this program; if not, write to the
	Free Software Foundation, Inc.,
	59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 */

/*
	Module: rt2x00lib
	Abstract: rt2x00 generic device routines.
 */

#include <linux/kernel.h>
#include <linux/module.h>

#include "rt2x00.h"
#include "rt2x00lib.h"

/*
 * Link tuning handlers
 */
35
void rt2x00lib_reset_link_tuner(struct rt2x00_dev *rt2x00dev)
36
{
37 38 39 40 41 42 43 44 45 46 47
	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
		return;

	/*
	 * Reset link information.
	 * Both the currently active vgc level as well as
	 * the link tuner counter should be reset. Resetting
	 * the counter is important for devices where the
	 * device should only perform link tuning during the
	 * first minute after being enabled.
	 */
48 49 50
	rt2x00dev->link.count = 0;
	rt2x00dev->link.vgc_level = 0;

51 52 53 54 55 56 57 58 59 60 61
	/*
	 * Reset the link tuner.
	 */
	rt2x00dev->ops->lib->reset_tuner(rt2x00dev);
}

static void rt2x00lib_start_link_tuner(struct rt2x00_dev *rt2x00dev)
{
	/*
	 * Clear all (possibly) pre-existing quality statistics.
	 */
62 63 64 65 66 67 68 69 70 71 72 73
	memset(&rt2x00dev->link.qual, 0, sizeof(rt2x00dev->link.qual));

	/*
	 * The RX and TX percentage should start at 50%
	 * this will assure we will get at least get some
	 * decent value when the link tuner starts.
	 * The value will be dropped and overwritten with
	 * the correct (measured )value anyway during the
	 * first run of the link tuner.
	 */
	rt2x00dev->link.qual.rx_percentage = 50;
	rt2x00dev->link.qual.tx_percentage = 50;
74

75
	rt2x00lib_reset_link_tuner(rt2x00dev);
76 77 78 79 80 81 82

	queue_delayed_work(rt2x00dev->hw->workqueue,
			   &rt2x00dev->link.work, LINK_TUNE_INTERVAL);
}

static void rt2x00lib_stop_link_tuner(struct rt2x00_dev *rt2x00dev)
{
83
	cancel_delayed_work_sync(&rt2x00dev->link.work);
84 85 86 87 88 89 90 91 92 93 94 95 96 97
}

/*
 * Radio control handlers.
 */
int rt2x00lib_enable_radio(struct rt2x00_dev *rt2x00dev)
{
	int status;

	/*
	 * Don't enable the radio twice.
	 * And check if the hardware button has been disabled.
	 */
	if (test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags) ||
98
	    test_bit(DEVICE_DISABLED_RADIO_HW, &rt2x00dev->flags))
99 100
		return 0;

101
	/*
I
Ivo van Doorn 已提交
102
	 * Initialize all data queues.
103
	 */
I
Ivo van Doorn 已提交
104 105
	rt2x00queue_init_rx(rt2x00dev);
	rt2x00queue_init_tx(rt2x00dev);
106

107 108 109
	/*
	 * Enable radio.
	 */
110 111
	status =
	    rt2x00dev->ops->lib->set_device_state(rt2x00dev, STATE_RADIO_ON);
112 113 114
	if (status)
		return status;

115
	rt2x00leds_led_radio(rt2x00dev, true);
116
	rt2x00led_led_activity(rt2x00dev, true);
117

118 119 120 121 122
	__set_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags);

	/*
	 * Enable RX.
	 */
123
	rt2x00lib_toggle_rx(rt2x00dev, STATE_RADIO_RX_ON);
124 125 126 127

	/*
	 * Start the TX queues.
	 */
128
	ieee80211_wake_queues(rt2x00dev->hw);
129 130 131 132 133 134 135 136 137 138

	return 0;
}

void rt2x00lib_disable_radio(struct rt2x00_dev *rt2x00dev)
{
	if (!__test_and_clear_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
		return;

	/*
139
	 * Stop all scheduled work.
140
	 */
141 142
	if (work_pending(&rt2x00dev->intf_work))
		cancel_work_sync(&rt2x00dev->intf_work);
143 144
	if (work_pending(&rt2x00dev->filter_work))
		cancel_work_sync(&rt2x00dev->filter_work);
145 146 147 148 149 150 151 152 153

	/*
	 * Stop the TX queues.
	 */
	ieee80211_stop_queues(rt2x00dev->hw);

	/*
	 * Disable RX.
	 */
154
	rt2x00lib_toggle_rx(rt2x00dev, STATE_RADIO_RX_OFF);
155 156 157 158 159

	/*
	 * Disable radio.
	 */
	rt2x00dev->ops->lib->set_device_state(rt2x00dev, STATE_RADIO_OFF);
160
	rt2x00led_led_activity(rt2x00dev, false);
161
	rt2x00leds_led_radio(rt2x00dev, false);
162 163
}

164
void rt2x00lib_toggle_rx(struct rt2x00_dev *rt2x00dev, enum dev_state state)
165 166 167 168
{
	/*
	 * When we are disabling the RX, we should also stop the link tuner.
	 */
169
	if (state == STATE_RADIO_RX_OFF)
170 171 172 173 174 175 176
		rt2x00lib_stop_link_tuner(rt2x00dev);

	rt2x00dev->ops->lib->set_device_state(rt2x00dev, state);

	/*
	 * When we are enabling the RX, we should also start the link tuner.
	 */
177
	if (state == STATE_RADIO_RX_ON &&
178
	    (rt2x00dev->intf_ap_count || rt2x00dev->intf_sta_count))
179 180 181
		rt2x00lib_start_link_tuner(rt2x00dev);
}

182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206
static void rt2x00lib_evaluate_antenna_sample(struct rt2x00_dev *rt2x00dev)
{
	enum antenna rx = rt2x00dev->link.ant.active.rx;
	enum antenna tx = rt2x00dev->link.ant.active.tx;
	int sample_a =
	    rt2x00_get_link_ant_rssi_history(&rt2x00dev->link, ANTENNA_A);
	int sample_b =
	    rt2x00_get_link_ant_rssi_history(&rt2x00dev->link, ANTENNA_B);

	/*
	 * We are done sampling. Now we should evaluate the results.
	 */
	rt2x00dev->link.ant.flags &= ~ANTENNA_MODE_SAMPLE;

	/*
	 * During the last period we have sampled the RSSI
	 * from both antenna's. It now is time to determine
	 * which antenna demonstrated the best performance.
	 * When we are already on the antenna with the best
	 * performance, then there really is nothing for us
	 * left to do.
	 */
	if (sample_a == sample_b)
		return;

207 208
	if (rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY)
		rx = (sample_a > sample_b) ? ANTENNA_A : ANTENNA_B;
209

210 211
	if (rt2x00dev->link.ant.flags & ANTENNA_TX_DIVERSITY)
		tx = (sample_a > sample_b) ? ANTENNA_A : ANTENNA_B;
212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231

	rt2x00lib_config_antenna(rt2x00dev, rx, tx);
}

static void rt2x00lib_evaluate_antenna_eval(struct rt2x00_dev *rt2x00dev)
{
	enum antenna rx = rt2x00dev->link.ant.active.rx;
	enum antenna tx = rt2x00dev->link.ant.active.tx;
	int rssi_curr = rt2x00_get_link_ant_rssi(&rt2x00dev->link);
	int rssi_old = rt2x00_update_ant_rssi(&rt2x00dev->link, rssi_curr);

	/*
	 * Legacy driver indicates that we should swap antenna's
	 * when the difference in RSSI is greater that 5. This
	 * also should be done when the RSSI was actually better
	 * then the previous sample.
	 * When the difference exceeds the threshold we should
	 * sample the rssi from the other antenna to make a valid
	 * comparison between the 2 antennas.
	 */
I
Ivo van Doorn 已提交
232
	if (abs(rssi_curr - rssi_old) < 5)
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
		return;

	rt2x00dev->link.ant.flags |= ANTENNA_MODE_SAMPLE;

	if (rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY)
		rx = (rx == ANTENNA_A) ? ANTENNA_B : ANTENNA_A;

	if (rt2x00dev->link.ant.flags & ANTENNA_TX_DIVERSITY)
		tx = (tx == ANTENNA_A) ? ANTENNA_B : ANTENNA_A;

	rt2x00lib_config_antenna(rt2x00dev, rx, tx);
}

static void rt2x00lib_evaluate_antenna(struct rt2x00_dev *rt2x00dev)
{
	/*
	 * Determine if software diversity is enabled for
	 * either the TX or RX antenna (or both).
	 * Always perform this check since within the link
	 * tuner interval the configuration might have changed.
	 */
	rt2x00dev->link.ant.flags &= ~ANTENNA_RX_DIVERSITY;
	rt2x00dev->link.ant.flags &= ~ANTENNA_TX_DIVERSITY;

	if (rt2x00dev->hw->conf.antenna_sel_rx == 0 &&
I
Ivo van Doorn 已提交
258
	    rt2x00dev->default_ant.rx == ANTENNA_SW_DIVERSITY)
259 260
		rt2x00dev->link.ant.flags |= ANTENNA_RX_DIVERSITY;
	if (rt2x00dev->hw->conf.antenna_sel_tx == 0 &&
I
Ivo van Doorn 已提交
261
	    rt2x00dev->default_ant.tx == ANTENNA_SW_DIVERSITY)
262 263 264 265
		rt2x00dev->link.ant.flags |= ANTENNA_TX_DIVERSITY;

	if (!(rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY) &&
	    !(rt2x00dev->link.ant.flags & ANTENNA_TX_DIVERSITY)) {
266
		rt2x00dev->link.ant.flags = 0;
267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
		return;
	}

	/*
	 * If we have only sampled the data over the last period
	 * we should now harvest the data. Otherwise just evaluate
	 * the data. The latter should only be performed once
	 * every 2 seconds.
	 */
	if (rt2x00dev->link.ant.flags & ANTENNA_MODE_SAMPLE)
		rt2x00lib_evaluate_antenna_sample(rt2x00dev);
	else if (rt2x00dev->link.count & 1)
		rt2x00lib_evaluate_antenna_eval(rt2x00dev);
}

static void rt2x00lib_update_link_stats(struct link *link, int rssi)
{
	int avg_rssi = rssi;

	/*
	 * Update global RSSI
	 */
	if (link->qual.avg_rssi)
		avg_rssi = MOVING_AVERAGE(link->qual.avg_rssi, rssi, 8);
	link->qual.avg_rssi = avg_rssi;

	/*
	 * Update antenna RSSI
	 */
	if (link->ant.rssi_ant)
		rssi = MOVING_AVERAGE(link->ant.rssi_ant, rssi, 8);
	link->ant.rssi_ant = rssi;
}

301
static void rt2x00lib_precalculate_link_signal(struct link_qual *qual)
302
{
303 304 305 306
	if (qual->rx_failed || qual->rx_success)
		qual->rx_percentage =
		    (qual->rx_success * 100) /
		    (qual->rx_failed + qual->rx_success);
307
	else
308
		qual->rx_percentage = 50;
309

310 311 312 313
	if (qual->tx_failed || qual->tx_success)
		qual->tx_percentage =
		    (qual->tx_success * 100) /
		    (qual->tx_failed + qual->tx_success);
314
	else
315
		qual->tx_percentage = 50;
316

317 318 319 320
	qual->rx_success = 0;
	qual->rx_failed = 0;
	qual->tx_success = 0;
	qual->tx_failed = 0;
321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
}

static int rt2x00lib_calculate_link_signal(struct rt2x00_dev *rt2x00dev,
					   int rssi)
{
	int rssi_percentage = 0;
	int signal;

	/*
	 * We need a positive value for the RSSI.
	 */
	if (rssi < 0)
		rssi += rt2x00dev->rssi_offset;

	/*
	 * Calculate the different percentages,
	 * which will be used for the signal.
	 */
	if (rt2x00dev->rssi_offset)
		rssi_percentage = (rssi * 100) / rt2x00dev->rssi_offset;

	/*
	 * Add the individual percentages and use the WEIGHT
	 * defines to calculate the current link signal.
	 */
	signal = ((WEIGHT_RSSI * rssi_percentage) +
347 348
		  (WEIGHT_TX * rt2x00dev->link.qual.tx_percentage) +
		  (WEIGHT_RX * rt2x00dev->link.qual.rx_percentage)) / 100;
349 350 351 352 353 354 355 356 357

	return (signal > 100) ? 100 : signal;
}

static void rt2x00lib_link_tuner(struct work_struct *work)
{
	struct rt2x00_dev *rt2x00dev =
	    container_of(work, struct rt2x00_dev, link.work.work);

358 359 360 361 362 363 364
	/*
	 * When the radio is shutting down we should
	 * immediately cease all link tuning.
	 */
	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
		return;

365 366 367
	/*
	 * Update statistics.
	 */
368
	rt2x00dev->ops->lib->link_stats(rt2x00dev, &rt2x00dev->link.qual);
369
	rt2x00dev->low_level_stats.dot11FCSErrorCount +=
370
	    rt2x00dev->link.qual.rx_failed;
371 372 373 374 375 376 377 378

	/*
	 * Only perform the link tuning when Link tuning
	 * has been enabled (This could have been disabled from the EEPROM).
	 */
	if (!test_bit(CONFIG_DISABLE_LINK_TUNING, &rt2x00dev->flags))
		rt2x00dev->ops->lib->link_tuner(rt2x00dev);

379 380 381 382
	/*
	 * Precalculate a portion of the link signal which is
	 * in based on the tx/rx success/failure counters.
	 */
383
	rt2x00lib_precalculate_link_signal(&rt2x00dev->link.qual);
384

385 386 387 388 389
	/*
	 * Send a signal to the led to update the led signal strength.
	 */
	rt2x00leds_led_quality(rt2x00dev, rt2x00dev->link.qual.avg_rssi);

390 391 392 393 394 395
	/*
	 * Evaluate antenna setup, make this the last step since this could
	 * possibly reset some statistics.
	 */
	rt2x00lib_evaluate_antenna(rt2x00dev);

396 397 398 399 400 401 402 403
	/*
	 * Increase tuner counter, and reschedule the next link tuner run.
	 */
	rt2x00dev->link.count++;
	queue_delayed_work(rt2x00dev->hw->workqueue, &rt2x00dev->link.work,
			   LINK_TUNE_INTERVAL);
}

404 405 406 407
static void rt2x00lib_packetfilter_scheduled(struct work_struct *work)
{
	struct rt2x00_dev *rt2x00dev =
	    container_of(work, struct rt2x00_dev, filter_work);
408

409
	rt2x00dev->ops->lib->config_filter(rt2x00dev, rt2x00dev->packet_filter);
410 411
}

412 413
static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac,
					  struct ieee80211_vif *vif)
414
{
415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
	struct rt2x00_dev *rt2x00dev = data;
	struct rt2x00_intf *intf = vif_to_intf(vif);
	struct sk_buff *skb;
	struct ieee80211_bss_conf conf;
	int delayed_flags;

	/*
	 * Copy all data we need during this action under the protection
	 * of a spinlock. Otherwise race conditions might occur which results
	 * into an invalid configuration.
	 */
	spin_lock(&intf->lock);

	memcpy(&conf, &intf->conf, sizeof(conf));
	delayed_flags = intf->delayed_flags;
	intf->delayed_flags = 0;

	spin_unlock(&intf->lock);

	if (delayed_flags & DELAYED_UPDATE_BEACON) {
435 436 437
		skb = ieee80211_beacon_get(rt2x00dev->hw, vif);
		if (skb &&
		    rt2x00dev->ops->hw->beacon_update(rt2x00dev->hw, skb))
438 439 440
			dev_kfree_skb(skb);
	}

441 442
	if (delayed_flags & DELAYED_CONFIG_ERP)
		rt2x00lib_config_erp(rt2x00dev, intf, &intf->conf);
443 444 445

	if (delayed_flags & DELAYED_LED_ASSOC)
		rt2x00leds_led_assoc(rt2x00dev, !!rt2x00dev->intf_associated);
446
}
447

448 449 450 451
static void rt2x00lib_intf_scheduled(struct work_struct *work)
{
	struct rt2x00_dev *rt2x00dev =
	    container_of(work, struct rt2x00_dev, intf_work);
452 453

	/*
454 455
	 * Iterate over each interface and perform the
	 * requested configurations.
456
	 */
457 458 459
	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
					    rt2x00lib_intf_scheduled_iter,
					    rt2x00dev);
460 461
}

462 463 464
/*
 * Interrupt context handlers.
 */
465 466
static void rt2x00lib_beacondone_iter(void *data, u8 *mac,
				      struct ieee80211_vif *vif)
467
{
468
	struct rt2x00_intf *intf = vif_to_intf(vif);
469

470 471
	if (vif->type != IEEE80211_IF_TYPE_AP &&
	    vif->type != IEEE80211_IF_TYPE_IBSS)
472 473
		return;

474 475 476
	spin_lock(&intf->lock);
	intf->delayed_flags |= DELAYED_UPDATE_BEACON;
	spin_unlock(&intf->lock);
477 478 479 480 481 482 483
}

void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
{
	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
		return;

484 485 486
	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
						   rt2x00lib_beacondone_iter,
						   rt2x00dev);
487 488

	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
489 490 491
}
EXPORT_SYMBOL_GPL(rt2x00lib_beacondone);

I
Ivo van Doorn 已提交
492 493
void rt2x00lib_txdone(struct queue_entry *entry,
		      struct txdone_entry_desc *txdesc)
494
{
I
Ivo van Doorn 已提交
495
	struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
496 497 498 499 500 501 502
	struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(entry->skb);

	/*
	 * Send frame to debugfs immediately, after this call is completed
	 * we are going to overwrite the skb->cb array.
	 */
	rt2x00debug_dump_frame(rt2x00dev, DUMP_FRAME_TXDONE, entry->skb);
503 504 505 506

	/*
	 * Update TX statistics.
	 */
I
Ivo van Doorn 已提交
507 508 509 510
	rt2x00dev->link.qual.tx_success +=
	    test_bit(TXDONE_SUCCESS, &txdesc->flags);
	rt2x00dev->link.qual.tx_failed +=
	    txdesc->retry + !!test_bit(TXDONE_FAILURE, &txdesc->flags);
511

I
Ivo van Doorn 已提交
512 513 514
	/*
	 * Initialize TX status
	 */
515 516 517
	memset(&tx_info->status, 0, sizeof(tx_info->status));
	tx_info->status.ack_signal = 0;
	tx_info->status.excessive_retries =
I
Ivo van Doorn 已提交
518
	    test_bit(TXDONE_EXCESSIVE_RETRY, &txdesc->flags);
519
	tx_info->status.retry_count = txdesc->retry;
I
Ivo van Doorn 已提交
520

521
	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
I
Ivo van Doorn 已提交
522
		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
523
			tx_info->flags |= IEEE80211_TX_STAT_ACK;
I
Ivo van Doorn 已提交
524
		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
I
Ivo van Doorn 已提交
525
			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
526 527
	}

528
	if (tx_info->flags & IEEE80211_TX_CTL_USE_RTS_CTS) {
I
Ivo van Doorn 已提交
529
		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
I
Ivo van Doorn 已提交
530
			rt2x00dev->low_level_stats.dot11RTSSuccessCount++;
I
Ivo van Doorn 已提交
531
		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
I
Ivo van Doorn 已提交
532
			rt2x00dev->low_level_stats.dot11RTSFailureCount++;
533 534 535
	}

	/*
536 537 538 539
	 * Only send the status report to mac80211 when TX status was
	 * requested by it. If this was a extra frame coming through
	 * a mac80211 library call (RTS/CTS) then we should not send the
	 * status report back.
540
	 */
541 542
	if (tx_info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS)
		ieee80211_tx_status_irqsafe(rt2x00dev->hw, entry->skb);
543
	else
I
Ivo van Doorn 已提交
544
		dev_kfree_skb_irq(entry->skb);
545 546 547 548
	entry->skb = NULL;
}
EXPORT_SYMBOL_GPL(rt2x00lib_txdone);

I
Ivo van Doorn 已提交
549 550
void rt2x00lib_rxdone(struct queue_entry *entry,
		      struct rxdone_entry_desc *rxdesc)
551
{
I
Ivo van Doorn 已提交
552
	struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
553
	struct ieee80211_rx_status *rx_status = &rt2x00dev->rx_status;
554
	struct ieee80211_supported_band *sband;
555
	struct ieee80211_hdr *hdr;
I
Ivo van Doorn 已提交
556
	const struct rt2x00_rate *rate;
557
	unsigned int i;
I
Ivo van Doorn 已提交
558
	int idx = -1;
559
	u16 fc;
560 561 562 563

	/*
	 * Update RX statistics.
	 */
564 565
	sband = &rt2x00dev->bands[rt2x00dev->curr_band];
	for (i = 0; i < sband->n_bitrates; i++) {
I
Ivo van Doorn 已提交
566
		rate = rt2x00_get_rate(sband->bitrates[i].hw_value);
567

568 569 570 571
		if (((rxdesc->dev_flags & RXDONE_SIGNAL_PLCP) &&
		     (rate->plcp == rxdesc->signal)) ||
		    (!(rxdesc->dev_flags & RXDONE_SIGNAL_PLCP) &&
		      (rate->bitrate == rxdesc->signal))) {
572
			idx = i;
573 574 575 576
			break;
		}
	}

577 578 579 580 581 582 583
	if (idx < 0) {
		WARNING(rt2x00dev, "Frame received with unrecognized signal,"
			"signal=0x%.2x, plcp=%d.\n", rxdesc->signal,
			!!(rxdesc->dev_flags & RXDONE_SIGNAL_PLCP));
		idx = 0;
	}

584
	/*
585
	 * Only update link status if this is a beacon frame carrying our bssid.
586
	 */
I
Ivo van Doorn 已提交
587
	hdr = (struct ieee80211_hdr *)entry->skb->data;
588
	fc = le16_to_cpu(hdr->frame_control);
589
	if (is_beacon(fc) && (rxdesc->dev_flags & RXDONE_MY_BSS))
I
Ivo van Doorn 已提交
590
		rt2x00lib_update_link_stats(&rt2x00dev->link, rxdesc->rssi);
591

592
	rt2x00dev->link.qual.rx_success++;
593

594
	rx_status->rate_idx = idx;
595
	rx_status->qual =
I
Ivo van Doorn 已提交
596
	    rt2x00lib_calculate_link_signal(rt2x00dev, rxdesc->rssi);
597
	rx_status->signal = rxdesc->rssi;
I
Ivo van Doorn 已提交
598
	rx_status->flag = rxdesc->flags;
599
	rx_status->antenna = rt2x00dev->link.ant.active.rx;
600 601

	/*
I
Ivo van Doorn 已提交
602 603
	 * Send frame to mac80211 & debugfs.
	 * mac80211 will clean up the skb structure.
604
	 */
605
	rt2x00debug_dump_frame(rt2x00dev, DUMP_FRAME_RXDONE, entry->skb);
I
Ivo van Doorn 已提交
606 607
	ieee80211_rx_irqsafe(rt2x00dev->hw, entry->skb, rx_status);
	entry->skb = NULL;
608 609 610 611 612 613
}
EXPORT_SYMBOL_GPL(rt2x00lib_rxdone);

/*
 * Driver initialization handlers.
 */
I
Ivo van Doorn 已提交
614 615
const struct rt2x00_rate rt2x00_supported_rates[12] = {
	{
616
		.flags = DEV_RATE_CCK | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
617
		.bitrate = 10,
618
		.ratemask = BIT(0),
I
Ivo van Doorn 已提交
619 620 621
		.plcp = 0x00,
	},
	{
622
		.flags = DEV_RATE_CCK | DEV_RATE_SHORT_PREAMBLE | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
623
		.bitrate = 20,
624
		.ratemask = BIT(1),
I
Ivo van Doorn 已提交
625 626 627
		.plcp = 0x01,
	},
	{
628
		.flags = DEV_RATE_CCK | DEV_RATE_SHORT_PREAMBLE | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
629
		.bitrate = 55,
630
		.ratemask = BIT(2),
I
Ivo van Doorn 已提交
631 632 633
		.plcp = 0x02,
	},
	{
634
		.flags = DEV_RATE_CCK | DEV_RATE_SHORT_PREAMBLE | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
635
		.bitrate = 110,
636
		.ratemask = BIT(3),
I
Ivo van Doorn 已提交
637 638 639
		.plcp = 0x03,
	},
	{
640
		.flags = DEV_RATE_OFDM | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
641
		.bitrate = 60,
642
		.ratemask = BIT(4),
I
Ivo van Doorn 已提交
643 644 645 646 647
		.plcp = 0x0b,
	},
	{
		.flags = DEV_RATE_OFDM,
		.bitrate = 90,
648
		.ratemask = BIT(5),
I
Ivo van Doorn 已提交
649 650 651
		.plcp = 0x0f,
	},
	{
652
		.flags = DEV_RATE_OFDM | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
653
		.bitrate = 120,
654
		.ratemask = BIT(6),
I
Ivo van Doorn 已提交
655 656 657 658 659
		.plcp = 0x0a,
	},
	{
		.flags = DEV_RATE_OFDM,
		.bitrate = 180,
660
		.ratemask = BIT(7),
I
Ivo van Doorn 已提交
661 662 663
		.plcp = 0x0e,
	},
	{
664
		.flags = DEV_RATE_OFDM | DEV_RATE_BASIC,
I
Ivo van Doorn 已提交
665
		.bitrate = 240,
666
		.ratemask = BIT(8),
I
Ivo van Doorn 已提交
667 668 669 670 671
		.plcp = 0x09,
	},
	{
		.flags = DEV_RATE_OFDM,
		.bitrate = 360,
672
		.ratemask = BIT(9),
I
Ivo van Doorn 已提交
673 674 675 676 677
		.plcp = 0x0d,
	},
	{
		.flags = DEV_RATE_OFDM,
		.bitrate = 480,
678
		.ratemask = BIT(10),
I
Ivo van Doorn 已提交
679 680 681 682 683
		.plcp = 0x08,
	},
	{
		.flags = DEV_RATE_OFDM,
		.bitrate = 540,
684
		.ratemask = BIT(11),
I
Ivo van Doorn 已提交
685 686 687 688
		.plcp = 0x0c,
	},
};

689 690 691 692
static void rt2x00lib_channel(struct ieee80211_channel *entry,
			      const int channel, const int tx_power,
			      const int value)
{
693
	entry->center_freq = ieee80211_channel_to_frequency(channel);
694 695 696
	entry->hw_value = value;
	entry->max_power = tx_power;
	entry->max_antenna_gain = 0xff;
697 698 699
}

static void rt2x00lib_rate(struct ieee80211_rate *entry,
I
Ivo van Doorn 已提交
700
			   const u16 index, const struct rt2x00_rate *rate)
701
{
I
Ivo van Doorn 已提交
702 703 704
	entry->flags = 0;
	entry->bitrate = rate->bitrate;
	entry->hw_value = rt2x00_create_rate_hw_value(index, 0);
705
	entry->hw_value_short = entry->hw_value;
I
Ivo van Doorn 已提交
706 707 708 709 710

	if (rate->flags & DEV_RATE_SHORT_PREAMBLE) {
		entry->flags |= IEEE80211_RATE_SHORT_PREAMBLE;
		entry->hw_value_short |= rt2x00_create_rate_hw_value(index, 1);
	}
711 712 713 714 715 716 717 718
}

static int rt2x00lib_probe_hw_modes(struct rt2x00_dev *rt2x00dev,
				    struct hw_mode_spec *spec)
{
	struct ieee80211_hw *hw = rt2x00dev->hw;
	struct ieee80211_channel *channels;
	struct ieee80211_rate *rates;
719
	unsigned int num_rates;
720 721 722
	unsigned int i;
	unsigned char tx_power;

723 724 725 726 727
	num_rates = 0;
	if (spec->supported_rates & SUPPORT_RATE_CCK)
		num_rates += 4;
	if (spec->supported_rates & SUPPORT_RATE_OFDM)
		num_rates += 8;
728 729 730

	channels = kzalloc(sizeof(*channels) * spec->num_channels, GFP_KERNEL);
	if (!channels)
731
		return -ENOMEM;
732

733
	rates = kzalloc(sizeof(*rates) * num_rates, GFP_KERNEL);
734 735 736 737 738 739
	if (!rates)
		goto exit_free_channels;

	/*
	 * Initialize Rate list.
	 */
740
	for (i = 0; i < num_rates; i++)
I
Ivo van Doorn 已提交
741
		rt2x00lib_rate(&rates[i], i, rt2x00_get_rate(i));
742 743 744 745 746

	/*
	 * Initialize Channel list.
	 */
	for (i = 0; i < spec->num_channels; i++) {
747 748 749 750 751 752 753 754 755 756 757
		if (spec->channels[i].channel <= 14) {
			if (spec->tx_power_bg)
				tx_power = spec->tx_power_bg[i];
			else
				tx_power = spec->tx_power_default;
		} else {
			if (spec->tx_power_a)
				tx_power = spec->tx_power_a[i];
			else
				tx_power = spec->tx_power_default;
		}
758 759 760 761 762 763

		rt2x00lib_channel(&channels[i],
				  spec->channels[i].channel, tx_power, i);
	}

	/*
764
	 * Intitialize 802.11b, 802.11g
765
	 * Rates: CCK, OFDM.
766
	 * Channels: 2.4 GHz
767
	 */
768
	if (spec->supported_bands & SUPPORT_BAND_2GHZ) {
769 770 771 772 773 774
		rt2x00dev->bands[IEEE80211_BAND_2GHZ].n_channels = 14;
		rt2x00dev->bands[IEEE80211_BAND_2GHZ].n_bitrates = num_rates;
		rt2x00dev->bands[IEEE80211_BAND_2GHZ].channels = channels;
		rt2x00dev->bands[IEEE80211_BAND_2GHZ].bitrates = rates;
		hw->wiphy->bands[IEEE80211_BAND_2GHZ] =
		    &rt2x00dev->bands[IEEE80211_BAND_2GHZ];
775 776 777 778 779 780 781
	}

	/*
	 * Intitialize 802.11a
	 * Rates: OFDM.
	 * Channels: OFDM, UNII, HiperLAN2.
	 */
782
	if (spec->supported_bands & SUPPORT_BAND_5GHZ) {
783 784 785 786 787 788 789 790
		rt2x00dev->bands[IEEE80211_BAND_5GHZ].n_channels =
		    spec->num_channels - 14;
		rt2x00dev->bands[IEEE80211_BAND_5GHZ].n_bitrates =
		    num_rates - 4;
		rt2x00dev->bands[IEEE80211_BAND_5GHZ].channels = &channels[14];
		rt2x00dev->bands[IEEE80211_BAND_5GHZ].bitrates = &rates[4];
		hw->wiphy->bands[IEEE80211_BAND_5GHZ] =
		    &rt2x00dev->bands[IEEE80211_BAND_5GHZ];
791 792 793 794
	}

	return 0;

795
 exit_free_channels:
796 797 798 799 800 801 802
	kfree(channels);
	ERROR(rt2x00dev, "Allocation ieee80211 modes failed.\n");
	return -ENOMEM;
}

static void rt2x00lib_remove_hw(struct rt2x00_dev *rt2x00dev)
{
803
	if (test_bit(DEVICE_REGISTERED_HW, &rt2x00dev->flags))
804 805
		ieee80211_unregister_hw(rt2x00dev->hw);

806 807 808 809 810
	if (likely(rt2x00dev->hw->wiphy->bands[IEEE80211_BAND_2GHZ])) {
		kfree(rt2x00dev->hw->wiphy->bands[IEEE80211_BAND_2GHZ]->channels);
		kfree(rt2x00dev->hw->wiphy->bands[IEEE80211_BAND_2GHZ]->bitrates);
		rt2x00dev->hw->wiphy->bands[IEEE80211_BAND_2GHZ] = NULL;
		rt2x00dev->hw->wiphy->bands[IEEE80211_BAND_5GHZ] = NULL;
811 812 813 814 815 816 817 818 819 820 821 822 823 824 825
	}
}

static int rt2x00lib_probe_hw(struct rt2x00_dev *rt2x00dev)
{
	struct hw_mode_spec *spec = &rt2x00dev->spec;
	int status;

	/*
	 * Initialize HW modes.
	 */
	status = rt2x00lib_probe_hw_modes(rt2x00dev, spec);
	if (status)
		return status;

826 827 828 829 830
	/*
	 * Initialize HW fields.
	 */
	rt2x00dev->hw->queues = rt2x00dev->ops->tx_queues;

831 832 833 834 835 836 837 838 839
	/*
	 * Register HW.
	 */
	status = ieee80211_register_hw(rt2x00dev->hw);
	if (status) {
		rt2x00lib_remove_hw(rt2x00dev);
		return status;
	}

840
	__set_bit(DEVICE_REGISTERED_HW, &rt2x00dev->flags);
841 842 843 844 845 846 847

	return 0;
}

/*
 * Initialization/uninitialization handlers.
 */
848
static void rt2x00lib_uninitialize(struct rt2x00_dev *rt2x00dev)
849 850 851 852 853
{
	if (!__test_and_clear_bit(DEVICE_INITIALIZED, &rt2x00dev->flags))
		return;

	/*
854
	 * Unregister extra components.
855 856 857 858 859 860 861 862 863
	 */
	rt2x00rfkill_unregister(rt2x00dev);

	/*
	 * Allow the HW to uninitialize.
	 */
	rt2x00dev->ops->lib->uninitialize(rt2x00dev);

	/*
I
Ivo van Doorn 已提交
864
	 * Free allocated queue entries.
865
	 */
I
Ivo van Doorn 已提交
866
	rt2x00queue_uninitialize(rt2x00dev);
867 868
}

869
static int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev)
870 871 872 873 874 875 876
{
	int status;

	if (test_bit(DEVICE_INITIALIZED, &rt2x00dev->flags))
		return 0;

	/*
I
Ivo van Doorn 已提交
877
	 * Allocate all queue entries.
878
	 */
I
Ivo van Doorn 已提交
879 880
	status = rt2x00queue_initialize(rt2x00dev);
	if (status)
881 882 883 884 885 886
		return status;

	/*
	 * Initialize the device.
	 */
	status = rt2x00dev->ops->lib->initialize(rt2x00dev);
887 888 889 890
	if (status) {
		rt2x00queue_uninitialize(rt2x00dev);
		return status;
	}
891 892 893 894

	__set_bit(DEVICE_INITIALIZED, &rt2x00dev->flags);

	/*
895
	 * Register the extra components.
896
	 */
897
	rt2x00rfkill_register(rt2x00dev);
898 899 900 901

	return 0;
}

902 903 904 905 906 907 908 909 910 911 912
int rt2x00lib_start(struct rt2x00_dev *rt2x00dev)
{
	int retval;

	if (test_bit(DEVICE_STARTED, &rt2x00dev->flags))
		return 0;

	/*
	 * If this is the first interface which is added,
	 * we should load the firmware now.
	 */
913 914 915
	retval = rt2x00lib_load_firmware(rt2x00dev);
	if (retval)
		return retval;
916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932

	/*
	 * Initialize the device.
	 */
	retval = rt2x00lib_initialize(rt2x00dev);
	if (retval)
		return retval;

	/*
	 * Enable radio.
	 */
	retval = rt2x00lib_enable_radio(rt2x00dev);
	if (retval) {
		rt2x00lib_uninitialize(rt2x00dev);
		return retval;
	}

933 934 935 936
	rt2x00dev->intf_ap_count = 0;
	rt2x00dev->intf_sta_count = 0;
	rt2x00dev->intf_associated = 0;

937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952
	__set_bit(DEVICE_STARTED, &rt2x00dev->flags);

	return 0;
}

void rt2x00lib_stop(struct rt2x00_dev *rt2x00dev)
{
	if (!test_bit(DEVICE_STARTED, &rt2x00dev->flags))
		return;

	/*
	 * Perhaps we can add something smarter here,
	 * but for now just disabling the radio should do.
	 */
	rt2x00lib_disable_radio(rt2x00dev);

953 954 955 956
	rt2x00dev->intf_ap_count = 0;
	rt2x00dev->intf_sta_count = 0;
	rt2x00dev->intf_associated = 0;

957 958 959
	__clear_bit(DEVICE_STARTED, &rt2x00dev->flags);
}

960 961 962 963 964 965 966
/*
 * driver allocation handlers.
 */
int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
{
	int retval = -ENOMEM;

967 968 969 970 971 972
	/*
	 * Make room for rt2x00_intf inside the per-interface
	 * structure ieee80211_vif.
	 */
	rt2x00dev->hw->vif_data_size = sizeof(struct rt2x00_intf);

973 974 975 976 977 978 979 980 981 982 983 984
	/*
	 * Let the driver probe the device to detect the capabilities.
	 */
	retval = rt2x00dev->ops->lib->probe_hw(rt2x00dev);
	if (retval) {
		ERROR(rt2x00dev, "Failed to allocate device.\n");
		goto exit;
	}

	/*
	 * Initialize configuration work.
	 */
985
	INIT_WORK(&rt2x00dev->intf_work, rt2x00lib_intf_scheduled);
986
	INIT_WORK(&rt2x00dev->filter_work, rt2x00lib_packetfilter_scheduled);
987 988 989
	INIT_DELAYED_WORK(&rt2x00dev->link.work, rt2x00lib_link_tuner);

	/*
I
Ivo van Doorn 已提交
990
	 * Allocate queue array.
991
	 */
I
Ivo van Doorn 已提交
992
	retval = rt2x00queue_allocate(rt2x00dev);
993 994 995 996 997 998 999 1000 1001 1002 1003 1004
	if (retval)
		goto exit;

	/*
	 * Initialize ieee80211 structure.
	 */
	retval = rt2x00lib_probe_hw(rt2x00dev);
	if (retval) {
		ERROR(rt2x00dev, "Failed to initialize hw.\n");
		goto exit;
	}

1005
	/*
1006
	 * Register extra components.
1007 1008
	 */
	rt2x00leds_register(rt2x00dev);
1009
	rt2x00rfkill_allocate(rt2x00dev);
1010 1011
	rt2x00debug_register(rt2x00dev);

1012 1013
	__set_bit(DEVICE_PRESENT, &rt2x00dev->flags);

1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
	return 0;

exit:
	rt2x00lib_remove_dev(rt2x00dev);

	return retval;
}
EXPORT_SYMBOL_GPL(rt2x00lib_probe_dev);

void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
{
1025 1026
	__clear_bit(DEVICE_PRESENT, &rt2x00dev->flags);

1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037
	/*
	 * Disable radio.
	 */
	rt2x00lib_disable_radio(rt2x00dev);

	/*
	 * Uninitialize device.
	 */
	rt2x00lib_uninitialize(rt2x00dev);

	/*
1038
	 * Free extra components
1039 1040 1041
	 */
	rt2x00debug_deregister(rt2x00dev);
	rt2x00rfkill_free(rt2x00dev);
1042 1043
	rt2x00leds_unregister(rt2x00dev);

1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054
	/*
	 * Free ieee80211_hw memory.
	 */
	rt2x00lib_remove_hw(rt2x00dev);

	/*
	 * Free firmware image.
	 */
	rt2x00lib_free_firmware(rt2x00dev);

	/*
I
Ivo van Doorn 已提交
1055
	 * Free queue structures.
1056
	 */
I
Ivo van Doorn 已提交
1057
	rt2x00queue_free(rt2x00dev);
1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069
}
EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);

/*
 * Device state handlers
 */
#ifdef CONFIG_PM
int rt2x00lib_suspend(struct rt2x00_dev *rt2x00dev, pm_message_t state)
{
	int retval;

	NOTICE(rt2x00dev, "Going to sleep.\n");
1070 1071 1072 1073 1074 1075 1076
	__clear_bit(DEVICE_PRESENT, &rt2x00dev->flags);

	/*
	 * Only continue if mac80211 has open interfaces.
	 */
	if (!test_bit(DEVICE_STARTED, &rt2x00dev->flags))
		goto exit;
1077
	__set_bit(DEVICE_STARTED_SUSPEND, &rt2x00dev->flags);
1078 1079

	/*
1080
	 * Disable radio.
1081
	 */
1082
	rt2x00lib_stop(rt2x00dev);
1083
	rt2x00lib_uninitialize(rt2x00dev);
1084 1085 1086 1087

	/*
	 * Suspend/disable extra components.
	 */
1088
	rt2x00leds_suspend(rt2x00dev);
1089
	rt2x00rfkill_suspend(rt2x00dev);
1090 1091
	rt2x00debug_deregister(rt2x00dev);

1092
exit:
1093
	/*
1094 1095 1096 1097 1098 1099 1100 1101 1102
	 * Set device mode to sleep for power management,
	 * on some hardware this call seems to consistently fail.
	 * From the specifications it is hard to tell why it fails,
	 * and if this is a "bad thing".
	 * Overall it is safe to just ignore the failure and
	 * continue suspending. The only downside is that the
	 * device will not be in optimal power save mode, but with
	 * the radio and the other components already disabled the
	 * device is as good as disabled.
1103 1104 1105
	 */
	retval = rt2x00dev->ops->lib->set_device_state(rt2x00dev, STATE_SLEEP);
	if (retval)
1106 1107
		WARNING(rt2x00dev, "Device failed to enter sleep state, "
			"continue suspending.\n");
1108 1109 1110 1111 1112

	return 0;
}
EXPORT_SYMBOL_GPL(rt2x00lib_suspend);

1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134
static void rt2x00lib_resume_intf(void *data, u8 *mac,
				  struct ieee80211_vif *vif)
{
	struct rt2x00_dev *rt2x00dev = data;
	struct rt2x00_intf *intf = vif_to_intf(vif);

	spin_lock(&intf->lock);

	rt2x00lib_config_intf(rt2x00dev, intf,
			      vif->type, intf->mac, intf->bssid);


	/*
	 * Master or Ad-hoc mode require a new beacon update.
	 */
	if (vif->type == IEEE80211_IF_TYPE_AP ||
	    vif->type == IEEE80211_IF_TYPE_IBSS)
		intf->delayed_flags |= DELAYED_UPDATE_BEACON;

	spin_unlock(&intf->lock);
}

1135 1136 1137 1138 1139 1140 1141
int rt2x00lib_resume(struct rt2x00_dev *rt2x00dev)
{
	int retval;

	NOTICE(rt2x00dev, "Waking up.\n");

	/*
1142
	 * Restore/enable extra components.
1143 1144
	 */
	rt2x00debug_register(rt2x00dev);
1145
	rt2x00rfkill_resume(rt2x00dev);
1146
	rt2x00leds_resume(rt2x00dev);
1147

1148
	/*
1149
	 * Only continue if mac80211 had open interfaces.
1150
	 */
1151
	if (!__test_and_clear_bit(DEVICE_STARTED_SUSPEND, &rt2x00dev->flags))
1152 1153
		return 0;

1154 1155 1156
	/*
	 * Reinitialize device and all active interfaces.
	 */
1157
	retval = rt2x00lib_start(rt2x00dev);
1158 1159 1160 1161 1162 1163
	if (retval)
		goto exit;

	/*
	 * Reconfigure device.
	 */
1164 1165 1166
	rt2x00lib_config(rt2x00dev, &rt2x00dev->hw->conf, 1);
	if (!rt2x00dev->hw->conf.radio_enabled)
		rt2x00lib_disable_radio(rt2x00dev);
1167

1168 1169 1170 1171 1172 1173
	/*
	 * Iterator over each active interface to
	 * reconfigure the hardware.
	 */
	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
					    rt2x00lib_resume_intf, rt2x00dev);
1174

1175 1176 1177 1178 1179
	/*
	 * We are ready again to receive requests from mac80211.
	 */
	__set_bit(DEVICE_PRESENT, &rt2x00dev->flags);

1180 1181 1182 1183 1184 1185
	/*
	 * It is possible that during that mac80211 has attempted
	 * to send frames while we were suspending or resuming.
	 * In that case we have disabled the TX queue and should
	 * now enable it again
	 */
1186
	ieee80211_wake_queues(rt2x00dev->hw);
1187

1188
	/*
1189 1190 1191
	 * During interface iteration we might have changed the
	 * delayed_flags, time to handles the event by calling
	 * the work handler directly.
1192
	 */
1193
	rt2x00lib_intf_scheduled(&rt2x00dev->intf_work);
1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213

	return 0;

exit:
	rt2x00lib_disable_radio(rt2x00dev);
	rt2x00lib_uninitialize(rt2x00dev);
	rt2x00debug_deregister(rt2x00dev);

	return retval;
}
EXPORT_SYMBOL_GPL(rt2x00lib_resume);
#endif /* CONFIG_PM */

/*
 * rt2x00lib module information.
 */
MODULE_AUTHOR(DRV_PROJECT);
MODULE_VERSION(DRV_VERSION);
MODULE_DESCRIPTION("rt2x00 library");
MODULE_LICENSE("GPL");