feat.c 16.0 KB
Newer Older
1 2 3 4 5 6
/*
 *  net/dccp/feat.c
 *
 *  An implementation of the DCCP protocol
 *  Andrea Bittau <a.bittau@cs.ucl.ac.uk>
 *
7 8 9 10 11 12 13 14 15 16
 *  ASSUMPTIONS
 *  -----------
 *  o All currently known SP features have 1-byte quantities. If in the future
 *    extensions of RFCs 4340..42 define features with item lengths larger than
 *    one byte, a feature-specific extension of the code will be required.
 *
 *  This program is free software; you can redistribute it and/or
 *  modify it under the terms of the GNU General Public License
 *  as published by the Free Software Foundation; either version
 *  2 of the License, or (at your option) any later version.
17 18 19 20
 */

#include <linux/module.h>

21
#include "ccid.h"
22 23 24 25
#include "feat.h"

#define DCCP_FEAT_SP_NOAGREE (-123)

26 27 28 29 30 31 32 33 34 35 36 37 38 39
/* copy constructor, fval must not already contain allocated memory */
static int dccp_feat_clone_sp_val(dccp_feat_val *fval, u8 const *val, u8 len)
{
	fval->sp.len = len;
	if (fval->sp.len > 0) {
		fval->sp.vec = kmemdup(val, len, gfp_any());
		if (fval->sp.vec == NULL) {
			fval->sp.len = 0;
			return -ENOBUFS;
		}
	}
	return 0;
}

40 41
int dccp_feat_change(struct dccp_minisock *dmsk, u8 type, u8 feature,
		     u8 *val, u8 len, gfp_t gfp)
42 43 44
{
	struct dccp_opt_pend *opt;

45
	dccp_feat_debug(type, feature, *val);
46

47
	if (len > 3) {
48
		DCCP_WARN("invalid length %d\n", len);
49
		return -EINVAL;
50 51
	}
	/* XXX add further sanity checks */
52

53
	/* check if that feature is already being negotiated */
54
	list_for_each_entry(opt, &dmsk->dccpms_pending, dccpop_node) {
55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
		/* ok we found a negotiation for this option already */
		if (opt->dccpop_feat == feature && opt->dccpop_type == type) {
			dccp_pr_debug("Replacing old\n");
			/* replace */
			BUG_ON(opt->dccpop_val == NULL);
			kfree(opt->dccpop_val);
			opt->dccpop_val	 = val;
			opt->dccpop_len	 = len;
			opt->dccpop_conf = 0;
			return 0;
		}
	}

	/* negotiation for a new feature */
	opt = kmalloc(sizeof(*opt), gfp);
	if (opt == NULL)
		return -ENOMEM;

	opt->dccpop_type = type;
	opt->dccpop_feat = feature;
	opt->dccpop_len	 = len;
	opt->dccpop_val	 = val;
	opt->dccpop_conf = 0;
	opt->dccpop_sc	 = NULL;

	BUG_ON(opt->dccpop_val == NULL);

82
	list_add_tail(&opt->dccpop_node, &dmsk->dccpms_pending);
83 84 85 86 87
	return 0;
}

EXPORT_SYMBOL_GPL(dccp_feat_change);

88 89 90
static int dccp_feat_update_ccid(struct sock *sk, u8 type, u8 new_ccid_nr)
{
	struct dccp_sock *dp = dccp_sk(sk);
91
	struct dccp_minisock *dmsk = dccp_msk(sk);
92 93
	/* figure out if we are changing our CCID or the peer's */
	const int rx = type == DCCPO_CHANGE_R;
94
	const u8 ccid_nr = rx ? dmsk->dccpms_rx_ccid : dmsk->dccpms_tx_ccid;
95 96 97 98 99 100 101 102 103 104 105 106 107
	struct ccid *new_ccid;

	/* Check if nothing is being changed. */
	if (ccid_nr == new_ccid_nr)
		return 0;

	new_ccid = ccid_new(new_ccid_nr, sk, rx, GFP_ATOMIC);
	if (new_ccid == NULL)
		return -ENOMEM;

	if (rx) {
		ccid_hc_rx_delete(dp->dccps_hc_rx_ccid, sk);
		dp->dccps_hc_rx_ccid = new_ccid;
108
		dmsk->dccpms_rx_ccid = new_ccid_nr;
109 110 111
	} else {
		ccid_hc_tx_delete(dp->dccps_hc_tx_ccid, sk);
		dp->dccps_hc_tx_ccid = new_ccid;
112
		dmsk->dccpms_tx_ccid = new_ccid_nr;
113 114 115 116 117
	}

	return 0;
}

118 119
static int dccp_feat_update(struct sock *sk, u8 type, u8 feat, u8 val)
{
120
	dccp_feat_debug(type, feat, val);
121 122 123 124 125

	switch (feat) {
	case DCCPF_CCID:
		return dccp_feat_update_ccid(sk, type, val);
	default:
126 127
		dccp_pr_debug("UNIMPLEMENTED: %s(%d, ...)\n",
			      dccp_feat_typename(type), feat);
128 129
		break;
	}
130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179
	return 0;
}

static int dccp_feat_reconcile(struct sock *sk, struct dccp_opt_pend *opt,
			       u8 *rpref, u8 rlen)
{
	struct dccp_sock *dp = dccp_sk(sk);
	u8 *spref, slen, *res = NULL;
	int i, j, rc, agree = 1;

	BUG_ON(rpref == NULL);

	/* check if we are the black sheep */
	if (dp->dccps_role == DCCP_ROLE_CLIENT) {
		spref = rpref;
		slen  = rlen;
		rpref = opt->dccpop_val;
		rlen  = opt->dccpop_len;
	} else {
		spref = opt->dccpop_val;
		slen  = opt->dccpop_len;
	}
	/*
	 * Now we have server preference list in spref and client preference in
	 * rpref
	 */
	BUG_ON(spref == NULL);
	BUG_ON(rpref == NULL);

	/* FIXME sanity check vals */

	/* Are values in any order?  XXX Lame "algorithm" here */
	for (i = 0; i < slen; i++) {
		for (j = 0; j < rlen; j++) {
			if (spref[i] == rpref[j]) {
				res = &spref[i];
				break;
			}
		}
		if (res)
			break;
	}

	/* we didn't agree on anything */
	if (res == NULL) {
		/* confirm previous value */
		switch (opt->dccpop_feat) {
		case DCCPF_CCID:
			/* XXX did i get this right? =P */
			if (opt->dccpop_type == DCCPO_CHANGE_L)
180
				res = &dccp_msk(sk)->dccpms_tx_ccid;
181
			else
182
				res = &dccp_msk(sk)->dccpms_rx_ccid;
183 184 185
			break;

		default:
186 187
			DCCP_BUG("Fell through, feat=%d", opt->dccpop_feat);
			/* XXX implement res */
188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226
			return -EFAULT;
		}

		dccp_pr_debug("Don't agree... reconfirming %d\n", *res);
		agree = 0; /* this is used for mandatory options... */
	}

	/* need to put result and our preference list */
	rlen = 1 + opt->dccpop_len;
	rpref = kmalloc(rlen, GFP_ATOMIC);
	if (rpref == NULL)
		return -ENOMEM;

	*rpref = *res;
	memcpy(&rpref[1], opt->dccpop_val, opt->dccpop_len);

	/* put it in the "confirm queue" */
	if (opt->dccpop_sc == NULL) {
		opt->dccpop_sc = kmalloc(sizeof(*opt->dccpop_sc), GFP_ATOMIC);
		if (opt->dccpop_sc == NULL) {
			kfree(rpref);
			return -ENOMEM;
		}
	} else {
		/* recycle the confirm slot */
		BUG_ON(opt->dccpop_sc->dccpoc_val == NULL);
		kfree(opt->dccpop_sc->dccpoc_val);
		dccp_pr_debug("recycling confirm slot\n");
	}
	memset(opt->dccpop_sc, 0, sizeof(*opt->dccpop_sc));

	opt->dccpop_sc->dccpoc_val = rpref;
	opt->dccpop_sc->dccpoc_len = rlen;

	/* update the option on our side [we are about to send the confirm] */
	rc = dccp_feat_update(sk, opt->dccpop_type, opt->dccpop_feat, *res);
	if (rc) {
		kfree(opt->dccpop_sc->dccpoc_val);
		kfree(opt->dccpop_sc);
227
		opt->dccpop_sc = NULL;
228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
		return rc;
	}

	dccp_pr_debug("Will confirm %d\n", *rpref);

	/* say we want to change to X but we just got a confirm X, suppress our
	 * change
	 */
	if (!opt->dccpop_conf) {
		if (*opt->dccpop_val == *res)
			opt->dccpop_conf = 1;
		dccp_pr_debug("won't ask for change of same feature\n");
	}

	return agree ? 0 : DCCP_FEAT_SP_NOAGREE; /* used for mandatory opts */
}

static int dccp_feat_sp(struct sock *sk, u8 type, u8 feature, u8 *val, u8 len)
{
247
	struct dccp_minisock *dmsk = dccp_msk(sk);
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
	struct dccp_opt_pend *opt;
	int rc = 1;
	u8 t;

	/*
	 * We received a CHANGE.  We gotta match it against our own preference
	 * list.  If we got a CHANGE_R it means it's a change for us, so we need
	 * to compare our CHANGE_L list.
	 */
	if (type == DCCPO_CHANGE_L)
		t = DCCPO_CHANGE_R;
	else
		t = DCCPO_CHANGE_L;

	/* find our preference list for this feature */
263
	list_for_each_entry(opt, &dmsk->dccpms_pending, dccpop_node) {
264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
		if (opt->dccpop_type != t || opt->dccpop_feat != feature)
			continue;

		/* find the winner from the two preference lists */
		rc = dccp_feat_reconcile(sk, opt, val, len);
		break;
	}

	/* We didn't deal with the change.  This can happen if we have no
	 * preference list for the feature.  In fact, it just shouldn't
	 * happen---if we understand a feature, we should have a preference list
	 * with at least the default value.
	 */
	BUG_ON(rc == 1);

	return rc;
}

static int dccp_feat_nn(struct sock *sk, u8 type, u8 feature, u8 *val, u8 len)
{
	struct dccp_opt_pend *opt;
285
	struct dccp_minisock *dmsk = dccp_msk(sk);
286 287 288
	u8 *copy;
	int rc;

289 290 291 292
	/* NN features must be Change L (sec. 6.3.2) */
	if (type != DCCPO_CHANGE_L) {
		dccp_pr_debug("received %s for NN feature %d\n",
				dccp_feat_typename(type), feature);
293 294 295 296 297 298 299 300 301 302
		return -EFAULT;
	}

	/* XXX sanity check opt val */

	/* copy option so we can confirm it */
	opt = kzalloc(sizeof(*opt), GFP_ATOMIC);
	if (opt == NULL)
		return -ENOMEM;

A
Arnaldo Carvalho de Melo 已提交
303
	copy = kmemdup(val, len, GFP_ATOMIC);
304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321
	if (copy == NULL) {
		kfree(opt);
		return -ENOMEM;
	}

	opt->dccpop_type = DCCPO_CONFIRM_R; /* NN can only confirm R */
	opt->dccpop_feat = feature;
	opt->dccpop_val	 = copy;
	opt->dccpop_len	 = len;

	/* change feature */
	rc = dccp_feat_update(sk, type, feature, *val);
	if (rc) {
		kfree(opt->dccpop_val);
		kfree(opt);
		return rc;
	}

322 323
	dccp_feat_debug(type, feature, *copy);

324
	list_add_tail(&opt->dccpop_node, &dmsk->dccpms_conf);
325 326 327 328

	return 0;
}

329 330
static void dccp_feat_empty_confirm(struct dccp_minisock *dmsk,
				    u8 type, u8 feature)
331 332 333 334 335 336 337 338 339 340 341
{
	/* XXX check if other confirms for that are queued and recycle slot */
	struct dccp_opt_pend *opt = kzalloc(sizeof(*opt), GFP_ATOMIC);

	if (opt == NULL) {
		/* XXX what do we do?  Ignoring should be fine.  It's a change
		 * after all =P
		 */
		return;
	}

342
	switch (type) {
343 344 345 346 347 348 349 350 351 352
	case DCCPO_CHANGE_L:
		opt->dccpop_type = DCCPO_CONFIRM_R;
		break;
	case DCCPO_CHANGE_R:
		opt->dccpop_type = DCCPO_CONFIRM_L;
		break;
	default:
		DCCP_WARN("invalid type %d\n", type);
		kfree(opt);
		return;
353
	}
354
	opt->dccpop_feat = feature;
355
	opt->dccpop_val	 = NULL;
356 357 358
	opt->dccpop_len	 = 0;

	/* change feature */
359 360
	dccp_pr_debug("Empty %s(%d)\n", dccp_feat_typename(type), feature);

361
	list_add_tail(&opt->dccpop_node, &dmsk->dccpms_conf);
362 363 364 365
}

static void dccp_feat_flush_confirm(struct sock *sk)
{
366
	struct dccp_minisock *dmsk = dccp_msk(sk);
367
	/* Check if there is anything to confirm in the first place */
368
	int yes = !list_empty(&dmsk->dccpms_conf);
369 370 371 372

	if (!yes) {
		struct dccp_opt_pend *opt;

373
		list_for_each_entry(opt, &dmsk->dccpms_pending, dccpop_node) {
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
			if (opt->dccpop_conf) {
				yes = 1;
				break;
			}
		}
	}

	if (!yes)
		return;

	/* OK there is something to confirm... */
	/* XXX check if packet is in flight?  Send delayed ack?? */
	if (sk->sk_state == DCCP_OPEN)
		dccp_send_ack(sk);
}

int dccp_feat_change_recv(struct sock *sk, u8 type, u8 feature, u8 *val, u8 len)
{
	int rc;

394
	dccp_feat_debug(type, feature, *val);
395 396 397 398 399 400 401 402 403 404 405 406 407 408 409

	/* figure out if it's SP or NN feature */
	switch (feature) {
	/* deal with SP features */
	case DCCPF_CCID:
		rc = dccp_feat_sp(sk, type, feature, val, len);
		break;

	/* deal with NN features */
	case DCCPF_ACK_RATIO:
		rc = dccp_feat_nn(sk, type, feature, val, len);
		break;

	/* XXX implement other features */
	default:
410 411
		dccp_pr_debug("UNIMPLEMENTED: not handling %s(%d, ...)\n",
			      dccp_feat_typename(type), feature);
412 413 414 415 416 417 418 419 420 421 422
		rc = -EFAULT;
		break;
	}

	/* check if there were problems changing features */
	if (rc) {
		/* If we don't agree on SP, we sent a confirm for old value.
		 * However we propagate rc to caller in case option was
		 * mandatory
		 */
		if (rc != DCCP_FEAT_SP_NOAGREE)
423
			dccp_feat_empty_confirm(dccp_msk(sk), type, feature);
424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
	}

	/* generate the confirm [if required] */
	dccp_feat_flush_confirm(sk);

	return rc;
}

EXPORT_SYMBOL_GPL(dccp_feat_change_recv);

int dccp_feat_confirm_recv(struct sock *sk, u8 type, u8 feature,
			   u8 *val, u8 len)
{
	u8 t;
	struct dccp_opt_pend *opt;
439
	struct dccp_minisock *dmsk = dccp_msk(sk);
440
	int found = 0;
441 442
	int all_confirmed = 1;

443
	dccp_feat_debug(type, feature, *val);
444 445

	/* locate our change request */
446 447 448
	switch (type) {
	case DCCPO_CONFIRM_L: t = DCCPO_CHANGE_R; break;
	case DCCPO_CONFIRM_R: t = DCCPO_CHANGE_L; break;
449
	default:	      DCCP_WARN("invalid type %d\n", type);
450 451 452 453
			      return 1;

	}
	/* XXX sanity check feature value */
454

455
	list_for_each_entry(opt, &dmsk->dccpms_pending, dccpop_node) {
456 457
		if (!opt->dccpop_conf && opt->dccpop_type == t &&
		    opt->dccpop_feat == feature) {
458 459 460
			found = 1;
			dccp_pr_debug("feature %d found\n", opt->dccpop_feat);

461 462 463 464 465 466 467 468
			/* XXX do sanity check */

			opt->dccpop_conf = 1;

			/* We got a confirmation---change the option */
			dccp_feat_update(sk, opt->dccpop_type,
					 opt->dccpop_feat, *val);

469
			/* XXX check the return value of dccp_feat_update */
470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487
			break;
		}

		if (!opt->dccpop_conf)
			all_confirmed = 0;
	}

	/* fix re-transmit timer */
	/* XXX gotta make sure that no option negotiation occurs during
	 * connection shutdown.  Consider that the CLOSEREQ is sent and timer is
	 * on.  if all options are confirmed it might kill timer which should
	 * remain alive until close is received.
	 */
	if (all_confirmed) {
		dccp_pr_debug("clear feat negotiation timer %p\n", sk);
		inet_csk_clear_xmit_timer(sk, ICSK_TIME_RETRANS);
	}

488 489 490
	if (!found)
		dccp_pr_debug("%s(%d, ...) never requested\n",
			      dccp_feat_typename(type), feature);
491 492 493 494 495
	return 0;
}

EXPORT_SYMBOL_GPL(dccp_feat_confirm_recv);

496
void dccp_feat_clean(struct dccp_minisock *dmsk)
497 498 499
{
	struct dccp_opt_pend *opt, *next;

500
	list_for_each_entry_safe(opt, next, &dmsk->dccpms_pending,
501
				 dccpop_node) {
502 503
		BUG_ON(opt->dccpop_val == NULL);
		kfree(opt->dccpop_val);
504 505 506 507 508 509 510

		if (opt->dccpop_sc != NULL) {
			BUG_ON(opt->dccpop_sc->dccpoc_val == NULL);
			kfree(opt->dccpop_sc->dccpoc_val);
			kfree(opt->dccpop_sc);
		}

511 512
		kfree(opt);
	}
513
	INIT_LIST_HEAD(&dmsk->dccpms_pending);
514

515
	list_for_each_entry_safe(opt, next, &dmsk->dccpms_conf, dccpop_node) {
516 517 518 519 520
		BUG_ON(opt == NULL);
		if (opt->dccpop_val != NULL)
			kfree(opt->dccpop_val);
		kfree(opt);
	}
521
	INIT_LIST_HEAD(&dmsk->dccpms_conf);
522 523 524 525 526 527 528 529 530 531
}

EXPORT_SYMBOL_GPL(dccp_feat_clean);

/* this is to be called only when a listening sock creates its child.  It is
 * assumed by the function---the confirm is not duplicated, but rather it is
 * "passed on".
 */
int dccp_feat_clone(struct sock *oldsk, struct sock *newsk)
{
532 533
	struct dccp_minisock *olddmsk = dccp_msk(oldsk);
	struct dccp_minisock *newdmsk = dccp_msk(newsk);
534 535 536
	struct dccp_opt_pend *opt;
	int rc = 0;

537 538
	INIT_LIST_HEAD(&newdmsk->dccpms_pending);
	INIT_LIST_HEAD(&newdmsk->dccpms_conf);
539

540
	list_for_each_entry(opt, &olddmsk->dccpms_pending, dccpop_node) {
541 542
		struct dccp_opt_pend *newopt;
		/* copy the value of the option */
A
Arnaldo Carvalho de Melo 已提交
543
		u8 *val = kmemdup(opt->dccpop_val, opt->dccpop_len, GFP_ATOMIC);
544 545 546 547

		if (val == NULL)
			goto out_clean;

A
Arnaldo Carvalho de Melo 已提交
548
		newopt = kmemdup(opt, sizeof(*newopt), GFP_ATOMIC);
549 550 551 552 553 554 555
		if (newopt == NULL) {
			kfree(val);
			goto out_clean;
		}

		/* insert the option */
		newopt->dccpop_val = val;
556
		list_add_tail(&newopt->dccpop_node, &newdmsk->dccpms_pending);
557 558 559 560 561

		/* XXX what happens with backlogs and multiple connections at
		 * once...
		 */
		/* the master socket no longer needs to worry about confirms */
562
		opt->dccpop_sc = NULL; /* it's not a memleak---new socket has it */
563 564 565 566 567 568 569 570 571 572 573

		/* reset state for a new socket */
		opt->dccpop_conf = 0;
	}

	/* XXX not doing anything about the conf queue */

out:
	return rc;

out_clean:
574
	dccp_feat_clean(newdmsk);
575 576 577 578 579 580
	rc = -ENOMEM;
	goto out;
}

EXPORT_SYMBOL_GPL(dccp_feat_clone);

581 582
static int __dccp_feat_init(struct dccp_minisock *dmsk, u8 type, u8 feat,
			    u8 *val, u8 len)
583 584
{
	int rc = -ENOMEM;
A
Arnaldo Carvalho de Melo 已提交
585
	u8 *copy = kmemdup(val, len, GFP_KERNEL);
586 587

	if (copy != NULL) {
588
		rc = dccp_feat_change(dmsk, type, feat, copy, len, GFP_KERNEL);
589 590 591 592 593 594
		if (rc)
			kfree(copy);
	}
	return rc;
}

595
int dccp_feat_init(struct dccp_minisock *dmsk)
596 597 598
{
	int rc;

599 600
	INIT_LIST_HEAD(&dmsk->dccpms_pending);
	INIT_LIST_HEAD(&dmsk->dccpms_conf);
601 602

	/* CCID L */
603
	rc = __dccp_feat_init(dmsk, DCCPO_CHANGE_L, DCCPF_CCID,
604
			      &dmsk->dccpms_tx_ccid, 1);
605 606 607 608
	if (rc)
		goto out;

	/* CCID R */
609
	rc = __dccp_feat_init(dmsk, DCCPO_CHANGE_R, DCCPF_CCID,
610
			      &dmsk->dccpms_rx_ccid, 1);
611 612 613 614
	if (rc)
		goto out;

	/* Ack ratio */
615
	rc = __dccp_feat_init(dmsk, DCCPO_CHANGE_L, DCCPF_ACK_RATIO,
616
			      &dmsk->dccpms_ack_ratio, 1);
617 618 619 620 621
out:
	return rc;
}

EXPORT_SYMBOL_GPL(dccp_feat_init);
622 623 624 625 626 627 628 629 630 631

#ifdef CONFIG_IP_DCCP_DEBUG
const char *dccp_feat_typename(const u8 type)
{
	switch(type) {
	case DCCPO_CHANGE_L:  return("ChangeL");
	case DCCPO_CONFIRM_L: return("ConfirmL");
	case DCCPO_CHANGE_R:  return("ChangeR");
	case DCCPO_CONFIRM_R: return("ConfirmR");
	/* the following case must not appear in feature negotation  */
632
	default:	      dccp_pr_debug("unknown type %d [BUG!]\n", type);
633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652
	}
	return NULL;
}

EXPORT_SYMBOL_GPL(dccp_feat_typename);

const char *dccp_feat_name(const u8 feat)
{
	static const char *feature_names[] = {
		[DCCPF_RESERVED]	= "Reserved",
		[DCCPF_CCID]		= "CCID",
		[DCCPF_SHORT_SEQNOS]	= "Allow Short Seqnos",
		[DCCPF_SEQUENCE_WINDOW]	= "Sequence Window",
		[DCCPF_ECN_INCAPABLE]	= "ECN Incapable",
		[DCCPF_ACK_RATIO]	= "Ack Ratio",
		[DCCPF_SEND_ACK_VECTOR]	= "Send ACK Vector",
		[DCCPF_SEND_NDP_COUNT]	= "Send NDP Count",
		[DCCPF_MIN_CSUM_COVER]	= "Min. Csum Coverage",
		[DCCPF_DATA_CHECKSUM]	= "Send Data Checksum",
	};
653 654 655
	if (feat > DCCPF_DATA_CHECKSUM && feat < DCCPF_MIN_CCID_SPECIFIC)
		return feature_names[DCCPF_RESERVED];

656 657 658 659 660 661 662 663
	if (feat >= DCCPF_MIN_CCID_SPECIFIC)
		return "CCID-specific";

	return feature_names[feat];
}

EXPORT_SYMBOL_GPL(dccp_feat_name);
#endif /* CONFIG_IP_DCCP_DEBUG */