intel_dp_mst.c 18.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*
 * Copyright © 2008 Intel Corporation
 *             2014 Red Hat Inc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 * IN THE SOFTWARE.
 *
 */

#include <drm/drmP.h>
#include "i915_drv.h"
#include "intel_drv.h"
29
#include <drm/drm_atomic_helper.h>
30 31 32 33
#include <drm/drm_crtc_helper.h>
#include <drm/drm_edid.h>

static bool intel_dp_mst_compute_config(struct intel_encoder *encoder,
34 35
					struct intel_crtc_state *pipe_config,
					struct drm_connector_state *conn_state)
36 37 38 39
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
	struct intel_dp *intel_dp = &intel_dig_port->dp;
L
Libin Yang 已提交
40 41
	struct intel_connector *connector =
		to_intel_connector(conn_state->connector);
42
	struct drm_atomic_state *state;
43
	int bpp;
44
	int lane_count, slots;
45
	const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
46 47 48 49
	int mst_pbn;

	pipe_config->has_pch_encoder = false;
	bpp = 24;
50 51 52 53 54
	if (intel_dp->compliance.test_data.bpc) {
		bpp = intel_dp->compliance.test_data.bpc * 3;
		DRM_DEBUG_KMS("Setting pipe bpp to %d\n",
			      bpp);
	}
55 56 57 58 59
	/*
	 * for MST we always configure max link bw - the spec doesn't
	 * seem to suggest we should do otherwise.
	 */
	lane_count = drm_dp_max_lane_count(intel_dp->dpcd);
60

61
	pipe_config->lane_count = lane_count;
62

63
	pipe_config->pipe_bpp = bpp;
64
	pipe_config->port_clock = intel_dp_max_link_rate(intel_dp);
65

66 67
	state = pipe_config->base.state;

L
Libin Yang 已提交
68 69
	if (drm_dp_mst_port_has_audio(&intel_dp->mst_mgr, connector->port))
		pipe_config->has_audio = true;
70
	mst_pbn = drm_dp_calc_pbn_mode(adjusted_mode->crtc_clock, bpp);
71 72 73 74 75 76 77 78 79 80

	pipe_config->pbn = mst_pbn;
	slots = drm_dp_find_vcpi_slots(&intel_dp->mst_mgr, mst_pbn);

	intel_link_compute_m_n(bpp, lane_count,
			       adjusted_mode->crtc_clock,
			       pipe_config->port_clock,
			       &pipe_config->dp_m_n);

	pipe_config->dp_m_n.tu = slots;
81

82 83 84 85
	return true;

}

86 87 88
static void intel_mst_disable_dp(struct intel_encoder *encoder,
				 struct intel_crtc_state *old_crtc_state,
				 struct drm_connector_state *old_conn_state)
89 90 91 92
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
	struct intel_dp *intel_dp = &intel_dig_port->dp;
93 94
	struct intel_connector *connector =
		to_intel_connector(old_conn_state->connector);
95 96
	int ret;

97
	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
98

99
	drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
100 101 102 103 104

	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
	if (ret) {
		DRM_ERROR("failed to update payload %d\n", ret);
	}
105
	if (old_crtc_state->has_audio)
L
Libin Yang 已提交
106
		intel_audio_codec_disable(encoder);
107 108
}

109 110 111
static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
				      struct intel_crtc_state *old_crtc_state,
				      struct drm_connector_state *old_conn_state)
112 113 114 115
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
	struct intel_dp *intel_dp = &intel_dig_port->dp;
116 117
	struct intel_connector *connector =
		to_intel_connector(old_conn_state->connector);
118

119
	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
120 121 122 123 124 125

	/* this can fail */
	drm_dp_check_act_status(&intel_dp->mst_mgr);
	/* and this can also fail */
	drm_dp_update_payload_part2(&intel_dp->mst_mgr);

126
	drm_dp_mst_deallocate_vcpi(&intel_dp->mst_mgr, connector->port);
127

128
	intel_dp->active_mst_links--;
129 130

	intel_mst->connector = NULL;
131
	if (intel_dp->active_mst_links == 0) {
132 133 134
		intel_dig_port->base.post_disable(&intel_dig_port->base,
						  NULL, NULL);

135 136 137 138
		intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
	}
}

139 140 141
static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
				    struct intel_crtc_state *pipe_config,
				    struct drm_connector_state *conn_state)
142 143 144 145
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
	struct intel_dp *intel_dp = &intel_dig_port->dp;
146
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
147
	enum port port = intel_dig_port->port;
148 149
	struct intel_connector *connector =
		to_intel_connector(conn_state->connector);
150 151 152 153
	int ret;
	uint32_t temp;
	int slots;

154 155 156
	/* MST encoders are bound to a crtc, not to a connector,
	 * force the mapping here for get_hw_state.
	 */
157 158
	connector->encoder = encoder;
	intel_mst->connector = connector;
159

160
	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
161

162 163 164
	if (intel_dp->active_mst_links == 0)
		intel_dig_port->base.pre_enable(&intel_dig_port->base,
						pipe_config, NULL);
165 166

	ret = drm_dp_mst_allocate_vcpi(&intel_dp->mst_mgr,
167 168
				       connector->port,
				       pipe_config->pbn, &slots);
169 170 171 172 173 174
	if (ret == false) {
		DRM_ERROR("failed to allocate vcpi\n");
		return;
	}


175
	intel_dp->active_mst_links++;
176 177 178 179 180 181
	temp = I915_READ(DP_TP_STATUS(port));
	I915_WRITE(DP_TP_STATUS(port), temp);

	ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
}

182 183 184
static void intel_mst_enable_dp(struct intel_encoder *encoder,
				struct intel_crtc_state *pipe_config,
				struct drm_connector_state *conn_state)
185 186 187 188
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
	struct intel_dp *intel_dp = &intel_dig_port->dp;
189
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
190 191 192
	enum port port = intel_dig_port->port;
	int ret;

193
	DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
194

195 196 197 198 199
	if (intel_wait_for_register(dev_priv,
				    DP_TP_STATUS(port),
				    DP_TP_STATUS_ACT_SENT,
				    DP_TP_STATUS_ACT_SENT,
				    1))
200 201 202 203 204
		DRM_ERROR("Timed out waiting for ACT sent\n");

	ret = drm_dp_check_act_status(&intel_dp->mst_mgr);

	ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
205
	if (pipe_config->has_audio)
L
Libin Yang 已提交
206
		intel_audio_codec_enable(encoder, pipe_config, conn_state);
207 208 209 210 211 212 213
}

static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
				      enum pipe *pipe)
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	*pipe = intel_mst->pipe;
214
	if (intel_mst->connector)
215 216 217 218 219
		return true;
	return false;
}

static void intel_dp_mst_enc_get_config(struct intel_encoder *encoder,
220
					struct intel_crtc_state *pipe_config)
221 222 223
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(&encoder->base);
	struct intel_digital_port *intel_dig_port = intel_mst->primary;
224 225
	struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
226
	enum transcoder cpu_transcoder = pipe_config->cpu_transcoder;
227 228
	u32 temp, flags = 0;

L
Libin Yang 已提交
229 230 231
	pipe_config->has_audio =
		intel_ddi_is_audio_enabled(dev_priv, crtc);

232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257
	temp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
	if (temp & TRANS_DDI_PHSYNC)
		flags |= DRM_MODE_FLAG_PHSYNC;
	else
		flags |= DRM_MODE_FLAG_NHSYNC;
	if (temp & TRANS_DDI_PVSYNC)
		flags |= DRM_MODE_FLAG_PVSYNC;
	else
		flags |= DRM_MODE_FLAG_NVSYNC;

	switch (temp & TRANS_DDI_BPC_MASK) {
	case TRANS_DDI_BPC_6:
		pipe_config->pipe_bpp = 18;
		break;
	case TRANS_DDI_BPC_8:
		pipe_config->pipe_bpp = 24;
		break;
	case TRANS_DDI_BPC_10:
		pipe_config->pipe_bpp = 30;
		break;
	case TRANS_DDI_BPC_12:
		pipe_config->pipe_bpp = 36;
		break;
	default:
		break;
	}
258
	pipe_config->base.adjusted_mode.flags |= flags;
259 260 261 262

	pipe_config->lane_count =
		((temp & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;

263 264 265 266 267 268 269 270 271 272 273 274
	intel_dp_get_m_n(crtc, pipe_config);

	intel_ddi_clock_get(&intel_dig_port->base, pipe_config);
}

static int intel_dp_mst_get_ddc_modes(struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct intel_dp *intel_dp = intel_connector->mst_port;
	struct edid *edid;
	int ret;

275 276 277
	if (!intel_dp) {
		return intel_connector_update_modes(connector, NULL);
	}
278

279
	edid = drm_dp_mst_get_edid(connector, &intel_dp->mst_mgr, intel_connector->port);
280 281 282 283 284 285 286
	ret = intel_connector_update_modes(connector, edid);
	kfree(edid);

	return ret;
}

static enum drm_connector_status
287
intel_dp_mst_detect(struct drm_connector *connector, bool force)
288 289 290 291
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct intel_dp *intel_dp = intel_connector->mst_port;

292 293
	if (!intel_dp)
		return connector_status_disconnected;
294
	return drm_dp_mst_detect_port(connector, &intel_dp->mst_mgr, intel_connector->port);
295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317
}

static int
intel_dp_mst_set_property(struct drm_connector *connector,
			  struct drm_property *property,
			  uint64_t val)
{
	return 0;
}

static void
intel_dp_mst_connector_destroy(struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);

	if (!IS_ERR_OR_NULL(intel_connector->edid))
		kfree(intel_connector->edid);

	drm_connector_cleanup(connector);
	kfree(connector);
}

static const struct drm_connector_funcs intel_dp_mst_connector_funcs = {
318
	.dpms = drm_atomic_helper_connector_dpms,
319 320 321
	.detect = intel_dp_mst_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.set_property = intel_dp_mst_set_property,
322
	.atomic_get_property = intel_connector_atomic_get_property,
323
	.late_register = intel_connector_register,
324
	.early_unregister = intel_connector_unregister,
325
	.destroy = intel_dp_mst_connector_destroy,
326
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
327
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
328 329 330 331 332 333 334 335 336 337 338
};

static int intel_dp_mst_get_modes(struct drm_connector *connector)
{
	return intel_dp_mst_get_ddc_modes(connector);
}

static enum drm_mode_status
intel_dp_mst_mode_valid(struct drm_connector *connector,
			struct drm_display_mode *mode)
{
339 340
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct intel_dp *intel_dp = intel_connector->mst_port;
341
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
342 343 344 345 346 347 348 349
	int bpp = 24; /* MST uses fixed bpp */
	int max_rate, mode_rate, max_lanes, max_link_clock;

	max_link_clock = intel_dp_max_link_rate(intel_dp);
	max_lanes = drm_dp_max_lane_count(intel_dp->dpcd);

	max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes);
	mode_rate = intel_dp_link_required(mode->clock, bpp);
350

351 352 353 354 355 356 357
	/* TODO - validate mode against available PBN for link */
	if (mode->clock < 10000)
		return MODE_CLOCK_LOW;

	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
		return MODE_H_ILLEGAL;

358
	if (mode_rate > max_rate || mode->clock > max_dotclk)
359 360
		return MODE_CLOCK_HIGH;

361 362 363
	return MODE_OK;
}

364 365 366 367 368 369 370
static struct drm_encoder *intel_mst_atomic_best_encoder(struct drm_connector *connector,
							 struct drm_connector_state *state)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct intel_dp *intel_dp = intel_connector->mst_port;
	struct intel_crtc *crtc = to_intel_crtc(state->crtc);

371 372
	if (!intel_dp)
		return NULL;
373 374 375
	return &intel_dp->mst_encoders[crtc->pipe]->base.base;
}

376 377 378 379
static struct drm_encoder *intel_mst_best_encoder(struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct intel_dp *intel_dp = intel_connector->mst_port;
380 381
	if (!intel_dp)
		return NULL;
382 383 384 385 386 387
	return &intel_dp->mst_encoders[0]->base.base;
}

static const struct drm_connector_helper_funcs intel_dp_mst_connector_helper_funcs = {
	.get_modes = intel_dp_mst_get_modes,
	.mode_valid = intel_dp_mst_mode_valid,
388
	.atomic_best_encoder = intel_mst_atomic_best_encoder,
389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
	.best_encoder = intel_mst_best_encoder,
};

static void intel_dp_mst_encoder_destroy(struct drm_encoder *encoder)
{
	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);

	drm_encoder_cleanup(encoder);
	kfree(intel_mst);
}

static const struct drm_encoder_funcs intel_dp_mst_enc_funcs = {
	.destroy = intel_dp_mst_encoder_destroy,
};

static bool intel_dp_mst_get_hw_state(struct intel_connector *connector)
{
406
	if (connector->encoder && connector->base.state->crtc) {
407 408 409 410 411 412 413 414
		enum pipe pipe;
		if (!connector->encoder->get_hw_state(connector->encoder, &pipe))
			return false;
		return true;
	}
	return false;
}

415 416
static void intel_connector_add_to_fbdev(struct intel_connector *connector)
{
417
#ifdef CONFIG_DRM_FBDEV_EMULATION
418
	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
419 420 421 422

	if (dev_priv->fbdev)
		drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper,
						&connector->base);
423 424 425 426 427
#endif
}

static void intel_connector_remove_from_fbdev(struct intel_connector *connector)
{
428
#ifdef CONFIG_DRM_FBDEV_EMULATION
429
	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
430 431 432 433

	if (dev_priv->fbdev)
		drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper,
						   &connector->base);
434 435 436
#endif
}

437
static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, const char *pathprop)
438 439 440 441 442 443 444 445
{
	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
	struct intel_connector *intel_connector;
	struct drm_connector *connector;
	int i;

446
	intel_connector = intel_connector_alloc();
447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
	if (!intel_connector)
		return NULL;

	connector = &intel_connector->base;
	drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs, DRM_MODE_CONNECTOR_DisplayPort);
	drm_connector_helper_add(connector, &intel_dp_mst_connector_helper_funcs);

	intel_connector->get_hw_state = intel_dp_mst_get_hw_state;
	intel_connector->mst_port = intel_dp;
	intel_connector->port = port;

	for (i = PIPE_A; i <= PIPE_C; i++) {
		drm_mode_connector_attach_encoder(&intel_connector->base,
						  &intel_dp->mst_encoders[i]->base.base);
	}
	intel_dp_add_properties(intel_dp, connector);

	drm_object_attach_property(&connector->base, dev->mode_config.path_property, 0);
465 466
	drm_object_attach_property(&connector->base, dev->mode_config.tile_property, 0);

467
	drm_mode_connector_set_path_property(connector, pathprop);
468 469 470 471 472 473 474
	return connector;
}

static void intel_dp_register_mst_connector(struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_device *dev = connector->dev;
475

476
	drm_modeset_lock_all(dev);
477
	intel_connector_add_to_fbdev(intel_connector);
478
	drm_modeset_unlock_all(dev);
479

480 481 482 483 484 485 486 487
	drm_connector_register(&intel_connector->base);
}

static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
					   struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_device *dev = connector->dev;
488

489
	drm_connector_unregister(connector);
490

491
	/* need to nuke the connector */
492
	drm_modeset_lock_all(dev);
493
	intel_connector_remove_from_fbdev(intel_connector);
494
	intel_connector->mst_port = NULL;
495
	drm_modeset_unlock_all(dev);
496

497
	drm_connector_unreference(&intel_connector->base);
498 499 500 501 502 503 504 505 506 507 508 509
	DRM_DEBUG_KMS("\n");
}

static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
{
	struct intel_dp *intel_dp = container_of(mgr, struct intel_dp, mst_mgr);
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;

	drm_kms_helper_hotplug_event(dev);
}

510
static const struct drm_dp_mst_topology_cbs mst_cbs = {
511
	.add_connector = intel_dp_add_mst_connector,
512
	.register_connector = intel_dp_register_mst_connector,
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
	.destroy_connector = intel_dp_destroy_mst_connector,
	.hotplug = intel_dp_mst_hotplug,
};

static struct intel_dp_mst_encoder *
intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum pipe pipe)
{
	struct intel_dp_mst_encoder *intel_mst;
	struct intel_encoder *intel_encoder;
	struct drm_device *dev = intel_dig_port->base.base.dev;

	intel_mst = kzalloc(sizeof(*intel_mst), GFP_KERNEL);

	if (!intel_mst)
		return NULL;

	intel_mst->pipe = pipe;
	intel_encoder = &intel_mst->base;
	intel_mst->primary = intel_dig_port;

	drm_encoder_init(dev, &intel_encoder->base, &intel_dp_mst_enc_funcs,
534
			 DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe));
535 536

	intel_encoder->type = INTEL_OUTPUT_DP_MST;
537
	intel_encoder->power_domain = intel_dig_port->base.power_domain;
538
	intel_encoder->port = intel_dig_port->port;
539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576
	intel_encoder->crtc_mask = 0x7;
	intel_encoder->cloneable = 0;

	intel_encoder->compute_config = intel_dp_mst_compute_config;
	intel_encoder->disable = intel_mst_disable_dp;
	intel_encoder->post_disable = intel_mst_post_disable_dp;
	intel_encoder->pre_enable = intel_mst_pre_enable_dp;
	intel_encoder->enable = intel_mst_enable_dp;
	intel_encoder->get_hw_state = intel_dp_mst_enc_get_hw_state;
	intel_encoder->get_config = intel_dp_mst_enc_get_config;

	return intel_mst;

}

static bool
intel_dp_create_fake_mst_encoders(struct intel_digital_port *intel_dig_port)
{
	int i;
	struct intel_dp *intel_dp = &intel_dig_port->dp;

	for (i = PIPE_A; i <= PIPE_C; i++)
		intel_dp->mst_encoders[i] = intel_dp_create_fake_mst_encoder(intel_dig_port, i);
	return true;
}

int
intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_base_id)
{
	struct intel_dp *intel_dp = &intel_dig_port->dp;
	struct drm_device *dev = intel_dig_port->base.base.dev;
	int ret;

	intel_dp->can_mst = true;
	intel_dp->mst_mgr.cbs = &mst_cbs;

	/* create encoders */
	intel_dp_create_fake_mst_encoders(intel_dig_port);
577 578
	ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, dev,
					   &intel_dp->aux, 16, 3, conn_base_id);
579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596
	if (ret) {
		intel_dp->can_mst = false;
		return ret;
	}
	return 0;
}

void
intel_dp_mst_encoder_cleanup(struct intel_digital_port *intel_dig_port)
{
	struct intel_dp *intel_dp = &intel_dig_port->dp;

	if (!intel_dp->can_mst)
		return;

	drm_dp_mst_topology_mgr_destroy(&intel_dp->mst_mgr);
	/* encoders will get killed by normal cleanup */
}