mmu.c 13.9 KB
Newer Older
J
Jeremy Fitzhardinge 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
/*
 * Xen mmu operations
 *
 * This file contains the various mmu fetch and update operations.
 * The most important job they must perform is the mapping between the
 * domain's pfn and the overall machine mfns.
 *
 * Xen allows guests to directly update the pagetable, in a controlled
 * fashion.  In other words, the guest modifies the same pagetable
 * that the CPU actually uses, which eliminates the overhead of having
 * a separate shadow pagetable.
 *
 * In order to allow this, it falls on the guest domain to map its
 * notion of a "physical" pfn - which is just a domain-local linear
 * address - into a real "machine address" which the CPU's MMU can
 * use.
 *
 * A pgd_t/pmd_t/pte_t will typically contain an mfn, and so can be
 * inserted directly into the pagetable.  When creating a new
 * pte/pmd/pgd, it converts the passed pfn into an mfn.  Conversely,
 * when reading the content back with __(pgd|pmd|pte)_val, it converts
 * the mfn back into a pfn.
 *
 * The other constraint is that all pages which make up a pagetable
 * must be mapped read-only in the guest.  This prevents uncontrolled
 * guest updates to the pagetable.  Xen strictly enforces this, and
 * will disallow any pagetable update which will end up mapping a
 * pagetable page RW, and will disallow using any writable page as a
 * pagetable.
 *
 * Naively, when loading %cr3 with the base of a new pagetable, Xen
 * would need to validate the whole pagetable before going on.
 * Naturally, this is quite slow.  The solution is to "pin" a
 * pagetable, which enforces all the constraints on the pagetable even
 * when it is not actively in use.  This menas that Xen can be assured
 * that it is still valid when you do load it into %cr3, and doesn't
 * need to revalidate it.
 *
 * Jeremy Fitzhardinge <jeremy@xensource.com>, XenSource Inc, 2007
 */
41
#include <linux/sched.h>
42
#include <linux/highmem.h>
J
Jeremy Fitzhardinge 已提交
43 44 45 46 47
#include <linux/bug.h>

#include <asm/pgtable.h>
#include <asm/tlbflush.h>
#include <asm/mmu_context.h>
48
#include <asm/paravirt.h>
J
Jeremy Fitzhardinge 已提交
49 50

#include <asm/xen/hypercall.h>
51
#include <asm/xen/hypervisor.h>
J
Jeremy Fitzhardinge 已提交
52 53 54 55

#include <xen/page.h>
#include <xen/interface/xen.h>

56
#include "multicalls.h"
J
Jeremy Fitzhardinge 已提交
57 58 59 60
#include "mmu.h"

xmaddr_t arbitrary_virt_to_machine(unsigned long address)
{
61
	unsigned int level;
62
	pte_t *pte = lookup_address(address, &level);
63
	unsigned offset = address & ~PAGE_MASK;
J
Jeremy Fitzhardinge 已提交
64 65 66 67 68 69 70 71 72 73

	BUG_ON(pte == NULL);

	return XMADDR((pte_mfn(*pte) << PAGE_SHIFT) + offset);
}

void make_lowmem_page_readonly(void *vaddr)
{
	pte_t *pte, ptev;
	unsigned long address = (unsigned long)vaddr;
74
	unsigned int level;
J
Jeremy Fitzhardinge 已提交
75

76
	pte = lookup_address(address, &level);
J
Jeremy Fitzhardinge 已提交
77 78 79 80 81 82 83 84 85 86 87 88
	BUG_ON(pte == NULL);

	ptev = pte_wrprotect(*pte);

	if (HYPERVISOR_update_va_mapping(address, ptev, 0))
		BUG();
}

void make_lowmem_page_readwrite(void *vaddr)
{
	pte_t *pte, ptev;
	unsigned long address = (unsigned long)vaddr;
89
	unsigned int level;
J
Jeremy Fitzhardinge 已提交
90

91
	pte = lookup_address(address, &level);
J
Jeremy Fitzhardinge 已提交
92 93 94 95 96 97 98 99 100 101 102
	BUG_ON(pte == NULL);

	ptev = pte_mkwrite(*pte);

	if (HYPERVISOR_update_va_mapping(address, ptev, 0))
		BUG();
}


void xen_set_pmd(pmd_t *ptr, pmd_t val)
{
J
Jeremy Fitzhardinge 已提交
103 104
	struct multicall_space mcs;
	struct mmu_update *u;
J
Jeremy Fitzhardinge 已提交
105

J
Jeremy Fitzhardinge 已提交
106 107 108 109 110 111 112 113 114 115 116
	preempt_disable();

	mcs = xen_mc_entry(sizeof(*u));
	u = mcs.args;
	u->ptr = virt_to_machine(ptr).maddr;
	u->val = pmd_val_ma(val);
	MULTI_mmu_update(mcs.mc, u, 1, NULL, DOMID_SELF);

	xen_mc_issue(PARAVIRT_LAZY_MMU);

	preempt_enable();
J
Jeremy Fitzhardinge 已提交
117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
}

/*
 * Associate a virtual page frame with a given physical page frame
 * and protection flags for that frame.
 */
void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
{
	pgd_t *pgd;
	pud_t *pud;
	pmd_t *pmd;
	pte_t *pte;

	pgd = swapper_pg_dir + pgd_index(vaddr);
	if (pgd_none(*pgd)) {
		BUG();
		return;
	}
	pud = pud_offset(pgd, vaddr);
	if (pud_none(*pud)) {
		BUG();
		return;
	}
	pmd = pmd_offset(pud, vaddr);
	if (pmd_none(*pmd)) {
		BUG();
		return;
	}
	pte = pte_offset_kernel(pmd, vaddr);
	/* <mfn,flags> stored as-is, to permit clearing entries */
	xen_set_pte(pte, mfn_pte(mfn, flags));

	/*
	 * It's enough to flush this one mapping.
	 * (PGE mappings get flushed as well)
	 */
	__flush_tlb_one(vaddr);
}

void xen_set_pte_at(struct mm_struct *mm, unsigned long addr,
		    pte_t *ptep, pte_t pteval)
{
159 160 161 162
	/* updates to init_mm may be done without lock */
	if (mm == &init_mm)
		preempt_disable();

J
Jeremy Fitzhardinge 已提交
163
	if (mm == current->mm || mm == &init_mm) {
164
		if (paravirt_get_lazy_mode() == PARAVIRT_LAZY_MMU) {
J
Jeremy Fitzhardinge 已提交
165 166 167 168 169
			struct multicall_space mcs;
			mcs = xen_mc_entry(0);

			MULTI_update_va_mapping(mcs.mc, addr, pteval, 0);
			xen_mc_issue(PARAVIRT_LAZY_MMU);
170
			goto out;
J
Jeremy Fitzhardinge 已提交
171 172
		} else
			if (HYPERVISOR_update_va_mapping(addr, pteval, 0) == 0)
173
				goto out;
J
Jeremy Fitzhardinge 已提交
174 175
	}
	xen_set_pte(ptep, pteval);
176 177 178 179

out:
	if (mm == &init_mm)
		preempt_enable();
J
Jeremy Fitzhardinge 已提交
180 181
}

J
Jeremy Fitzhardinge 已提交
182 183
/* Assume pteval_t is equivalent to all the other *val_t types. */
static pteval_t pte_mfn_to_pfn(pteval_t val)
J
Jeremy Fitzhardinge 已提交
184
{
J
Jeremy Fitzhardinge 已提交
185 186 187 188 189
	if (val & _PAGE_PRESENT) {
		unsigned long mfn = (val & PTE_MASK) >> PAGE_SHIFT;
		pteval_t flags = val & ~PTE_MASK;
		val = (mfn_to_pfn(mfn) << PAGE_SHIFT) | flags;
	}
J
Jeremy Fitzhardinge 已提交
190

J
Jeremy Fitzhardinge 已提交
191 192
	return val;
}
J
Jeremy Fitzhardinge 已提交
193

J
Jeremy Fitzhardinge 已提交
194 195 196 197 198 199 200 201 202 203 204 205 206 207
static pteval_t pte_pfn_to_mfn(pteval_t val)
{
	if (val & _PAGE_PRESENT) {
		unsigned long pfn = (val & PTE_MASK) >> PAGE_SHIFT;
		pteval_t flags = val & ~PTE_MASK;
		val = (pfn_to_mfn(pfn) << PAGE_SHIFT) | flags;
	}

	return val;
}

pteval_t xen_pte_val(pte_t pte)
{
	return pte_mfn_to_pfn(pte.pte);
J
Jeremy Fitzhardinge 已提交
208 209 210 211
}

pgdval_t xen_pgd_val(pgd_t pgd)
{
J
Jeremy Fitzhardinge 已提交
212
	return pte_mfn_to_pfn(pgd.pgd);
J
Jeremy Fitzhardinge 已提交
213 214 215 216
}

pte_t xen_make_pte(pteval_t pte)
{
J
Jeremy Fitzhardinge 已提交
217 218
	pte = pte_pfn_to_mfn(pte);
	return native_make_pte(pte);
J
Jeremy Fitzhardinge 已提交
219 220 221 222
}

pgd_t xen_make_pgd(pgdval_t pgd)
{
J
Jeremy Fitzhardinge 已提交
223 224
	pgd = pte_pfn_to_mfn(pgd);
	return native_make_pgd(pgd);
J
Jeremy Fitzhardinge 已提交
225 226 227 228
}

pmdval_t xen_pmd_val(pmd_t pmd)
{
J
Jeremy Fitzhardinge 已提交
229
	return pte_mfn_to_pfn(pmd.pmd);
J
Jeremy Fitzhardinge 已提交
230
}
231

232 233
void xen_set_pud(pud_t *ptr, pud_t val)
{
J
Jeremy Fitzhardinge 已提交
234 235
	struct multicall_space mcs;
	struct mmu_update *u;
236

J
Jeremy Fitzhardinge 已提交
237 238 239 240 241 242 243 244 245 246 247
	preempt_disable();

	mcs = xen_mc_entry(sizeof(*u));
	u = mcs.args;
	u->ptr = virt_to_machine(ptr).maddr;
	u->val = pud_val_ma(val);
	MULTI_mmu_update(mcs.mc, u, 1, NULL, DOMID_SELF);

	xen_mc_issue(PARAVIRT_LAZY_MMU);

	preempt_enable();
248 249 250 251 252 253 254 255 256
}

void xen_set_pte(pte_t *ptep, pte_t pte)
{
	ptep->pte_high = pte.pte_high;
	smp_wmb();
	ptep->pte_low = pte.pte_low;
}

J
Jeremy Fitzhardinge 已提交
257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
void xen_set_pte_atomic(pte_t *ptep, pte_t pte)
{
	set_64bit((u64 *)ptep, pte_val_ma(pte));
}

void xen_pte_clear(struct mm_struct *mm, unsigned long addr, pte_t *ptep)
{
	ptep->pte_low = 0;
	smp_wmb();		/* make sure low gets written first */
	ptep->pte_high = 0;
}

void xen_pmd_clear(pmd_t *pmdp)
{
	xen_set_pmd(pmdp, __pmd(0));
}

274
pmd_t xen_make_pmd(pmdval_t pmd)
J
Jeremy Fitzhardinge 已提交
275
{
J
Jeremy Fitzhardinge 已提交
276
	pmd = pte_pfn_to_mfn(pmd);
J
Jeremy Fitzhardinge 已提交
277
	return native_make_pmd(pmd);
J
Jeremy Fitzhardinge 已提交
278 279
}

280 281 282 283 284 285 286 287 288 289
/*
  (Yet another) pagetable walker.  This one is intended for pinning a
  pagetable.  This means that it walks a pagetable and calls the
  callback function on each page it finds making up the page table,
  at every level.  It walks the entire pagetable, but it only bothers
  pinning pte pages which are below pte_limit.  In the normal case
  this will be TASK_SIZE, but at boot we need to pin up to
  FIXADDR_TOP.  But the important bit is that we don't pin beyond
  there, because then we start getting into Xen's ptes.
*/
290
static int pgd_walk(pgd_t *pgd_base, int (*func)(struct page *, enum pt_level),
291
		    unsigned long limit)
J
Jeremy Fitzhardinge 已提交
292 293
{
	pgd_t *pgd = pgd_base;
294 295 296 297 298
	int flush = 0;
	unsigned long addr = 0;
	unsigned long pgd_next;

	BUG_ON(limit > FIXADDR_TOP);
J
Jeremy Fitzhardinge 已提交
299 300

	if (xen_feature(XENFEAT_auto_translated_physmap))
301 302 303 304 305
		return 0;

	for (; addr != FIXADDR_TOP; pgd++, addr = pgd_next) {
		pud_t *pud;
		unsigned long pud_limit, pud_next;
J
Jeremy Fitzhardinge 已提交
306

307 308 309
		pgd_next = pud_limit = pgd_addr_end(addr, FIXADDR_TOP);

		if (!pgd_val(*pgd))
J
Jeremy Fitzhardinge 已提交
310
			continue;
311

J
Jeremy Fitzhardinge 已提交
312 313 314
		pud = pud_offset(pgd, 0);

		if (PTRS_PER_PUD > 1) /* not folded */
315
			flush |= (*func)(virt_to_page(pud), PT_PUD);
316 317 318 319 320 321 322 323 324 325 326

		for (; addr != pud_limit; pud++, addr = pud_next) {
			pmd_t *pmd;
			unsigned long pmd_limit;

			pud_next = pud_addr_end(addr, pud_limit);

			if (pud_next < limit)
				pmd_limit = pud_next;
			else
				pmd_limit = limit;
J
Jeremy Fitzhardinge 已提交
327 328 329

			if (pud_none(*pud))
				continue;
330

J
Jeremy Fitzhardinge 已提交
331 332 333
			pmd = pmd_offset(pud, 0);

			if (PTRS_PER_PMD > 1) /* not folded */
334
				flush |= (*func)(virt_to_page(pmd), PT_PMD);
335 336 337 338 339 340 341

			for (; addr != pmd_limit; pmd++) {
				addr += (PAGE_SIZE * PTRS_PER_PTE);
				if ((pmd_limit-1) < (addr-1)) {
					addr = pmd_limit;
					break;
				}
J
Jeremy Fitzhardinge 已提交
342 343 344 345

				if (pmd_none(*pmd))
					continue;

346
				flush |= (*func)(pmd_page(*pmd), PT_PTE);
J
Jeremy Fitzhardinge 已提交
347 348 349 350
			}
		}
	}

351
	flush |= (*func)(virt_to_page(pgd_base), PT_PGD);
352 353

	return flush;
J
Jeremy Fitzhardinge 已提交
354 355
}

356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386
static spinlock_t *lock_pte(struct page *page)
{
	spinlock_t *ptl = NULL;

#if NR_CPUS >= CONFIG_SPLIT_PTLOCK_CPUS
	ptl = __pte_lockptr(page);
	spin_lock(ptl);
#endif

	return ptl;
}

static void do_unlock(void *v)
{
	spinlock_t *ptl = v;
	spin_unlock(ptl);
}

static void xen_do_pin(unsigned level, unsigned long pfn)
{
	struct mmuext_op *op;
	struct multicall_space mcs;

	mcs = __xen_mc_entry(sizeof(*op));
	op = mcs.args;
	op->cmd = level;
	op->arg1.mfn = pfn_to_mfn(pfn);
	MULTI_mmuext_op(mcs.mc, op, 1, NULL, DOMID_SELF);
}

static int pin_page(struct page *page, enum pt_level level)
387
{
388
	unsigned pgfl = TestSetPagePinned(page);
389 390 391 392 393 394 395 396 397 398 399 400
	int flush;

	if (pgfl)
		flush = 0;		/* already pinned */
	else if (PageHighMem(page))
		/* kmaps need flushing if we found an unpinned
		   highpage */
		flush = 1;
	else {
		void *pt = lowmem_page_address(page);
		unsigned long pfn = page_to_pfn(page);
		struct multicall_space mcs = __xen_mc_entry(0);
401
		spinlock_t *ptl;
402 403 404

		flush = 0;

405 406 407 408
		ptl = NULL;
		if (level == PT_PTE)
			ptl = lock_pte(page);

409 410
		MULTI_update_va_mapping(mcs.mc, (unsigned long)pt,
					pfn_pte(pfn, PAGE_KERNEL_RO),
411 412 413 414 415 416 417 418 419 420
					level == PT_PGD ? UVMF_TLB_FLUSH : 0);

		if (level == PT_PTE)
			xen_do_pin(MMUEXT_PIN_L1_TABLE, pfn);

		if (ptl) {
			/* Queue a deferred unlock for when this batch
			   is completed. */
			xen_mc_callback(do_unlock, ptl);
		}
421 422 423 424
	}

	return flush;
}
J
Jeremy Fitzhardinge 已提交
425

426 427 428
/* This is called just after a mm has been created, but it has not
   been used yet.  We need to make sure that its pagetable is all
   read-only, and can be pinned. */
J
Jeremy Fitzhardinge 已提交
429 430
void xen_pgd_pin(pgd_t *pgd)
{
431
	xen_mc_batch();
J
Jeremy Fitzhardinge 已提交
432

J
Jeremy Fitzhardinge 已提交
433 434 435
	if (pgd_walk(pgd, pin_page, TASK_SIZE)) {
		/* re-enable interrupts for kmap_flush_unused */
		xen_mc_issue(0);
436
		kmap_flush_unused();
J
Jeremy Fitzhardinge 已提交
437 438
		xen_mc_batch();
	}
439

440
	xen_do_pin(MMUEXT_PIN_L3_TABLE, PFN_DOWN(__pa(pgd)));
441
	xen_mc_issue(0);
J
Jeremy Fitzhardinge 已提交
442 443
}

444 445 446
/* The init_mm pagetable is really pinned as soon as its created, but
   that's before we have page structures to store the bits.  So do all
   the book-keeping now. */
447
static __init int mark_pinned(struct page *page, enum pt_level level)
J
Jeremy Fitzhardinge 已提交
448
{
449 450 451
	SetPagePinned(page);
	return 0;
}
J
Jeremy Fitzhardinge 已提交
452

453 454 455 456
void __init xen_mark_init_mm_pinned(void)
{
	pgd_walk(init_mm.pgd, mark_pinned, FIXADDR_TOP);
}
J
Jeremy Fitzhardinge 已提交
457

458
static int unpin_page(struct page *page, enum pt_level level)
459
{
460
	unsigned pgfl = TestClearPagePinned(page);
J
Jeremy Fitzhardinge 已提交
461

462 463 464
	if (pgfl && !PageHighMem(page)) {
		void *pt = lowmem_page_address(page);
		unsigned long pfn = page_to_pfn(page);
465 466 467 468 469 470 471 472 473 474
		spinlock_t *ptl = NULL;
		struct multicall_space mcs;

		if (level == PT_PTE) {
			ptl = lock_pte(page);

			xen_do_pin(MMUEXT_UNPIN_TABLE, pfn);
		}

		mcs = __xen_mc_entry(0);
475 476 477

		MULTI_update_va_mapping(mcs.mc, (unsigned long)pt,
					pfn_pte(pfn, PAGE_KERNEL),
478 479 480 481 482 483
					level == PT_PGD ? UVMF_TLB_FLUSH : 0);

		if (ptl) {
			/* unlock when batch completed */
			xen_mc_callback(do_unlock, ptl);
		}
484 485 486
	}

	return 0;		/* never need to flush on unpin */
J
Jeremy Fitzhardinge 已提交
487 488
}

489 490 491 492 493
/* Release a pagetables pages back as normal RW */
static void xen_pgd_unpin(pgd_t *pgd)
{
	xen_mc_batch();

494
	xen_do_pin(MMUEXT_UNPIN_TABLE, PFN_DOWN(__pa(pgd)));
495 496 497 498 499

	pgd_walk(pgd, unpin_page, TASK_SIZE);

	xen_mc_issue(0);
}
J
Jeremy Fitzhardinge 已提交
500 501 502

void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next)
{
503
	spin_lock(&next->page_table_lock);
J
Jeremy Fitzhardinge 已提交
504
	xen_pgd_pin(next->pgd);
505
	spin_unlock(&next->page_table_lock);
J
Jeremy Fitzhardinge 已提交
506 507 508 509
}

void xen_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm)
{
510
	spin_lock(&mm->page_table_lock);
J
Jeremy Fitzhardinge 已提交
511
	xen_pgd_pin(mm->pgd);
512
	spin_unlock(&mm->page_table_lock);
J
Jeremy Fitzhardinge 已提交
513 514 515
}


J
Jeremy Fitzhardinge 已提交
516 517 518 519 520 521
#ifdef CONFIG_SMP
/* Another cpu may still have their %cr3 pointing at the pagetable, so
   we need to repoint it somewhere else before we can unpin it. */
static void drop_other_mm_ref(void *info)
{
	struct mm_struct *mm = info;
J
Jeremy Fitzhardinge 已提交
522

J
Jeremy Fitzhardinge 已提交
523 524
	if (__get_cpu_var(cpu_tlbstate).active_mm == mm)
		leave_mm(smp_processor_id());
525 526 527 528 529 530 531

	/* If this cpu still has a stale cr3 reference, then make sure
	   it has been flushed. */
	if (x86_read_percpu(xen_current_cr3) == __pa(mm->pgd)) {
		load_cr3(swapper_pg_dir);
		arch_flush_lazy_cpu_mode();
	}
J
Jeremy Fitzhardinge 已提交
532
}
J
Jeremy Fitzhardinge 已提交
533

J
Jeremy Fitzhardinge 已提交
534 535
static void drop_mm_ref(struct mm_struct *mm)
{
536 537 538
	cpumask_t mask;
	unsigned cpu;

J
Jeremy Fitzhardinge 已提交
539 540 541 542 543
	if (current->active_mm == mm) {
		if (current->mm == mm)
			load_cr3(swapper_pg_dir);
		else
			leave_mm(smp_processor_id());
544 545 546 547 548 549 550 551 552 553 554 555 556 557
		arch_flush_lazy_cpu_mode();
	}

	/* Get the "official" set of cpus referring to our pagetable. */
	mask = mm->cpu_vm_mask;

	/* It's possible that a vcpu may have a stale reference to our
	   cr3, because its in lazy mode, and it hasn't yet flushed
	   its set of pending hypercalls yet.  In this case, we can
	   look at its actual current cr3 value, and force it to flush
	   if needed. */
	for_each_online_cpu(cpu) {
		if (per_cpu(xen_current_cr3, cpu) == __pa(mm->pgd))
			cpu_set(cpu, mask);
J
Jeremy Fitzhardinge 已提交
558 559
	}

560 561
	if (!cpus_empty(mask))
		xen_smp_call_function_mask(mask, drop_other_mm_ref, mm, 1);
J
Jeremy Fitzhardinge 已提交
562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
}
#else
static void drop_mm_ref(struct mm_struct *mm)
{
	if (current->active_mm == mm)
		load_cr3(swapper_pg_dir);
}
#endif

/*
 * While a process runs, Xen pins its pagetables, which means that the
 * hypervisor forces it to be read-only, and it controls all updates
 * to it.  This means that all pagetable updates have to go via the
 * hypervisor, which is moderately expensive.
 *
 * Since we're pulling the pagetable down, we switch to use init_mm,
 * unpin old process pagetable and mark it all read-write, which
 * allows further operations on it to be simple memory accesses.
 *
 * The only subtle point is that another CPU may be still using the
 * pagetable because of lazy tlb flushing.  This means we need need to
 * switch all CPUs off this pagetable before we can unpin it.
 */
void xen_exit_mmap(struct mm_struct *mm)
{
	get_cpu();		/* make sure we don't move around */
	drop_mm_ref(mm);
	put_cpu();
J
Jeremy Fitzhardinge 已提交
590

591
	spin_lock(&mm->page_table_lock);
592 593 594 595

	/* pgd may not be pinned in the error exit path of execve */
	if (PagePinned(virt_to_page(mm->pgd)))
		xen_pgd_unpin(mm->pgd);
596

597
	spin_unlock(&mm->page_table_lock);
J
Jeremy Fitzhardinge 已提交
598
}