edac_device_sysfs.c 23.6 KB
Newer Older
1 2 3
/*
 * file for managing the edac_device class of devices for EDAC
 *
4 5
 * (C) 2007 SoftwareBitMaker (http://www.softwarebitmaker.com)
 *
6 7 8 9 10 11 12 13
 * This file may be distributed under the terms of the
 * GNU General Public License.
 *
 * Written Doug Thompson <norsk5@xmission.com>
 *
 */

#include <linux/ctype.h>
14
#include <linux/module.h>
15 16 17 18 19 20 21 22 23 24 25 26 27 28 29

#include "edac_core.h"
#include "edac_module.h"

#define EDAC_DEVICE_SYMLINK	"device"

#define to_edacdev(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_edacdev_attr(a) container_of(a, struct edacdev_attribute, attr)


/*
 * Set of edac_device_ctl_info attribute store/show functions
 */

/* 'log_ue' */
30
static ssize_t edac_device_ctl_log_ue_show(struct edac_device_ctl_info
31
					*ctl_info, char *data)
32
{
33
	return sprintf(data, "%u\n", ctl_info->log_ue);
34 35
}

36
static ssize_t edac_device_ctl_log_ue_store(struct edac_device_ctl_info
37 38
					*ctl_info, const char *data,
					size_t count)
39 40
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
41
	ctl_info->log_ue = (simple_strtoul(data, NULL, 0) != 0);
42

43
	return count;
44 45 46
}

/* 'log_ce' */
47
static ssize_t edac_device_ctl_log_ce_show(struct edac_device_ctl_info
48
					*ctl_info, char *data)
49
{
50
	return sprintf(data, "%u\n", ctl_info->log_ce);
51 52
}

53
static ssize_t edac_device_ctl_log_ce_store(struct edac_device_ctl_info
54 55
					*ctl_info, const char *data,
					size_t count)
56 57
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
58
	ctl_info->log_ce = (simple_strtoul(data, NULL, 0) != 0);
59

60
	return count;
61 62 63
}

/* 'panic_on_ue' */
64 65
static ssize_t edac_device_ctl_panic_on_ue_show(struct edac_device_ctl_info
						*ctl_info, char *data)
66
{
67
	return sprintf(data, "%u\n", ctl_info->panic_on_ue);
68 69
}

70 71 72
static ssize_t edac_device_ctl_panic_on_ue_store(struct edac_device_ctl_info
						 *ctl_info, const char *data,
						 size_t count)
73 74
{
	/* if parameter is zero, turn off flag, if non-zero turn on flag */
75
	ctl_info->panic_on_ue = (simple_strtoul(data, NULL, 0) != 0);
76 77 78 79 80

	return count;
}

/* 'poll_msec' show and store functions*/
81
static ssize_t edac_device_ctl_poll_msec_show(struct edac_device_ctl_info
82
					*ctl_info, char *data)
83
{
84
	return sprintf(data, "%u\n", ctl_info->poll_msec);
85 86
}

87
static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info
88 89
					*ctl_info, const char *data,
					size_t count)
90 91 92 93 94 95 96 97
{
	unsigned long value;

	/* get the value and enforce that it is non-zero, must be at least
	 * one millisecond for the delay period, between scans
	 * Then cancel last outstanding delay for the work request
	 * and set a new one.
	 */
98 99
	value = simple_strtoul(data, NULL, 0);
	edac_device_reset_delay_period(ctl_info, value);
100

101
	return count;
102 103 104 105
}

/* edac_device_ctl_info specific attribute structure */
struct ctl_info_attribute {
106
	struct attribute attr;
107 108
	ssize_t(*show) (struct edac_device_ctl_info *, char *);
	ssize_t(*store) (struct edac_device_ctl_info *, const char *, size_t);
109 110 111 112 113 114 115
};

#define to_ctl_info(k) container_of(k, struct edac_device_ctl_info, kobj)
#define to_ctl_info_attr(a) container_of(a,struct ctl_info_attribute,attr)

/* Function to 'show' fields from the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_show(struct kobject *kobj,
116
				struct attribute *attr, char *buffer)
117
{
118 119
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
120

121 122 123
	if (ctl_info_attr->show)
		return ctl_info_attr->show(edac_dev, buffer);
	return -EIO;
124 125 126 127
}

/* Function to 'store' fields into the edac_dev 'ctl_info' structure */
static ssize_t edac_dev_ctl_info_store(struct kobject *kobj,
128 129
				struct attribute *attr,
				const char *buffer, size_t count)
130
{
131 132
	struct edac_device_ctl_info *edac_dev = to_ctl_info(kobj);
	struct ctl_info_attribute *ctl_info_attr = to_ctl_info_attr(attr);
133

134 135 136
	if (ctl_info_attr->store)
		return ctl_info_attr->store(edac_dev, buffer, count);
	return -EIO;
137 138 139 140
}

/* edac_dev file operations for an 'ctl_info' */
static struct sysfs_ops device_ctl_info_ops = {
141 142
	.show = edac_dev_ctl_info_show,
	.store = edac_dev_ctl_info_store
143 144 145 146
};

#define CTL_INFO_ATTR(_name,_mode,_show,_store)        \
static struct ctl_info_attribute attr_ctl_info_##_name = {      \
147 148 149
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
150 151 152
};

/* Declare the various ctl_info attributes here and their respective ops */
153
CTL_INFO_ATTR(log_ue, S_IRUGO | S_IWUSR,
154
	edac_device_ctl_log_ue_show, edac_device_ctl_log_ue_store);
155
CTL_INFO_ATTR(log_ce, S_IRUGO | S_IWUSR,
156
	edac_device_ctl_log_ce_show, edac_device_ctl_log_ce_store);
157
CTL_INFO_ATTR(panic_on_ue, S_IRUGO | S_IWUSR,
158 159
	edac_device_ctl_panic_on_ue_show,
	edac_device_ctl_panic_on_ue_store);
160
CTL_INFO_ATTR(poll_msec, S_IRUGO | S_IWUSR,
161
	edac_device_ctl_poll_msec_show, edac_device_ctl_poll_msec_store);
162 163 164 165 166 167 168 169 170 171

/* Base Attributes of the EDAC_DEVICE ECC object */
static struct ctl_info_attribute *device_ctrl_attr[] = {
	&attr_ctl_info_panic_on_ue,
	&attr_ctl_info_log_ue,
	&attr_ctl_info_log_ce,
	&attr_ctl_info_poll_msec,
	NULL,
};

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198
/*
 * edac_device_ctrl_master_release
 *
 *	called when the reference count for the 'main' kobj
 *	for a edac_device control struct reaches zero
 *
 *	Reference count model:
 *		One 'main' kobject for each control structure allocated.
 *		That main kobj is initially set to one AND
 *		the reference count for the EDAC 'core' module is
 *		bumped by one, thus added 'keep in memory' dependency.
 *
 *		Each new internal kobj (in instances and blocks) then
 *		bumps the 'main' kobject.
 *
 *		When they are released their release functions decrement
 *		the 'main' kobj.
 *
 *		When the main kobj reaches zero (0) then THIS function
 *		is called which then decrements the EDAC 'core' module.
 *		When the module reference count reaches zero then the
 *		module no longer has dependency on keeping the release
 *		function code in memory and module can be unloaded.
 *
 *		This will support several control objects as well, each
 *		with its own 'main' kobj.
 */
199 200
static void edac_device_ctrl_master_release(struct kobject *kobj)
{
201
	struct edac_device_ctl_info *edac_dev = to_edacdev(kobj);
202

203
	debugf4("%s() control index=%d\n", __func__, edac_dev->dev_idx);
204

205 206 207 208 209 210 211
	/* decrement the EDAC CORE module ref count */
	module_put(edac_dev->owner);

	/* free the control struct containing the 'main' kobj
	 * passed in to this routine
	 */
	kfree(edac_dev);
212 213
}

214
/* ktype for the main (master) kobject */
215 216 217
static struct kobj_type ktype_device_ctrl = {
	.release = edac_device_ctrl_master_release,
	.sysfs_ops = &device_ctl_info_ops,
218
	.default_attrs = (struct attribute **)device_ctrl_attr,
219 220 221
};

/*
222
 * edac_device_register_sysfs_main_kobj
223 224 225 226 227 228
 *
 *	perform the high level setup for the new edac_device instance
 *
 * Return:  0 SUCCESS
 *         !0 FAILURE
 */
229
int edac_device_register_sysfs_main_kobj(struct edac_device_ctl_info *edac_dev)
230 231
{
	struct sysdev_class *edac_class;
232
	int err;
233 234 235

	debugf1("%s()\n", __func__);

236 237 238
	/* get the /sys/devices/system/edac reference */
	edac_class = edac_get_edac_class();
	if (edac_class == NULL) {
239 240 241
		debugf1("%s() no edac_class error\n", __func__);
		err = -ENODEV;
		goto err_out;
242
	}
243 244 245 246 247

	/* Point to the 'edac_class' this instance 'reports' to */
	edac_dev->edac_class = edac_class;

	/* Init the devices's kobject */
248
	memset(&edac_dev->kobj, 0, sizeof(struct kobject));
249 250 251 252 253 254 255 256 257 258 259 260

	/* Record which module 'owns' this control structure
	 * and bump the ref count of the module
	 */
	edac_dev->owner = THIS_MODULE;

	if (!try_module_get(edac_dev->owner)) {
		err = -ENODEV;
		goto err_out;
	}

	/* register */
261 262 263
	err = kobject_init_and_add(&edac_dev->kobj, &ktype_device_ctrl,
				   &edac_class->kset.kobj,
				   "%s", edac_dev->name);
264 265
	if (err) {
		debugf1("%s()Failed to register '.../edac/%s'\n",
266
			__func__, edac_dev->name);
267
		goto err_kobj_reg;
268
	}
269
	kobject_uevent(&edac_dev->kobj, KOBJ_ADD);
270

271 272 273 274
	/* At this point, to 'free' the control struct,
	 * edac_device_unregister_sysfs_main_kobj() must be used
	 */

275
	debugf4("%s() Registered '.../edac/%s' kobject\n",
276 277 278
		__func__, edac_dev->name);

	return 0;
279 280 281 282 283 284 285

	/* Error exit stack */
err_kobj_reg:
	module_put(edac_dev->owner);

err_out:
	return err;
286 287 288
}

/*
289
 * edac_device_unregister_sysfs_main_kobj:
290 291
 *	the '..../edac/<name>' kobject
 */
292 293
void edac_device_unregister_sysfs_main_kobj(
					struct edac_device_ctl_info *edac_dev)
294 295
{
	debugf0("%s()\n", __func__);
296
	debugf4("%s() name of kobject is: %s\n",
297 298 299 300
		__func__, kobject_name(&edac_dev->kobj));

	/*
	 * Unregister the edac device's kobject and
301 302 303 304
	 * allow for reference count to reach 0 at which point
	 * the callback will be called to:
	 *   a) module_put() this module
	 *   b) 'kfree' the memory
305 306 307 308
	 */
	kobject_unregister(&edac_dev->kobj);
}

309
/* edac_dev -> instance information */
310 311 312 313

/*
 * Set of low-level instance attribute show functions
 */
314
static ssize_t instance_ue_count_show(struct edac_device_instance *instance,
315
				char *data)
316
{
317
	return sprintf(data, "%u\n", instance->counters.ue_count);
318 319
}

320
static ssize_t instance_ce_count_show(struct edac_device_instance *instance,
321
				char *data)
322
{
323
	return sprintf(data, "%u\n", instance->counters.ce_count);
324 325 326 327 328 329 330 331 332 333 334 335
}

#define to_instance(k) container_of(k, struct edac_device_instance, kobj)
#define to_instance_attr(a) container_of(a,struct instance_attribute,attr)

/* DEVICE instance kobject release() function */
static void edac_device_ctrl_instance_release(struct kobject *kobj)
{
	struct edac_device_instance *instance;

	debugf1("%s()\n", __func__);

336 337 338
	/* map from this kobj to the main control struct
	 * and then dec the main kobj count
	 */
339
	instance = to_instance(kobj);
340
	kobject_put(&instance->ctl->kobj);
341 342 343 344
}

/* instance specific attribute structure */
struct instance_attribute {
345
	struct attribute attr;
346 347
	ssize_t(*show) (struct edac_device_instance *, char *);
	ssize_t(*store) (struct edac_device_instance *, const char *, size_t);
348 349 350 351
};

/* Function to 'show' fields from the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_show(struct kobject *kobj,
352
				struct attribute *attr, char *buffer)
353
{
354 355
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
356

357 358 359
	if (instance_attr->show)
		return instance_attr->show(instance, buffer);
	return -EIO;
360 361 362 363
}

/* Function to 'store' fields into the edac_dev 'instance' structure */
static ssize_t edac_dev_instance_store(struct kobject *kobj,
364 365
				struct attribute *attr,
				const char *buffer, size_t count)
366
{
367 368
	struct edac_device_instance *instance = to_instance(kobj);
	struct instance_attribute *instance_attr = to_instance_attr(attr);
369

370 371 372
	if (instance_attr->store)
		return instance_attr->store(instance, buffer, count);
	return -EIO;
373 374 375 376
}

/* edac_dev file operations for an 'instance' */
static struct sysfs_ops device_instance_ops = {
377 378
	.show = edac_dev_instance_show,
	.store = edac_dev_instance_store
379 380 381 382
};

#define INSTANCE_ATTR(_name,_mode,_show,_store)        \
static struct instance_attribute attr_instance_##_name = {      \
383 384 385
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
386 387 388 389 390 391 392
};

/*
 * Define attributes visible for the edac_device instance object
 *	Each contains a pointer to a show and an optional set
 *	function pointer that does the low level output/input
 */
393 394
INSTANCE_ATTR(ce_count, S_IRUGO, instance_ce_count_show, NULL);
INSTANCE_ATTR(ue_count, S_IRUGO, instance_ue_count_show, NULL);
395 396 397 398 399 400 401 402 403 404 405 406

/* list of edac_dev 'instance' attributes */
static struct instance_attribute *device_instance_attr[] = {
	&attr_instance_ce_count,
	&attr_instance_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'instance' */
static struct kobj_type ktype_instance_ctrl = {
	.release = edac_device_ctrl_instance_release,
	.sysfs_ops = &device_instance_ops,
407
	.default_attrs = (struct attribute **)device_instance_attr,
408 409
};

410
/* edac_dev -> instance -> block information */
411

412 413 414 415
#define to_block(k) container_of(k, struct edac_device_block, kobj)
#define to_block_attr(a) \
	container_of(a, struct edac_dev_sysfs_block_attribute, attr)

416 417 418
/*
 * Set of low-level block attribute show functions
 */
419 420
static ssize_t block_ue_count_show(struct kobject *kobj,
					struct attribute *attr, char *data)
421
{
422 423
	struct edac_device_block *block = to_block(kobj);

424
	return sprintf(data, "%u\n", block->counters.ue_count);
425 426
}

427 428
static ssize_t block_ce_count_show(struct kobject *kobj,
					struct attribute *attr, char *data)
429
{
430 431
	struct edac_device_block *block = to_block(kobj);

432
	return sprintf(data, "%u\n", block->counters.ce_count);
433 434 435 436 437 438 439 440 441
}

/* DEVICE block kobject release() function */
static void edac_device_ctrl_block_release(struct kobject *kobj)
{
	struct edac_device_block *block;

	debugf1("%s()\n", __func__);

442
	/* get the container of the kobj */
443
	block = to_block(kobj);
444 445 446 447 448

	/* map from 'block kobj' to 'block->instance->controller->main_kobj'
	 * now 'release' the block kobject
	 */
	kobject_put(&block->instance->ctl->kobj);
449 450 451 452 453
}


/* Function to 'show' fields from the edac_dev 'block' structure */
static ssize_t edac_dev_block_show(struct kobject *kobj,
454
				struct attribute *attr, char *buffer)
455
{
456 457
	struct edac_dev_sysfs_block_attribute *block_attr =
						to_block_attr(attr);
458

459
	if (block_attr->show)
460
		return block_attr->show(kobj, attr, buffer);
461
	return -EIO;
462 463 464 465
}

/* Function to 'store' fields into the edac_dev 'block' structure */
static ssize_t edac_dev_block_store(struct kobject *kobj,
466 467
				struct attribute *attr,
				const char *buffer, size_t count)
468
{
469 470 471
	struct edac_dev_sysfs_block_attribute *block_attr;

	block_attr = to_block_attr(attr);
472

473
	if (block_attr->store)
474
		return block_attr->store(kobj, attr, buffer, count);
475
	return -EIO;
476 477 478 479
}

/* edac_dev file operations for a 'block' */
static struct sysfs_ops device_block_ops = {
480 481
	.show = edac_dev_block_show,
	.store = edac_dev_block_store
482 483 484
};

#define BLOCK_ATTR(_name,_mode,_show,_store)        \
485
static struct edac_dev_sysfs_block_attribute attr_block_##_name = {	\
486 487 488
	.attr = {.name = __stringify(_name), .mode = _mode },   \
	.show   = _show,                                        \
	.store  = _store,                                       \
489 490
};

491 492
BLOCK_ATTR(ce_count, S_IRUGO, block_ce_count_show, NULL);
BLOCK_ATTR(ue_count, S_IRUGO, block_ue_count_show, NULL);
493 494

/* list of edac_dev 'block' attributes */
495
static struct edac_dev_sysfs_block_attribute *device_block_attr[] = {
496 497 498 499 500 501 502 503 504
	&attr_block_ce_count,
	&attr_block_ue_count,
	NULL,
};

/* The 'ktype' for each edac_dev 'block' */
static struct kobj_type ktype_block_ctrl = {
	.release = edac_device_ctrl_block_release,
	.sysfs_ops = &device_block_ops,
505
	.default_attrs = (struct attribute **)device_block_attr,
506 507
};

508
/* block ctor/dtor  code */
509 510 511 512

/*
 * edac_device_create_block
 */
513
static int edac_device_create_block(struct edac_device_ctl_info *edac_dev,
514
				struct edac_device_instance *instance,
515
				struct edac_device_block *block)
516
{
517
	int i;
518
	int err;
519
	struct edac_dev_sysfs_block_attribute *sysfs_attrib;
520
	struct kobject *main_kobj;
521

522 523 524 525
	debugf4("%s() Instance '%s' inst_p=%p  block '%s'  block_p=%p\n",
		__func__, instance->name, instance, block->name, block);
	debugf4("%s() block kobj=%p  block kobj->parent=%p\n",
		__func__, &block->kobj, &block->kobj.parent);
526 527

	/* init this block's kobject */
528
	memset(&block->kobj, 0, sizeof(struct kobject));
529

530 531 532 533 534 535 536 537 538 539
	/* bump the main kobject's reference count for this controller
	 * and this instance is dependant on the main
	 */
	main_kobj = kobject_get(&edac_dev->kobj);
	if (!main_kobj) {
		err = -ENODEV;
		goto err_out;
	}

	/* Add this block's kobject */
540 541 542
	err = kobject_init_and_add(&block->kobj, &ktype_block_ctrl,
				   &instance->kobj,
				   "%s", block->name);
543
	if (err) {
544
		debugf1("%s() Failed to register instance '%s'\n",
545
			__func__, block->name);
546 547 548
		kobject_put(main_kobj);
		err = -ENODEV;
		goto err_out;
549 550
	}

551 552 553 554
	/* If there are driver level block attributes, then added them
	 * to the block kobject
	 */
	sysfs_attrib = block->block_attributes;
555 556 557 558 559 560 561 562 563 564
	if (sysfs_attrib && block->nr_attribs) {
		for (i = 0; i < block->nr_attribs; i++, sysfs_attrib++) {

			debugf4("%s() creating block attrib='%s' "
				"attrib->%p to kobj=%p\n",
				__func__,
				sysfs_attrib->attr.name,
				sysfs_attrib, &block->kobj);

			/* Create each block_attribute file */
565
			err = sysfs_create_file(&block->kobj,
566
				&sysfs_attrib->attr);
567 568 569 570
			if (err)
				goto err_on_attrib;
		}
	}
571
	kobject_uevent(&block->kobj, KOBJ_ADD);
572

573
	return 0;
574

575
	/* Error unwind stack */
576 577 578
err_on_attrib:
	kobject_unregister(&block->kobj);

579
err_out:
580
	return err;
581 582 583
}

/*
584
 * edac_device_delete_block(edac_dev,block);
585
 */
586
static void edac_device_delete_block(struct edac_device_ctl_info *edac_dev,
587
				struct edac_device_block *block)
588
{
589 590
	struct edac_dev_sysfs_block_attribute *sysfs_attrib;
	int i;
591

592 593 594 595 596
	/* if this block has 'attributes' then we need to iterate over the list
	 * and 'remove' the attributes on this block
	 */
	sysfs_attrib = block->block_attributes;
	if (sysfs_attrib && block->nr_attribs) {
597 598 599
		for (i = 0; i < block->nr_attribs; i++, sysfs_attrib++) {

			/* remove each block_attrib file */
600 601 602 603
			sysfs_remove_file(&block->kobj,
				(struct attribute *) sysfs_attrib);
		}
	}
604

605 606 607
	/* unregister this block's kobject, SEE:
	 *	edac_device_ctrl_block_release() callback operation
	 */
608 609 610
	kobject_unregister(&block->kobj);
}

611
/* instance ctor/dtor code */
612 613 614 615 616

/*
 * edac_device_create_instance
 *	create just one instance of an edac_device 'instance'
 */
617
static int edac_device_create_instance(struct edac_device_ctl_info *edac_dev,
618
				int idx)
619 620 621 622
{
	int i, j;
	int err;
	struct edac_device_instance *instance;
623
	struct kobject *main_kobj;
624 625 626 627

	instance = &edac_dev->instances[idx];

	/* Init the instance's kobject */
628
	memset(&instance->kobj, 0, sizeof(struct kobject));
629

630
	instance->ctl = edac_dev;
631

632 633 634 635 636 637 638 639
	/* bump the main kobject's reference count for this controller
	 * and this instance is dependant on the main
	 */
	main_kobj = kobject_get(&edac_dev->kobj);
	if (!main_kobj) {
		err = -ENODEV;
		goto err_out;
	}
640

641 642 643
	/* Formally register this instance's kobject under the edac_device */
	err = kobject_init_and_add(&instance->kobj, &ktype_instance_ctrl,
				   &edac_dev->kobj, "%s", instance->name);
644 645
	if (err != 0) {
		debugf2("%s() Failed to register instance '%s'\n",
646
			__func__, instance->name);
647 648
		kobject_put(main_kobj);
		goto err_out;
649 650
	}

651
	debugf4("%s() now register '%d' blocks for instance %d\n",
652
		__func__, instance->nr_blocks, idx);
653 654

	/* register all blocks of this instance */
655
	for (i = 0; i < instance->nr_blocks; i++) {
656 657
		err = edac_device_create_block(edac_dev, instance,
						&instance->blocks[i]);
658
		if (err) {
659
			/* If any fail, remove all previous ones */
660
			for (j = 0; j < i; j++)
661 662 663
				edac_device_delete_block(edac_dev,
							&instance->blocks[j]);
			goto err_release_instance_kobj;
664 665
		}
	}
666
	kobject_uevent(&instance->kobj, KOBJ_ADD);
667

668
	debugf4("%s() Registered instance %d '%s' kobject\n",
669 670 671
		__func__, idx, instance->name);

	return 0;
672 673 674 675 676 677 678

	/* error unwind stack */
err_release_instance_kobj:
	kobject_unregister(&instance->kobj);

err_out:
	return err;
679 680 681 682 683 684
}

/*
 * edac_device_remove_instance
 *	remove an edac_device instance
 */
685 686
static void edac_device_delete_instance(struct edac_device_ctl_info *edac_dev,
					int idx)
687 688
{
	struct edac_device_instance *instance;
689
	int i;
690 691 692 693

	instance = &edac_dev->instances[idx];

	/* unregister all blocks in this instance */
694
	for (i = 0; i < instance->nr_blocks; i++)
695
		edac_device_delete_block(edac_dev, &instance->blocks[i]);
696

697 698 699
	/* unregister this instance's kobject, SEE:
	 *	edac_device_ctrl_instance_release() for callback operation
	 */
700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715
	kobject_unregister(&instance->kobj);
}

/*
 * edac_device_create_instances
 *	create the first level of 'instances' for this device
 *	(ie  'cache' might have 'cache0', 'cache1', 'cache2', etc
 */
static int edac_device_create_instances(struct edac_device_ctl_info *edac_dev)
{
	int i, j;
	int err;

	debugf0("%s()\n", __func__);

	/* iterate over creation of the instances */
716 717
	for (i = 0; i < edac_dev->nr_instances; i++) {
		err = edac_device_create_instance(edac_dev, i);
718 719
		if (err) {
			/* unwind previous instances on error */
720
			for (j = 0; j < i; j++)
721
				edac_device_delete_instance(edac_dev, j);
722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737
			return err;
		}
	}

	return 0;
}

/*
 * edac_device_delete_instances(edac_dev);
 *	unregister all the kobjects of the instances
 */
static void edac_device_delete_instances(struct edac_device_ctl_info *edac_dev)
{
	int i;

	/* iterate over creation of the instances */
738
	for (i = 0; i < edac_dev->nr_instances; i++)
739
		edac_device_delete_instance(edac_dev, i);
740 741
}

742
/* edac_dev sysfs ctor/dtor  code */
743

744
/*
745
 * edac_device_add_main_sysfs_attributes
746 747
 *	add some attributes to this instance's main kobject
 */
748
static int edac_device_add_main_sysfs_attributes(
749 750
			struct edac_device_ctl_info *edac_dev)
{
751
	struct edac_dev_sysfs_attribute *sysfs_attrib;
752
	int err = 0;
753 754

	sysfs_attrib = edac_dev->sysfs_attributes;
755 756 757 758 759 760
	if (sysfs_attrib) {
		/* iterate over the array and create an attribute for each
		 * entry in the list
		 */
		while (sysfs_attrib->attr.name != NULL) {
			err = sysfs_create_file(&edac_dev->kobj,
761
				(struct attribute*) sysfs_attrib);
762 763
			if (err)
				goto err_out;
764

765 766
			sysfs_attrib++;
		}
767
	}
768

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
err_out:
	return err;
}

/*
 * edac_device_remove_main_sysfs_attributes
 *	remove any attributes to this instance's main kobject
 */
static void edac_device_remove_main_sysfs_attributes(
			struct edac_device_ctl_info *edac_dev)
{
	struct edac_dev_sysfs_attribute *sysfs_attrib;

	/* if there are main attributes, defined, remove them. First,
	 * point to the start of the array and iterate over it
	 * removing each attribute listed from this device's instance's kobject
	 */
	sysfs_attrib = edac_dev->sysfs_attributes;
	if (sysfs_attrib) {
		while (sysfs_attrib->attr.name != NULL) {
			sysfs_remove_file(&edac_dev->kobj,
					(struct attribute *) sysfs_attrib);
			sysfs_attrib++;
		}
	}
794 795
}

796 797 798
/*
 * edac_device_create_sysfs() Constructor
 *
799 800 801 802 803 804
 * accept a created edac_device control structure
 * and 'export' it to sysfs. The 'main' kobj should already have been
 * created. 'instance' and 'block' kobjects should be registered
 * along with any 'block' attributes from the low driver. In addition,
 * the main attributes (if any) are connected to the main kobject of
 * the control structure.
805 806 807 808 809 810 811 812
 *
 * Return:
 *	0	Success
 *	!0	Failure
 */
int edac_device_create_sysfs(struct edac_device_ctl_info *edac_dev)
{
	int err;
813
	struct kobject *edac_kobj = &edac_dev->kobj;
814 815 816

	debugf0("%s() idx=%d\n", __func__, edac_dev->dev_idx);

817 818 819 820 821
	/*  go create any main attributes callers wants */
	err = edac_device_add_main_sysfs_attributes(edac_dev);
	if (err) {
		debugf0("%s() failed to add sysfs attribs\n", __func__);
		goto err_out;
822 823
	}

824 825 826 827
	/* create a symlink from the edac device
	 * to the platform 'device' being used for this
	 */
	err = sysfs_create_link(edac_kobj,
828
				&edac_dev->dev->kobj, EDAC_DEVICE_SYMLINK);
829 830 831
	if (err) {
		debugf0("%s() sysfs_create_link() returned err= %d\n",
			__func__, err);
832
		goto err_remove_main_attribs;
833 834
	}

835 836 837 838
	/* Create the first level instance directories
	 * In turn, the nested blocks beneath the instances will
	 * be registered as well
	 */
839
	err = edac_device_create_instances(edac_dev);
840 841 842
	if (err) {
		debugf0("%s() edac_device_create_instances() "
			"returned err= %d\n", __func__, err);
843
		goto err_remove_link;
844 845 846
	}


847
	debugf4("%s() create-instances done, idx=%d\n",
848
		__func__, edac_dev->dev_idx);
849 850 851 852

	return 0;

	/* Error unwind stack */
853 854 855
err_remove_link:
	/* remove the sym link */
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);
856

857 858
err_remove_main_attribs:
	edac_device_remove_main_sysfs_attributes(edac_dev);
859

860
err_out:
861 862 863 864 865 866
	return err;
}

/*
 * edac_device_remove_sysfs() destructor
 *
867
 * given an edac_device struct, tear down the kobject resources
868 869 870 871 872
 */
void edac_device_remove_sysfs(struct edac_device_ctl_info *edac_dev)
{
	debugf0("%s()\n", __func__);

873 874
	/* remove any main attributes for this device */
	edac_device_remove_main_sysfs_attributes(edac_dev);
875

876
	/* remove the device sym link */
877 878
	sysfs_remove_link(&edac_dev->kobj, EDAC_DEVICE_SYMLINK);

879 880
	/* walk the instance/block kobject tree, deconstructing it */
	edac_device_delete_instances(edac_dev);
881
}