selftest_engine_heartbeat.c 9.1 KB
Newer Older
C
Chris Wilson 已提交
1
// SPDX-License-Identifier: MIT
2 3 4 5
/*
 * Copyright © 2018 Intel Corporation
 */

6 7
#include <linux/sort.h>

8 9 10 11
#include "i915_drv.h"

#include "intel_gt_requests.h"
#include "i915_selftest.h"
12
#include "selftest_engine_heartbeat.h"
13

14 15 16 17 18 19
static void reset_heartbeat(struct intel_engine_cs *engine)
{
	intel_engine_set_heartbeat(engine,
				   engine->defaults.heartbeat_interval_ms);
}

20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
static int timeline_sync(struct intel_timeline *tl)
{
	struct dma_fence *fence;
	long timeout;

	fence = i915_active_fence_get(&tl->last_request);
	if (!fence)
		return 0;

	timeout = dma_fence_wait_timeout(fence, true, HZ / 2);
	dma_fence_put(fence);
	if (timeout < 0)
		return timeout;

	return 0;
}

static int engine_sync_barrier(struct intel_engine_cs *engine)
{
	return timeline_sync(engine->kernel_context->timeline);
}

42 43 44 45 46 47 48 49 50 51 52 53 54
struct pulse {
	struct i915_active active;
	struct kref kref;
};

static int pulse_active(struct i915_active *active)
{
	kref_get(&container_of(active, struct pulse, active)->kref);
	return 0;
}

static void pulse_free(struct kref *kref)
{
55 56 57 58
	struct pulse *p = container_of(kref, typeof(*p), kref);

	i915_active_fini(&p->active);
	kfree(p);
59 60 61 62 63 64 65
}

static void pulse_put(struct pulse *p)
{
	kref_put(&p->kref, pulse_free);
}

66
static void pulse_retire(struct i915_active *active)
67 68 69 70 71 72 73 74 75 76 77 78 79
{
	pulse_put(container_of(active, struct pulse, active));
}

static struct pulse *pulse_create(void)
{
	struct pulse *p;

	p = kmalloc(sizeof(*p), GFP_KERNEL);
	if (!p)
		return p;

	kref_init(&p->kref);
80
	i915_active_init(&p->active, pulse_active, pulse_retire, 0);
81 82 83 84

	return p;
}

85 86
static void pulse_unlock_wait(struct pulse *p)
{
87
	i915_active_unlock_wait(&p->active);
88 89
}

90 91 92 93 94 95
static int __live_idle_pulse(struct intel_engine_cs *engine,
			     int (*fn)(struct intel_engine_cs *cs))
{
	struct pulse *p;
	int err;

96 97
	GEM_BUG_ON(!intel_engine_pm_is_awake(engine));

98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
	p = pulse_create();
	if (!p)
		return -ENOMEM;

	err = i915_active_acquire(&p->active);
	if (err)
		goto out;

	err = i915_active_acquire_preallocate_barrier(&p->active, engine);
	if (err) {
		i915_active_release(&p->active);
		goto out;
	}

	i915_active_acquire_barrier(&p->active);
	i915_active_release(&p->active);

	GEM_BUG_ON(i915_active_is_idle(&p->active));
116
	GEM_BUG_ON(llist_empty(&engine->barrier_tasks));
117 118 119 120 121

	err = fn(engine);
	if (err)
		goto out;

122 123
	GEM_BUG_ON(!llist_empty(&engine->barrier_tasks));

124
	if (engine_sync_barrier(engine)) {
125 126 127 128 129
		struct drm_printer m = drm_err_printer("pulse");

		pr_err("%s: no heartbeat pulse?\n", engine->name);
		intel_engine_dump(engine, &m, "%s", engine->name);

130 131 132 133
		err = -ETIME;
		goto out;
	}

134 135
	GEM_BUG_ON(READ_ONCE(engine->serial) != engine->wakeref_serial);

136 137
	pulse_unlock_wait(p); /* synchronize with the retirement callback */

138
	if (!i915_active_is_idle(&p->active)) {
139 140
		struct drm_printer m = drm_err_printer("pulse");

141 142
		pr_err("%s: heartbeat pulse did not flush idle tasks\n",
		       engine->name);
143 144
		i915_active_print(&p->active, &m);

145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
		err = -EINVAL;
		goto out;
	}

out:
	pulse_put(p);
	return err;
}

static int live_idle_flush(void *arg)
{
	struct intel_gt *gt = arg;
	struct intel_engine_cs *engine;
	enum intel_engine_id id;
	int err = 0;

	/* Check that we can flush the idle barriers */

	for_each_engine(engine, gt, id) {
164
		st_engine_heartbeat_disable(engine);
165
		err = __live_idle_pulse(engine, intel_engine_flush_barriers);
166
		st_engine_heartbeat_enable(engine);
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183
		if (err)
			break;
	}

	return err;
}

static int live_idle_pulse(void *arg)
{
	struct intel_gt *gt = arg;
	struct intel_engine_cs *engine;
	enum intel_engine_id id;
	int err = 0;

	/* Check that heartbeat pulses flush the idle barriers */

	for_each_engine(engine, gt, id) {
184
		st_engine_heartbeat_disable(engine);
185
		err = __live_idle_pulse(engine, intel_engine_pulse);
186
		st_engine_heartbeat_enable(engine);
187 188 189 190 191 192 193 194 195
		if (err && err != -ENODEV)
			break;

		err = 0;
	}

	return err;
}

196 197 198 199 200 201 202 203 204
static int cmp_u32(const void *_a, const void *_b)
{
	const u32 *a = _a, *b = _b;

	return *a - *b;
}

static int __live_heartbeat_fast(struct intel_engine_cs *engine)
{
205
	const unsigned int error_threshold = max(20000u, jiffies_to_usecs(6));
206 207 208 209 210 211 212
	struct intel_context *ce;
	struct i915_request *rq;
	ktime_t t0, t1;
	u32 times[5];
	int err;
	int i;

213
	ce = intel_context_create(engine);
214 215 216 217 218 219 220 221 222 223 224
	if (IS_ERR(ce))
		return PTR_ERR(ce);

	intel_engine_pm_get(engine);

	err = intel_engine_set_heartbeat(engine, 1);
	if (err)
		goto err_pm;

	for (i = 0; i < ARRAY_SIZE(times); i++) {
		do {
225 226 227 228 229
			/* Manufacture a tick */
			intel_engine_park_heartbeat(engine);
			GEM_BUG_ON(engine->heartbeat.systole);
			engine->serial++; /*  pretend we are not idle! */
			intel_engine_unpark_heartbeat(engine);
230 231 232

			flush_delayed_work(&engine->heartbeat.work);
			if (!delayed_work_pending(&engine->heartbeat.work)) {
233 234
				pr_err("%s: heartbeat %d did not start\n",
				       engine->name, i);
235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
				err = -EINVAL;
				goto err_pm;
			}

			rcu_read_lock();
			rq = READ_ONCE(engine->heartbeat.systole);
			if (rq)
				rq = i915_request_get_rcu(rq);
			rcu_read_unlock();
		} while (!rq);

		t0 = ktime_get();
		while (rq == READ_ONCE(engine->heartbeat.systole))
			yield(); /* work is on the local cpu! */
		t1 = ktime_get();

		i915_request_put(rq);
		times[i] = ktime_us_delta(t1, t0);
	}

	sort(times, ARRAY_SIZE(times), sizeof(times[0]), cmp_u32, NULL);

	pr_info("%s: Heartbeat delay: %uus [%u, %u]\n",
		engine->name,
		times[ARRAY_SIZE(times) / 2],
		times[0],
		times[ARRAY_SIZE(times) - 1]);

263 264 265 266 267 268 269 270
	/*
	 * Ideally, the upper bound on min work delay would be something like
	 * 2 * 2 (worst), +1 for scheduling, +1 for slack. In practice, we
	 * are, even with system_wq_highpri, at the mercy of the CPU scheduler
	 * and may be stuck behind some slow work for many millisecond. Such
	 * as our very own display workers.
	 */
	if (times[ARRAY_SIZE(times) / 2] > error_threshold) {
271 272 273
		pr_err("%s: Heartbeat delay was %uus, expected less than %dus\n",
		       engine->name,
		       times[ARRAY_SIZE(times) / 2],
274
		       error_threshold);
275 276 277
		err = -EINVAL;
	}

278
	reset_heartbeat(engine);
279 280 281 282 283 284 285 286 287 288 289
err_pm:
	intel_engine_pm_put(engine);
	intel_context_put(ce);
	return err;
}

static int live_heartbeat_fast(void *arg)
{
	struct intel_gt *gt = arg;
	struct intel_engine_cs *engine;
	enum intel_engine_id id;
290
	int err = 0;
291 292

	/* Check that the heartbeat ticks at the desired rate. */
L
Lucas De Marchi 已提交
293
	if (!CONFIG_DRM_I915_HEARTBEAT_INTERVAL)
294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
		return 0;

	for_each_engine(engine, gt, id) {
		err = __live_heartbeat_fast(engine);
		if (err)
			break;
	}

	return err;
}

static int __live_heartbeat_off(struct intel_engine_cs *engine)
{
	int err;

	intel_engine_pm_get(engine);

	engine->serial++;
	flush_delayed_work(&engine->heartbeat.work);
	if (!delayed_work_pending(&engine->heartbeat.work)) {
		pr_err("%s: heartbeat not running\n",
		       engine->name);
		err = -EINVAL;
		goto err_pm;
	}

	err = intel_engine_set_heartbeat(engine, 0);
	if (err)
		goto err_pm;

	engine->serial++;
	flush_delayed_work(&engine->heartbeat.work);
	if (delayed_work_pending(&engine->heartbeat.work)) {
		pr_err("%s: heartbeat still running\n",
		       engine->name);
		err = -EINVAL;
		goto err_beat;
	}

	if (READ_ONCE(engine->heartbeat.systole)) {
		pr_err("%s: heartbeat still allocated\n",
		       engine->name);
		err = -EINVAL;
		goto err_beat;
	}

err_beat:
341
	reset_heartbeat(engine);
342 343 344 345 346 347 348 349 350 351
err_pm:
	intel_engine_pm_put(engine);
	return err;
}

static int live_heartbeat_off(void *arg)
{
	struct intel_gt *gt = arg;
	struct intel_engine_cs *engine;
	enum intel_engine_id id;
352
	int err = 0;
353 354

	/* Check that we can turn off heartbeat and not interrupt VIP */
L
Lucas De Marchi 已提交
355
	if (!CONFIG_DRM_I915_HEARTBEAT_INTERVAL)
356 357 358 359 360 361 362 363 364 365 366 367 368 369
		return 0;

	for_each_engine(engine, gt, id) {
		if (!intel_engine_has_preemption(engine))
			continue;

		err = __live_heartbeat_off(engine);
		if (err)
			break;
	}

	return err;
}

370 371 372 373 374
int intel_heartbeat_live_selftests(struct drm_i915_private *i915)
{
	static const struct i915_subtest tests[] = {
		SUBTEST(live_idle_flush),
		SUBTEST(live_idle_pulse),
375 376
		SUBTEST(live_heartbeat_fast),
		SUBTEST(live_heartbeat_off),
377 378 379 380 381 382 383
	};
	int saved_hangcheck;
	int err;

	if (intel_gt_is_wedged(&i915->gt))
		return 0;

384 385
	saved_hangcheck = i915->params.enable_hangcheck;
	i915->params.enable_hangcheck = INT_MAX;
386

387
	err = intel_gt_live_subtests(tests, &i915->gt);
388

389
	i915->params.enable_hangcheck = saved_hangcheck;
390 391
	return err;
}
392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407

void st_engine_heartbeat_disable(struct intel_engine_cs *engine)
{
	engine->props.heartbeat_interval_ms = 0;

	intel_engine_pm_get(engine);
	intel_engine_park_heartbeat(engine);
}

void st_engine_heartbeat_enable(struct intel_engine_cs *engine)
{
	intel_engine_pm_put(engine);

	engine->props.heartbeat_interval_ms =
		engine->defaults.heartbeat_interval_ms;
}
408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429

void st_engine_heartbeat_disable_no_pm(struct intel_engine_cs *engine)
{
	engine->props.heartbeat_interval_ms = 0;

	/*
	 * Park the heartbeat but without holding the PM lock as that
	 * makes the engines appear not-idle. Note that if/when unpark
	 * is called due to the PM lock being acquired later the
	 * heartbeat still won't be enabled because of the above = 0.
	 */
	if (intel_engine_pm_get_if_awake(engine)) {
		intel_engine_park_heartbeat(engine);
		intel_engine_pm_put(engine);
	}
}

void st_engine_heartbeat_enable_no_pm(struct intel_engine_cs *engine)
{
	engine->props.heartbeat_interval_ms =
		engine->defaults.heartbeat_interval_ms;
}