radio-mr800.c 18.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24
/*
 * A driver for the AverMedia MR 800 USB FM radio. This device plugs
 * into both the USB and an analog audio input, so this thing
 * only deals with initialization and frequency setting, the
 * audio data has to be handled by a sound driver.
 *
 * Copyright (c) 2008 Alexey Klimov <klimov.linux@gmail.com>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 */

/*
25
 * Big thanks to authors and contributors of dsbr100.c and radio-si470x.c
26 27 28 29 30 31 32
 *
 * When work was looked pretty good, i discover this:
 * http://av-usbradio.sourceforge.net/index.php
 * http://sourceforge.net/projects/av-usbradio/
 * Latest release of theirs project was in 2005.
 * Probably, this driver could be improved trough using their
 * achievements (specifications given).
33 34 35
 * Also, Faidon Liambotis <paravoid@debian.org> wrote nice driver for this radio
 * in 2007. He allowed to use his driver to improve current mr800 radio driver.
 * http://kerneltrap.org/mailarchive/linux-usb-devel/2007/10/11/342492
36 37 38 39
 *
 * Version 0.01:	First working version.
 * 			It's required to blacklist AverMedia USB Radio
 * 			in usbhid/hid-quirks.c
40 41 42 43 44 45
 * Version 0.10:	A lot of cleanups and fixes: unpluging the device,
 * 			few mutex locks were added, codinstyle issues, etc.
 * 			Added stereo support. Thanks to
 * 			Douglas Schilling Landgraf <dougsland@gmail.com> and
 * 			David Ellingsworth <david@identd.dyndns.org>
 * 			for discussion, help and support.
46
 * Version 0.11:	Converted to v4l2_device.
47 48
 *
 * Many things to do:
49
 * 	- Correct power management of device (suspend & resume)
50 51 52 53 54 55 56 57 58 59 60
 * 	- Add code for scanning and smooth tuning
 * 	- Add code for sensitivity value
 * 	- Correct mistakes
 * 	- In Japan another FREQ_MIN and FREQ_MAX
 */

/* kernel includes */
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
A
Alexey Dobriyan 已提交
61
#include <linux/smp_lock.h>
62 63
#include <linux/input.h>
#include <linux/videodev2.h>
64
#include <media/v4l2-device.h>
65 66 67
#include <media/v4l2-ioctl.h>
#include <linux/usb.h>
#include <linux/version.h>	/* for KERNEL_VERSION MACRO */
68
#include <linux/mutex.h>
69 70 71 72

/* driver and module definitions */
#define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"
#define DRIVER_DESC "AverMedia MR 800 USB FM radio driver"
73 74
#define DRIVER_VERSION "0.11"
#define RADIO_VERSION KERNEL_VERSION(0, 1, 1)
75 76 77 78 79 80 81 82

MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");

#define USB_AMRADIO_VENDOR 0x07ca
#define USB_AMRADIO_PRODUCT 0xb800

83 84 85 86 87
/* dev_warn macro with driver name */
#define MR800_DRIVER_NAME "radio-mr800"
#define amradio_dev_warn(dev, fmt, arg...)				\
		dev_warn(dev, MR800_DRIVER_NAME " - " fmt, ##arg)

88 89 90
#define amradio_dev_err(dev, fmt, arg...) \
		dev_err(dev, MR800_DRIVER_NAME " - " fmt, ##arg)

91 92 93 94 95 96 97 98 99 100
/* Probably USB_TIMEOUT should be modified in module parameter */
#define BUFFER_LENGTH 8
#define USB_TIMEOUT 500

/* Frequency limits in MHz -- these are European values.  For Japanese
devices, that would be 76 and 91.  */
#define FREQ_MIN  87.5
#define FREQ_MAX 108.0
#define FREQ_MUL 16000

101 102 103 104
/*
 * Commands that device should understand
 * List isnt full and will be updated with implementation of new functions
 */
105
#define AMRADIO_SET_FREQ	0xa4
106
#define AMRADIO_SET_MUTE	0xab
107
#define AMRADIO_SET_MONO	0xae
108 109 110 111 112

/* Comfortable defines for amradio_set_mute */
#define AMRADIO_START		0x00
#define AMRADIO_STOP		0x01

113 114 115 116
/* Comfortable defines for amradio_set_stereo */
#define WANT_STEREO		0x00
#define WANT_MONO		0x01

117 118 119 120 121 122 123 124
/* module parameter */
static int radio_nr = -1;
module_param(radio_nr, int, 0);
MODULE_PARM_DESC(radio_nr, "Radio Nr");

static int usb_amradio_probe(struct usb_interface *intf,
			     const struct usb_device_id *id);
static void usb_amradio_disconnect(struct usb_interface *intf);
125 126
static int usb_amradio_open(struct file *file);
static int usb_amradio_close(struct file *file);
127 128 129 130 131 132 133 134
static int usb_amradio_suspend(struct usb_interface *intf,
				pm_message_t message);
static int usb_amradio_resume(struct usb_interface *intf);

/* Data for one (physical) device */
struct amradio_device {
	/* reference to USB and video device */
	struct usb_device *usbdev;
135
	struct video_device videodev;
136
	struct v4l2_device v4l2_dev;
137 138 139 140 141 142

	unsigned char *buffer;
	struct mutex lock;	/* buffer locking */
	int curfreq;
	int stereo;
	int muted;
143
	int initialized;
144 145
};

146 147
#define vdev_to_amradio(r) container_of(r, struct amradio_device, videodev)

148 149 150 151 152 153 154 155 156 157 158
/* USB Device ID List */
static struct usb_device_id usb_amradio_device_table[] = {
	{USB_DEVICE_AND_INTERFACE_INFO(USB_AMRADIO_VENDOR, USB_AMRADIO_PRODUCT,
							USB_CLASS_HID, 0, 0) },
	{ }						/* Terminating entry */
};

MODULE_DEVICE_TABLE(usb, usb_amradio_device_table);

/* USB subsystem interface */
static struct usb_driver usb_amradio_driver = {
159
	.name			= MR800_DRIVER_NAME,
160 161 162 163 164 165
	.probe			= usb_amradio_probe,
	.disconnect		= usb_amradio_disconnect,
	.suspend		= usb_amradio_suspend,
	.resume			= usb_amradio_resume,
	.reset_resume		= usb_amradio_resume,
	.id_table		= usb_amradio_device_table,
166
	.supports_autosuspend	= 0,
167 168
};

169 170
/* switch on/off the radio. Send 8 bytes to device */
static int amradio_set_mute(struct amradio_device *radio, char argument)
171 172 173 174
{
	int retval;
	int size;

175
	BUG_ON(!mutex_is_locked(&radio->lock));
176 177 178 179 180

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x00;
181 182
	radio->buffer[4] = AMRADIO_SET_MUTE;
	radio->buffer[5] = argument;
183 184 185 186 187 188
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

189 190
	if (retval < 0 || size != BUFFER_LENGTH) {
		amradio_dev_warn(&radio->videodev.dev, "set mute failed\n");
191
		return retval;
192
	}
193

194
	radio->muted = argument;
195 196 197 198 199 200 201 202 203

	return retval;
}

/* set a frequency, freq is defined by v4l's TUNER_LOW, i.e. 1/16th kHz */
static int amradio_setfreq(struct amradio_device *radio, int freq)
{
	int retval;
	int size;
204
	unsigned short freq_send = 0x10 + (freq >> 3) / 25;
205

206
	BUG_ON(!mutex_is_locked(&radio->lock));
207 208 209 210 211

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x03;
212
	radio->buffer[4] = AMRADIO_SET_FREQ;
213 214 215 216 217 218 219
	radio->buffer[5] = 0x00;
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x08;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

220
	if (retval < 0 || size != BUFFER_LENGTH)
221
		goto out_err;
222 223 224 225 226 227 228 229 230 231 232 233 234

	/* frequency is calculated from freq_send and placed in first 2 bytes */
	radio->buffer[0] = (freq_send >> 8) & 0xff;
	radio->buffer[1] = freq_send & 0xff;
	radio->buffer[2] = 0x01;
	radio->buffer[3] = 0x00;
	radio->buffer[4] = 0x00;
	/* 5 and 6 bytes of buffer already = 0x00 */
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

235 236 237 238 239 240 241 242
	if (retval < 0 || size != BUFFER_LENGTH)
		goto out_err;

	goto out;

out_err:
	amradio_dev_warn(&radio->videodev.dev, "set frequency failed\n");
out:
243 244 245 246 247 248 249 250
	return retval;
}

static int amradio_set_stereo(struct amradio_device *radio, char argument)
{
	int retval;
	int size;

251
	BUG_ON(!mutex_is_locked(&radio->lock));
252 253 254 255 256 257 258 259 260 261 262 263 264

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x00;
	radio->buffer[4] = AMRADIO_SET_MONO;
	radio->buffer[5] = argument;
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

265 266
	if (retval < 0 || size != BUFFER_LENGTH) {
		amradio_dev_warn(&radio->videodev.dev, "set stereo failed\n");
267
		return retval;
268
	}
269

270 271 272 273
	if (argument == WANT_STEREO)
		radio->stereo = 1;
	else
		radio->stereo = 0;
274 275 276 277

	return retval;
}

278 279 280 281 282
/* Handle unplugging the device.
 * We call video_unregister_device in any case.
 * The last function called in this procedure is
 * usb_amradio_device_release.
 */
283 284 285 286
static void usb_amradio_disconnect(struct usb_interface *intf)
{
	struct amradio_device *radio = usb_get_intfdata(intf);

287
	mutex_lock(&radio->lock);
288
	radio->usbdev = NULL;
289
	mutex_unlock(&radio->lock);
290

291
	usb_set_intfdata(intf, NULL);
292
	v4l2_device_disconnect(&radio->v4l2_dev);
293
	video_unregister_device(&radio->videodev);
294 295 296 297 298 299
}

/* vidioc_querycap - query device capabilities */
static int vidioc_querycap(struct file *file, void *priv,
					struct v4l2_capability *v)
{
300
	struct amradio_device *radio = file->private_data;
301

302 303
	strlcpy(v->driver, "radio-mr800", sizeof(v->driver));
	strlcpy(v->card, "AverMedia MR 800 USB FM Radio", sizeof(v->card));
304
	usb_make_path(radio->usbdev, v->bus_info, sizeof(v->bus_info));
305 306 307 308 309 310 311 312 313
	v->version = RADIO_VERSION;
	v->capabilities = V4L2_CAP_TUNER;
	return 0;
}

/* vidioc_g_tuner - get tuner attributes */
static int vidioc_g_tuner(struct file *file, void *priv,
				struct v4l2_tuner *v)
{
314
	struct amradio_device *radio = file->private_data;
315
	int retval;
316

317 318
	if (v->index > 0)
		return -EINVAL;
319 320 321 322

/* TODO: Add function which look is signal stereo or not
 * 	amradio_getstat(radio);
 */
323 324 325 326 327 328 329

/* we call amradio_set_stereo to set radio->stereo
 * Honestly, amradio_getstat should cover this in future and
 * amradio_set_stereo shouldn't be here
 */
	retval = amradio_set_stereo(radio, WANT_STEREO);

330 331 332 333 334 335 336 337 338 339 340 341
	strcpy(v->name, "FM");
	v->type = V4L2_TUNER_RADIO;
	v->rangelow = FREQ_MIN * FREQ_MUL;
	v->rangehigh = FREQ_MAX * FREQ_MUL;
	v->rxsubchans = V4L2_TUNER_SUB_MONO | V4L2_TUNER_SUB_STEREO;
	v->capability = V4L2_TUNER_CAP_LOW;
	if (radio->stereo)
		v->audmode = V4L2_TUNER_MODE_STEREO;
	else
		v->audmode = V4L2_TUNER_MODE_MONO;
	v->signal = 0xffff;     /* Can't get the signal strength, sad.. */
	v->afc = 0; /* Don't know what is this */
342 343

	return retval;
344 345 346 347 348 349
}

/* vidioc_s_tuner - set tuner attributes */
static int vidioc_s_tuner(struct file *file, void *priv,
				struct v4l2_tuner *v)
{
350
	struct amradio_device *radio = file->private_data;
351
	int retval = -EINVAL;
352

353 354
	if (v->index > 0)
		return -EINVAL;
355 356 357 358 359 360 361 362 363 364 365

	/* mono/stereo selector */
	switch (v->audmode) {
	case V4L2_TUNER_MODE_MONO:
		retval = amradio_set_stereo(radio, WANT_MONO);
		break;
	case V4L2_TUNER_MODE_STEREO:
		retval = amradio_set_stereo(radio, WANT_STEREO);
		break;
	}

366
	return retval;
367 368 369 370 371 372
}

/* vidioc_s_frequency - set tuner radio frequency */
static int vidioc_s_frequency(struct file *file, void *priv,
				struct v4l2_frequency *f)
{
373
	struct amradio_device *radio = file->private_data;
374
	int retval = 0;
375

376
	radio->curfreq = f->frequency;
377

378
	retval = amradio_setfreq(radio, radio->curfreq);
379 380

	return retval;
381 382 383 384 385 386
}

/* vidioc_g_frequency - get tuner radio frequency */
static int vidioc_g_frequency(struct file *file, void *priv,
				struct v4l2_frequency *f)
{
387
	struct amradio_device *radio = file->private_data;
388

389 390
	f->type = V4L2_TUNER_RADIO;
	f->frequency = radio->curfreq;
391

392
	return 0;
393 394 395 396 397 398
}

/* vidioc_queryctrl - enumerate control items */
static int vidioc_queryctrl(struct file *file, void *priv,
				struct v4l2_queryctrl *qc)
{
399 400 401
	switch (qc->id) {
	case V4L2_CID_AUDIO_MUTE:
		return v4l2_ctrl_query_fill(qc, 0, 1, 1, 1);
402
	}
403

404 405 406 407 408 409 410
	return -EINVAL;
}

/* vidioc_g_ctrl - get the value of a control */
static int vidioc_g_ctrl(struct file *file, void *priv,
				struct v4l2_control *ctrl)
{
411
	struct amradio_device *radio = file->private_data;
412

413 414 415
	switch (ctrl->id) {
	case V4L2_CID_AUDIO_MUTE:
		ctrl->value = radio->muted;
416
		return 0;
417
	}
418

419
	return -EINVAL;
420 421 422 423 424 425
}

/* vidioc_s_ctrl - set the value of a control */
static int vidioc_s_ctrl(struct file *file, void *priv,
				struct v4l2_control *ctrl)
{
426
	struct amradio_device *radio = file->private_data;
427 428
	int retval = -EINVAL;

429 430
	switch (ctrl->id) {
	case V4L2_CID_AUDIO_MUTE:
431
		if (ctrl->value)
432
			retval = amradio_set_mute(radio, AMRADIO_STOP);
433
		else
434
			retval = amradio_set_mute(radio, AMRADIO_START);
435

436
		break;
437
	}
438 439

	return retval;
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
}

/* vidioc_g_audio - get audio attributes */
static int vidioc_g_audio(struct file *file, void *priv,
				struct v4l2_audio *a)
{
	if (a->index > 1)
		return -EINVAL;

	strcpy(a->name, "Radio");
	a->capability = V4L2_AUDCAP_STEREO;
	return 0;
}

/* vidioc_s_audio - set audio attributes  */
static int vidioc_s_audio(struct file *file, void *priv,
					struct v4l2_audio *a)
{
	if (a->index != 0)
		return -EINVAL;
	return 0;
}

/* vidioc_g_input - get input */
static int vidioc_g_input(struct file *filp, void *priv, unsigned int *i)
{
	*i = 0;
	return 0;
}

/* vidioc_s_input - set input */
static int vidioc_s_input(struct file *filp, void *priv, unsigned int i)
{
	if (i != 0)
		return -EINVAL;
	return 0;
}

478 479 480 481 482
static int usb_amradio_init(struct amradio_device *radio)
{
	int retval;

	retval = amradio_set_mute(radio, AMRADIO_STOP);
483
	if (retval)
484 485 486
		goto out_err;

	retval = amradio_set_stereo(radio, WANT_STEREO);
487
	if (retval)
488 489 490 491 492 493 494 495 496 497 498
		goto out_err;

	radio->initialized = 1;
	goto out;

out_err:
	amradio_dev_err(&radio->videodev.dev, "initialization failed\n");
out:
	return retval;
}

499
/* open device - amradio_start() and amradio_setfreq() */
500
static int usb_amradio_open(struct file *file)
501
{
502
	struct amradio_device *radio = vdev_to_amradio(video_devdata(file));
503
	int retval = 0;
504

505 506
	mutex_lock(&radio->lock);

507
	if (!radio->usbdev) {
508 509 510
		retval = -EIO;
		goto unlock;
	}
511

512
	file->private_data = radio;
513

514 515 516
	if (unlikely(!radio->initialized))
		retval = usb_amradio_init(radio);

517 518 519
unlock:
	mutex_unlock(&radio->lock);
	return retval;
520 521
}

522
/*close device */
523
static int usb_amradio_close(struct file *file)
524
{
525
	struct amradio_device *radio = file->private_data;
526
	int retval = 0;
527

528
	mutex_lock(&radio->lock);
529

530
	if (!radio->usbdev)
531
		retval = -EIO;
532

533 534
	mutex_unlock(&radio->lock);
	return retval;
535 536
}

537 538 539 540 541 542 543 544
static long usb_amradio_ioctl(struct file *file, unsigned int cmd,
				unsigned long arg)
{
	struct amradio_device *radio = file->private_data;
	long retval = 0;

	mutex_lock(&radio->lock);

545
	if (!radio->usbdev) {
546 547 548 549 550 551 552 553 554 555 556
		retval = -EIO;
		goto unlock;
	}

	retval = video_ioctl2(file, cmd, arg);

unlock:
	mutex_unlock(&radio->lock);
	return retval;
}

557 558 559 560 561
/* Suspend device - stop device. Need to be checked and fixed */
static int usb_amradio_suspend(struct usb_interface *intf, pm_message_t message)
{
	struct amradio_device *radio = usb_get_intfdata(intf);

562 563
	mutex_lock(&radio->lock);

564
	if (!radio->muted && radio->initialized) {
565
		amradio_set_mute(radio, AMRADIO_STOP);
566 567
		radio->muted = 0;
	}
568

569
	dev_info(&intf->dev, "going into suspend..\n");
570

571
	mutex_unlock(&radio->lock);
572 573 574 575 576 577 578 579
	return 0;
}

/* Resume device - start device. Need to be checked and fixed */
static int usb_amradio_resume(struct usb_interface *intf)
{
	struct amradio_device *radio = usb_get_intfdata(intf);

580 581
	mutex_lock(&radio->lock);

582 583 584 585
	if (unlikely(!radio->initialized))
		goto unlock;

	if (radio->stereo)
586
		amradio_set_stereo(radio, WANT_STEREO);
587
	else
588
		amradio_set_stereo(radio, WANT_MONO);
589

590
	amradio_setfreq(radio, radio->curfreq);
591

592 593
	if (!radio->muted)
		amradio_set_mute(radio, AMRADIO_START);
594 595

unlock:
596
	dev_info(&intf->dev, "coming out of suspend..\n");
597

598
	mutex_unlock(&radio->lock);
599 600 601 602
	return 0;
}

/* File system interface */
603
static const struct v4l2_file_operations usb_amradio_fops = {
604 605 606
	.owner		= THIS_MODULE,
	.open		= usb_amradio_open,
	.release	= usb_amradio_close,
607
	.ioctl		= usb_amradio_ioctl,
608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624
};

static const struct v4l2_ioctl_ops usb_amradio_ioctl_ops = {
	.vidioc_querycap    = vidioc_querycap,
	.vidioc_g_tuner     = vidioc_g_tuner,
	.vidioc_s_tuner     = vidioc_s_tuner,
	.vidioc_g_frequency = vidioc_g_frequency,
	.vidioc_s_frequency = vidioc_s_frequency,
	.vidioc_queryctrl   = vidioc_queryctrl,
	.vidioc_g_ctrl      = vidioc_g_ctrl,
	.vidioc_s_ctrl      = vidioc_s_ctrl,
	.vidioc_g_audio     = vidioc_g_audio,
	.vidioc_s_audio     = vidioc_s_audio,
	.vidioc_g_input     = vidioc_g_input,
	.vidioc_s_input     = vidioc_s_input,
};

625
static void usb_amradio_video_device_release(struct video_device *videodev)
626
{
627
	struct amradio_device *radio = vdev_to_amradio(videodev);
628

629 630
	v4l2_device_unregister(&radio->v4l2_dev);

631 632 633 634 635
	/* free rest memory */
	kfree(radio->buffer);
	kfree(radio);
}

636
/* check if the device is present and register with v4l and usb if it is */
637 638 639 640
static int usb_amradio_probe(struct usb_interface *intf,
				const struct usb_device_id *id)
{
	struct amradio_device *radio;
641
	int retval = 0;
642

643
	radio = kzalloc(sizeof(struct amradio_device), GFP_KERNEL);
644

645 646
	if (!radio) {
		dev_err(&intf->dev, "kmalloc for amradio_device failed\n");
647 648
		retval = -ENOMEM;
		goto err;
649
	}
650 651 652

	radio->buffer = kmalloc(BUFFER_LENGTH, GFP_KERNEL);

653 654
	if (!radio->buffer) {
		dev_err(&intf->dev, "kmalloc for radio->buffer failed\n");
655 656
		retval = -ENOMEM;
		goto err_nobuf;
657 658
	}

659
	retval = v4l2_device_register(&intf->dev, &radio->v4l2_dev);
660 661
	if (retval < 0) {
		dev_err(&intf->dev, "couldn't register v4l2_device\n");
662
		goto err_v4l2;
663 664
	}

665
	strlcpy(radio->videodev.name, radio->v4l2_dev.name,
666
		sizeof(radio->videodev.name));
667
	radio->videodev.v4l2_dev = &radio->v4l2_dev;
668 669 670
	radio->videodev.fops = &usb_amradio_fops;
	radio->videodev.ioctl_ops = &usb_amradio_ioctl_ops;
	radio->videodev.release = usb_amradio_video_device_release;
671 672 673 674 675 676

	radio->usbdev = interface_to_usbdev(intf);
	radio->curfreq = 95.16 * FREQ_MUL;

	mutex_init(&radio->lock);

677
	video_set_drvdata(&radio->videodev, radio);
678

679 680
	retval = video_register_device(&radio->videodev, VFL_TYPE_RADIO,
					radio_nr);
681
	if (retval < 0) {
682
		dev_err(&intf->dev, "could not register video device\n");
683
		goto err_vdev;
684 685 686 687
	}

	usb_set_intfdata(intf, radio);
	return 0;
688 689

err_vdev:
690
	v4l2_device_unregister(&radio->v4l2_dev);
691 692 693 694 695 696
err_v4l2:
	kfree(radio->buffer);
err_nobuf:
	kfree(radio);
err:
	return retval;
697 698 699 700 701 702
}

static int __init amradio_init(void)
{
	int retval = usb_register(&usb_amradio_driver);

703 704 705
	pr_info(KBUILD_MODNAME
		": version " DRIVER_VERSION " " DRIVER_DESC "\n");

706
	if (retval)
707 708 709
		pr_err(KBUILD_MODNAME
			": usb_register failed. Error number %d\n", retval);

710 711 712 713 714 715 716 717 718 719 720
	return retval;
}

static void __exit amradio_exit(void)
{
	usb_deregister(&usb_amradio_driver);
}

module_init(amradio_init);
module_exit(amradio_exit);