edac_mc.c 30.8 KB
Newer Older
A
Alan Cox 已提交
1 2
/*
 * edac_mc kernel module
3
 * (C) 2005, 2006 Linux Networx (http://lnxi.com)
A
Alan Cox 已提交
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
 * This file may be distributed under the terms of the
 * GNU General Public License.
 *
 * Written by Thayne Harbaugh
 * Based on work by Dan Hollis <goemon at anime dot net> and others.
 *	http://www.anime.net/~goemon/linux-ecc/
 *
 * Modified by Dave Peterson and Doug Thompson
 *
 */

#include <linux/module.h>
#include <linux/proc_fs.h>
#include <linux/kernel.h>
#include <linux/types.h>
#include <linux/smp.h>
#include <linux/init.h>
#include <linux/sysctl.h>
#include <linux/highmem.h>
#include <linux/timer.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/spinlock.h>
#include <linux/list.h>
#include <linux/ctype.h>
D
Dave Jiang 已提交
29
#include <linux/edac.h>
30
#include <linux/bitops.h>
31
#include <linux/uaccess.h>
A
Alan Cox 已提交
32
#include <asm/page.h>
33
#include "edac_mc.h"
34
#include "edac_module.h"
35 36
#include <ras/ras_event.h>

37 38 39 40 41 42
#ifdef CONFIG_EDAC_ATOMIC_SCRUB
#include <asm/edac.h>
#else
#define edac_atomic_scrub(va, size) do { } while (0)
#endif

43 44 45
int edac_op_state = EDAC_OPSTATE_INVAL;
EXPORT_SYMBOL_GPL(edac_op_state);

B
Borislav Petkov 已提交
46 47
static int edac_report = EDAC_REPORTING_ENABLED;

A
Alan Cox 已提交
48
/* lock to memory controller's control array */
49
static DEFINE_MUTEX(mem_ctls_mutex);
50
static LIST_HEAD(mc_devices);
A
Alan Cox 已提交
51

52 53 54 55
/*
 * Used to lock EDAC MC to just one module, avoiding two drivers e. g.
 *	apei/ghes and i7core_edac to be used at the same time.
 */
56
static const char *edac_mc_owner;
57

58
int edac_get_report_status(void)
B
Borislav Petkov 已提交
59 60 61
{
	return edac_report;
}
62
EXPORT_SYMBOL_GPL(edac_get_report_status);
B
Borislav Petkov 已提交
63

64
void edac_set_report_status(int new)
B
Borislav Petkov 已提交
65 66 67 68 69 70
{
	if (new == EDAC_REPORTING_ENABLED ||
	    new == EDAC_REPORTING_DISABLED ||
	    new == EDAC_REPORTING_FORCE)
		edac_report = new;
}
71
EXPORT_SYMBOL_GPL(edac_set_report_status);
B
Borislav Petkov 已提交
72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116

static int edac_report_set(const char *str, const struct kernel_param *kp)
{
	if (!str)
		return -EINVAL;

	if (!strncmp(str, "on", 2))
		edac_report = EDAC_REPORTING_ENABLED;
	else if (!strncmp(str, "off", 3))
		edac_report = EDAC_REPORTING_DISABLED;
	else if (!strncmp(str, "force", 5))
		edac_report = EDAC_REPORTING_FORCE;

	return 0;
}

static int edac_report_get(char *buffer, const struct kernel_param *kp)
{
	int ret = 0;

	switch (edac_report) {
	case EDAC_REPORTING_ENABLED:
		ret = sprintf(buffer, "on");
		break;
	case EDAC_REPORTING_DISABLED:
		ret = sprintf(buffer, "off");
		break;
	case EDAC_REPORTING_FORCE:
		ret = sprintf(buffer, "force");
		break;
	default:
		ret = -EINVAL;
		break;
	}

	return ret;
}

static const struct kernel_param_ops edac_report_ops = {
	.set = edac_report_set,
	.get = edac_report_get,
};

module_param_cb(edac_report, &edac_report_ops, &edac_report, 0644);

117 118
unsigned int edac_dimm_info_location(struct dimm_info *dimm, char *buf,
				     unsigned int len)
119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
{
	struct mem_ctl_info *mci = dimm->mci;
	int i, n, count = 0;
	char *p = buf;

	for (i = 0; i < mci->n_layers; i++) {
		n = snprintf(p, len, "%s %d ",
			      edac_layer_name[mci->layers[i].type],
			      dimm->location[i]);
		p += n;
		len -= n;
		count += n;
		if (!len)
			break;
	}

	return count;
}

A
Alan Cox 已提交
138 139
#ifdef CONFIG_EDAC_DEBUG

140
static void edac_mc_dump_channel(struct rank_info *chan)
A
Alan Cox 已提交
141
{
142 143 144 145
	edac_dbg(4, "  channel->chan_idx = %d\n", chan->chan_idx);
	edac_dbg(4, "    channel = %p\n", chan);
	edac_dbg(4, "    channel->csrow = %p\n", chan->csrow);
	edac_dbg(4, "    channel->dimm = %p\n", chan->dimm);
146 147
}

148
static void edac_mc_dump_dimm(struct dimm_info *dimm)
149
{
150 151
	char location[80];

152 153 154
	if (!dimm->nr_pages)
		return;

155 156 157
	edac_dimm_info_location(dimm, location, sizeof(location));

	edac_dbg(4, "%s%i: %smapped as virtual row %d, chan %d\n",
158
		 dimm->mci->csbased ? "rank" : "dimm",
159
		 dimm->idx, location, dimm->csrow, dimm->cschannel);
160 161 162 163 164
	edac_dbg(4, "  dimm = %p\n", dimm);
	edac_dbg(4, "  dimm->label = '%s'\n", dimm->label);
	edac_dbg(4, "  dimm->nr_pages = 0x%x\n", dimm->nr_pages);
	edac_dbg(4, "  dimm->grain = %d\n", dimm->grain);
	edac_dbg(4, "  dimm->nr_pages = 0x%x\n", dimm->nr_pages);
A
Alan Cox 已提交
165 166
}

167
static void edac_mc_dump_csrow(struct csrow_info *csrow)
A
Alan Cox 已提交
168
{
169 170 171 172 173 174 175 176
	edac_dbg(4, "csrow->csrow_idx = %d\n", csrow->csrow_idx);
	edac_dbg(4, "  csrow = %p\n", csrow);
	edac_dbg(4, "  csrow->first_page = 0x%lx\n", csrow->first_page);
	edac_dbg(4, "  csrow->last_page = 0x%lx\n", csrow->last_page);
	edac_dbg(4, "  csrow->page_mask = 0x%lx\n", csrow->page_mask);
	edac_dbg(4, "  csrow->nr_channels = %d\n", csrow->nr_channels);
	edac_dbg(4, "  csrow->channels = %p\n", csrow->channels);
	edac_dbg(4, "  csrow->mci = %p\n", csrow->mci);
A
Alan Cox 已提交
177 178
}

179
static void edac_mc_dump_mci(struct mem_ctl_info *mci)
A
Alan Cox 已提交
180
{
181 182 183 184 185 186 187 188 189 190 191 192 193
	edac_dbg(3, "\tmci = %p\n", mci);
	edac_dbg(3, "\tmci->mtype_cap = %lx\n", mci->mtype_cap);
	edac_dbg(3, "\tmci->edac_ctl_cap = %lx\n", mci->edac_ctl_cap);
	edac_dbg(3, "\tmci->edac_cap = %lx\n", mci->edac_cap);
	edac_dbg(4, "\tmci->edac_check = %p\n", mci->edac_check);
	edac_dbg(3, "\tmci->nr_csrows = %d, csrows = %p\n",
		 mci->nr_csrows, mci->csrows);
	edac_dbg(3, "\tmci->nr_dimms = %d, dimms = %p\n",
		 mci->tot_dimms, mci->dimms);
	edac_dbg(3, "\tdev = %p\n", mci->pdev);
	edac_dbg(3, "\tmod_name:ctl_name = %s:%s\n",
		 mci->mod_name, mci->ctl_name);
	edac_dbg(3, "\tpvt_info = %p\n\n", mci->pvt_info);
A
Alan Cox 已提交
194 195
}

196 197
#endif				/* CONFIG_EDAC_DEBUG */

198
const char * const edac_mem_types[] = {
199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217
	[MEM_EMPTY]	= "Empty",
	[MEM_RESERVED]	= "Reserved",
	[MEM_UNKNOWN]	= "Unknown",
	[MEM_FPM]	= "FPM",
	[MEM_EDO]	= "EDO",
	[MEM_BEDO]	= "BEDO",
	[MEM_SDR]	= "Unbuffered-SDR",
	[MEM_RDR]	= "Registered-SDR",
	[MEM_DDR]	= "Unbuffered-DDR",
	[MEM_RDDR]	= "Registered-DDR",
	[MEM_RMBS]	= "RMBS",
	[MEM_DDR2]	= "Unbuffered-DDR2",
	[MEM_FB_DDR2]	= "FullyBuffered-DDR2",
	[MEM_RDDR2]	= "Registered-DDR2",
	[MEM_XDR]	= "XDR",
	[MEM_DDR3]	= "Unbuffered-DDR3",
	[MEM_RDDR3]	= "Registered-DDR3",
	[MEM_LRDDR3]	= "Load-Reduced-DDR3-RAM",
	[MEM_DDR4]	= "Unbuffered-DDR4",
218
	[MEM_RDDR4]	= "Registered-DDR4",
219
	[MEM_LRDDR4]	= "Load-Reduced-DDR4-RAM",
220
	[MEM_NVDIMM]	= "Non-volatile-RAM",
221 222 223
};
EXPORT_SYMBOL_GPL(edac_mem_types);

224 225 226 227 228 229
/**
 * edac_align_ptr - Prepares the pointer offsets for a single-shot allocation
 * @p:		pointer to a pointer with the memory offset to be used. At
 *		return, this will be incremented to point to the next offset
 * @size:	Size of the data structure to be reserved
 * @n_elems:	Number of elements that should be reserved
A
Alan Cox 已提交
230 231
 *
 * If 'size' is a constant, the compiler will optimize this whole function
232 233 234 235 236 237 238 239 240
 * down to either a no-op or the addition of a constant to the value of '*p'.
 *
 * The 'p' pointer is absolutely needed to keep the proper advancing
 * further in memory to the proper offsets when allocating the struct along
 * with its embedded structs, as edac_device_alloc_ctl_info() does it
 * above, for example.
 *
 * At return, the pointer 'p' will be incremented to be used on a next call
 * to this function.
A
Alan Cox 已提交
241
 */
242
void *edac_align_ptr(void **p, unsigned int size, int n_elems)
A
Alan Cox 已提交
243
{
244
	unsigned int align, r;
245
	void *ptr = *p;
A
Alan Cox 已提交
246

247 248 249 250 251 252 253 254
	*p += size * n_elems;

	/*
	 * 'p' can possibly be an unaligned item X such that sizeof(X) is
	 * 'size'.  Adjust 'p' so that its alignment is at least as
	 * stringent as what the compiler would provide for X and return
	 * the aligned result.
	 * Here we assume that the alignment of a "long long" is the most
A
Alan Cox 已提交
255 256 257 258 259 260 261 262 263 264 265 266
	 * stringent alignment that the compiler will ever provide by default.
	 * As far as I know, this is a reasonable assumption.
	 */
	if (size > sizeof(long))
		align = sizeof(long long);
	else if (size > sizeof(int))
		align = sizeof(long);
	else if (size > sizeof(short))
		align = sizeof(int);
	else if (size > sizeof(char))
		align = sizeof(short);
	else
267
		return (char *)ptr;
A
Alan Cox 已提交
268

269
	r = (unsigned long)p % align;
A
Alan Cox 已提交
270 271

	if (r == 0)
272
		return (char *)ptr;
A
Alan Cox 已提交
273

274 275
	*p += align - r;

276
	return (void *)(((unsigned long)ptr) + align - r);
A
Alan Cox 已提交
277 278
}

279 280 281
static void _edac_mc_free(struct mem_ctl_info *mci)
{
	struct csrow_info *csr;
282
	int i, chn, row;
283 284

	if (mci->dimms) {
285
		for (i = 0; i < mci->tot_dimms; i++)
286 287 288
			kfree(mci->dimms[i]);
		kfree(mci->dimms);
	}
289

290
	if (mci->csrows) {
291
		for (row = 0; row < mci->nr_csrows; row++) {
292
			csr = mci->csrows[row];
293 294 295 296 297 298 299
			if (!csr)
				continue;

			if (csr->channels) {
				for (chn = 0; chn < mci->num_cschannel; chn++)
					kfree(csr->channels[chn]);
				kfree(csr->channels);
300
			}
301
			kfree(csr);
302 303 304 305 306 307
		}
		kfree(mci->csrows);
	}
	kfree(mci);
}

308 309
struct mem_ctl_info *edac_mc_alloc(unsigned int mc_num,
				   unsigned int n_layers,
310
				   struct edac_mc_layer *layers,
311
				   unsigned int sz_pvt)
A
Alan Cox 已提交
312 313
{
	struct mem_ctl_info *mci;
314
	struct edac_mc_layer *layer;
315 316
	struct csrow_info *csr;
	struct rank_info *chan;
317
	struct dimm_info *dimm;
318
	u32 *ce_per_layer[EDAC_MAX_LAYERS], *ue_per_layer[EDAC_MAX_LAYERS];
319
	unsigned int pos[EDAC_MAX_LAYERS];
320
	unsigned int idx, size, tot_dimms = 1, count = 1;
321
	unsigned int tot_csrows = 1, tot_channels = 1, tot_errcount = 0;
322
	void *pvt, *p, *ptr = NULL;
323
	int i, j, row, chn, n, len;
324 325
	bool per_rank = false;

326 327
	if (WARN_ON(n_layers > EDAC_MAX_LAYERS || n_layers == 0))
		return NULL;
328

329 330 331 332
	/*
	 * Calculate the total amount of dimms and csrows/cschannels while
	 * in the old API emulation mode
	 */
333 334 335 336 337
	for (idx = 0; idx < n_layers; idx++) {
		tot_dimms *= layers[idx].size;

		if (layers[idx].is_virt_csrow)
			tot_csrows *= layers[idx].size;
338
		else
339
			tot_channels *= layers[idx].size;
340

341
		if (layers[idx].type == EDAC_MC_LAYER_CHIP_SELECT)
342 343
			per_rank = true;
	}
A
Alan Cox 已提交
344 345 346 347 348 349

	/* Figure out the offsets of the various items from the start of an mc
	 * structure.  We want the alignment of each item to be at least as
	 * stringent as what the compiler would provide if we could simply
	 * hardcode everything into a single struct.
	 */
350
	mci = edac_align_ptr(&ptr, sizeof(*mci), 1);
351 352 353
	layer = edac_align_ptr(&ptr, sizeof(*layer), n_layers);
	for (i = 0; i < n_layers; i++) {
		count *= layers[i].size;
354
		edac_dbg(4, "errcount layer %d size %d\n", i, count);
355 356 357 358 359
		ce_per_layer[i] = edac_align_ptr(&ptr, sizeof(u32), count);
		ue_per_layer[i] = edac_align_ptr(&ptr, sizeof(u32), count);
		tot_errcount += 2 * count;
	}

360
	edac_dbg(4, "allocating %d error counters\n", tot_errcount);
361
	pvt = edac_align_ptr(&ptr, sz_pvt, 1);
362
	size = ((unsigned long)pvt) + sz_pvt;
A
Alan Cox 已提交
363

364 365 366 367 368
	edac_dbg(1, "allocating %u bytes for mci data (%d %s, %d csrows/channels)\n",
		 size,
		 tot_dimms,
		 per_rank ? "ranks" : "dimms",
		 tot_csrows * tot_channels);
369

370 371
	mci = kzalloc(size, GFP_KERNEL);
	if (mci == NULL)
A
Alan Cox 已提交
372 373 374 375 376
		return NULL;

	/* Adjust pointers so they point within the memory we just allocated
	 * rather than an imaginary chunk of memory located at address 0.
	 */
377 378 379 380 381
	layer = (struct edac_mc_layer *)(((char *)mci) + ((unsigned long)layer));
	for (i = 0; i < n_layers; i++) {
		mci->ce_per_layer[i] = (u32 *)((char *)mci + ((unsigned long)ce_per_layer[i]));
		mci->ue_per_layer[i] = (u32 *)((char *)mci + ((unsigned long)ue_per_layer[i]));
	}
382
	pvt = sz_pvt ? (((char *)mci) + ((unsigned long)pvt)) : NULL;
A
Alan Cox 已提交
383

384
	/* setup index and various internal pointers */
385 386
	mci->mc_idx = mc_num;
	mci->tot_dimms = tot_dimms;
A
Alan Cox 已提交
387
	mci->pvt_info = pvt;
388 389 390 391 392
	mci->n_layers = n_layers;
	mci->layers = layer;
	memcpy(mci->layers, layers, sizeof(*layer) * n_layers);
	mci->nr_csrows = tot_csrows;
	mci->num_cschannel = tot_channels;
393
	mci->csbased = per_rank;
A
Alan Cox 已提交
394

395
	/*
396
	 * Alocate and fill the csrow/channels structs
397
	 */
J
Joe Perches 已提交
398
	mci->csrows = kcalloc(tot_csrows, sizeof(*mci->csrows), GFP_KERNEL);
399 400
	if (!mci->csrows)
		goto error;
401
	for (row = 0; row < tot_csrows; row++) {
402 403 404 405
		csr = kzalloc(sizeof(**mci->csrows), GFP_KERNEL);
		if (!csr)
			goto error;
		mci->csrows[row] = csr;
406 407 408
		csr->csrow_idx = row;
		csr->mci = mci;
		csr->nr_channels = tot_channels;
J
Joe Perches 已提交
409
		csr->channels = kcalloc(tot_channels, sizeof(*csr->channels),
410 411 412
					GFP_KERNEL);
		if (!csr->channels)
			goto error;
413 414

		for (chn = 0; chn < tot_channels; chn++) {
415 416 417 418
			chan = kzalloc(sizeof(**csr->channels), GFP_KERNEL);
			if (!chan)
				goto error;
			csr->channels[chn] = chan;
A
Alan Cox 已提交
419
			chan->chan_idx = chn;
420 421 422 423 424
			chan->csrow = csr;
		}
	}

	/*
425
	 * Allocate and fill the dimm structs
426
	 */
J
Joe Perches 已提交
427
	mci->dimms  = kcalloc(tot_dimms, sizeof(*mci->dimms), GFP_KERNEL);
428 429 430
	if (!mci->dimms)
		goto error;

431 432 433
	memset(&pos, 0, sizeof(pos));
	row = 0;
	chn = 0;
434
	for (idx = 0; idx < tot_dimms; idx++) {
435
		chan = mci->csrows[row]->channels[chn];
436

437
		dimm = kzalloc(sizeof(**mci->dimms), GFP_KERNEL);
438 439
		if (!dimm)
			goto error;
440
		mci->dimms[idx] = dimm;
441
		dimm->mci = mci;
442
		dimm->idx = idx;
443

444 445 446 447 448 449 450 451 452 453 454 455 456 457
		/*
		 * Copy DIMM location and initialize it.
		 */
		len = sizeof(dimm->label);
		p = dimm->label;
		n = snprintf(p, len, "mc#%u", mc_num);
		p += n;
		len -= n;
		for (j = 0; j < n_layers; j++) {
			n = snprintf(p, len, "%s#%u",
				     edac_layer_name[layers[j].type],
				     pos[j]);
			p += n;
			len -= n;
458 459
			dimm->location[j] = pos[j];

460 461 462 463
			if (len <= 0)
				break;
		}

464 465 466 467 468 469
		/* Link it to the csrows old API data */
		chan->dimm = dimm;
		dimm->csrow = row;
		dimm->cschannel = chn;

		/* Increment csrow location */
470
		if (layers[0].is_virt_csrow) {
471
			chn++;
472 473 474 475 476 477 478 479 480 481
			if (chn == tot_channels) {
				chn = 0;
				row++;
			}
		} else {
			row++;
			if (row == tot_csrows) {
				row = 0;
				chn++;
			}
482
		}
483

484 485 486 487 488 489
		/* Increment dimm location */
		for (j = n_layers - 1; j >= 0; j--) {
			pos[j]++;
			if (pos[j] < layers[j].size)
				break;
			pos[j] = 0;
A
Alan Cox 已提交
490 491 492
		}
	}

493
	mci->op_state = OP_ALLOC;
494

A
Alan Cox 已提交
495
	return mci;
496 497

error:
498
	_edac_mc_free(mci);
499 500

	return NULL;
501
}
502
EXPORT_SYMBOL_GPL(edac_mc_alloc);
A
Alan Cox 已提交
503 504 505

void edac_mc_free(struct mem_ctl_info *mci)
{
506
	edac_dbg(1, "\n");
507

508 509
	if (device_is_registered(&mci->dev))
		edac_unregister_sysfs(mci);
510

511
	_edac_mc_free(mci);
A
Alan Cox 已提交
512
}
513
EXPORT_SYMBOL_GPL(edac_mc_free);
A
Alan Cox 已提交
514

515 516 517 518 519 520 521 522 523 524 525 526 527 528
bool edac_has_mcs(void)
{
	bool ret;

	mutex_lock(&mem_ctls_mutex);

	ret = list_empty(&mc_devices);

	mutex_unlock(&mem_ctls_mutex);

	return !ret;
}
EXPORT_SYMBOL_GPL(edac_has_mcs);

529 530
/* Caller must hold mem_ctls_mutex */
static struct mem_ctl_info *__find_mci_by_dev(struct device *dev)
A
Alan Cox 已提交
531 532 533 534
{
	struct mem_ctl_info *mci;
	struct list_head *item;

535
	edac_dbg(3, "\n");
A
Alan Cox 已提交
536 537 538 539

	list_for_each(item, &mc_devices) {
		mci = list_entry(item, struct mem_ctl_info, link);

540
		if (mci->pdev == dev)
A
Alan Cox 已提交
541 542 543 544 545
			return mci;
	}

	return NULL;
}
546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563

/**
 * find_mci_by_dev
 *
 *	scan list of controllers looking for the one that manages
 *	the 'dev' device
 * @dev: pointer to a struct device related with the MCI
 */
struct mem_ctl_info *find_mci_by_dev(struct device *dev)
{
	struct mem_ctl_info *ret;

	mutex_lock(&mem_ctls_mutex);
	ret = __find_mci_by_dev(dev);
	mutex_unlock(&mem_ctls_mutex);

	return ret;
}
564
EXPORT_SYMBOL_GPL(find_mci_by_dev);
A
Alan Cox 已提交
565

566 567 568 569 570 571
/*
 * edac_mc_workq_function
 *	performs the operation scheduled by a workq request
 */
static void edac_mc_workq_function(struct work_struct *work_req)
{
J
Jean Delvare 已提交
572
	struct delayed_work *d_work = to_delayed_work(work_req);
573 574 575 576
	struct mem_ctl_info *mci = to_edac_mem_ctl_work(d_work);

	mutex_lock(&mem_ctls_mutex);

577
	if (mci->op_state != OP_RUNNING_POLL) {
578 579 580 581
		mutex_unlock(&mem_ctls_mutex);
		return;
	}

B
Borislav Petkov 已提交
582
	if (edac_op_state == EDAC_OPSTATE_POLL)
583 584 585 586
		mci->edac_check(mci);

	mutex_unlock(&mem_ctls_mutex);

587
	/* Queue ourselves again. */
B
Borislav Petkov 已提交
588
	edac_queue_work(&mci->work, msecs_to_jiffies(edac_mc_get_poll_msec()));
589 590 591
}

/*
592 593 594 595
 * edac_mc_reset_delay_period(unsigned long value)
 *
 *	user space has updated our poll period value, need to
 *	reset our workq delays
596
 */
597
void edac_mc_reset_delay_period(unsigned long value)
598
{
599 600 601 602 603 604 605 606
	struct mem_ctl_info *mci;
	struct list_head *item;

	mutex_lock(&mem_ctls_mutex);

	list_for_each(item, &mc_devices) {
		mci = list_entry(item, struct mem_ctl_info, link);

607 608
		if (mci->op_state == OP_RUNNING_POLL)
			edac_mod_work(&mci->work, value);
609
	}
610 611 612
	mutex_unlock(&mem_ctls_mutex);
}

613 614


615 616 617
/* Return 0 on success, 1 on failure.
 * Before calling this function, caller must
 * assign a unique value to mci->mc_idx.
618 619 620 621
 *
 *	locking model:
 *
 *		called with the mem_ctls_mutex lock held
622
 */
623
static int add_mc_to_global_list(struct mem_ctl_info *mci)
A
Alan Cox 已提交
624 625 626 627
{
	struct list_head *item, *insert_before;
	struct mem_ctl_info *p;

628
	insert_before = &mc_devices;
A
Alan Cox 已提交
629

630
	p = __find_mci_by_dev(mci->pdev);
631
	if (unlikely(p != NULL))
632
		goto fail0;
A
Alan Cox 已提交
633

634 635
	list_for_each(item, &mc_devices) {
		p = list_entry(item, struct mem_ctl_info, link);
A
Alan Cox 已提交
636

637 638 639
		if (p->mc_idx >= mci->mc_idx) {
			if (unlikely(p->mc_idx == mci->mc_idx))
				goto fail1;
A
Alan Cox 已提交
640

641 642
			insert_before = item;
			break;
A
Alan Cox 已提交
643 644 645 646 647
		}
	}

	list_add_tail_rcu(&mci->link, insert_before);
	return 0;
648

649
fail0:
650
	edac_printk(KERN_WARNING, EDAC_MC,
651
		"%s (%s) %s %s already assigned %d\n", dev_name(p->pdev),
652
		edac_dev_name(mci), p->mod_name, p->ctl_name, p->mc_idx);
653 654
	return 1;

655
fail1:
656
	edac_printk(KERN_WARNING, EDAC_MC,
657 658
		"bug in low-level driver: attempt to assign\n"
		"    duplicate mc_idx %d in %s()\n", p->mc_idx, __func__);
659
	return 1;
A
Alan Cox 已提交
660 661
}

662
static int del_mc_from_global_list(struct mem_ctl_info *mci)
663 664
{
	list_del_rcu(&mci->link);
665 666 667 668 669 670

	/* these are for safe removal of devices from global list while
	 * NMI handlers may be traversing list
	 */
	synchronize_rcu();
	INIT_LIST_HEAD(&mci->link);
671

B
Borislav Petkov 已提交
672
	return list_empty(&mc_devices);
673 674
}

675
struct mem_ctl_info *edac_mc_find(int idx)
676
{
677
	struct mem_ctl_info *mci;
678
	struct list_head *item;
679 680

	mutex_lock(&mem_ctls_mutex);
681 682 683

	list_for_each(item, &mc_devices) {
		mci = list_entry(item, struct mem_ctl_info, link);
684 685
		if (mci->mc_idx == idx)
			goto unlock;
686 687
	}

688
	mci = NULL;
689 690 691
unlock:
	mutex_unlock(&mem_ctls_mutex);
	return mci;
692 693 694
}
EXPORT_SYMBOL(edac_mc_find);

695 696 697 698 699
const char *edac_get_owner(void)
{
	return edac_mc_owner;
}
EXPORT_SYMBOL_GPL(edac_get_owner);
A
Alan Cox 已提交
700 701

/* FIXME - should a warning be printed if no error detection? correction? */
702 703
int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci,
			       const struct attribute_group **groups)
A
Alan Cox 已提交
704
{
705
	int ret = -EINVAL;
706
	edac_dbg(0, "\n");
707

A
Alan Cox 已提交
708 709 710
#ifdef CONFIG_EDAC_DEBUG
	if (edac_debug_level >= 3)
		edac_mc_dump_mci(mci);
D
Dave Peterson 已提交
711

A
Alan Cox 已提交
712
	if (edac_debug_level >= 4) {
713
		struct dimm_info *dimm;
A
Alan Cox 已提交
714 715 716
		int i;

		for (i = 0; i < mci->nr_csrows; i++) {
717 718
			struct csrow_info *csrow = mci->csrows[i];
			u32 nr_pages = 0;
A
Alan Cox 已提交
719
			int j;
D
Dave Peterson 已提交
720

721 722 723 724 725 726 727 728
			for (j = 0; j < csrow->nr_channels; j++)
				nr_pages += csrow->channels[j]->dimm->nr_pages;
			if (!nr_pages)
				continue;
			edac_mc_dump_csrow(csrow);
			for (j = 0; j < csrow->nr_channels; j++)
				if (csrow->channels[j]->dimm->nr_pages)
					edac_mc_dump_channel(csrow->channels[j]);
A
Alan Cox 已提交
729
		}
730 731 732

		mci_for_each_dimm(mci, dimm)
			edac_mc_dump_dimm(dimm);
A
Alan Cox 已提交
733 734
	}
#endif
735
	mutex_lock(&mem_ctls_mutex);
A
Alan Cox 已提交
736

737 738 739 740 741
	if (edac_mc_owner && edac_mc_owner != mci->mod_name) {
		ret = -EPERM;
		goto fail0;
	}

A
Alan Cox 已提交
742
	if (add_mc_to_global_list(mci))
743
		goto fail0;
A
Alan Cox 已提交
744 745 746 747

	/* set load time so that error rate can be tracked */
	mci->start_time = jiffies;

748
	mci->bus = edac_get_sysfs_subsys();
B
Borislav Petkov 已提交
749

750
	if (edac_create_sysfs_mci_device(mci, groups)) {
751
		edac_mc_printk(mci, KERN_WARNING,
752
			"failed to create sysfs device\n");
753 754
		goto fail1;
	}
A
Alan Cox 已提交
755

756
	if (mci->edac_check) {
757 758
		mci->op_state = OP_RUNNING_POLL;

759 760 761
		INIT_DELAYED_WORK(&mci->work, edac_mc_workq_function);
		edac_queue_work(&mci->work, msecs_to_jiffies(edac_mc_get_poll_msec()));

762 763 764 765
	} else {
		mci->op_state = OP_RUNNING_INTERRUPT;
	}

A
Alan Cox 已提交
766
	/* Report action taken */
767 768 769 770
	edac_mc_printk(mci, KERN_INFO,
		"Giving out device to module %s controller %s: DEV %s (%s)\n",
		mci->mod_name, mci->ctl_name, mci->dev_name,
		edac_op_state_to_string(mci->op_state));
A
Alan Cox 已提交
771

772 773
	edac_mc_owner = mci->mod_name;

774
	mutex_unlock(&mem_ctls_mutex);
775
	return 0;
A
Alan Cox 已提交
776

777
fail1:
778 779
	del_mc_from_global_list(mci);

780
fail0:
781
	mutex_unlock(&mem_ctls_mutex);
782
	return ret;
A
Alan Cox 已提交
783
}
784
EXPORT_SYMBOL_GPL(edac_mc_add_mc_with_groups);
A
Alan Cox 已提交
785

786
struct mem_ctl_info *edac_mc_del_mc(struct device *dev)
A
Alan Cox 已提交
787
{
788
	struct mem_ctl_info *mci;
A
Alan Cox 已提交
789

790
	edac_dbg(0, "\n");
791

792
	mutex_lock(&mem_ctls_mutex);
793

794
	/* find the requested mci struct in the global list */
795
	mci = __find_mci_by_dev(dev);
796
	if (mci == NULL) {
797
		mutex_unlock(&mem_ctls_mutex);
798 799 800
		return NULL;
	}

801 802 803
	/* mark MCI offline: */
	mci->op_state = OP_OFFLINE;

B
Borislav Petkov 已提交
804
	if (del_mc_from_global_list(mci))
805
		edac_mc_owner = NULL;
806

807
	mutex_unlock(&mem_ctls_mutex);
808

809
	if (mci->edac_check)
810
		edac_stop_work(&mci->work);
811 812

	/* remove from sysfs */
813 814
	edac_remove_sysfs_mci_device(mci);

D
Dave Peterson 已提交
815
	edac_printk(KERN_INFO, EDAC_MC,
816
		"Removed device %d for %s %s: DEV %s\n", mci->mc_idx,
817
		mci->mod_name, mci->ctl_name, edac_dev_name(mci));
818

819
	return mci;
A
Alan Cox 已提交
820
}
821
EXPORT_SYMBOL_GPL(edac_mc_del_mc);
A
Alan Cox 已提交
822

823 824
static void edac_mc_scrub_block(unsigned long page, unsigned long offset,
				u32 size)
A
Alan Cox 已提交
825 826 827 828 829
{
	struct page *pg;
	void *virt_addr;
	unsigned long flags = 0;

830
	edac_dbg(3, "\n");
A
Alan Cox 已提交
831 832

	/* ECC error page was not in our memory. Ignore it. */
833
	if (!pfn_valid(page))
A
Alan Cox 已提交
834 835 836 837 838 839 840 841
		return;

	/* Find the actual page structure then map it and fix */
	pg = pfn_to_page(page);

	if (PageHighMem(pg))
		local_irq_save(flags);

842
	virt_addr = kmap_atomic(pg);
A
Alan Cox 已提交
843 844

	/* Perform architecture specific atomic scrub operation */
845
	edac_atomic_scrub(virt_addr + offset, size);
A
Alan Cox 已提交
846 847

	/* Unmap and complete */
848
	kunmap_atomic(virt_addr);
A
Alan Cox 已提交
849 850 851 852 853 854

	if (PageHighMem(pg))
		local_irq_restore(flags);
}

/* FIXME - should return -1 */
D
Dave Peterson 已提交
855
int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, unsigned long page)
A
Alan Cox 已提交
856
{
857
	struct csrow_info **csrows = mci->csrows;
858
	int row, i, j, n;
A
Alan Cox 已提交
859

860
	edac_dbg(1, "MC%d: 0x%lx\n", mci->mc_idx, page);
A
Alan Cox 已提交
861 862 863
	row = -1;

	for (i = 0; i < mci->nr_csrows; i++) {
864
		struct csrow_info *csrow = csrows[i];
865 866
		n = 0;
		for (j = 0; j < csrow->nr_channels; j++) {
867
			struct dimm_info *dimm = csrow->channels[j]->dimm;
868 869 870
			n += dimm->nr_pages;
		}
		if (n == 0)
A
Alan Cox 已提交
871 872
			continue;

873 874 875 876
		edac_dbg(3, "MC%d: first(0x%lx) page(0x%lx) last(0x%lx) mask(0x%lx)\n",
			 mci->mc_idx,
			 csrow->first_page, page, csrow->last_page,
			 csrow->page_mask);
A
Alan Cox 已提交
877 878 879 880 881 882 883 884 885 886 887

		if ((page >= csrow->first_page) &&
		    (page <= csrow->last_page) &&
		    ((page & csrow->page_mask) ==
		     (csrow->first_page & csrow->page_mask))) {
			row = i;
			break;
		}
	}

	if (row == -1)
D
Dave Peterson 已提交
888
		edac_mc_printk(mci, KERN_ERR,
889 890
			"could not look up page error address %lx\n",
			(unsigned long)page);
A
Alan Cox 已提交
891 892 893

	return row;
}
894
EXPORT_SYMBOL_GPL(edac_mc_find_csrow_by_page);
A
Alan Cox 已提交
895

896 897 898 899 900
const char *edac_layer_name[] = {
	[EDAC_MC_LAYER_BRANCH] = "branch",
	[EDAC_MC_LAYER_CHANNEL] = "channel",
	[EDAC_MC_LAYER_SLOT] = "slot",
	[EDAC_MC_LAYER_CHIP_SELECT] = "csrow",
901
	[EDAC_MC_LAYER_ALL_MEM] = "memory",
902 903 904 905
};
EXPORT_SYMBOL_GPL(edac_layer_name);

static void edac_inc_ce_error(struct mem_ctl_info *mci,
906 907 908
			      bool enable_per_layer_report,
			      const int pos[EDAC_MAX_LAYERS],
			      const u16 count)
A
Alan Cox 已提交
909
{
910
	int i, index = 0;
A
Alan Cox 已提交
911

912
	mci->ce_mc += count;
A
Alan Cox 已提交
913

914
	if (!enable_per_layer_report) {
915
		mci->ce_noinfo_count += count;
A
Alan Cox 已提交
916 917
		return;
	}
D
Dave Peterson 已提交
918

919 920 921 922
	for (i = 0; i < mci->n_layers; i++) {
		if (pos[i] < 0)
			break;
		index += pos[i];
923
		mci->ce_per_layer[i][index] += count;
924 925 926 927 928 929 930 931

		if (i < mci->n_layers - 1)
			index *= mci->layers[i + 1].size;
	}
}

static void edac_inc_ue_error(struct mem_ctl_info *mci,
				    bool enable_per_layer_report,
932 933
				    const int pos[EDAC_MAX_LAYERS],
				    const u16 count)
934 935 936
{
	int i, index = 0;

937
	mci->ue_mc += count;
938 939

	if (!enable_per_layer_report) {
940
		mci->ue_noinfo_count += count;
A
Alan Cox 已提交
941 942 943
		return;
	}

944 945 946 947
	for (i = 0; i < mci->n_layers; i++) {
		if (pos[i] < 0)
			break;
		index += pos[i];
948
		mci->ue_per_layer[i][index] += count;
949

950 951 952 953
		if (i < mci->n_layers - 1)
			index *= mci->layers[i + 1].size;
	}
}
A
Alan Cox 已提交
954

955
static void edac_ce_error(struct mem_ctl_info *mci,
956
			  const u16 error_count,
957 958 959 960 961 962 963 964 965
			  const int pos[EDAC_MAX_LAYERS],
			  const char *msg,
			  const char *location,
			  const char *label,
			  const char *detail,
			  const char *other_detail,
			  const bool enable_per_layer_report,
			  const unsigned long page_frame_number,
			  const unsigned long offset_in_page,
966
			  long grain)
967 968
{
	unsigned long remapped_page;
969 970 971 972
	char *msg_aux = "";

	if (*msg)
		msg_aux = " ";
973 974 975 976

	if (edac_mc_get_log_ce()) {
		if (other_detail && *other_detail)
			edac_mc_printk(mci, KERN_WARNING,
977 978 979
				       "%d CE %s%son %s (%s %s - %s)\n",
				       error_count, msg, msg_aux, label,
				       location, detail, other_detail);
980 981
		else
			edac_mc_printk(mci, KERN_WARNING,
982 983 984
				       "%d CE %s%son %s (%s %s)\n",
				       error_count, msg, msg_aux, label,
				       location, detail);
985
	}
986
	edac_inc_ce_error(mci, enable_per_layer_report, pos, error_count);
A
Alan Cox 已提交
987

988
	if (mci->scrub_mode == SCRUB_SW_SRC) {
A
Alan Cox 已提交
989
		/*
990 991 992 993 994 995 996 997 998 999
			* Some memory controllers (called MCs below) can remap
			* memory so that it is still available at a different
			* address when PCI devices map into memory.
			* MC's that can't do this, lose the memory where PCI
			* devices are mapped. This mapping is MC-dependent
			* and so we call back into the MC driver for it to
			* map the MC page to a physical (CPU) page which can
			* then be mapped to a virtual page - which can then
			* be scrubbed.
			*/
A
Alan Cox 已提交
1000
		remapped_page = mci->ctl_page_to_phys ?
1001 1002
			mci->ctl_page_to_phys(mci, page_frame_number) :
			page_frame_number;
A
Alan Cox 已提交
1003

1004 1005
		edac_mc_scrub_block(remapped_page,
					offset_in_page, grain);
A
Alan Cox 已提交
1006 1007 1008
	}
}

1009
static void edac_ue_error(struct mem_ctl_info *mci,
1010
			  const u16 error_count,
1011 1012 1013 1014 1015 1016 1017
			  const int pos[EDAC_MAX_LAYERS],
			  const char *msg,
			  const char *location,
			  const char *label,
			  const char *detail,
			  const char *other_detail,
			  const bool enable_per_layer_report)
A
Alan Cox 已提交
1018
{
1019 1020 1021 1022 1023
	char *msg_aux = "";

	if (*msg)
		msg_aux = " ";

1024 1025 1026
	if (edac_mc_get_log_ue()) {
		if (other_detail && *other_detail)
			edac_mc_printk(mci, KERN_WARNING,
1027 1028 1029
				       "%d UE %s%son %s (%s %s - %s)\n",
				       error_count, msg, msg_aux, label,
				       location, detail, other_detail);
1030 1031
		else
			edac_mc_printk(mci, KERN_WARNING,
1032 1033 1034
				       "%d UE %s%son %s (%s %s)\n",
				       error_count, msg, msg_aux, label,
				       location, detail);
1035
	}
D
Dave Peterson 已提交
1036

1037 1038
	if (edac_mc_get_panic_on_ue()) {
		if (other_detail && *other_detail)
1039 1040
			panic("UE %s%son %s (%s%s - %s)\n",
			      msg, msg_aux, label, location, detail, other_detail);
1041
		else
1042 1043
			panic("UE %s%son %s (%s%s)\n",
			      msg, msg_aux, label, location, detail);
1044 1045
	}

1046
	edac_inc_ue_error(mci, enable_per_layer_report, pos, error_count);
A
Alan Cox 已提交
1047 1048
}

1049 1050 1051 1052 1053 1054
void edac_raw_mc_handle_error(const enum hw_event_mc_err_type type,
			      struct mem_ctl_info *mci,
			      struct edac_raw_error_desc *e)
{
	char detail[80];
	int pos[EDAC_MAX_LAYERS] = { e->top_layer, e->mid_layer, e->low_layer };
1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069
	u8 grain_bits;

	/* Sanity-check driver-supplied grain value. */
	if (WARN_ON_ONCE(!e->grain))
		e->grain = 1;

	grain_bits = fls_long(e->grain - 1);

	/* Report the error via the trace interface */
	if (IS_ENABLED(CONFIG_RAS))
		trace_mc_event(type, e->msg, e->label, e->error_count,
			       mci->mc_idx, e->top_layer, e->mid_layer,
			       e->low_layer,
			       (e->page_frame_number << PAGE_SHIFT) | e->offset_in_page,
			       grain_bits, e->syndrome, e->other_detail);
1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091

	/* Memory type dependent details about the error */
	if (type == HW_EVENT_ERR_CORRECTED) {
		snprintf(detail, sizeof(detail),
			"page:0x%lx offset:0x%lx grain:%ld syndrome:0x%lx",
			e->page_frame_number, e->offset_in_page,
			e->grain, e->syndrome);
		edac_ce_error(mci, e->error_count, pos, e->msg, e->location, e->label,
			      detail, e->other_detail, e->enable_per_layer_report,
			      e->page_frame_number, e->offset_in_page, e->grain);
	} else {
		snprintf(detail, sizeof(detail),
			"page:0x%lx offset:0x%lx grain:%ld",
			e->page_frame_number, e->offset_in_page, e->grain);

		edac_ue_error(mci, e->error_count, pos, e->msg, e->location, e->label,
			      detail, e->other_detail, e->enable_per_layer_report);
	}


}
EXPORT_SYMBOL_GPL(edac_raw_mc_handle_error);
1092

1093 1094
void edac_mc_handle_error(const enum hw_event_mc_err_type type,
			  struct mem_ctl_info *mci,
1095
			  const u16 error_count,
1096 1097 1098
			  const unsigned long page_frame_number,
			  const unsigned long offset_in_page,
			  const unsigned long syndrome,
1099 1100 1101
			  const int top_layer,
			  const int mid_layer,
			  const int low_layer,
1102
			  const char *msg,
1103
			  const char *other_detail)
A
Alan Cox 已提交
1104
{
1105
	struct dimm_info *dimm;
1106 1107
	char *p;
	int row = -1, chan = -1;
1108
	int pos[EDAC_MAX_LAYERS] = { top_layer, mid_layer, low_layer };
1109 1110
	int i, n_labels = 0;
	struct edac_raw_error_desc *e = &mci->error_desc;
A
Alan Cox 已提交
1111

1112
	edac_dbg(3, "MC%d\n", mci->mc_idx);
A
Alan Cox 已提交
1113

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
	/* Fills the error report buffer */
	memset(e, 0, sizeof (*e));
	e->error_count = error_count;
	e->top_layer = top_layer;
	e->mid_layer = mid_layer;
	e->low_layer = low_layer;
	e->page_frame_number = page_frame_number;
	e->offset_in_page = offset_in_page;
	e->syndrome = syndrome;
	e->msg = msg;
	e->other_detail = other_detail;

1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147
	/*
	 * Check if the event report is consistent and if the memory
	 * location is known. If it is known, enable_per_layer_report will be
	 * true, the DIMM(s) label info will be filled and the per-layer
	 * error counters will be incremented.
	 */
	for (i = 0; i < mci->n_layers; i++) {
		if (pos[i] >= (int)mci->layers[i].size) {

			edac_mc_printk(mci, KERN_ERR,
				       "INTERNAL ERROR: %s value is out of range (%d >= %d)\n",
				       edac_layer_name[mci->layers[i].type],
				       pos[i], mci->layers[i].size);
			/*
			 * Instead of just returning it, let's use what's
			 * known about the error. The increment routines and
			 * the DIMM filter logic will do the right thing by
			 * pointing the likely damaged DIMMs.
			 */
			pos[i] = -1;
		}
		if (pos[i] >= 0)
1148
			e->enable_per_layer_report = true;
A
Alan Cox 已提交
1149 1150
	}

1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161
	/*
	 * Get the dimm label/grain that applies to the match criteria.
	 * As the error algorithm may not be able to point to just one memory
	 * stick, the logic here will get all possible labels that could
	 * pottentially be affected by the error.
	 * On FB-DIMM memory controllers, for uncorrected errors, it is common
	 * to have only the MC channel and the MC dimm (also called "branch")
	 * but the channel is not known, as the memory is arranged in pairs,
	 * where each memory belongs to a separate channel within the same
	 * branch.
	 */
1162
	p = e->label;
1163
	*p = '\0';
1164

1165
	mci_for_each_dimm(mci, dimm) {
1166
		if (top_layer >= 0 && top_layer != dimm->location[0])
1167
			continue;
1168
		if (mid_layer >= 0 && mid_layer != dimm->location[1])
1169
			continue;
1170
		if (low_layer >= 0 && low_layer != dimm->location[2])
1171
			continue;
A
Alan Cox 已提交
1172

1173
		/* get the max grain, over the error match range */
1174 1175
		if (dimm->grain > e->grain)
			e->grain = dimm->grain;
1176

1177 1178 1179 1180 1181 1182
		/*
		 * If the error is memory-controller wide, there's no need to
		 * seek for the affected DIMMs because the whole
		 * channel/memory controller/...  may be affected.
		 * Also, don't show errors for empty DIMM slots.
		 */
1183 1184
		if (!e->enable_per_layer_report || !dimm->nr_pages)
			continue;
1185

1186 1187 1188 1189 1190 1191 1192 1193
		if (n_labels >= EDAC_MAX_LABELS) {
			e->enable_per_layer_report = false;
			break;
		}
		n_labels++;
		if (p != e->label) {
			strcpy(p, OTHER_LABEL);
			p += strlen(OTHER_LABEL);
1194
		}
1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213
		strcpy(p, dimm->label);
		p += strlen(p);

		/*
		 * get csrow/channel of the DIMM, in order to allow
		 * incrementing the compat API counters
		 */
		edac_dbg(4, "%s csrows map: (%d,%d)\n",
			mci->csbased ? "rank" : "dimm",
			dimm->csrow, dimm->cschannel);
		if (row == -1)
			row = dimm->csrow;
		else if (row >= 0 && row != dimm->csrow)
			row = -2;

		if (chan == -1)
			chan = dimm->cschannel;
		else if (chan >= 0 && chan != dimm->cschannel)
			chan = -2;
1214 1215
	}

1216 1217
	if (!e->enable_per_layer_report) {
		strcpy(e->label, "any memory");
1218
	} else {
1219
		edac_dbg(4, "csrow/channel to increment: (%d,%d)\n", row, chan);
1220 1221
		if (p == e->label)
			strcpy(e->label, "unknown memory");
1222 1223
		if (type == HW_EVENT_ERR_CORRECTED) {
			if (row >= 0) {
1224
				mci->csrows[row]->ce_count += error_count;
1225
				if (chan >= 0)
1226
					mci->csrows[row]->channels[chan]->ce_count += error_count;
1227 1228 1229
			}
		} else
			if (row >= 0)
1230
				mci->csrows[row]->ue_count += error_count;
1231 1232
	}

1233
	/* Fill the RAM location data */
1234
	p = e->location;
1235

1236 1237 1238
	for (i = 0; i < mci->n_layers; i++) {
		if (pos[i] < 0)
			continue;
1239

1240 1241 1242
		p += sprintf(p, "%s:%d ",
			     edac_layer_name[mci->layers[i].type],
			     pos[i]);
1243
	}
1244
	if (p > e->location)
1245 1246
		*(p - 1) = '\0';

1247
	edac_raw_mc_handle_error(type, mci, e);
1248
}
1249
EXPORT_SYMBOL_GPL(edac_mc_handle_error);