Improve the `AvocadoParams.iteritems()` to return unique items only
in the same fashion `multiplexer` does it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

dmesg -c does not work well in multi-user/execution scenario and also it
removes the messages for debugging purposes on the system. Let's store
full dmesg and leave it up-to the users to diff it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

From Fedora 22 onwards, DNF is the official package
manager of that distro. Although mostly similar to
yum, there are a few differences that must be taken
to account (besides, the yum wrapper that ships with
dnf is going to go deprecated eventually).

So introduce a basic DnfBackend class and detection
to software manager.

The yum subcommand 'localinstall' has been deprecated on yum,
and it's not supported on the new generation program dnf.
Let's simplify the code and use simply 'install' in all cases.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Plugins: remove external plugin support

In preparation for the large plugin refactor, let's simplify the code ASAP
and drop related (custom) functionality that is going to be replaced.

Standard setuptools entrypoints is going to provide better capability then
our custom code that supports external 'avocado_*.py'module loading.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Use pure git URL for users getting started with Avocado

The other URL, which denotes git+ssh, requires the user to acknowledge
host SSH keys and so forth. Let's keep things simple.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado/core/data_dir.py: rely on `tempfile.mkstemp()` to choose a te…

avocado.core.loader: Return empty list instead of None:

From the Python `tempfile.mkstemp()` docs:

The default directory is chosen from a platform-dependent list, but
the user of the application can control the directory location by
setting the TMPDIR, TEMP or TMP environment variables.

So, let's let `tempfile.mkstemp()` itself choose the temp dir, based
on what the use may have set in environment variables.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Makefile: Use mock to build RPMs

Instead of trusting in rpmbuild to do the rpm builds,
use mock - a program that builds the rpms from fresh
chroots. This ensures that BuildRequires are correct
and that the binary rpms build cleanly.

This requires a few changes to the Makefile targets
and the avocado spec file, laid out in this patch.

Also, add instructions on how to fulfill deps to build
RPM packages.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The plugin's discover() method should always return a
list of tests, and not None, since the discover() method
in TestLoaderProxy uses .extend(), that only works with
an iterable. This fixes the issue found when running
`avocado list` (no arguments passed to list):

Test discovery plugin <avocado.core.loader.ExternalLoader object at 0x7f5b42978850> failed: 'NoneType' object is not iterable
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Package build updates

Add a setuptools dependency at build time to keep
build requirements synchronized.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Recent ubuntu versions require explicit python-setuptools
dependencies, so we have to oblige.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

avocado: Add a maintenance guide

Mass import cleanups

Ubuntu build updates

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The option --prune is not available anymore in setup.py.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This is an automated mass import cleanup across all
avocado source files:

1) Imports follow the order:
 * Standard library imports
 * Non standard library external imports
 * Internal imports
 All separated by a single line
2) One line between imports and the rest of the code
3) Remove unused imports in the process
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In order for the process to not get lost and help newer
maintainers, here's a writeup with the steps to keep in
mind when releasing avocado.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

[V2] Add tag docs

Give a brief explanation of the test detection mechanism
and link to WritingTests for more details on how to use
the test tags.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add a note about safe test loading and the docstring
tags functionality.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Test Loader: support for enable/disable docstring tags [v2]

Since the test loader now attempts to find Avocado instrumented tests
by using a parser and doesn't really load/execute test files, it can't
tell if a given class inherits from avocado.Test.

For those cases, a developer may signal, using a docstring tag, that
either:

 * A test class that doesn't look like an Avocado test class is indeed
   one ("🥑 enable")
 * A test class that looks like an Avocado test class should not be
   treated as such ("🥑 disable")

Also included is a a simple optimization by breaking earlier from the
parser loop.

Changes from v1:
   * Added two more tests and suggestions by Lukáš Doktor

Changes from v0:
   * Added fix reported by Lukáš Doktor
Signed-off-by: NCleber Rosa <crosa@redhat.com>
CC: Lukáš Doktor <ldoktor@redhat.com>

Inside test classes there may docstrings which may contain tags that
give special meaning. The tags are defined by "🥑 <value>" in a
single line. For now the only two "official" Avocado tags values
exist:

 * enable: the class is an Avocado INSTRUMENTED test, even if it
   doesn't "look like" one.
 * disable: the class is *NOT* an Avocado INSTRUMENTED test, even if
   looks like one.

Changes from v0:
 * Use unittest2 on Python 2.6
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Sphinx will attempt to fetch the Python objects inventory during the build
process. If for some reason, this test is being run on a machine that can
not access that address simply because of network restrictions (or the
developer may simply be on a plane) then it's better to SKIP the test than
to give a false positive.

Changes from v0:
 * Use unittest2 on Python 2.6
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.core.loader: improve the --loaders [v2b]

Previously loader plugins simply ignored extra_params, which were not
supported. With this patch plugins must take care of all extra_params or
it raises an exception explaining what went wrong.

It also adds default handling for "allowed_test_types", which only
supports simple string and checks, whether the specified test type is
the only supported test type. (external and avocado-vt uses this)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This patch doesn't change any functionality, it only renames the
inner_runner to external_runner (the plugin is called simply external)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Autopep8 style cleanup + alphabetic import + import cleanup in
avocado.core.{loader,test} and selftests.functional.test_basic.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently InnerRunner lives within the FileLoader plugin and overrides
it's function in case inner_runner is supplied. This patch extracts
it and creates separate plugin for it. This plugin is still part of the
core and is registered automatically during the runtime.

On --inner-runner usage it overrides the --loader order and registers
only itself as by specifying --inner-runner people asks to use it.

When inner_runner is specified in --loader, it's processed accordingly
to the priority. When one uses only "inner_runner" without extra_params,
it never matches any tests (to keep the behavior).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>