Just like the next block is doing.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The module path only get's updated on the AvocadoModule constructor,
so after that, it won't change and the `path` variable is thus
unnecessary.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Adding info about the missing `is_avocado` parameter, and remove
docstring for non existing parameter (most probably a leftover from
_examine_class()).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJan Richter <jarichte@redhat.com>

Merge branch 'selftests_extract_from_checkall' of https://github.com/clebergnu/avocado into clebergnu-selftests_extract_from_checkall

Selftests: extract from checkall

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the requirement target for "check", given that it's already
called from the selftests/checkall script.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

These are superior than the ones defined in the test, and using them
removes the duplicate code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The network utility used to (attempt to) get a free port defaults to
picking sequential ports.  But, that's not a requirement of this test.
When running tests in parallel, the same port may get allocated when a
sequential approach is used, and that is greatly minimized when random
ports are requested.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When working on a private fork and topic branches, it's helpful to not
have this limitation, and have builds triggered for them.

For the main repo, it should not a problem given that branches are not
often (only on LTS releases), and those are also desirable to have
builds run.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of one large test method, let's have one for each.  Also,
let's define the base_logdir from the calling side, as with that
we can be sure that the test won't do any funky business, and
the tearDown() won't be trying to recursively remove what it
shouldn't.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Before and after variants get inserted.  This should make it easier to
both follow the code, and eventually to make the test factory a
documented structure.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

On all tested Python 3 versions, the SimpleQueue is available from
the multiprocessing module, so let's drop the conditional import.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

A "from <module> import <symbol>" statement will not always have
a module name set, one example is:

   from . import BASEDIR

In these situations, the statement's module attribute will be None.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which are only necessary under Python 2, and thus, not needed
anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The previous working dropping Python 2, removed the explicit
requirement of the six module, but because stevedore depends
on it, it would still be installed.

Now, every trace of explicit six usage has been removed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJan Richter <jarichte@redhat.com>

As there's no reason for this file to be executable.

Reference: https://github.com/avocado-framework/avocado/issues/3064Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Added append_file, append_one_line functions to genio.
There are situations where files with more than one line
are to be created with some filtered data. In those
situations, the existing functions namely write_file,
write_one_line are not helping.
Signed-off-by: NNageswara R Sastry <rnsastry@linux.vnet.ibm.com>

Settings Dispatcher: move it to its own module

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

fixed redhat distro version check in Rhel8.0
/etc/redhat-release output pattern changed

cat /etc/redhat-release
Red Hat Enterprise Linux release 8.0 Beta (Ootpa)

changed regex pattern which handle Rhel8 case as well
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because of deprecation according to author.

Reference: https://github.com/avocado-framework/avocado/issues/3074Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need to keep the special conditions for Python 2, now that
it's not supported anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This test actually works fine under Python 3, the skip was not
properly lifted before.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We can now just use the module name as in Python 3 standard library.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python version used to run Avocado is not being respected in this
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>