When wrapping process, the parameter for a local wrap is defined
by using a shell-like glob interface (*make for example).

So remove the parts that mentions the old behavior (absolute
 and relative paths comparison), before the changes
introduced in commit f6bf2c02

Also, drop obvious and thus useless comment about the wrapper when
it's expressed as a relative path
Signed-off-by: NRudá Moura <rmoura@redhat.com>

API Review (5th round) - Fixed

This module depends closely on the, already moved, avocado.core.remoter
module. Let's move it along.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The reason for the chosen name is that avocado.core already has a
remote module (directory) related to (remote) TestRunner and
TestResults.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

One of the possibilities when Avocado delegates the execution of a process to
the utility library process is undefined behavior.

This can help, for example, when this library is set to run processes in more
complex environments, including with users manipulating these process inside
debuggers.

Previously, we would have the process utility module with knowledge about
an Avocado internal exception that flags that a test should exist as SKIP
in these circunstances. Now, to avoid these prior knowledge and layer
violation, let the user of the API register which exception should be
raised when such situations occur.

A more complex version of this change, deemed unnecessary for now,
would be to register callbacks which could, in turn, raise those exceptions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

While still making the VERSION symbol available in the top level
Avocado module. Even though this is very simple information that
could live under the avocado module itself, it would break the
consistency of having avocado.core importing from avocado (toplevel).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The runtime module had already been diminished by moving some of its
well, runtime configurations, directly to appropriate modules.
The still standing runtime configurations are: current test and
current job.

It's clearly *not* the best design to have common utility modules,
that is, avocado.utils with *knowledge* about the inner workings
of an external entity such as the Avocado Job and Test classes.
It would be much better for Avocado Job and Test classes to
register hooks/callbacks with the utility methods in a agnostic
way.

Since some of the utility modules were not designed as external
entities, the coupling is still pretty tight, and some more
profound API changes would be necessary.

For now, our goal is to avoid the crossing of boundaries when it
comes to importing and using modules, having a sane, layered approach.

The next level, still pending, is to remove this knowledge dependency
and make the utility code trully generic.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of having a "common ground" that two namespaces would import and
share runtime information, let's just make the plugin set the defaults
for the module.

This is the same approache used for the GDB utility module.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of having a "common ground" that two namespaces would import and
share runtime information, let's just make the plugin set the defaults
for the module.

This is quite appropriate, both regarding the namespace where the
configurations are kept (in the avocado.utils.gdb module itself) and
also regarding the single direction of module layering.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This check is being added to both to checkall and to travis.yaml,
s o that either in local and remote (CI) checks this can be quickly
flagged.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So that it doesn't match when we look for out of boundaries imports
throughout our code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Modify the path when running as standalone test.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Modify the --tree view to look like linux "tree" command and add support
to display content, inherited values or both.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Without this patch the root node path is ''. With this patch it returns
path-like '/'.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The current implementation iterates through the avaliable key/values
and displays only the last value per unique key. This patch uses
the value origin and displays the "origin:key => value" for all
unique available records per variant.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "--system-wide|-s" option can be used to display the result of
only the files user asked for or the whole package including nodes/values
defined by plugins and other branches.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

sort imports alphabetically.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

 core.loader: Log discover_url exceptions [v1]

Add a bunch of avocado unittests and verify functionally
how they respond to being run under python (default unittest
runner).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Introduced with commit d6abdcd4,
avocado tests no longer report correctly to the unittest runner.
The reason is that there is a structure that must be correctly
updated by the run() method (the result instance), that was not
being updated in the new implementation.

Therefore, one possible fix, presented here, is to once again
*not* implement run() at all. this way we avoid messing around
with internal data structures, and when avocado is executed
under nosetests, or the default unittest runner, we get the
expected behavior of the method. The downside is that we have
less perceived integration among both classes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Unittests only consider exceptions derived from AssertionError
to be actual failures. Although TestFail is more of a generic
'this test failed' kind of thing, for all intents and purposes
it doesn't impact the rest of avocado. So, let's make the change.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The `discover_url` function should not fail, instead it should return
empty results. In case of failure, it's impossible to find out what
went wrong as we don't log any details, thus it might happen that
`avocado list` shows tests, which are not found during `avocado run`.
This patch temporarily logs reason into the `avocado.app.exceptions`
and traceback into the `avocado.app.traceback` logger. Booth are
enabled by default, but the plan is to make these optional and
show only the `exceptions` by default.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This function is a wrapper around logging.getLogger and it uses the
same format as log_exc_info. It's useful for logging exception details
and other explanation to specific logger.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When exception travels across multiple try/except blocks it's hard to
find where the "log_exc_info" was called from. This information is
not part of the traceback but is quite good place to see why
is the exception harmful.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

API review: implement relative imports also on avocado.core.*

The same approach has already been applied to avocado.utils itself
and it's documented at:

https://www.python.org/dev/peps/pep-0328/Signed-off-by: NCleber Rosa <crosa@redhat.com>

API Review: add test methods for SKIP/FAIL/ERROR themselves

setup.py: add missing module avocado.utils.external

It was previously not possible for a test to skip itself (due to say,
missing requirements) during the setUp() phase. Any exception caught
at this point was reflected as a test failure.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Instead of playing with core exceptions or downgrading those exceptions
to the base Test API, let's allow users to do so with convenience
methods.

The example tests now make use of those, and can now remain in the
examples directory instead of the former proposal of turning them
into "functional test assets" and moving them to the selftests
directory.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The new location was not reflected on the setup.py script, resulting
in the module not being present after installation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Add option to read a custom configuration from a file ǘ[v2]

avocado.core.remote.runner: When setup/teardown fails, exit gently.

When setup() or tear_down() fails, Avocado
will provide a gentle error message and a proper exit code and
put the traceback in the test log.

  ./scripts/avocado run --remote-host nowhereland passtest
  LOGIN      : rmoura@nowhereland:22
  Avocado job failed: JobError: Name lookup failed for nowhereland

Prior to this commit, when setup or tear_down failed,
Avocado dumps the traceback and prints that it crashed, which
can potentially confuses the user.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Use command line --config to read a custom configuration from a file.
Note this option is for the avocado application, so it has
effect for all subcommands.

Example:

$ avocado --config /var/tmp/avocado.conf config
Config files read (in order):
/home/rmoura/Work/avocado/etc/avocado/avocado.conf
/home/rmoura/Work/avocado/etc/avocado/conf.d/gdb.conf
/var/tmp/avocado.conf
...

Also, update man-page about the new option --config.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

To introduce the command option --config, it requires to use
the _process_config_path() method outside avocado.core.settings, so
let's make it public as process_config_path().
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Documentation Review (3rd round)