Those test runners are implemented as TestResult classes, so they may
also signal their intention to use stdout.  If they don't, both the
RemoteTestResult/VMTestResult and HumanTestResult will end up using
the stdout.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The docker cleanup can sometimes fail, which masks the original failure.
This patch catches all exceptions and only log them to UI as warnings.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `docker run` command can actually take longer, when pulling the
image from hub. Let's remove the timeout completelly.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `docker run` command can actually produce several lines of output
(eg pulling the image) before it writes the container id. Let's use only
the last line when getting the cid.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The cleanup fails when the remote docker connection is not established.
This skips the cleanup when the resource was not yet created.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

* https://github.com/avocado-framework/avocado:
  avocado.core.runner: Remove the unused setup/tear_down methods
  avocado.core.remote: Style fixes in runner
  avocado.core.remote: Improve the `tear_down` execution
  avocado.core.remote: Improve VMTestRunner tear_down method
  avocado.core.remote: Handle urls without assigned files
  avocado.plugins: Add plugin to run job in docker container

The `setup` and `tear_down` methods are defined in `TestRunner`, but
they are not handleded, nor used by it. This is dangerous, because even
from description they give the impression, that you can simply implement
them and they'll magically does the job.

Those methods are used inside `RemoteRunner` and they should only be
defined there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

For some reason the RemoteTestRunner's tear_down is only called on
`setup` errors, or after the testing. This patch removes the special
handling and adds the `tear_down` into `try/finally` block starting with
`setup` and ending when the testing is done. This should make sure that
we always run `tear_down` in RemoteTestRunner.

This means there is no need for special handling in `VMTestRunner`
anymore so it has been removed too.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The tear_down method can be currently called even before the `self.vm`
is initialized, producing an ugly traceback. This patch only cleanups
the vm when it's initialized and undefines it afterwards, so multiple
runs won't restore the snapshot multiple times.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The remote runner url=>file is rather simple, it takes the url and if
the file does not exists, it uses test_dir + url. Fabric should copy
that file, but it silently ignores missing files, therefor (unless the
file already exists on the remote machine) it fails later in the code
with "Unable to discover ...".

This patch adds check to make sure the mapped file exists. If not it
raises exception.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Similarly to --remote or --vm plugins this plugin allows one to run the
job inside a docker container by specifying the docker image. It
executes a new container, then attaches it and uses it similarly as
--remote plugin uses remote machine.

To check it out you can use "ldoktor/fedora-avocado" image which is
available on (the default) hub.docker.com
Signed-off-by: NCleber Rosa <crosa@redhat.com>
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This reverts commit 00e9aa46.

* https://github.com/avocado-framework/avocado:
  docs: remove mentions of tagged_name test property
  avocado/core/test.py: remove support for string test names and tags

* https://github.com/avocado-framework/avocado:
  Result: use FileOrStdoutAction on result plugins and app
  Parser: introduce FileOrStdoutAction

This change replaces the in-job logic to deal with the standard output
with the FileOrStdoutAction that does it at the command line parsing
time.  Then, it deals with a possible command line option conflict (the
first two players that attempt to use stdout) at the application level,
exiting the application in such case.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The goal of this custom command line parser action is to move the
logic of incompatible options out of the job layer.  The execution
of a job should have no knowledge about plugins that are attempting
to use the standard output.

One hint is left on the processed arguments, a key named
`stdout_claimed_by` that can be used by the rest of the application to
decide if they should use the stdout or not.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

During the implementation of test ids (5973e898) some references to the
tagged name of a test were left in the docs.

Let's remove them for good.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When the support for Test IDs was introduced, support for string based
test names and tags was kept in deprecated mode, scheduled to be
removed on an upcoming release.

This planned upcoming release for removal has already passed, so let's
remove them now.

Reference: https://trello.com/c/QqZmfkYtSigned-off-by: NCleber Rosa <crosa@redhat.com>

Deal with IOError due to (EPIPE) [v2]

* https://github.com/avocado-framework/avocado:
  Adding more release notes versions
  Organize release notes
  Improve documentation index

By ignoring the exception, and preventing Avocado from crashing.
Since the actions inside the block that may trigger an IOError are the
writes to stdout and stderr, we can be pretty confident that there
will be no adverse effects.

Reference: https://trello.com/c/sztjbAXySigned-off-by: NCleber Rosa <crosa@redhat.com>

Another batch of release notes.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Let's create a release_notes directory and an dedicated index file.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Add captions to separate sections in readthedocs left menu.
Remove the heads as we are now using captions.
Fix anchors.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

This reverts commit a82f2acf.

With this option, a test that ends with a 'bad' status will make
the job to be interrupted.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Including the release notes in our docs.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

examples: Add `make spell` to testplan

Support for spell checking had been added to avocado recently, let's
make that mandatory step of manual testplan.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Now users can execute 'avocado run --replay latest' to have the latest
job replayed. No need to remember the job id.

Reference: https://trello.com/c/C0YCTT6dSigned-off-by: NAmador Pahim <apahim@redhat.com>