The use of "deepcopy" should not be necessary as we only use it here to
override certain keys with our values, not to modify their value.

Even if (theoretically) modified those mutable values later in the
code, it'd have been done even without "deepcopy" for cases where we
didn't forced the "args".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit makes sure all inputs in yaml2mux plugin are decoded and
passed as unicodes to variants. As a consequence this allows to actually
use this plugin on python3 environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The fingerprint might contain unicode characters, let's use
"astring.ENCODING" to avoid EncodeErrors.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

For computers this does not really matters, but for people the use of
'\n' make debugging slightly easier.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This replaces the naive "str()" approach of turning objects into strings
with proper "astring.to_text" alternative that should take care of the
proper encoding and works well on py2 as well as py3.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Explicitly close the files we are using.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We use "iteritems()" on this object which on py2 results int
"dict.iteritems", but on py3 it uses "dict.items". Because we want to
modify the outcome we need to replace the "dict.items" with the slow
implementation using "__getitem__" internally.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We use the __str__ to generate fingerprint and re-ordering the set leads
to different fingerprints.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change updates the handle_exception function so it doesn't need to
use a bare-except anymore. The code except responsible for get the crash
directory was kept in a separeted function. This specific code snippet
can't raise any exception. Internally it uses the
avocado.utils.path.usable_rw_dir that already deals with possible
exceptions.

Another possible point of exception could be the import of
avocado.core.data_dir module before avocado be installed itself. However
this import was moved to the initial block of import and dealed proper
as ImportError.

This way seems all the code insisde try block keep being processed by
try-except blocks without bare-except like before.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

I was trying to use the external runner, in a reasonably simple way:
from within a project (QEMU) build dir, I'd run:

 $ avocado run --external-runner=tests/qemu-iotests/check \
   --external-runner-chdir=runner -- 001 002

But, what should work, did not.  The problem is with the non-absolute
path to the external runner, that is needed because we're changing
directories.

Absolute paths won't hurt otherwise (when no chdir is done), so it's
always done here.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

added disk utility
1- get_disk_blocksize -- this function return block size of given disk(path)
2- get_disks -- this function return all disk present in system
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The iterating through module statements and lookout for classes is
strictly tied to module status (avocado imports). Let's move it into the
"AvocadoModule" and only treat classes in "find_avocado_tests".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some of our inputs were not protected against unwanted input, resulting
in interrupted discovery and no tests reported. Let's fix that and make
sure we keep discovering them.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables pylint check w0631. Since the only occurrence is on
external spark library, it was disabled specifically.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This check makes sure the excepts in try/except are not duplicated
regarding the exception type.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

We'll need to pass those information to other functions, let's bundle
them to make the code clearer. (keep using "path" internally as
accessing local variable is faster)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "test_import" and "mod_import" are not really necessary as we store
"test_import_name" and "mod_import_name", which can never be empty
string. Let's depend solely on names.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The build directory of the main Avocado module is already cleaned by
the `clean` rule, but when plugins contain a build directory, they are
not currently cleaned.

Sometimes this leads to annoying `inspekt` failures, because previous
different versions of the plugin may be in the build directory, and
the error message only mentions the name of the module/class/method
violating the check, but not the exact file name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Besides enabling the check, this change also makes ISO9660PyCDLib
inherit from MixInMntDirMount so it has the implementation of
mount_dir() property.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The W0223 pylint check warns about any abstract method which is not
implemented by subclasses. Currently this warning are being raised for
VMImageHtmlParser (Python 3.7). However it seems it happens because an
open Python bug[1] about HtmlParser not implementing the error()
abstract method of (inner) superclass _markupase.ParserBase().

To enable avocado project checks for cases like that, this change
disables the related check only for the specific case.

[1] - https://bugs.python.org/issue31844Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

added utility which return modules directory path of running kernel

after this patch

>>> from avocado.utils import linux_modules
>>> print linux_modules.get_modules_dir()
/lib/modules/4.6.4-201.fc23.x86_64/kernel
>>>
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This pylint checks for possible redefining outer names. Some occurrences
was preserved with disable flag because they would broke some public
api, like method/functions names or parameters.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The W0613 check for unnused arguments. The most of the current cases
seems legitmate so the proper flag was added in each line so pylint can
ignore it.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

fixed pep8 issue in script
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

This pylint check makes sure the log message is not built in log
statement itself, but uses the proper argument from logger to do it
lazy.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>