fixed pep8 issue on line no 319
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

In SUSE distro distro.detect() is failing as undefined variable

log:
START 1-generic/sosreport.py:sosreport_test.test;run-cd82
Test metadata:
  filename: /root/avocado-fvt-wrapper/tests/avocado-misc-tests/generic/sosreport.py
DATA (filename=output.expected) => NOT FOUND (data sources: variant, test, file)

Reproduced traceback from: /usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/core/test.py:814
Traceback (most recent call last):
  File "/root/avocado-fvt-wrapper/tests/avocado-misc-tests/generic/sosreport.py", line 42, in setUp
    dist = distro.detect()
  File "/usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/utils/distro.py", line 416, in detect
    distro_result = probe_instance.get_distro()
  File "/usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/utils/distro.py", line 370, in get_distro
    with open(self.check_file) as check_file:
AttributeError: 'SUSEProbe' object has no attribute 'check_file'
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Server infrastructure: switch default URLs to HTTPS

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Test statuses: do not rely on varianter_yaml_to_mux plugin

HTTPS has been enabled on the avocado-project.org server, so let's use
it by default on docs and when downloading images from it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Avocado used to provide support for "test aliases", that is, one could
call "avocado run synctest" when the file containing the test was
named "synctest.py".  See e65ff614 for an example.

Since this "feature" has been long removed, let's remove the tests
also.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Remove variable assigments that are used just once and never actually
used.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And not a directory.  Tests were being always skipped becaused of that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The directory check is being performed, but without value to the test.
Let's turn it into an assertion.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  SIMPLE tests: improve status API

Currently simple tests have a limited status API, being able to set only
the WARN status by generating an output string in a very specific and
hard-coded format.

This patch, while respects the current behaviour, creates configuration
keys, allowing users to provide regular expressions to search for in the
test outputs, aiming to set the final test status to either WARN or SKIP
when the test finishes with exit code 0.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Which is an optional plugin, and the test statuses feature is at the
innermost core of Avocado.  While the original test indeed saved a lot
of duplicated code, it's code that serves a specific testing purpose,
and it's better to be simpler and more verbose and with the right (no)
dependencies.

This issue came up during the Python 3 port work.  Now that all the
unittests (selftests/unit/*) were passing (locally, there's one other
PR pending to be accepted), the next logical step is getting the
"core" functional (selftests/functional/*) tests passing.  Because
the 'varianter_yaml_to_mux' optional plugins port is not done, the
"core" functional tests fail and the current work flow is broken.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Success rate to use the following formula:

    ( PASS + WARN ) / ( TOTAL - SKIP - CANCEL ) * 100
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The commit 3a66bcbf is causing the
"selftests.functional.test_basic.RunnerOperationTest.test_read" selftest
to fail.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Whiteboard was (probably accidentally) removed from the test attributes.
This patch recreates the whiteboard.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's a difference on how Python 2 and 3 represents a set(), which is true
for the set derived FilterSet.  It just happens the a tree fingerprint
depends on its environment, which depends on the FilterSet representation.

Let's provide a predictive __repr__ implementation, and consequently, a
predictive fingerprint for Trees across Python versions.

This fixes the following unittest failure on Python 3:

   FAIL: test_fingerprint (selftests.unit.test_tree.TreeNode)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/home/cleber/src/avocado/avocado/selftests/unit/test_tree.py", line 63, in test_fingerprint
       "/foo{},{},FilterSet([]),FilterSet([])")
   AssertionError: '/foo{},{},FilterSet(),FilterSet()' != '/foo{},{},FilterSet([]),FilterSet([])'
   - /foo{},{},FilterSet(),FilterSet()
   + /foo{},{},FilterSet([]),FilterSet([])
   ?                     ++            ++
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The YAML Test Loader is sending the messages for the UI. They
should go to the Job Log instead.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Count WARN in to calculate the success rate in the HTML report.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Add support to provide input with subprocess.Popen's stdin.write
method. Optionally flush the input buffer.
Signed-off-by: NHarish <harish@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Recently we introduced "in-package-config" which is packaged by default
with Avocado and in the original version if exists the system-wide
config is not used at all. I think this is unexpected behavior as users
are used to set configs in /etc so this patch changes it to first use
in-package-config, then in-etc-config and last the user-config.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Unless a lower version is set as a requirement, the RPM building
process will attempt to download from PyPI, which is not allowed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

In case no suitable jobdir location can be created (user basically can't
write anywhere) Avocado crashes without a meaningful message, let's
provide one.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The user-config location ("~/.config/avocado.conf") might not be
writable by users (usually when executing in docker without user
home-dir). Let's use the file if available, but don't fail in case we
fail to produce it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Some tweaks here and there found during the upkeep.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>