IMHO short names for Makefile targets are desirable, so let's shorten
the names of the Debian related targets. Also, they better match the
RPM target names like that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Simple attempt to give the help message output a better look.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

To simplify usage with python2.6 add requirements-python26.txt which
adds python2.6 requirements (on top of requirements.txt). It includes
booth avocado and selftest dependencies and is automatically invoked
when running on system with python 2.6.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Without the --upgrade the installation fails when the package of
incompatible version is already installed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This fixes the recently introduced commit 5f7bafd0, running the skip
function instead of passing the function itself to `unittest.skipIf`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

selftests/functional/test_output.py: skip test on absence of PIL library

The `test_gendata` test of `OutputTest` runs the example test
`gendata.py`, but the `gendata.py` itself has a conditional in one of
the tests that make use of the PIL (aka Pillow package) library and
does nothing if it's missing.

PIL (Pillow) is highly dependent on C compilers and libraries to be
able to build itself. This makes systems it harder to run the full
Avocado self tests on more diverse (usually minimalist) systems.

So, let's make that functional test optional, if the libraries are not
present.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Human output: functional test fixes [v2]

There are a couple of functional unittests that assume that a given
output was produced by the regular UI, that is, the Human output
format.

That is fine, since they're functional tests. But, some situations
lead to test errors, instead of pointing failures. Let's turn those
into explicit checks and fail properly instead of producing errors.

Note: These errors were visible when the human output was disabled, in
the plugin overhaul work, but the fixes still make sense independently
of that work.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

scripts.avocado: Use /var/tmp if TMP not set in env

Some distributions mount /tmp as tmpfs, which does not implement all
usual filesystem functions, like O_DIRECT flag. This causes problems for
some tests. Let's check if the user already set TMP in environment and
if not, try to use /var/tmp by default.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

virtualenv: allow tests to run properly on them

While going through the dependency list (requirements*.txt files) and
performing our self tests out of virtual environments, I noticed that
some tests are run outside the virtual environments.

The reason is that, even though the virtual environment is activated
for the test session (and say, `which python` gives `/venv/bin/python`),
we have hard coded `/usr/bin/python` in most places.

According to the some discussions on the virtualenv project itself[1],
a quick solution is to revert to the also common `/usr/bin/env python`
way of pointing to the Python interpreter.

[1] - https://github.com/pypa/virtualenv/issues/124Signed-off-by: NCleber Rosa <crosa@redhat.com>

Fix test providers checkout

Var "lbranch" was hard coded to "master", so it was never copied from var "branch".

"make check" needs pydot to run.

We used to support subtests filter to load only some of the avocado
tests, but the functionality is broken. This patch brings this
functionality back. It uses "re.search" so people can use partial
matches. Additionally it includes selftests to prevent future breakages.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This patch adds unittest for loading simple tests with arguments.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

requirements-travis.txt: Require inspektor 0.2.0

Inspektor 0.2.0 has some improvements in the queue,
mainly now by default we are going to start being
picky on unused imports. Which is something I wanted
to do for a long time.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

avocado: Fixing unused imports

This was caught by modified inspektor check. I'm still
working on inspektor, meanwhile let's send this fix.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

When the test process exits before the deadline, it raises exception
while trying to destroy it. Let's just ignore the OSError and proceed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently the test status was only updated on `TestStatus.check` method,
which was also used in `TestStatus.abort`. But the meaning of `check`
return is whether the job was interrupted. It does not mean the status
is valid, which in some cases might have reported the test status `None`.

This patch reworks the way we interact with `TestStatus`. It contains
`interrupt` variable, which means the test was interrupted and we should
leave the execution. It still have the `status` variable, which contains
the status, but now those two variables are automatically updated on
query (using __getattribute__).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

requirements-travis.txt: Fix inspektor requirement problems

Require inspektor 0.1.19 to fix the pylint requirement
problems on python 2.6.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

avocado.utils.process: Improve detection to run cmd in GDB [v2]

shlex.split() can fail on some strange commands (eg. on an unfinished
quotation). This patch fallbacks to simple string.split() in such cases,
which might return incorrect results, but is safer to use. Although it
logs warning about this notifying the user about possible issue.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

It has been reported that avocado crashes when a malformed command
is attempted to be executed, even when using `shell=True`.

The reason is that `shlex.split` will raise `ValueError` on those
commands. Since improving `shlex.split` may be too complex, and
possibly not the best place to "fix" this, let's just assume safely
that this command should be run on GDB.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

README: Change the yum repository

The repository for Fedora/RHEL has changed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

software_manager: Add --allow-unauthenticated to apt options

Sometimes we might add a repo that has no GPG keys and
still want to install a package from that repo. We need
--allow-unauthenticated to tell APT that we really want to install
it.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

avocado.core.remoter: Fix error on exception reference

fabric.network was never imported in avocado.core.remoter,
but fabric.network.NetworkError was referenced in its code,
making the exception to never actually be captured. Let's
fix it.

While at it, let's resolve one complaint of the pycharm
python checker: When importing some module on a try/except
block, make some effort to define the module in case of
failure.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>