The newly released pylint version 2.2.0, changed its default behavior
(enabled) the following checks:

 * :unnecessary-pass (W0107): *Unnecessary pass statement*
   Used when a "pass" statement that can be avoided is encountered.

 * :unused-import (W0611): *Unused %s*
   Used when an imported module or variable is not used.

Let's apply fixes to those checks, and at the same time, pin the
pylint versions so that our CI environment is more stable (code that
test our code -- pylint -- doesn't change, while our code changes).

For Python 2, the latest release was 1.9.3, so let's use that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python3 only allows seek from the beginning of the file when the file is
opened in text mode.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

On python3 divisions are converted to float automatically, but floats
can't be supplied to seek.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When attaching only partial log file we already calculate the "size =
max_size / 2", therefor it does not make sense to divide it twice (it
actually results in even shorter attached logs.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

On some environments, we can not count on the reference count and
automatic cleanup of that instance, and consequently, the left over
temporary directory constitutes a failure.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The Makefile is used mostly on development related work flows, and has
up to know stick to Python 2 by default.  I think it's time to flip
the switch, and look for a Python 3 binary by default.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

When a test is interrupted, there is no reason it should get only 1 second to do it's
cleanup when we otherwise give a test 10 seconds to clean up if it just dies.

Fixes: 2908
Signed-off-by: NBrian J. Murrell <brian@interlinx.bc.ca>

The correct name of the exception is TestAbortError, and not
TestAbortedError.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current utils kernel module has no tests. Recently it was added a
fix[1] to the process of kernel url building. To keep this process
without future regressions, this change adds a proper test for it.

It's important to note that a new internal method was added to the
KernelBuild class to make easier to test it. Indirectly it's an
improvement of download method that now is shorter and more explicit.

[1] - commit c84ac6baSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

1. rewrite MtabLock, as a proxy class for filelock.FileLock.
2. update related unit test.
Signed-off-by: Nlolyu <lolyu@redhat.com>

not passed while kernel download avocado error out as

TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

when url not passed it uses default  else try to use custome url as
base url
Reported-by: Nlolyu <lolyu@redhat.com>
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The 98442498 added fail-reason to UI,
but for some tests this could be multiple lines of explanation, which
does not really fit in the UI purpose. Let's limit the maximum size to
255 chars (this number is not important, it just have to be sensible)
and avoid '\n' in the output.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This reverts commit 8cc9be2a.

This reverts commit 8cc9be2a, bringing
back the commit 55f420f7
"optional_plugins: Use simple "copy" in "loader_yaml" for args" as the
fingerprint is finally static and there should not be any CI failures
anymore.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This reverts commit 7e30455a, bringing
back the commit e6c3dad8
"optional_plugins: Use simple "copy" in "loader_yaml" for args" as the
fingerprint is finally static and there should not be any CI failures
anymore.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The fingerprint must be static across executions, but TreeEnvironment is
simple unsorted dictionary. Let's sort it on demand (usually only for
fingerprint).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This change adds a functional version of OpenSUSE vmimage provider.
Because of some specific aspects of OpenSUSE versioning this provider
version works properly with most recent known versions (42.3, 42.2. 42.1
and 15.0) and should work properly with future versions as well (15+).

This provider version also don't work with Tumbleweed (rolling release)
versions, only with Leap versions. Because for tests it's better to
change one thing at time, the rolling release is not a version supported
right now.

Reference: https://trello.com/c/i2TSbT3MSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently, the only way to pass parameters to Avocado is by using the
variants layer, that is, one of the existing varianter plugin
implementations.  This was based on earlier design decisions, that
we're trying to fix without breaking expectation and compatibility.

While it'd makes sense to support parameters created by the varianter
layer itself, together with non-varianter parameters, it seems that we
can start by adding support for one or the other being used at a time.

This commit does exactly that: add support for a method of passing
parameters via the command line for all tests in a job, without
having to resort to the varianter.  When the varianter is used,
it takes precedence and the core test parameter passing support
is ignored.

This should solve a number of use cases that require one-time
executions of tests with different parameters, especially
executions during test development and debugging.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The lv_utils functional tests, which usually don't run because
they require privileged execution, revealed a number of broken
expectations when it comes to bytes and text handling.

Let's fix both the module and the test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

When running privileged, MixInMntDir requires the "mixed in class" to
adhere to some expectations, including having a `path` attribute, and
unmounting the filesystem on `close()`.

It looks like this wasn't properly tested because of the seldom (if
any) privileged executions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>