Signed-off-by: NAmador Pahim <apahim@redhat.com>

And only if the method is not available, attempt to fallback to
the stdout itself if it is a string.

Before 30617c1e, the following kind of check was done:

   >>> type(bytes('foo')) in string_types
   False

And after it, the check was changed to:

   >>> isinstance(bytes('foo'), string_types)
   True

That made the bytes decoding not to be performed at times.  While the
new check is correct, we should favor the attempt to decode, and
only if not available, fallback to the original stdout if it looks
like a string.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

in avocado/core/data_dir.py, line 232, in __del__
Signed-off-by: Nchunfuwen <chwen@redhat.com>

string in python3
Signed-off-by: Nchunfuwen <chwen@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Lint: enable unreachable code (W0101) check
  Lint: enable reimported (W0404) check
  Lint: add check for warnings also on CI
  Lint: W0622 fixes

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Pylint describes this warning as:

   Used when a module is reimported multiple times.

Let's enable it and fix the one occurrence it finds.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The following two issues come up on the CI environment:

    ************* Module avocado_runner_remote
    W0622: 51,0: ConnectionError: Redefining built-in 'ConnectionError'
    ************* Module tests.test_mux
    W0622:130,8: TestMuxTree.test_basic_functions: Redefining built-in 'ascii'

And are fixed here.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Update process.run, process.system, process.system_output
docstring for new allow_output_check
Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Each Job creates several dirs/files and uses certain handlers to setup
the environment, let's be explicit and instead of preparing everything
magically on __init__ and cleaning most of it after "run" let users to
"setup" and "cleanup" the Job handlers explicitly and to simplify the
usage also support __enter__ and __exit__ methods to be able to simply
use:

    # No job
    with Job(...) as job:
        # do your stuff with temporary handlers set
    # Job temporary handlers cleaned
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently we use global "avocado.core.data_dir.get_tmp_dir" temporary
directory for Job execution, which does not allow coexistence of
multiple jobs. Let's only use that location as base_tmpdir and create a
per-job dir there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `srcdir` is always executed during `_setup_environment_variables`,
initializing it lazily only consumes more mem and power. As a benefit
having it initialized we can directly access `self.__srcdir` internally
and remove the hack to not-log-warning-on-internal-access.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Lint: enable W0612 and W0622 checks
  Result Upload plugin: use rsync binary as found
  selftests/.data/test_statuses.py: avoid redefining Exceptions
  avocado/utils/memory.py: do not mask builtin MemoryError

These warnings are described as:

 W0612: Used when a variable is defined but not used.
 W0622: Used when a variable or function override a built-in.

After a suggestion from Andrei Stepanov, we decided to immediately
enable these.

Rerefence: https://pagure.io/standard-test-roles/pull-request/144
Reference: https://trello.com/c/Ohh7Q6qj/1183-enable-w-in-travis-make-checkSigned-off-by: NCleber Rosa <crosa@redhat.com>

The results *should* be the same without this change, but it
can lead to a different binary being used from the one that
was found previously.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That is, to fix this pylint condition:

   W0622:263,0: Exception: Redefining built-in 'Exception'

We need to rename the Exception test.  To make things consistent,
let's rename all of the tests accordingly.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python already has a builtin MemoryError exception.  The description
of such an exception is different from the goal here, so let's just
use a different name.

Reference: https://docs.python.org/3/library/exceptions.html#MemoryErrorSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Test: initialize workdir early in non-lazy mode
  Test: rely on TestId.str_filesystem for the workdir
  Test: provide more metadata information
  Test: use more appropriate exceptions on invalid input
  Test: log test init before other messages

Signed-off-by: NWilliam Tambe <william.tambe@amd.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

And use it when running tests.

Note: this is a partial implementation, to satisfy the following use
case:

   $ echo "#!/bin/sh" > a.sh
   $ echo "echo ěčřž" >> a.sh
   $ chmod +x a.sh
   $ avocado run a.sh
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Sometimes, the command to be executed is a string encoded a specific
encoding, different than the system or hard coded default.

Let's make the encoding configurable, and it will apply also to the
content produced by the command.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `shlex.split` does not support "unicode" strings on PY2 and "bytes"
on PY3. Let's normalize the command to get expected format before
processing it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `path.find_command` raises exception in case it fails to find the
binary. Let's use the same approach as in
`selftests.functional.test_basic` to get binary or skip individual
tests.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

This should allow easier integration with children that override
"self.params". Such classes should simply use custom "self.params" and
report their "self.custom_params" while in "get_state" the stock Avocado
params would be used.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "self.params" should be Avocado params, but tests might override
them (and Avocado-vt does). Let's be lenient to failures and simply
report None.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This adds Python 3 packages for Avocado and for all plugins that have
its dependencies fulfilled by Python 3 versions of their requirements.
Signed-off-by: NCleber Rosa <crosa@redhat.com>