Signed-off-by: NAmador Pahim <apahim@redhat.com>

The docstring given on `_greedy_path()` has examples that don't match
the implementation.  To prevent the implementation from deviating
(again?) let's turn those into tests.

Also, to make the purpose of that function more clear, this
changes its name to `_greedy_path_to_re()`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

"file" is not available on python3, let's use "open" to get file
instance.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The subprocess.DEVNULL is not available on Python2.

This reverts commit e51acbfa.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

examples/tests/gdbtest.py already imports the portable range() from
the six library, but was not using it.  Let's fix this.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That is already used when the detected version is Python 3, but
pylint doesn't know about it, so let's make it ignore that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.utils.external.gdbmi_parser uses `cmp` which is Python 2 only.
Let's use the simple recipe for Python 3 compatibility as per
https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons .
Signed-off-by: NCleber Rosa <crosa@redhat.com>

On Python 2, input() has a different behavior, including an evaluation
of the obtained string.  On Python 3, it just returns the stripped
string.

Let's hand off the difference handling to six.

PS: we won't use use six.moves.input() on the failtest_ugly.py file,
given that it's intended to be a bad example.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current syntax is incompatible with Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

A few extra configurations needed for the Python 3 builds running on Travis-CI.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Merge branch 'travis_configuration_python3' of https://github.com/clebergnu/avocado into clebergnu-travis_configuration_python3

The environment that Travis-CI sets up is somehow broken with regards
to the requirements for six.  The exact message we get and running
selftests/run is:

   pkg_resources.ContextualVersionConflict: (six 1.9.0
   (/home/travis/virtualenv/python3.4_with_system_site_packages/lib/python3.4/site-packages),
   Requirement.parse('six>=1.10.0'), {'Fabric3'})

Let's bump the requirements to 1.10.0, to try to help Travis-CI.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

pylint catches what the (on purpose) nasty example test does with:
"Raising a new style class which doesn't inherit from BaseException".

But, since that's on purpose, let's silent pylint instead.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which, different than standard Python xml.etree library, can do
schema validation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

pylint reports that the `avocado.core` module doesn't exist, which
is really weird.  Let's disable this false negative.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which is the preferred way of saying that a parameter is a file,
and, makes pylint happy on Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The HTML plugin is using the `subprocess` library to fire up the
web browser that will show the report.  In theory, we could be
using our own `avocado.utils.process` for that, but given the
comments in that section, I believe there may be caveats.

As a fix for the immediate issue at hand (pylint catching a failure on
a Python 3 environment about using `file`), let's just use the
definitions from the `subprocess` module itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of comparing a string against the exception, and relying
on its conversion to a string.  This approach is undesirable and
is caught by pylint on Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That's the only sane way to handle data, as bytes.  Let's not assume
any enconding on them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This lock doesn't prevent, say, multiple drainers from writing to
a single location.  It's not a cross-instance lock so I fail to
see how it has any purpose at all.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It doesn't have a 'result_obj' attribute, but it does have a `result`
attribute which should be an instance of
`avocado.utils.process.CmdResult`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.utils.process.system_output() is a utility function that has the
goal of returning the process output only.  Let's use it instead when
that's the only goal of the calling code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This moves the tests that belong to plugins (remote and vm) to their own directories.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Because that version contains Python 3 syntax fixes.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Move tests to the plugin's own directory.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Move tests to the plugin's own directory.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Merge branch 'move_yaml_to_mux_tests_v2' of https://github.com/clebergnu/avocado into clebergnu-move_yaml_to_mux_tests_v2

Merge branch 'epel_7_rpm_build_release_57_0_release_1_upstream' of https://github.com/clebergnu/avocado into clebergnu-epel_7_rpm_build_release_57_0_release_1_upstream

Merge branch 'tree_docs_tests' of https://github.com/clebergnu/avocado into clebergnu-tree_docs_tests

Signed-off-by: NCleber Rosa <crosa@redhat.com>

These classes and methods have knowledge about the YAML files, and the
YAML to Mux plugin is the only user of those.  this plugin.  So it
makes sense to move it to the plugin module.
Signed-off-by: NCleber Rosa <crosa@redhat.com>