Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Instead of adding version at the class init time, add it
as one of the program's arguments. This will get rid of
a deprecation message while executing on python 2.6.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

EPEL ships with pystache 0.3.5, that has different API.
Let's make a resonable effort that the report works
there as well.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use the logutils backport, available on pip and EPEL,
that allows us to keep using the dict logging config
method in python 2.6.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Dict comprehensions using curly braces is a
new feature, introduced in python 2.7. Let's
use equivalent 2.6 friendly constructs (list
comprehension and generating a list of tuples
with the dict() builtin).

Changes from v1:
 * Per ldoktor's suggestion, use list
   comprehensions and dict() instead of the
   more straight forward (and possibly slower)
   for loop.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

It turns out that ignore not being there still makes
the pylint check to pass on both python 2.6 and 2.7.

The reason why this commit is necessary is that the
ignore type is unknown in pylint 1.4, causing the
2.7 related CI job to fail.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This adds more tests to the release test plan, adds more precise descriptions
of the test and expected results.

Also, the test plan follows a sequence of steps that is more concise and eases
the manual testing process.

Changes from v2:
* Added Remote Machine HTML links test

Changes from v1:
* Added HTML sysinfo test
* Added HTML external links test
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado/utils/io.py: rename to genio.py (meaning generic I/O)

The reason for this rename is that there's a name clash with Python's
standard library `io` module. This name clash manifest while performing
a simple Python validation of the avocado/utils/archive.py module:

$ python avocado/utils/archive.py
Traceback (most recent call last):
  File "archive.py", line 22, in <module>
    import zipfile
  File "/usr/lib64/python2.7/zipfile.py", line 501, in <module>
    class ZipExtFile(io.BufferedIOBase):
AttributeError: 'module' object has no attribute 'BufferedIOBase'

The explanation to that error is that Python itself adds the base
directory where the "executed" module file lives to the head of
the module search path list.

After some dicussion we realized that we should strive to not
name modules with the same names as Python's standard ones.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

loader: Ignore imported classes.

pyliblzma: make it optional since it is not essential [v2]

The line above says enough, but let me stress the point that we want
Avocado to be portable enough to run on various and possibly limited
systems.

Embedded systems and lightweight VMs/containers are a very compeling
target for avocado, so IMHO we should strive to make the avocado core
runnable with as little as a standard Python installation.

Changes from v1:
* Renamed LZMA_SUPPORTED to LZMA_CAPABLE
* There's no need to make _WrapLZMA class definition conditional
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows people to derive indirectly from test.Test and still
import the direct base class like this:

    from base import MyBaseTest

    class MyInheritedTest(MyBaseTest):
        ...

Without this change, the loader might pick `MyBaseTest` as the
class to test instead of `MyInheritedTest`.
Signed-off-by: NMarius Vollmer <mvollmer@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Regression and cosmetics

Signed-off-by: NRudá Moura <rmoura@redhat.com>

Fix regression when the number of lines from the output was reduced,
so we're now assuming 13 lines, instead of 14.

Fix issue #472.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Jobless mode 

Update the command line options, when running tests as standalone
tests (aka Jobless mode):

* --remote-test-results, -r (previously --keep-logs, -r).
* --test-results-dir, -d (new option).

Example:

```
$ python examples/tests/passtest.py -h                                                                                                                                                      OK
usage: passtest.py [-h] [-r] [-d TEST_RESULTS_DIR]

optional arguments:
  -h, --help            show this help message and exit
  -r, --remove-test-results
                        remove all test results files after test execution
  -d TEST_RESULTS_DIR, --test-results-dir TEST_RESULTS_DIR
                        use an alternative test results directory
```
Signed-off-by: NRudá Moura <rmoura@redhat.com>

use an exclusive log handler for sysinfo (avocado.sysinfo),
so we can fine control the log output for sysinfo. Filter
by 'ERROR' by default.

Now the sysinfo will not display any information inside the test log,
by a normal execution of the test.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

avocado.plugins.runner: improve -m description [v2]

functional tests: claim back 3 seconds by using passtest instead of slee...

Adding multiple multiplex files via -m is order dependent. This might
not be obvious and this patch adds the note about this.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

 avocado.test: Escape filename when executing SimpleTest

Even though we have changed functional tests to use passtest instead of
sleeptest, there still has 3 more tests can go with passtest.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Current behavior of process.run(shell=False) is it expects multiple
arguments and split the provided cmd. This doesn't fit the SimpleTest
as it founds a binary and then tries to execute it without any
arguments as it might be separated by spaces. This patch escapes the
executed command using "pipes.quote" to avoid it's splitting.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Remote test support: extra checks for improved usability [v3]

Makefile: implement `link` target

Adding this extra check will give more precise error messages to the user in
case the given tests do not exist on the remote system. This is basically a
safeguard against a user using `--remote-no-copy` and asking to run tests
that do not exist on the remote system.

When not using `--remote-no-copy` the tests will be copied and this check
should always succeed. But, because of timing issues, concurrent access to
the remote system, and so many other issues could result in tests being
removed, I believe the user can still benefit from this (lighweight) check.

Changes from v1:
 * return the original `avocado list` error message, which is more detailed
   and includes the missing files, instead of a general error message.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That will link avocado-virt modules and plugins if they happen to
live in the same directory as avocado (toplevel directory) does.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

By performing a simpler check before actually trying to run avocado (and tests)
on the remote system, we can be more precise about avocado not being installed.

Also the check adds some output check, that should minimize false positives if
for some reason another `avocado` executable exists in the remote system $PATH.

This also paves the way for checking specific avocado versions (the regex used
already breaks down the version numbers).

Changes from v1:
 * Also return the version number if avocado is found to be installed on the
   remote system
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When using `--remote-no-copy` the test files will neither be copied from the
current system nor executed on it, so disable all sorts of checks.

This is a fix for the local check only. A more complicated issue is to perform
similar checks on the RemoteTestRunner and report possible failures in a clean
way.

This address the github issue #417.

Changes from v1:
* Use a simpler Python idiom (getattr with default instead of hasattr and
  extra check). Spotted by Rudá Moura.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.test: Little speed optimization of the warn log

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

  self.job: Command line options in "jobless mode" [V2]

Fix avocado runner problem when running avocado from the base package.

The current way the text was built looks bad while
looking at the docs in the browser.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

* Include `avocado.module` inside setup.py.
* Check if htmlresult plugin is installed from the import,
  to set the HTML result feature on or off.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Share functionality of remote and vm plugins inside the  new submodule `avocado.remote`.

avocado.test: Fortify avocado before very nasty exceptions