Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

On 03d81fea, we let the Avocado developer choose the Python version
to use by setting a PYTHON variable that gets passed to `make`
commands.

But, we missed the case when the execution of the selftests is not
done in parallel.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Given that the setUp() phase is not useful for test_disk_space, and the
custom cleanup done in the test is better had at the tearDown() phase.

Additionally, the following changes where made to make it more reliable:

 * Avoid the busy loop giving modprobe some time between attempts
 * Use "modprobe -r" instead of rmmod, which handlers module dependencies
 * Do an explicit check for status
 * If "modprobe -r" doesn't succeed, it's not a test failure, but a test
   a test error (given that the get_diskspace() function already ran
   and succeeded).

Ideally, the module removal would be done by the linux_modules.unload_module()
but there are some issues with that function that needs addressing first
(such as returning a meaningful result).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

As we don't need to support Python < 2.7 anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The logic of _make_test_runner() is too simple, and can be further
simplified, to justify a separate method.  Referring back to the
implementation of _make_test_runner() makes reading the code harder
IMO, so let's inline it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The related command line option is "--keep-tmp", and it keeps the
setting on "keep_tmp", so it just makes sense, for easier reading of
the code, to name the variable in a similar way.

While at it, let's prevent crash if "os.path.exists()" in "cleanup()"
is given a tmpdir that is None.  This was not caught before because
the default value of "__remove_tmp" would prevent "os.path.exists()"
to be reached.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

A gzip file doesn't have all the "archive" properties that a tarfile
or zipfile has, but still, it could be useful to wrap in the archive
module.

At this point, support is being added to allow for files compressed
with gzip, to be acknowledged as valid in avocado.utils.is_archive()
and transparently handled with avocado.util.uncompress().

The goal of this implementation is to allow for gzip files, which
are compressed tarbals, to be properly handled at uncompress() time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The PYTHON variable evaluation changed recently resulting in different
than default PYTHON variable in some plugins resulting "make link" in
setting Avocado under different python than the linked plugin (eg.
Avocado-vt). Let's make sure we use the same python by passing
PYTHON="$(PYTHON)".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The newly released pylint version 2.2.0, changed its default behavior
(enabled) the following checks:

 * :unnecessary-pass (W0107): *Unnecessary pass statement*
   Used when a "pass" statement that can be avoided is encountered.

 * :unused-import (W0611): *Unused %s*
   Used when an imported module or variable is not used.

Let's apply fixes to those checks, and at the same time, pin the
pylint versions so that our CI environment is more stable (code that
test our code -- pylint -- doesn't change, while our code changes).

For Python 2, the latest release was 1.9.3, so let's use that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python3 only allows seek from the beginning of the file when the file is
opened in text mode.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

On python3 divisions are converted to float automatically, but floats
can't be supplied to seek.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When attaching only partial log file we already calculate the "size =
max_size / 2", therefor it does not make sense to divide it twice (it
actually results in even shorter attached logs.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

On some environments, we can not count on the reference count and
automatic cleanup of that instance, and consequently, the left over
temporary directory constitutes a failure.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The Makefile is used mostly on development related work flows, and has
up to know stick to Python 2 by default.  I think it's time to flip
the switch, and look for a Python 3 binary by default.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

When a test is interrupted, there is no reason it should get only 1 second to do it's
cleanup when we otherwise give a test 10 seconds to clean up if it just dies.

Fixes: 2908
Signed-off-by: NBrian J. Murrell <brian@interlinx.bc.ca>

The correct name of the exception is TestAbortError, and not
TestAbortedError.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current utils kernel module has no tests. Recently it was added a
fix[1] to the process of kernel url building. To keep this process
without future regressions, this change adds a proper test for it.

It's important to note that a new internal method was added to the
KernelBuild class to make easier to test it. Indirectly it's an
improvement of download method that now is shorter and more explicit.

[1] - commit c84ac6baSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

1. rewrite MtabLock, as a proxy class for filelock.FileLock.
2. update related unit test.
Signed-off-by: Nlolyu <lolyu@redhat.com>

not passed while kernel download avocado error out as

TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

when url not passed it uses default  else try to use custome url as
base url
Reported-by: Nlolyu <lolyu@redhat.com>
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The 98442498 added fail-reason to UI,
but for some tests this could be multiple lines of explanation, which
does not really fit in the UI purpose. Let's limit the maximum size to
255 chars (this number is not important, it just have to be sensible)
and avoid '\n' in the output.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>