When the chosen value can't be changed, bacause of some constrain. The function randomly choose diferent valueWhen the chosen value couldn't be changed, because of some constraints. The function randomly chose different value, which is not expected behavior. Now when this event occurs, the function raises ValueError exception and it's handled.
Signed-off-by: NJan Richter <jarichte@redhat.com>

The new version of CIT varianter which support constraints for combinations.
Signed-off-by: NJan Richter <jarichte@redhat.com>

I clearly missed that on 71d915dd, as there's no point of using
a locally defined "basedir" and the one from the sefltests module.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The data type expected to be given to each yield variant contains the
variant id, the "variant" itself, which should be a list of
TreeNode-like instances, and finally the applicable default search
paths.

The "variant" itself, has to be a list, given that on the very first
varianter implementation, it's supposed to contain one item for each
branch of the tree.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Rules such as "check" on our Makefile make sure that no temporary
directory created by Avocado is left behind, but, it's very hard to
tell who created a rogue directory.

This brings improvements to the naming of the temporary directory, so
that it's trivial to tell which test created in the first place.

Additionally, it improves the temporary directory creation, usually by
making use of a tearDown() test phase, instead of other more fragile
methods.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Current 'None' evaluates as string where 'None' is not None.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

These are superior than the ones defined in the test, and using them
removes the duplicate code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which are only necessary under Python 2, and thus, not needed
anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The previous working dropping Python 2, removed the explicit
requirement of the six module, but because stevedore depends
on it, it would still be installed.

Now, every trace of explicit six usage has been removed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python version used to run Avocado is not being respected in this
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the compatiblity helper six.  With Python 2 gone, a number of
package changes are also introduced, so that the packages are always
named python3-<suffix>.

Also, because it would be confusing not having an "avocado" script,
and to conform with the system wide change introduced by distros that
now offer Python 3 by default, the scripts are no longer called
avocado-3 (or avocado-3.x), but simply "avocado".
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit c60f0ae8 fixed a CVE warning that GitHub sent notifications
about.  While so, it was attempted to fulfill the downstream (Fedora
and EPEL) dependencies in the same patch, keeping users of Python 2
with possibly vulnerable versions.

The matching of versions that ship in the Fedora and EPEL distros are
really best done in the SPEC file.  Finally, this was motivated by the
fact that the simple Python version check was not enough because
PyYAML>=4.2b2 is not available on Fedora 28, even though it contains
Python 3.

Reference: https://trello.com/c/3UMFOyzQ/1484-pyyaml-requirement-not-fulfilled-on-f28Signed-off-by: NCleber Rosa <crosa@redhat.com>

When the Robot Framework finds an issue worthwhile to be shown on
the UI, it will do so, but that confuses Avocado users by mixing
the content from both layers.

Let's disable the Robot framework console logger, and only shown
the messages we intend to.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This changes addresses the CVE-2017-18342[1] that defines: "In PyYAML
before 4.1, the yaml.load() API could execute arbitrary code. In other
words, yaml.safe_load is not used."

The change affects only installation using Python 3 because when
building EL7 RPMs, we want to use version 3.10, which is packaged on
EPEL.

[1] - https://nvd.nist.gov/vuln/detail/CVE-2017-18342Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Without this, the data files associated with the avocado_result_html
module won't be installed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We only render HTML, that is, we never render anything that must not
have any content escaped. So, let's always enable the autoescape
feature.

This fixes the issue with jinja2 version 2.7.2, available on EL 7,
that has the autoescape parameter to environments, but doesn't have
the select_autoescape() utility function for selecting what to escape
automatically.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Since the pystache project seems to be dead, without recent updates and
has not support planned for Python 3.7+, this change replace it by jinja
template engine.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The new template structure is based on Jinja template engine. Besides
the template statements itself it was also split the js and css code in
proper separated files. This way the results template keeps simpler.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The test names are based on the executable output with '-l', but
it should be treated as text, and not as bytes.

This fixes issue #2927.

Reference: https://github.com/avocado-framework/avocado/issues/2927Signed-off-by: NCleber Rosa <crosa@redhat.com>

The newly released pylint version 2.2.0, changed its default behavior
(enabled) the following checks:

 * :unnecessary-pass (W0107): *Unnecessary pass statement*
   Used when a "pass" statement that can be avoided is encountered.

 * :unused-import (W0611): *Unused %s*
   Used when an imported module or variable is not used.

Let's apply fixes to those checks, and at the same time, pin the
pylint versions so that our CI environment is more stable (code that
test our code -- pylint -- doesn't change, while our code changes).

For Python 2, the latest release was 1.9.3, so let's use that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This reverts commit 8cc9be2a.

This reverts commit 8cc9be2a, bringing
back the commit 55f420f7
"optional_plugins: Use simple "copy" in "loader_yaml" for args" as the
fingerprint is finally static and there should not be any CI failures
anymore.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This reverts commit 7e30455a, bringing
back the commit e6c3dad8
"optional_plugins: Use simple "copy" in "loader_yaml" for args" as the
fingerprint is finally static and there should not be any CI failures
anymore.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The fingerprint must be static across executions, but TreeEnvironment is
simple unsorted dictionary. Let's sort it on demand (usually only for
fingerprint).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change fix some spelling errors and add to the list os ignoring
words some new cases
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This reverts commit e6c3dad8.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There was a functional test on avocado that depended on html plugin.
This change moves this test to proper plugin instead of run the test
only if the plugin is available during test execution.

Reference: https://trello.com/c/EVggIZzjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

There was a functional test on avocado that depended on remote plugin.
This change moves this test to proper plugin instead of run the test
only if the plugin is available during test execution.

Reference: https://trello.com/c/NPEUj0wZSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Similar to the approach taken on the previous commits, let's
unwind apply_using and improve its docstrings.

This also new tests for this specific unit of code, and a functional
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.

I've timed the performance changes caused by this, and on most
trials they presented similar performance.

This also adds new tests for this specific unit of code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.

I've timed the performance changes caused by this, and on most
trials they presented similar performance.

This also adds new tests for this specific unit of code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The action is the same, only the condition changes, so let's use a
membership test for the type of the control tag.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.  At the same time, this allows
us to write tests for those smaller units.

I've timed the performance changes caused by this, and on all
trials they presented slightly better (but overall insignifcant)
improvements.  This is just mentioned to assert that there are
no performance downsides to this change.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The changes in this commit are causing intermittent failures in our CI
environment under Python 3.x.

This reverts commit 55f420f7.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The use of "deepcopy" should not be necessary as we only use it here to
override certain keys with our values, not to modify their value.

Even if (theoretically) modified those mutable values later in the
code, it'd have been done even without "deepcopy" for cases where we
didn't forced the "args".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit makes sure all inputs in yaml2mux plugin are decoded and
passed as unicodes to variants. As a consequence this allows to actually
use this plugin on python3 environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>