* move man pages into common package
* claim ownership of all config and content directories
* Python version-specific packaging of avocado-rest-client
Signed-off-by: NMerlin Mathesius <mmathesi@redhat.com>

* selftests/unit/test_xunit.py: also output schema validation errors
* selftests/unit/test_xunit.py: junit XSD file is only used in one test
* selftests/unit/test_xunit.py: specify JUnit variation used
Signed-off-by: NWainer dos Santos Moschetta <wainersm@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Python 3: fix re.findall() using string pattern on a bytes-like object

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  python 3 : Journalctl collection failed issue

re.findall(regexp, out) or re.search need regexp and out in the same type:st
currently regexp is string,but out is bytes,which cause exception thrown whe
Fix this issue by transfering out into string forcedly
Signed-off-by: Nchunfuwen <chwen@redhat.com>

json.loads(xx) on python 3 need string object
out_journalctl open in text mode but bytes passed in
Simply fix them by forcing to string and open in bytes mode
Signed-off-by: Nchunfuwen <chwen@redhat.com>

On Fedora 28, if a Python 2 script is invoked with "/usr/bin/python",
it will produce a warning like this:

   DEPRECATION WARNING: python2 invoked with /usr/bin/python.
       Use /usr/bin/python3 or /usr/bin/python2
       /usr/bin/python will be removed or switched to Python 3 in the future.
       If you cannot make the switch now, please follow instructions at https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Quick_Opt-Out

Let's tell the unittests explicitly to use the versioned script,
created during the "pythonX.Y setup.py develop --user" step.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Used during the %check phase.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When a plugin is not installed, its command line options are not
registered with the optparse based code.  That is caught earlier than
Avocado's own handling of incompatible options (in this case, the replay
and the remote runner), and results in the errors such as:

  avocado run: error: unrecognized arguments: --remote-hostname

When building RPM packages for Python 3, the remote runner plugin is
not available, and this test should be skipped.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The "--old-chroot" command line option was added right after the
chroot model was changed in Fedora and was causing build failures.

It now seems to perform OK, so let's use the "current" chroot method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

On b97a4cfa, the (noisy) output produced by the inspekt lint (and
underline pylint) was silenced by having it redirected to a file.

This seems to no longer be necessary.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The 'avocado list -V' prints the list of tests as a matrix with
Type, Test and Tag(s) columns. Some lines may get trailing
whitespace chars due the method used to align the columns' value.

Changed the call to avocado.utils.astring.iter_tabular_output()
so that trailing whitespace are removed from each row.

Adjusted the PluginsTest.test_list_no_file_loader() test due lack
of whitespace on outputs to be compared.

Reference: https://trello.com/c/JWeay87z/1045-strip-tabularoutput-linesSigned-off-by: NWainer dos Santos Moschetta <wainersm@redhat.com>

Signed-off-by: NWainer dos Santos Moschetta <wainersm@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  python3: fix 'str' does not support the buffer interface

Fix issue:Log file /var/log/messages collection failed: 'str' does not support the buffer interface
Signed-off-by: Nchunfuwen <chwen@redhat.com>

Added 'strip' parameter (default False) to avocado.utils.astring's
iter_tabular_output() and tabular_output() methods that strips
trailing whitespace of rows on the tabular output.

Also introduced unit tests for those methods.
Signed-off-by: NWainer dos Santos Moschetta <wainersm@redhat.com>

It's not easy to find one definitive specification for the the JUnit /
Xunit formats, and a number of different schemas have been published
by different entities.

The current schema version we ship was based on a repository that is
no longer available.  Even though the format is exactly the same,
let's switch to the schema hosted by the JUnit project, and to what
is considered the Jenkins schema (as part of the JUnit 5 project).

Reference: https://junit.org/junit5/
Reference: https://raw.githubusercontent.com/junit-team/junit5/master/platform-tests/src/test/resources/jenkins-junit.xsdSigned-off-by: NCleber Rosa <crosa@redhat.com>

So it makes no sense to use in the setup phase.  Let's move that
closer to its actual usage.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's useful to show the schema validation errors when invalid output
is produced.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Following the common JUnit XSD description, covert the timestamp to iso 8601.
I also hit parsing fail while importing avocado xunit result to other system
as timestap format.
Signed-off-by: NXiao Liang <xiliang@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which means it won't be executed on environments such as Travis, where
resources are limited and this test fails from time to time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit 33517beb has a syntax
failure because reason is a mandatory argument.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

test_run_sudo() actually needs sudo, because it attempts to run it.
Let's check for the file at the usual location, and skip the test
unless it exists.

   ERROR: test_run_sudo (selftests.unit.test_utils_process.TestProcessRun)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
       return func(*args, **keywargs)
     File "selftests/unit/test_utils_process.py", line 180, in test_run_sudo
       p = process.run(cmd='ls -l', sudo=True, ignore_status=True)
     File "avocado/utils/process.py", line 1272, in run
       cmd_result = sp.run(timeout=timeout)
     File "avocado/utils/process.py", line 781, in run
       self._init_subprocess()
     File "avocado/utils/process.py", line 571, in _init_subprocess
       raise details
   OSError: [Errno 2] No such file or directory (/bin/sudo -n ls -l)
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Depending on the Python version stack being used *by inspekt*, it
can produce this error:

   Syntax check FAIL
   ************* Module avocado.utils.astring
   E0602:305,32: is_text: Undefined variable 'unicode'

Let's disable that check, since that variable is a reserved word
that should always exist in Python 2.7, for which a conditional
exists.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Some of the package names were changed from "{name}" to
"{version}-{name}" without changing their requirements. Let's fix it
here.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Mock complains about several files being installed, but not part of the
rpm. These files are copied and generated when selftesting the Avocado.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "assertEquals" is set as deprecated in py3 in favor of
"assertEqual".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some tests execute avocado directly, which uses "/usr/bin/env python" by
default. On distributions with py2 and py3 installed we might end-up
running those tests using python2 while running the main selftest by
python3.

With this change we need to make sure to pass the correct python binary
in UNITTEST_AVOCADO_CMD as it's not doing this by default (to allow any
avocado command).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The FDDrainer reads from process output and write to loggers.  The
test log, which is intended for humans, can indeed try to treat it as
text.  The stream logger, on the other hand, should deal with data as
binary content *only*, but this will be handled on a future change.

By having text content passed to the loggers, we avoid the occurrence
of log lines that look like:

  [stdout] b'command output'

Or output files (job-YYYY-MM-DDTHH.MM-id/tests/<test>/output) that
may literally contain:

  b'command output'

The encoding used is the one specified at the command execution.  With
this fix, a number of tests on Python 3 can now run successfully.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

In the module global scope, "man echo" is executed to attempt to
determine if it's a GNU echo.  But, "man echo" in a locale such
as UTF-8 produces funky copyright characters:

  $ LANG=en_US.UTF-8 man echo | chardetect -
  <stdin>: windows-1252 with confidence 0.73

Which can not be decoded by the UTF-8 codec, producing
UnicodeDecodeErrors.  Even if that wasn't the case, it's better to
control the locale of command that can generate varied output, and
that we depend on.

  $ LANG=C man echo | chardetect -
  <stdin>: ascii with confidence 1.0
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change introduces the following requirement: the command to
be run by the avocado.utils.process functions should be given as unicode.
It brings a clearer interface, in which there's no need to deal with
encodings internally.

For simple test, it brings changes to respect the of passing unicode.
And, it changes the presentation of simple tests with unicode names
explicitly expreseed as such.

The way to deal with the process data that may be generated on
stdout/stderr is unchanged.
Signed-off-by: NCleber Rosa <crosa@redhat.com>