It has been reported that avocado crashes when a malformed command
is attempted to be executed, even when using `shell=True`.

The reason is that `shlex.split` will raise `ValueError` on those
commands. Since improving `shlex.split` may be too complex, and
possibly not the best place to "fix" this, let's just assume safely
that this command should be run on GDB.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

README: Change the yum repository

The repository for Fedora/RHEL has changed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

software_manager: Add --allow-unauthenticated to apt options

Sometimes we might add a repo that has no GPG keys and
still want to install a package from that repo. We need
--allow-unauthenticated to tell APT that we really want to install
it.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

avocado.core.remoter: Fix error on exception reference

fabric.network was never imported in avocado.core.remoter,
but fabric.network.NetworkError was referenced in its code,
making the exception to never actually be captured. Let's
fix it.

While at it, let's resolve one complaint of the pycharm
python checker: When importing some module on a try/except
block, make some effort to define the module in case of
failure.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Let's use comprehensions for generating pools and itertools to flatten
the list of variants. This improves the performance ~10%.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Multiplex doc: attempt to reduce confusion on file format and line nu…

Miscellaneous fixes

Ideally our HTML formatted docs would have toggable line numbers. Since
we don't have that, let's just try to be clearer about the line numbers
not being part of the multiplex file format.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This example file should have been remove together with commit
7b969527. Better late than never,
so let's do it now.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Fix the docstring that doesn't reflect that the result parameter
should actually be a TestResultProxy.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Some tests might require additional cleanups not just after the test,
but after the whole job. This patch adds another message called
"func_at_exit", which can be pushed by the test and will get registered
and called when all tests finish.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The test_status is handled in TestRunner.run_test quite chaotically.
This patch extracts test-related communication into a separate class,
and provides simple abstraction, making it simpler to extend it of
other messages.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The current probe is not identifying the version numbers
for CentOS 7.X. Let's use a more relaxed regexp to fix
that problem.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

It turns out we forgot to state fabric dependencies in the
debian package. Let's fix that problem.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Let's remove an artifact from old times. The current
process APIs should handle stdout and stderr just fine.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Add the gdebi-core dependency that our ubuntu users might need
to if they are going to use the avocado software manager
library.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

It turns out that apt doesn't really handle local installs
graciously as dnf/yum, but thankfully there is a program
named gdebi, shipped in Debian and Ubuntu, that would let
us do that. Use it when available (we can make gdebi a
dependency for the avocado debian package to ensure it'll
always be there).
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Fix the command used to check package status (there was
a missing space there) and the logic for checking installation
(verify OK string in the entire command output).
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

process.py: CmdError class backward compatibility fix

In the newer CmdError class implementation the __init__() doesn't
have anymore the third non-mandatory argument "additional_text".
But still in the different parts of the source code the
CmdError is used with the third argument. If there is no special
reason behind deleting the "additional_text" then I would suggest
to keep for having the backward compatibility.
(for example got argument amount errors while running particular
libvirt tests which had to raise a CmdError exception)

avocado/core/virt.py: avoid crashing when trying to detect VM IP address

The current code assumes that libvirt will always return information
about the VM in a given format, and also assumes that the VM will have
a NIC, which may not be the case.

This adds better checks if the conditions are not met, skipping the
IP detection feature, instead of crashing.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Together with the asset files, we'll now host the RPM repos at
a couple of OpenShift instances, named after the Avocado Project.

The two main repo files are located at:

 * https://repos-avocadoproject.rhcloud.com/static/avocado-fedora.repo
 * https://repos-avocadoproject.rhcloud.com/static/avocado-el.repo

And they point to the same base URL for individual repositories.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

With recent refactorings of the loading code, some of
the logic became unreachable (and irrelevant to avocado).
Let's remove the unreachable code.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

To sync with the latest changes in Avocado.
Signed-off-by: NCleber Rosa <crosa@redhat.com>