Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables pylint check w0631. Since the only occurrence is on
external spark library, it was disabled specifically.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This check makes sure the excepts in try/except are not duplicated
regarding the exception type.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Besides enabling the check, this change also makes ISO9660PyCDLib
inherit from MixInMntDirMount so it has the implementation of
mount_dir() property.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This pylint checks for possible redefining outer names. Some occurrences
was preserved with disable flag because they would broke some public
api, like method/functions names or parameters.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The W0613 check for unnused arguments. The most of the current cases
seems legitmate so the proper flag was added in each line so pylint can
ignore it.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This pylint check makes sure the log message is not built in log
statement itself, but uses the proper argument from logger to do it
lazy.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The testIdentity changed here was using assertTrue with a constant
instead of a conditional. So, to make lint pass it was updated to a more
appropriate assert.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables checks for use of global statement (W0603).

There are some specific points using global currently. However, since
refactor these places is not simple enough, they was allower
specifically. This way we can isolate them and stop using global in
other future implementations.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables loads of pylint checks that do not require big code
changes.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change introduce AVOCADO_PARALLEL_LINT variable to
selftest/checkall script to make possible set the parallel lint
execution per environment.

Since currently the Travis CI is failing due lint parallel execution,
this change already sets AVOCADO_PARALLEL_LINT to 1 in Travis CI.

Reference: https://trello.com/c/LQ0szonHSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables W0150 (lost-exception) and W1645 (Exception.message
removed in Python 3) related to exception heandling.

This change also enables other checks that didn't require code changes
W0122, W0123, W0124, W0125.

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

This check is based on a number of packages that are either Python 2
only and/or are not available on most distros.  And, pylint itself
supports this type of check.

Reference: https://trello.com/c/rfSAXdyiSigned-off-by: NCleber Rosa <crosa@redhat.com>

During the parallel execution of unittests, only conditions for FAIL
and ERROR are checked.  Under Python > 3.4, that's fine because load
failures are treated as FAILures:

   $ python3.6
   Python 3.6.5 (default, Mar 29 2018, 18:20:46)
   [GCC 8.0.1 20180317 (Red Hat 8.0.1-0.19)] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import unittest.loader
   >>> l = unittest.loader.TestLoader()
   >>> l.loadTestsFromName('selftests.unit.test_utils_cpu.Cpu.test_cpu_arch_ppc64_power8')
   <unittest.suite.TestSuite tests=[<unittest.loader._FailedTest testMethod=test_utils_cpu>]>

But, under Python 3.4, no such treatment is done:

   $ python3.4
   Python 3.4.3 (default, Jan 13 2018, 13:06:46)
   [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import unittest.loader
   >>> l = unittest.loader.TestLoader()
   >>> l.loadTestsFromName('selftests.unit.test_utils_cpu.Cpu.test_cpu_arch_ppc64_power8')
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
     File "/home/cleber/.local/lib/python3.4/unittest/loader.py", line 114, in loadTestsFromName
       parent, obj = obj, getattr(obj, part)
   AttributeError: 'module' object has no attribute 'test_utils_cpu'

This implements a simple check for load failures, which is not
perfect, but better than none.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

On b97a4cfa, the (noisy) output produced by the inspekt lint (and
underline pylint) was silenced by having it redirected to a file.

This seems to no longer be necessary.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There are few issues (3 to my count) which affect a number of tests
on Python 3.  Instead of not executing any of the functional tests,
let's skip the broken ones.

This is important because it will prevent new issues from making
its way into the Avocado code.

The list of tests being skipped is being tracked on our planning board,
so that they are accounted for, and enabled when fixed.

Reference: https://trello.com/c/eFY9Vw1R/1282-python-3-functional-tests-checklistSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Pylint describes this warning as:

   Used when a module is reimported multiple times.

Let's enable it and fix the one occurrence it finds.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

These warnings are described as:

 W0612: Used when a variable is defined but not used.
 W0622: Used when a variable or function override a built-in.

After a suggestion from Andrei Stepanov, we decided to immediately
enable these.

Rerefence: https://pagure.io/standard-test-roles/pull-request/144
Reference: https://trello.com/c/Ohh7Q6qj/1183-enable-w-in-travis-make-checkSigned-off-by: NCleber Rosa <crosa@redhat.com>

This removes the exception of allowing failures on the Travis CI jobs
with Python 3, while, at the same time, temporary restricts Python 3
jobs to run only unittests and the documentation build for the Avocado
core.  That is, it excludes the functional tests, and the optional
plugin's tests.

While it may look like a step back, it's actually a step forward in the
Python 3 port, because now any regression on the unittests will be caught.
And, when the additional fixes are applied to address the functional tests
and plugin's tests, the whole set of tests will be enabled for Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The "realpath" is being deprecated in favor of "readlink -f", which
should mainly work the same way. This is required by Travis as it's
version of Ubuntu does not contain "realpath".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In Travis more tests are failing when running in parallel, but still 20
failed tests in parallel re-ran in series are faster than all tests in
series.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This change enables plugins tests to also be run in parallel, if
they exist.

Because the "selftests/{unit,functional,doc}" directories are valid
Python modules, that is, they contain `__init__.py` files and can
be imported by the unittest runner, no special handling is necessary.

But, since the complete path for directories which (can) hold plugins
tests are not valid Python modules (and shouldn't be), some special
handling of directories is necessary.

Because of that, it's not currently possible to run *all* of the
tests (from "core" selftests and from plugins) at the same time.
A future enhacement would be to better schedule processes that
can be loaded from the same path at the same time, but all of
them at once with global "test slices".
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This simple test, after the s390x version, checks the proper parsing
of and x86_64 /proc/cpuinfo.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

To avoid having W0102 (dangerous default arguments) enable W0102 in
`make check`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Occasionally the parallel check reports "pid XXX is not a child of this
shell", let's try to avoid this issue.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The parallel checker is a great tool, but frequently fails with
false-negatives. Let's re-run the failed tests in series in case less
than 10 failures were present and consider check successful in case they
pass.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Avocado supports running python unittests directly without the need to
discover them via script, let's use it in our selftests script.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Inspektor 0.4.5 brings a number of updates, including
porting to the cliff command line application framework,
which makes inspekt commands to look more natural in
terms of arguments.  Let's update and reflect that
in the CI scripts.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

For couple of weeks the `inspekt lint` produces unwanted `Your code has
been rated at 10.00/10 (previous run: 10.00/10, +0.00)` messages
polluting the log too much for me to bear. I tried to remove those
messages, but so far I haven't found a solution, so let's just silence
it unless there is a lint failure.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

To make sure the seltests does not leave job results behind,
we introduced a check which compares the job-results directory
content from before the selftets with the content after the
selftests. But using `AVOCADO_SELF_CHECK=1 make check`, we
expect at least one extra result in the job-results directory,
making the content of the job-results to not be the same after
the tests.

This patch changes the avocado command used for self check
in `make check`, pointing the results to a temporary directory.

Reference: https://trello.com/c/y57xZSUSSigned-off-by: NAmador Pahim <apahim@redhat.com>

checkall runs `ls` twice in the job-results dir. Once before the
selftests and once again after the tests, comparing the outputs to make
sure there's no new results there after the selftests.

When the job-results does not exist in advance (the case in travis
environments), the message 'ls: cannot access /home/travis/avocado/job-results:
No such file or directory' is shown in the logs. The message is harmless
and does not affect the check. Let's just suppress the stderr from the
`ls` command in that check.

Reference: https://trello.com/c/IBoLAJjfSigned-off-by: NAmador Pahim <apahim@redhat.com>

It happened couple of times that running our selftests produced a new
entries in the default results directory. Let's use this optional check
to avoid such issue.

To enable this check one has to set "AVOCADO_RESULTSDIR_CHECK" env
variable. This check is enabled in travis as I do not expect travis to
run avocado tests while running the selfcheck, unlike on developer
computers.

Note the check is rather simple and only assumes the default results
directory. For selfcheck I think it's enough.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

So far we only executed the first argument, but we might want to execute
complex cmdlines instead just one command. Let's use $* instead of $1.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

pep8 v2.3.0 introduced the check for bare except clause (E722). Until
now, we don't explicitly disable the pep8 check we don't want because
inspect has a default exclude list (E501, E265, W601 and E402).

Let's make explicit the exclude list for the checks we don't want in our
selftests, adding to the list the new E722 check.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The signed-off-by check makes sure the latest commit contains correct
"Signed-off-by" message. As this check is executed per each commit in
travis, it should make sure all new commits contain this message which
is quite important as it states that the author agrees with the terms
from our contribution guide.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>