Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

We shouldn't try to find other syslog candidates files after one
is already found.  Let's return earlier when a valid one is found.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We have sysinfo job hooks and test hooks. Job hooks are only executed
when sysinfo is enabled, but test hooks are executed anyway. This patch
makes the test to respect sysinfo setting and only execute test hooks
when sysinfo is enabled.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

We have a LogWatcher class for system log files, but so far systemd
journal messages were ignored. This patch creates a jounalctl watcher
class and collects the journalctl messages diff per test, creating a gz
file out of them.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

We do log the lack of permissions, but we don't log the missing files.
Let's fix that.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

We omitted the license in setup.py, let's add it and while on it define
the classifiers related to this project.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We use custom setup.py file, where we define all the versioning
ourselves. Let's get rid of the unused config file which does nothing at
all.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  setup.py: add stevedore to install requirements
  HTML Result Plugin: remove plugin requirements from core definition
  HTML Result Plugin: add avocado-framework as a installation requirement
  PyPI: define more consistent package name

avocado.core.runner: Disable stdin for tests

We already disable stdin by setting sys.stdin for tests, but there is
still way to access it via `os.read(0, ...)`. This patch replaces the
`0` (STDIN) file descriptor with the `/dev/null` file descriptor.

Simple check is:

    avocado run /bin/read

which hangs until data are provided and fails with this patch.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Result plugins: also list them on "plugins" command

The "install_requires" parameter lists the Python packages that are
required to be installed as base requirements.  Right now, we have a
bunch of "suggested" packages, which in their absence, will make some
plugins fail to load (as expected) and some features to be gracefully
disabled.

Stevedore, though, is a mandatory requirement because it's a
foundation for the plugin functionality.  So, let's always try to
install as part of `setup.py` so we have always have a functional
installation.

This should allow users to run `pip install avocado-framework` and
have much better results than today.

Note: this is not intended to be a substitute for the full
requirements*.txt files.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The pystache package is only needed on the, now optional, HTML result
plugin.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Now that the avocado package has been given a proper unique name,
that is, avocado-framework, we can define it as a requirement for
external and optional plugins.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We have been using "avocado" as the name of our package, as seen by
core Python tools such as pkg_resources and repositories uch as
pypi.python.org.  The fact is that, even though our libraries modules
live under the "avocado" namespace, there's no need to forge the
package name.

With this change, external packages can declare "avocado-framework"
as a requirement.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The "Result" plugin interface was defined a while ago, and we now have
three implementations (JSON, XUnit, HTML).

Let's include them in the plugin listing, that is, when a user calls
`avocado plugins`.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

optional_plugins.html: Minor fixes

The method `logdir` is not used anywhere in the template, nor in the
plugin itself. I tried to find any occurrences and also setting a
breakpoint without any use whatsoever. Let's remove it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

No actual changes, just style fixes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  HTML Result: host it in a directory outside the avocado package
  HTML Result: move rendering code from core to the plugin itself
  HTML Result: add missing fields to formatted version of test info
  HTML result: use names closer to underlying result instance
  Makefile: smokecheck also needs clean/develop
  Makefile: fix test name used on smokecheck

avocado.core.sysinfo: Force LC_ALL for sysinfo collection [v2]

This commit allows setting custom LC_ALL for sysinfo collection to
simplify `avocado diff` comparison between different machines. One can
disable this by setting no/empty value.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This step makes the HTML result a proper Python plugin, by living
outside the Avocado package namespace.

The RPM package is also adjusted: it now builds ands install both
Avocado and the HTML result plugin while keeping the two separate
installable packages.

Developers can use the usual `make link` and `make clean` to enable
and disable all plugins (including this one).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change removes the knowledge, and dependency, that the current
Avocado core has of the HTML rendering code.

The only user visible change is that the UI message about the
generated HTML file now appears one line after it used to appear.  The
reason is not because of the HTML plugin itself, but because the
results are now generated outside the context of the job, and that is,
chronologically a bit later than it used to be.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit 84a8acc0 fixed a problem with 625eefe0, by reverting its
original proposal and copying everything from the inner test result
information to a new dict that is fed to the report template.

It turns out that only two entries were missing (test ID and status)
so we don't really need to copy the whole thing.

Again, this is basically a revert of 84a8acc0 that adds those two
missing fields.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need to have different names on the ReportModel class from
the Result instance, which is really the source of information.

This change is a step towards using better known names and possibly
making the ReportModel a child of Result itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Create a git workflow section based on the devel list
discussion.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Plugins: add support for optional plugins dir and related Makefile targets

This reverts commit 6cb88049.

The rationale is that we should really use LC_ALL instead of LANG.

The `run` does not accept arguments anymore but stores them in `self`.
Let's get rid of the outdated docstring.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently only tree produced from yaml file is filtered. This patch
changes the logic to first produce the full tree and then apply filters.
The difference is that this way one can filter also nodes defined via
`avocado_devault_params` like avocado-vt params or `--mux-inject` ones.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `MULTIPLEX_CAPABLE` only influences the `yaml` parser. All other
functions are available without it so let's allow users to use them.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The option `--multiplex-files` has been deprecated for several releases,
let's finally remove it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>