Skip to content

A
avocado

openeuler / avocado

通知 0
Star 0
Fork 0
A
avocado

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 16 2月, 2018 4 次提交
    • C
      xunit plugin: fix DOM usage · bfab1c6b
      由 Cleber Rosa 提交于 
      On Python 3, it's not possible to create Elements detached from a
Document.  The following code fails (later than it should) on Python
3:

   >>> from xml.dom.minidom import Element
   >>> e = Element('foo')
   >>> e.setAttribute('bar', 'baz')
   Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
   File "/usr/lib64/python3.6/xml/dom/minidom.py", line 741, in setAttribute
      attr.ownerDocument = self.ownerDocument
   AttributeError: ownerDocument

Let's create elements within the document, with the `createElement`
API.  According to the docs "The element is not inserted into the
document when it is created", so the (unchanged) code that actually puts
the element in the right place still applies.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
      bfab1c6b
    • C
      avocado.utils.iso9660: always deal with bytes · 01c84866
      由 Cleber Rosa 提交于 
      The avocado.utils.process module has been changed so that the content
of stdout and stderr are now bytes.  The content generated by the
iso9660 backend implementations should also operate on bytes, given
that it makes little sense for the library to assume a given content
type of a file (inside an iso9660 archive).

To make the data returned by the various backend `read()`
implementations always return bytes on both Python 2 and 3, an
explicit conversion is done from strings to bytes (which affects only
Python 2, since Python 3 already operates with bytes on files opened
in binary mode).
Signed-off-by: NCleber Rosa <crosa@redhat.com>
      01c84866
    • C
      avocado.utils.process: use bytes for raw stdout/stderr · 7d0e6a44
      由 Cleber Rosa 提交于 
      This brings a change in behaviour, in which the stdout/stderr of the
executed process will now be of bytes type, instead of a string type.

Two new attributes, which are implemented as properties, have been
added to the CmdResult class, `stdout_text` and `stderr_text`.  Those
are convenience methods that will return the same content that is in
`stdout` and `stderr`, reespectively, but decoded on the fly[1].

With regards to encoding, if one is not provided, the result of
`sys.getdefaultencoding()` will be used ("utf-8" for Python 3 and
"ascii" for Python 2).

Applications and/or tests using the APIs that return a CmdResult
should, to the best of my knowledge, set a default encoding themselves
so a stable behavior across Python versions.  But that if left to
users of this API.

A different tradeoff/design decision has to do with the tests modified
here.  One option is to have "text" (as in sequences of human readable
glyphs) as being of Python type "str".  On Python 2, "str" can be
compared to "bytes" because a conversion will happen on demand.  That
is, the following is fine on Python 2:

   >>> result = process.run("command")
   >>> "expected" in process.stdout

Where `expected` is of type "str" and `process.stdout` is of type
"bytes".  This is not true of Python 3, so either the types must match
or a conversion must be done explicitly.  The solutions to that are:

1) have these "text" as (of type) "bytes" in the source code itself,
   and avoid the conversion whenever possible
2) have "strings" in the source code itself, and use the conversion
   provided by `CmdResult.stdout_text` and `CmdResult.stderr_text`.

The approach chosen here is to avoid conversion if possible, that is,
use "byte" types, given the fact that the source code encoding is by
default 'ascii' and most of the "text" dealt with here can be
represented in 'ascii' too.  This is equivalent of doing:

   result = process.run("command")
   b"expected" in process.stdout
   "errors: %s" % 0 in process.stderr_text

[1] The obvious alternative, instead of decoding these on the fly
    would be to have multiple copies of the "same" data.  This assumes
    that binary data produced on the stdout/stderr will usually be
    larger than textual data.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
      7d0e6a44
    • C
      Merge remote-tracking branch 'ldoktor/result-dispatchers' · 15d436d7
      由 Cleber Rosa 提交于 
      Signed-off-by: NCleber Rosa <crosa@redhat.com>
      15d436d7
  3. 15 2月, 2018 11 次提交
  5. 14 2月, 2018 2 次提交
  7. 13 2月, 2018 11 次提交
  9. 12 2月, 2018 5 次提交
  11. 10 2月, 2018 2 次提交
  13. 08 2月, 2018 3 次提交
  15. 07 2月, 2018 1 次提交
  17. 06 2月, 2018 1 次提交