Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Fix byte vs string file io for python 3

Reference: https://github.com/avocado-framework/avocado/issues/2024Signed-off-by: NJan Zerebecki <jan.foss@zerebecki.de>

Most of the LazyProperty variables in Test are actually always read on
"get_state" and other occasions so it does not make sense to set it
Lazily.

Also protect the remaining lazily initialized property from overriding
by using @property instead of our custom LazyProperty, which is not
really a property.

This commit requires some adjustments to nasty example tests which used
to override self.srcdir, which is not allowed (and restricted since this
commit).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

All test loaders now return the test name as a value under the first
level test class parameters.  Let's drop the legacy code that used
to check at the test parameters "id" key and the test class parameter
"path" key.

This has also been tested with external loaders such as Avocado-VT
and Avocado-Virt.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The replay plugin checks for `remote` execution, which requires remote
runner to be installed. Let's avoid crash by supplying default on
missing attribute.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

It looks like the tags mechanism has a lot of potential to be used
very often, so a long command line option seems to much typing.

Let's add `-t` (for *t*ags), to allow users to run commands which
are much nicer to type, such as:

 $ avocado run . -t BZ12345678
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This symlink is a legacy compatibility that now, after another LTS
release doesn't need to be created anymore.

The loading of a `urls` file has been kept, as a way to keep
compatibility when replaying jobs created under older versions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The location of the HTML report was moved from
`$RESULTS/html/results.html` to `$RESULTS/results.html`, while a link
was left on the first location.

We don't have to carry that compatibility link anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When trying out Avocado installations, I wanted to silence the plugin
errors that I knew would fail to load.  I chose to do that by running
a command such as:

 $ avocado --config=silent_plugins.conf run passtest.py

But it did not behave as expected.  The reason is that plugins are
loaded first, and then the parsing of command line (with additional
parsing of config files) is done.  Let's parse the command line
earlier then.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's now python-aexpect packages on EL7, so we should
be using it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

That was actually a trial/error commit that was then removed.  I
merged the branch I had, instead of the latest one which excluded that
one.

This reverts commit 2d9baccd.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This selftest tries to load jobdata and verifies they produce correct
results.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The cmdline wasn't stored till avocado-40.0. Let's try to get it from
job.log, if available.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This allows replaying jobs executed by Avocado-36.x in Avocado-52.0.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NAmador Pahim <apahim@redhat.com>

When loading older jobs some arguments might not be available. Let's
reflect that and only override the arg when it's available.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `Varianter.dump` function which serializes the object is quite
useful to walk and serialize arbitrary variants. Let's extract the
separatable part and make it available for outer use.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Before Avocado-49.0 the mux did not defined `variant_ids`, let's
emulate it when it's not available (usually after unpickling
of an old-type-mux object).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `to_str` method is used to list/visualize the variants. As the
structure is not kept, let's just list all variants along with their
params.

This is a simplified version of the `mux` plugin's `to_str` and it
ignores `summary` and `variants` as it's not really useful nowadays, but
we can improve that in the future, if necessary.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Let's assume TreeNodeEnvOnly is equal to other node if they share the
same name, path and environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Avocado selftest supports parallel check, enabled by the env. variable
`AVOCADO_PARALLEL_CHECK`. Let's enable that in travis so big PRs will
have a better change to finish before the travis 50min timeout.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Let's whitelist the --execution-order in replay as it might be useful to
users and it is a safe value.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

During replay we distinguish between force-overridden values by checking
whether the current value is None, which fails when the default is
not-None. Let's prepare for being able to replay with execution-order by
using default based on None (code already handles that as
variants-per-test).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

All other result plugins write (by default) to the job results dir.
The HTML plugin was different because it used to require a number of
files.  Now, it's a single file, and thus, could/should live in the
same place as other files.

To ease the transition of the location, let's add a symlink, so that
users can still rely on the old location.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

This section should help people running 36.x to move towards using 52.x
Avocado version.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>