Signed-off-by: NAmador Pahim <apahim@redhat.com>

The current TestName class records more than a test name (according
to the Avocado specification).  It records, and by default, presents
the Test ID (__str__() and __repr__()).

The Test Name, again according to the Avocado specifications, is
contained within a Test ID, so it's not necessary to have two
different classes IMO.

Finally, the str_filesystem() method was adapted to be coherent with
the fact that it returns a file system representation of the Test ID,
not the Test Name.  It also became a property, to match the same use
of str_uid and str_variant.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's a clear difference about of what a test file, and a test
itself, is in Avocado.  The datadir attribute though, has not been
created with such a difference in mind.

The best solution would be to renamed it to something like
"file_datadir", but since it's test a public (and stable) API, it's
not going to be changed anytime soon.

So, for now, let's clarify the meaning of the datadir property.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current assignment of variant and str_variant attributes of a
TestName have two extra conditional blocks that are unnecessary.

Besides that, IMO, the proposed code is easier to follow.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python code should not be doing type check/enforcement.

This bit was here temporarily, when the name parameter to
avocado.core.test.Test got changed.  Now it's way past time to remove
it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current example, on Test Names, where being given on the Test ID
section.  Let's move them closer to the Test Name section, and while
at it, also give Test ID examples.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

While a given resolver could return such a test name, I think this is
a bad example for a Test Name in this section.

The reason is that it's not possible, with the available test
resolvers/loaders to create a test such as that (it used to be).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The execute_cmd() method is not supposed to be public, to be used by
instances of the SimpleTest and ExternalRunnerTest class.

Let's make it protected then.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because it's a Python standard module, and while it doesn't violate
any style rules, using a different name avoid any confusion.

While changing the parameter name, do a minor improvement of the
docstrings.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The vast majority of selftests do not use CamelCase, but some still
remain.  Let's stick to a single naming pattern.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Fix Travis check

With the EOL of Ubuntu 12.04, Travis CI is now running our tests using
Ubuntu 14.04. With this change, our check started to fail.

Even though I'm not sure about the reasons, I could make it work by
using a newer version of Pillow and also installing libvirt-python from
pip, since it's not working in the virtualenv if installed from apt.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

utils.wait: docstring typo

Parameter is `step`, docstring says `steps`. Fixing.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

selftests: Two small selftest-related tweaks

This test is failing on my "slow" system, let's increase the timeouts,
they are used in `wait_for` so it shouldn't slow down the "quick"
systems.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Recently we changed the inspekt execution to use the 0.4.5 syntax and
forgot to include this change in `requirements-selftest`. Fixing it now.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  travis: Update to inspektor 0.4.5
  Linter Fixes

Inspektor 0.4.5 brings a number of updates, including
porting to the cliff command line application framework,
which makes inspekt commands to look more natural in
terms of arguments.  Let's update and reflect that
in the CI scripts.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Found by the newest version of inspektor, 0.4.5.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Fixing spell error introduced recently.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  YAML Loader: move it into its own plugin and package

The SIGINT/SIGTERM handlers are currently broken. When we execute a
SIMPLE TEST, which ignores SIGINT/SIGTERM, the test process will not
finish on SIGINT/SIGTERM, becoming orphan.

Reproducer::

    $ cat /tmp/test.py
    #!/usr/bin/env python
    import signal
    import time

    if __name__ == "__main__":
        signal.signal(signal.SIGINT, signal.SIG_IGN)
        signal.signal(signal.SIGTERM, signal.SIG_IGN)
        signal.signal(signal.SIGQUIT, signal.SIG_IGN)
        while True:
            time.sleep(0.1)

    $ avocado run /tmp/test.py

Then play with `Ctrl+C` (once and twice), with `kill -2 <pid>` and
`kill <pid>`. Check if Avocado hangs or whether any process is left
behind.

Also, the only test we have for those cases is supposed to catch the
issue with SIGINT (test_interrupt.InterruptTest.test_badly_behaved), but
it's not really working.

This patch fixes the SIGINT/SIGTERM actions, as follows:

- When a SIGINT is sent to the main main process, we send the same SIGINT
  to all the children hope for the best. This reproduces the behaviour
  on Ctrl+C.
- On a second SIGINT (after the 2s ignore period), meaning process is
  still running, we send a SIGKILL to all the children.
- When a SIGTERM is sent to the main process, we now send a SIGKILL to
  all the children (instead of a SIGTERM), so any subprocess ignoring
  SIGTERM will be terminated anyway.

Reference: https://trello.com/c/5RPZPH4FSigned-off-by: NAmador Pahim <apahim@redhat.com>

The newly introduced YAML Loader plugin is currently hosted on the
same plugin (directory and module) as the varianter one.  While they
share a lot of code, they have different purposes.

Let's move the YAML loader into its own plugin, so that its
installation is also optional and the separation is clearer.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  python-avocado.spec: fix dependency on Python YAML packages
  Makefile: remove section about packages needed to build Avocado
  Makefile: use old chroot implementation for mock

This change is already present on the downstream (Fedora/EPEL)
packages, and for some reason, was missing here.  It causes
the installation to be attempted by pip, which should never
be done during RPM builds.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

All the Avocado deps are now either on Fedora or EPEL, so there's no
need for any extra setup, and consequently, for that documentation
section.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

mock has switched to using systemd-nspawn for its chroots.  It looks
like it's breaking the Avocado workflow for building packages.

Until we can better evaluate what's missing there, let's revert back
to the old implementation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Use the new "b'' % foo" formats from PEP461.
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>

Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>

At least, selftests.unit.test_xunit passes.
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>

Part of fixing selftests.unit.test_xunit under Python 3.
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>