This is an attempt to catch most (if not all) usages of open
that do not follow the context manager pattern.

Sometimes, for better readability, our own `genio` library is
used.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Added two more functions to multipath.py library file

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  resultsdb: print IU message only when using default TUI

To avoid having W0102 (dangerous default arguments) enable W0102 in
`make check`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Despite the reviews we have some W0102s that potentially corrupts the
arguments. Let's get rid of them.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The default parameters mechanism proved to be confusing, overlapping
and thus was scheduled to be removed.  This implements the removal
of the default_params API.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The message is being printed even woth different result formats (json,
tap, ...). This patch makes it to be printed only when using default
TUI.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Allowing 'None' to be used as a possible value in the list of valid
execution order modes is a way to deal with a default (implicit)
mode.

Let's make this default mode explicit and documented.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's use more meaningful names, rather than variable and indexes to
improve readability.

Also, let's make the two possible branches of execution more visible.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Any non-empty tupple will evaluate to True, even ones filled with
empty strings, None, False, etc.

Let's remove this useless conditional.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Our goal to completely separate the basic parameter interface and the
varianter pass through here: splitting these modules into their
reespective ones.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

A few unused imports exist in the optional plugins.  Let's remove
them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Double free errors are silent in Fedora 27, making the test
doublefree.py to fail.

Using `MALLOC_CHECK_=1` is guaranteed to expose the double free
errors, regardless the OS double free handling. This patch updates
the doublefree.py test to use the `MALLOC_CHECK_=1` approach.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The documentation and examples on the output check feature are
outdated or innaccurate.

For instance, the synctest.py example would produce different output
than recorded in the accompanying reference files because the API
parameters were not being respected.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The avocado.utils.process APIs offer the `allow_output_check`
parameter which exists at a function call level, and thus should be
applied only during the scope of that function.

While it's questionable if a test process should be able to skip
some of its generated output (by means of an `avocado.utils.process`
function parameter), the fact is that the utility libraries offer
that at a lower level.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

In commit 4514a8ad, the default value from the command line option
`--output-check-record` was being used to set the mode of the
`avocado.utils.process` APIs with regards to output record mode.

The problem with that is it makes it impossible for the API to
distinguish between "no explicit behavior requested" and "explicitly
being asked to disable recording".
Signed-off-by: NCleber Rosa <crosa@redhat.com>

First, the recording of the output should be governed by the
corresponding setting alone.  There's no need to check the test being
run in job standalone mode, because if that's being run like that,
there's no way to actually set the record mode.

Then, for the output check mode, it won't happen if the the test is
being run in standalone mode or if the output recording has been
explicitly disabled (then we have no material to check the reference
with) or if the checking itself has not been enabled.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The script module is frequently used in Avocado itself in its
functional tests to generate tests files that will be run by the
`avocado` command line test runner.

Being able to create files that are *not* executable is important
because it can determine if a file will be identified as a SIMPLE or
INSTRUMENTED test.  Let's make that read only file permission
available as a definition in the module level, just like
`DEFAULT_MODE` is there.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Avocado recently introduced the support to record the combined
output generated by a test.  Now, this introduces support for
checking against a previously record combined output.

If an 'output.expected' file exists, it'll take precedence
over the `stdout.expected` and `stderr.expected` files.

Also it's necessary to switch the default operation mode for
the `avocado.utils.process` functions, since to compare with
an `output.expected` file, the record mode for the currently
running test has to be the same.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `_reference_check()` utility method now provides more meaningful
results.  This allows one to check wether a check was actually
performed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The code is basically the same for all stream and files.  Let's
have a single method instead.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The code is basically the same for all different files.  Let's
have a single method instead.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The same code is run on multiple other tests.  It's a waste to run
it yet another time by itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There was once an idea that the "mux" would be an interface that would
be reused by other implementations (say, json_to_mux, foo_to_mux,
etc).  Now, it seems much more important to make the Avocado varianter
design and interfaces better, and advocate its use instead.

Additionally, there has always been a gray line between the
Multiplexer and the Avocado params.  Moving the mux outside of the
Avocado core will help to draw clearer lines.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Test to cover the fixes in subtests filter. The filter
should work in a directory discovery for both INSTRUMENTED
and SIMPLE tests.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Simple tests discovery is not considering the subtests filter.

This patch adds to the simple test discovery process the capability of
filtering the tests by subtests filter.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Currently the subtests_filter is not used under test discovery in
directories.

This patch fixes that by adding the `subtests_filter` argument to
`_make_tests()` also in directory dicovery mode.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The call of `__del__` is not guaranteed and we are responsible for
cleaning those files. Let's call this function late in our `app` code.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

And include jobdata results and a test for 52.0 (LTS).

The 52.0 release, an LTS release, was meant to allow transitions from
the previous LTS version (36.0lts) and it did so including the ability
to replay jobs created with the older version.

Now, we're 6+ months into the 52.0 release, and as promised, we'll
stop maintaining 36.0lts.  To keep to code clean, let's remove all
this compatibility with versions before 52.0.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>