While the readability aspect is debatable, this is IMO easier to
grasp than a multiline condition.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's give a little more info, and split the parameter type into its
own docstring line.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Another simple refactor, because it makes sense to have related
attributes set together instead of scattered all over the place.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's move the logging map definitions to a class scope, and simplify
the setting of the loglevel attribute.

In theory, even though it's not supported now, this should also allow
code that define their own jobs to easily customize the logging level.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

When `make develop` is run egg-info directories are created. We
shouldn't add them to version control, so this commit adds the proper
entry to gitignore file.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

E1111 error happens when a function which doesn't return is used to
assign to something. In this particular case the unittest.TextTestResut
stopTest method doesn't return and its result is being assigned to a
variable. This behaviour makes pylint fails with E1111 error. This
commit just don't assign the result of super() call and also keeps the
super class method behavior (not returing).
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python 3.7 introduced a new way to add breakpoint on the code. It was
added the built-in breackpoint function. There was couple of places
where the word breakpoint was being redefined making pylint execution
fail with W0622 error (Redefining built-in). This commit replaces
'breakpoint' with 'break_point' in these places.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which will return the first member of the archive, either a file or
directory.  If the archive is empty, it'll return None.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently we compare the full TreeNodeEnvironment object to make sure
they come from the same origin, which only works for connected tree. But
Avocado supports (and uses in json-load) passing leaves of unconnected
trees, but then the TreeNodeEnvironments are not matching.

Let's rely only on "TreeNodeEnvironment.path" and declare these matching
environments, no matter what values are stored (see selftest for
details)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

On python3 we can get "TypeError: can't pickle zipimport.zipimporter
objects" error when trying to "copy.deepcopy" the arguments and I
haven't found any real need for it on "initialize" call (plugins are not
overriding arguments, or they copy it themselves). Let's avoid this by
not copying args.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  avocado.utils.network: introduce default port values for find_free_port()

The "paths" is supposed to be a list of paths and not just string.
Fortunatelly this was why this plugin actually worked, because it turned
paths into `['/', 'r', 'u', 'n']` making the root node available. Anyway
let's fix the value and use the only location this plugin puts variables
in, which is `/`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This plugin uses flat structure, there is no need to set the default
path.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

There was a minor bug/inconsistency in "to_str" method where
"self.parameter_path" is returned instead of list of leaves. Instead of
fixing it let's use the built-in "varianter.to_str" which uses the
"usual" implementation.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

On many situations, users just need a port, there's no need to pick
from a defined range.  Let's introduce defaults, so it can be used
without any arguments for that use case.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  ISO9660: add a pycdlib backend

Instead of repeating those definitions on most test files, let's define
them once, and reuse them across tests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When AVOCADO is set by the environment variable, it may or may not contain
a Python interpreter.  In any situation, Avocado itself won't know about
it, and will log the avocado test runner script in its logs.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of trying locations on Python 2 and 3.  The same pattern is
used on other locations.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of creating new temporary dirs and files, and handling their
removal in each test, let's just create additional dirs/files in the
already provided tmpdir, which will be removed by the test tearDown
method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

commit "c5d62099 Makefile: add requirements-plugins target" forgot an
's' in 'requirements'
Signed-off-by: NFabiano Rosas <farosas@linux.ibm.com>

This implements another backend for the avocado.utils.iso9660 library,
based on the pure Python pycdlib.

The library, as it's the case with all other ISO9660 utilities, is
optional and should only attempted to be be used if they are available
in the system.

In theory, we're well equipped with backends, but this brings the
interesting possibility of running on non-UNIX platforms.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Difference between aarch32/64 is fairly simple, let's detect it
ourselves instead of relying on "machine.platform".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  CIT Varianter: add RPM packages

Add RPM packaging for the CIT varianter plugin.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Makefile: Make sure to use pip of the same version as python

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Some systems don't ship with "pip" binary and only provide the "pip3".
Instead of attempting to get the right one, let's just use "python -m
pip" that should work the same way plus we always use the right version
(py2/py3).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>