Avocado already logs when process is executed, it could be useful to
also know when the process finishes. Note it's not immediately after the
process finishes, but it's logged when avocado notices the process
finished.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently when the process time-outs, it's killed by default with
SIGTERM and then the status is reported. This usually results in process
returning non-zero status, which is then reported to the user. The
problem is that SIGTERM can be caught and handled inside the executed
command and it can report 0. Then the user does not know whether the
command actually finished on time or whether it was killed by avocado.

This commit sets the `self.result.interrupted`, which makes sure the
status is propagated even when the process finishes with zero.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently the interrution is hardcoded to be ctrl+c (signal) only. This
patch uses the `self.result.interrupted` as interruption reason, which
should allow different types of interruptions.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The interrupted message lacked '' around the cmd and ignored the
additional_text.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This patch uses Timer instead of a busy poll loop when using
`process.run` with timeout.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This method allows to query for PID of the created process.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  aexpect: add it to source and package installation requirements

* https://github.com/avocado-framework/avocado:
  avocado.utils.asset raise exception when not able to fetch asset

Currently asset fetcher returns path to the asset file or None
when it fails to fetch it. This patch makes it o raise an exception
in such cases.

Reference: https://trello.com/c/CXhCbFArSigned-off-by: NAmador Pahim <apahim@redhat.com>

The aexpect module is used by the Docker plugin.  Since we do not
package those separately, let's add it as a global Avocado dependency.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `expire` argument was added later and there are usecases where it
was not used. Let's use default which keeps the original handling, which
is unlimited expiration.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The main change is actually incorrect, the kernel.py library uses
`data_dirs` argument to determine the `cache_dirs`, which is by default
`self.work_dir`.

This reverts commit 36ea7be6.

avocado/utils/kernel.py: fix the use of the asset library [v2]

avocado/plugins/journal.py: make the goal of this plugin more clear

We found some users of this plugin, and we're unsure they actually use
this as intended.  Even if they don't use it as intended, it may be a
good thing, *but* we should make it clear what was the original goal
of this feature.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the docstring of the asset library itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Use the avocado.utils.filelock to avoid race conditions:
 - Download the files with a temporary unique name.
 - Lock the original file.
 - Move downloaded file to the original name.
 - Compute the hash, creating the hashfile.
 - Verify the file against the provided hash.
 - Unlock the original file.
 (While the lock is acquired, users trying to use the file will wait until
 the lock is released or, on wait timeout, receive a cache miss)

Drop EnviromentError exceptions on cache miss. Instead, we now only
log an error message and return None.

Clean debug messages. Log was being polluted by asset fetcher. Let's
make it quieter.

Reference: https://trello.com/c/NeFPMkZY
Reference: https://trello.com/c/OWCprQpdSigned-off-by: NAmador Pahim <apahim@redhat.com>

This is a general purpose file locker.

If the lock file already exists and it contains the current process
id in it, we wait until the timeout for the lock to be released,
raising an AlreadyLocked exception when the timeout is reached.

If the lock file already exists and it contains a pid of another
running process, we raise an AlreadyLocked exception.

If the lock file exists and it has no running processes pid in it,
we try to clean the file and acquire the lock, raising a LockFailed
exception when something goes wrong.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

This allows `AVOCADO_SELF_CHECK=1 ./selftests/checkall` to run
inside virtualenv environemnts.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Fedora 24 using screen has TERM=screen.xterm-256color. This patch adds
that terminal option in the list of valid options to be colorized.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Those test runners are implemented as TestResult classes, so they may
also signal their intention to use stdout.  If they don't, both the
RemoteTestResult/VMTestResult and HumanTestResult will end up using
the stdout.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The docker cleanup can sometimes fail, which masks the original failure.
This patch catches all exceptions and only log them to UI as warnings.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `docker run` command can actually take longer, when pulling the
image from hub. Let's remove the timeout completelly.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `docker run` command can actually produce several lines of output
(eg pulling the image) before it writes the container id. Let's use only
the last line when getting the cid.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The cleanup fails when the remote docker connection is not established.
This skips the cleanup when the resource was not yet created.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

* https://github.com/avocado-framework/avocado:
  avocado.core.runner: Remove the unused setup/tear_down methods
  avocado.core.remote: Style fixes in runner
  avocado.core.remote: Improve the `tear_down` execution
  avocado.core.remote: Improve VMTestRunner tear_down method
  avocado.core.remote: Handle urls without assigned files
  avocado.plugins: Add plugin to run job in docker container

The `setup` and `tear_down` methods are defined in `TestRunner`, but
they are not handleded, nor used by it. This is dangerous, because even
from description they give the impression, that you can simply implement
them and they'll magically does the job.

Those methods are used inside `RemoteRunner` and they should only be
defined there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>