Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently, the only way to pass parameters to Avocado is by using the
variants layer, that is, one of the existing varianter plugin
implementations.  This was based on earlier design decisions, that
we're trying to fix without breaking expectation and compatibility.

While it'd makes sense to support parameters created by the varianter
layer itself, together with non-varianter parameters, it seems that we
can start by adding support for one or the other being used at a time.

This commit does exactly that: add support for a method of passing
parameters via the command line for all tests in a job, without
having to resort to the varianter.  When the varianter is used,
it takes precedence and the core test parameter passing support
is ignored.

This should solve a number of use cases that require one-time
executions of tests with different parameters, especially
executions during test development and debugging.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The lv_utils functional tests, which usually don't run because
they require privileged execution, revealed a number of broken
expectations when it comes to bytes and text handling.

Let's fix both the module and the test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

When running privileged, MixInMntDir requires the "mixed in class" to
adhere to some expectations, including having a `path` attribute, and
unmounting the filesystem on `close()`.

It looks like this wasn't properly tested because of the seldom (if
any) privileged executions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Usually verbose variable names improve readability, but here, they're
used only once, and the docstring is quite clear.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Instead of nested conditionals, let's flatten the branching, as all
possible conditions cause a method exit either by returning or by
raising an exception.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Out into a utility method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change fix some spelling errors and add to the list os ignoring
words some new cases
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This implements a connection wrapper around SSH, and requires the
OpenSSH client tools installed.

It uses a master connection for a number of reasons, including but not
limited to being able to distinguish between connection failures and
command execution failures.

Most of the command execution results are accurate and similar to
users of `avocado.utils.process.run()`: the exit status is preserved
for the local user inspection.  The stdout and stderr, time taken to
execute the command (including the remote part) is also available.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change focus mostly on increasing tests for VmImageHtmlParser and
ImageProviderBase. During the tests implementation some improvements
were detected: the process of feed a html parser run both for get an
image version and image url was duplicated so it was unified in a single
method.

Besides that the process of get a best version for an image was put on a
specific method so each provider can override it if required. Today the
default rule for a best version is based on calling max() function on
found versions. However we can't assume it's the default for every
provider. As far as we know, for a possible OpenSuse provider in future
this rule will not be valid.

Reference: https://trello.com/c/vtM1SPpJSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This reverts commit e6c3dad8.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The result in get_submodules contains duplicates, which
result from no check of visited in DFS.
Solved by using ordered_list_unique from data_structures to
del duplicates before returning from each recursion.
Signed-off-by: Nlolyu <lolyu@redhat.com>

Fix issue: re.search(r"Loaded: loaded", output) failed
| TypeError: cannot use a string pattern on a bytes-like object
Signed-off-by: NSitong Liu <siliu@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows us to detect when someone imports avocado multiple times
with different names.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

_log_calls uses func_code and func_name, which are not supported
in python3.
Signed-off-by: Nlolyu <lolyu@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change makes possible to call kill_process_tree() function with
pid of sudo enabled processes and it also makes possible handle timeout of
subprocesses called with sudo=True.

Both cases now use a new function created in process module to return
the user owner id of a pid (get_owner_id).

For the case of subprocesses run with sudo=True it was necessary adjust
the send_signal() method of SubProcess class so it can send the signal
for sudo process child.

Reference: https://trello.com/c/ROPWdFFrSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Currently there is a typo and a bug. Let's fix the typo, add selftest to
document the current behavior and deal with the bug (should detect 4
classes) later.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows a public key to be set as an authorized key for the
default user, and consequently, the matching private key to be used
for authentication.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

If the username is "root", let's also allow it to be used for network
based logins such as SSH.  When this is set to True (the default),
any attempt to connect via SSH will result in a message similar to:

"Please login as user root rather than user root".

Which only makes sense for when another user is configured.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because other authentication mechanisms may be used, it makes sense
to allow for username *only* configuration.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Seems that is important have a default way to get a process owner id in
process utils module. This function will be useful soon when we have to
deal with timeout of sudo enabled processes.

Reference: https://trello.com/c/ROPWdFFrSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

To non-parallel execution script.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There was a functional test on avocado that depended on html plugin.
This change moves this test to proper plugin instead of run the test
only if the plugin is available during test execution.

Reference: https://trello.com/c/EVggIZzjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>