Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The reason for this to exist was supposedly identify (inheritance)
checks, but none of these actually exist.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

To decode into the correct encoding and work properly across different
Python versions.

While at it, improve the docstring.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

To the relevant code block that can, for a reason we expect, raise
such exception.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current sysinfo end_test() hook is badly positioned, in a way that
it only gets called if no exception is raised (that is, tests end with
PASS).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Commit 5cb976a9 attempted to remove avocado-server from release test
plan, but forgot this one.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

If the AVOCADO variable starts with the Python interpreter, the
command that will be logged by Avocado needs to be adjusted.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

For upcoming release 64.0
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The MAKEFILE variable name is misleading, given that it holds the
location of a possible PLUGIN directory.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The testIdentity changed here was using assertTrue with a constant
instead of a conditional. So, to make lint pass it was updated to a more
appropriate assert.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows user to ask for a image for a "fedora" image on a "ppc64"
or "ppc64le" arch, without being exposed to the fact that Fedora hosts
those images in a different location (and treats them as secondary
arches).  Those images are still "Fedora", and that's what users need
to know.

The better fix here would be one that only determines the location of
the images (`url_versions`) based on the architecture.  It would be
possible to do this here, maybe, by using a property for
`url_versions` instead.  But this breaks the general design of the
code and maybe some expectations.

This change chooses to defer that to a possibly more coprehensive
change in the ImageProviderBase class, making the more dynamic
evaluation standard or common.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's use a base class to avoid some of the duplicated code.  There's
the opportunity to clean up a lot more, but the way I see it, it'd
require changes to the base class interface.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Those distros provide images for aarch64, but call them arm64 instead.
Let's allow the use of either name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables checks for use of global statement (W0603).

There are some specific points using global currently. However, since
refactor these places is not simple enough, they was allower
specifically. This way we can isolate them and stop using global in
other future implementations.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NRyan Goodfellow <rgoodfel@isi.edu>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Based on the discussion, it makes sense to have individual tests for
bad and good requests, and also one that shares the state among bad
and good requests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables loads of pylint checks that do not require big code
changes.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

avocado crashed if user provide non exsting profiler
this patch address that , if profiler not avilable than
framework  handle gracefully handle
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

a instance variable

1-Rename pipe variable  to meaningful name
2-Above variable moved as in __init as it should
  instance variable
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Add __init__ constructor that can be hold instance variable
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

1-fixed pep8 issue
2- cleanup : changed compress_logf to compress_log in
Daemon and Command class as actual read param is compress_log
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

This addition to the utilities library facilitates the use of the
cloudinit features inside Linux OSs images for the cloud.

For now, it eases the creation of "cidata" ISOs, containing
configuration to cloud-init, and also a simple "phone home"
server.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>