Originally we only processed files that existed and when they were read
we updated list of config locations and in case of no return list of
failed-to-read paths. Anyway the "config.read" function accepts list of
config files and returns list of successfully parsed files. Missing
files are automatically skipped and broken files raise exception, so
let's just simply create list of to-be-read files and feed it into the
"config.read" function.

As a result the list of not-read files actually works, still in this
version it's only displayed on "avocado config", where users can get
notion of all possible locations and in "avocado run" only parsed files
are displayed as it doesn't seem important enough to log them there to
me.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This docstring is a bit cryptic, let's makes it 100% clear it's only
used by unittests and the "--config" argument uses different approach.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When the intree config exists, it's the same resource as pkg config.
Let's only process the pkg config and use pkg_resources properly to list
the directory with extra config files.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently in-tree is evaluated based on presence of config files, but in
reallity the "settings.intree" used to get tests path. Let's use it to
check for in-tree detection, which should better correspond to how this
value is being used.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NMerlin Mathesius <mmathesi@redhat.com>

This test was always skipped due to different urllib handling in
python3. Let's use our download library to check the connectivity.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We recently switched from simple to recursive discovery by default,
let's document how the discovery works now.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This turned-out to be hard to split, so it's almost-complete rework of
how modules are examined. It brought several fixes which are accompanied
with selftests as well as there are selftests for the
default-recursive-behavior.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This introduces an utility method to the AvocadoModule class that
let's one check if a given class definition (from AST) seems to be a
valid Avocado Test class.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This introduces an utility to the AvocadoModule class that keeps
track of the importable entities.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This is small simplification of the path attribute assigment.
Signed-off-by: NCleber Rosa <crosa@redhat.com>
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Recently we fixed bug where timeouts were not kept under certain
conditions, but the fix lacked selftests modification of those 2
affected selftests as they rely on test-postprocess timing.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

python2-resultsdb_api package has been removed in F30 so
python2-avocado-plugins-resultsdb was also disabled.

This is a "manual" cherry-pick from Merlin Mathesius' work, picked
after the COPR build started failing on rawhide.

CC: Merlin Mathesius <mmathesi@redhat.com>
Reference: https://src.fedoraproject.org/fork/merlinm/rpms/python-avocado/c/fa2eeb5c8a92bb788adf7288b882bcd2f5086cb1?branch=latest
Reference: https://copr-be.cloud.fedoraproject.org/results/@avocado/avocado-latest/fedora-rawhide-x86_64/00854194-python-avocado/builder-live.logSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

fix that opens compressed file in binary instead of text mode.
Signed-off-by: Nlolyu <lolyu@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The interrupted message might be slightly misleading as there are
several timeouts before declaring the process interrupted and the wait
might not be issued immediatelly so let's use the (time - start_time)
value instead of timeout value.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When we execute process with a timeout, we allow to specify signal to be
used after the timeout is reached defaulting to SIGTERM. This signal is
not always enough to really finish the process, on the other hand using
SIGKILL all the time might do even more damage.

Instead this version attempts to use the user-specified signal and only
if that fails it sends SIGKILL to it. The same behavior is now shared on
negative-timeout behavior.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This code is only accessible when timeout is specified so we do want to
finish as soon as possible. Let's replace the "wait" with "poll" which
might lead to declaring process Zombie even when it's not, but it's
already passed 2 timeouts so I think it's better to finish and report
something than to insist on waiting.

This improves a real bug where Avocado hanged after process execution
with timeout. This version is not the full fix, it only declares such
process as zombie and avoids the complete hang.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Our process library only allows to specify timeout for process execution
when used as the whole package using "run" method, but it might be
useful to allow the same kind of treatement for "wait". Let's move the
code there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Recently we modified the reported xunit job name to match the avocado
job name, but this breaks the Jenkins feature that detects first failure
as it only evaluates results of the same job name. Let's allow to set
this value so people can have multiple results easily comparable.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The "import multiprocessing.queues" results in imported
"multiprocessing".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The finish_deadline should be the time of the end, not timeout. This
fixes actual issue where interrupted test reports hang, because
it never checks whether the process actually lives:

    avocado run sleeptenmin.py --mux-inject /run:timeout:1
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Instead of relying only on the SSH status code, which can succeed
while still not leaving a usable master connection running, let's add
an explicit check.

Reference: https://github.com/avocado-framework/avocado/issues/2900Signed-off-by: NCleber Rosa <crosa@redhat.com>

The connection sharing functionality of SSH, on which the
avocado.utils.ssh.Session is based upon, requires setting control path
to be given to both the SSH holding the master connection, and to the
SSH instance that should eventually reuse the master connection.

That setting was completely absenting from the library, and the only
reason it worked, was because my local SSH configurations
(~/.ssh/config) had a default setting.

To avoid clashes (even if they could, in theory, be beneficial), let's
flag the control path for the connections initialized by Avocado as
such.

Reference: https://github.com/avocado-framework/avocado/issues/2900Signed-off-by: NCleber Rosa <crosa@redhat.com>

Starting with Fedora 30, only a minimal set of language packs are
installed on build roots, and consequently available during the build
of packages.

Some of the Avocado tests use varied locale settings, so we need the
full language packs installed.

Reference: https://github.com/avocado-framework/avocado/issues/2978
Refernece: https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildrootSigned-off-by: NCleber Rosa <crosa@redhat.com>

Some tests for the vmimage module do not specify the arch to use to
determine the image that will (would) be fetched.  It then relies on
the default of using the host arch.  But, if the test is run on a host
arch different than x86_64, the test will fail.

Let's make the test more deterministic by providing the arch parameter
value.

Reference: https://trello.com/c/92VQRMoC/1483-vmimage-tests-fail-under-x8664Signed-off-by: NCleber Rosa <crosa@redhat.com>