Since we have one variant per suite now, this plugin needs to get the
list of variants instead of only one.
Signed-off-by: NBeraldo Leal <bleal@redhat.com>

With the mechanism (and requirement) for plugins to update the default
parameters gone, let's remove the default parameters themselves from
the variants.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The `update_defaults()` interface is only implemented by the Yaml to
Mux plugin, and it was a requirement that was justified by plugins
such as the now archived "avocado_virt".

Test parameters can be provided by using the existing varianter
implementations (such as the simple dictionary based).  And for
plugins, a much better alternative for plugins is to register options.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The concept of a "default variant" was not particular the intention,
but rather the side effect of the implementation.  To make things
clearer, let's not present any variant if none was actively created by
any plugin implementation.

Further work will change the internals to completely remove its
existence.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

In order to keep consistency, I'm moving varianter related things to the
proper class.
Signed-off-by: NBeraldo Leal <bleal@redhat.com>

Including a mass change using the default style, and a check to make
sure we don't regress.

There are a few exceptions on selftests that play with the import
order on purpose, so those are skipped from the checks.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This patch address the below reported issue on
test name not having complete variants tag names.

Now we get all relevant variants tags included in
the test name which will be useful for result
analysis.

Fixes: https://github.com/avocado-framework/avocado/issues/3615

Adjust selftests for this change.
Signed-off-by: NSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>

This "args" parameter would be used when that object came from the
command line arguments only.  It's now the norm to call this object
"config", as it comes from the future.settings module, which takes
into account not only the command line parser but configuration files
and even manually crafted dictionaries.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This pylint checks if method arguments differ from the implemented interface or the overridden method.
Signed-off-by: NJan Richter <jarichte@redhat.com>

Which are only necessary under Python 2, and thus, not needed
anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And the compatiblity helper six.  With Python 2 gone, a number of
package changes are also introduced, so that the packages are always
named python3-<suffix>.

Also, because it would be confusing not having an "avocado" script,
and to conform with the system wide change introduced by distros that
now offer Python 3 by default, the scripts are no longer called
avocado-3 (or avocado-3.x), but simply "avocado".
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The fingerprint might contain unicode characters, let's use
"astring.ENCODING" to avoid EncodeErrors.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

For computers this does not really matters, but for people the use of
'\n' make debugging slightly easier.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This replaces the naive "str()" approach of turning objects into strings
with proper "astring.to_text" alternative that should take care of the
proper encoding and works well on py2 as well as py3.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The W0613 check for unnused arguments. The most of the current cases
seems legitmate so the proper flag was added in each line so pylint can
ignore it.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

On python3 we can get "TypeError: can't pickle zipimport.zipimporter
objects" error when trying to "copy.deepcopy" the arguments and I
haven't found any real need for it on "initialize" call (plugins are not
overriding arguments, or they copy it themselves). Let's avoid this by
not copying args.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

So one can call len(Varianter()).
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because it's only used once, so let's inline it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

With 36lts End of Life, we can remove compatibility code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Recently we renamed the default varianter paths from "mux_path" to
"paths", which results in default "paths" being used when replaying
older results (including 52.0). Let's "upgrade" the results on-load.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

A lot of the core Avocado code still refers to "mux" based terminology.
For instance, what was previously "mux_path" is now "parameter paths",
and what was previously "mux" is now really variants.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

We are including double line break to separate the plugins variants even
if the plugin to_str() method retuns empty string.

This patch makes the varianter to include the double line break only if
the to_str() method returns non-empty string.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Our goal to completely separate the basic parameter interface and the
varianter pass through here: splitting these modules into their
reespective ones.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

As part of 0795831f, all occurrences of dict.iteritems() turned into
iteritems(dict).  The problem is that AvocadoParams doesn't implement
the items() method that six.iteritems() expects from Python 3.

So given that AvocadoParams doesn't provide it, we could either implement
items() just to satisfy iteritems(), or just use the existing interface.

This commit chooses the later, which means reverting a small part of
the changes (incorrect ones) from 0795831f.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Basically switch to use the alias provided by six, with the Python
3 name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This changes uses the six compatibility equivalents for iterkeys,
iteritems and itervalues.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The variant-id is defined as string defining the variant name, but it
can also contain value `None` to mark the variant as "without name".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When no variants are provided Avocado sets the default variant, but
instead of list of mux paths it created just string "/run", which
processed into ["/", "r", "u", "n"]. Let's fix this by setting list.

Also the proper mux_path should be `/run/*` in order to include all
children nodes of the "/run".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Let's add yaml_testsuite loader which allows parsing YAML file and
producing testsuite out of it.

At this point due to Avocado limitation it only supports
FileLoader-based test discovery, but it should be possible with greater
changes to extend the scope of this loader for just about any Avocado
loader.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The existing way to produce variant_ids can be useful for other plugins
as well. Let's extract it and move it into `varianter`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `Varianter.dump` function which serializes the object is quite
useful to walk and serialize arbitrary variants. Let's extract the
separatable part and make it available for outer use.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `to_str` method is used to list/visualize the variants. As the
structure is not kept, let's just list all variants along with their
params.

This is a simplified version of the `mux` plugin's `to_str` and it
ignores `summary` and `variants` as it's not really useful nowadays, but
we can improve that in the future, if necessary.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When Varianter plugins report no variants, default is provided by
Varianter on `itertests`. The same needs to be emulated in case of
`to_str`, otherwise users would not get the same results as during
`run`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We are about to need human readable variant representation outside the
`mux` module, let's create a generic implementation based on that one to
allow people to re-use it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `--system-wide` option's destination is "variants-skip-defaults" and
not "variants_skip_defaults" due which this option did not actually
work.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Including additions of words to ignore, and substitution of words
we better keep off the ignore list.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently we just pickle the varianter object and hope we'll be able to
load it with other Avocado version. It usually works, but is not really
scalable. This patch adds a way to serialize Varianter into a list of
dicts and serializes it using json, turning the unsafe objects to
strings. Then it adds a way to load Varianter status using this
serialized state.

This procedure is lossy as it always assumes we are in non-debug mode
and it replaces the variants with safe representations. As a benefit one
does not need the original plugins to be able to reuse/replay the
variants as Avocado loads the representation using fake classes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We had already split the mux into mutliple files.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>