Instead of using the commands module, available only in Python 2.7
and earlier, let's use our own utils.process module.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is a simple collection of syntatic fixes that work across
Python 2.7 and 3.x.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

That includes creating a new section for them, and also adding
name and description to the `yaml_to_mux` implementation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

These were introduced when the throbber feedback was implemented,
and probably the idea was to give extra information in the UI.

This was never implemented, and no other internal component relies
on it, so let's remove it to avoid bitrot.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

We have received many requests to support skip tests from inside the
test method. As we can do that without breaking our own concepts, we
decided to introduce the CANCEL status and the corresponding
self.cancel() method to the Test class.

Reference: https://trello.com/c/viBJIEwISigned-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

To make sure the seltests does not leave job results behind,
we introduced a check which compares the job-results directory
content from before the selftets with the content after the
selftests. But using `AVOCADO_SELF_CHECK=1 make check`, we
expect at least one extra result in the job-results directory,
making the content of the job-results to not be the same after
the tests.

This patch changes the avocado command used for self check
in `make check`, pointing the results to a temporary directory.

Reference: https://trello.com/c/y57xZSUSSigned-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NRadek Duda <rduda@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NJun Guo <blackhumour.gj@gmail.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Mention the behaviour of different skip forms regarding the tearDown().

Reference: https://trello.com/c/gsdBAmMYSigned-off-by: NAmador Pahim <apahim@redhat.com>

On some environments, such as when building RPM packages, very little
can be assumed to be available.  `man` is such as command that is
*not* available, so let's check for it and skip tests accordingly.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is a step towards reducing the delta between Avocado "upstream"
packages, that is, the packages offered in our own custom repo, and
packages provided by "dowsntream" distros such as Fedora and (EP)EL.

The package rename is probably the change that could affect users
the most, so let's try to do this early (sprint-wise).  The proper
"Provides" and "Obsoletes" tags should, though, make the update
seamless.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The correct package name doesn't contain "python-"
Signed-off-by: NAmos Kong <amos@scylladb.com>

And not `order()` as mentioned in the docstring.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The definition of AVOCADO_JOB_FAIL was "Something went wrong with the
Job itself, by explicit avocado.core.exceptions.JobError exception",
while AVOCADO_FAIL is defined as "Something else went wrong and
avocado failed (or crashed). Commonly used on command line validation
errors".

With those in mind, I support that AVOCADO_JOB_FAIL should be slightly
adjusted (see changes in the diff), to include other types of
failures, but limited to job *execution* failures.  AVOCADO_FAIL is
already generic enough, so there's no need to change its definition.
This is important, IMHO, because users could quickly understand if a
job was executed, and failed, or if some earlier type of failure (such
as command line validation) happened.

With this updated definition, I spotted a few places where AVOCADO_FAIL
and AVOCADO_JOB_FAIL usage should be changed.  Examples:

 * In `avocado.plugins.diff` the resultsdir is attempted to be read, but
   in my book that still doesn't qualify as a job failure, because a job
   is not being executed.

 * In `avocado.plugins.replay` while there's functionality to run a
   (replayed) job, many of the occurrences of AVOCADO_JOB_FAIL are
   similar to the `avocado.plugins.diff` and happen while trying to load
   jobdata from the previous job resultsdir.

 * In `avocado.plugins.multiplex` the situation is a bit more tricky.  The
   same code is executed when multiple avocado subcommands are executed.
   If the currently executed command is `run`, it would mean that a job is
   being attempted to be executed.  In fact, a job *is* already executing
   at this point, so a AVOCADO_JOB_FAIL is appropriate.  In other scenarios,
   such as when running `$ avocado multiplex`, these failures have nothing
   to do with jobs, so AVOCADO_FAIL is appropriate.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Many process related APIs that avocado has are tied to
the GNU version of the 'ps' command, and therefore, do
not directly port to MacOS.

The correct solution would be to reimplement those APIs
using the 'psutil' module, but then people would complain
about avocado requiring EPEL. I don't have a good plan
on how to solve it just yet, so let's just document those
as TODO list items. We can fix those on later Pull Requests.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

macOS doesn't support the extended attributes of the files
in the zip file created for that unittest.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

macOS doesn't have any of the system files necessary
for the partition code to work, so let's skip the tests
for that platform.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

macOS doesn't have utilities to handle logical volumes out
of the box, so let's skip the lv_utils tests entirely on
that platform.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

On macOS, when trying to access certain processes as
a regular user, a PermissionDenied exception will
be thrown. So let's catch that exception to avoid
errors executing test_interrupt.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

The message obtained trying to execute doublefree will
be different when using other C libraries. Let's expand
the list of accepted outputs by adding the macOS C library
message.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Some Unixes won't have /bin/true, so let's make life
easier for those other OS to run the unittests.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

The filesystem name in Mac OS is 'cd9660', so we can
easily adapt the mounting code to that OS.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

All the plugin interfaces defined in `avocado.core.plugin_interfaces`
ommit the "plugin" term, simply because this is already qualified in
the module name.

Let's also standardize the Varianter interface to "plugin-less" name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

variants.itertests() changed the format of each variant from a tuple to
a dictionary. After that change, the runner was not updated to provide
the mux_path considering the new format.

This patch adds the mux_path to the factory params in _iter_variants(),
fixing the Test.self.__params resolution.
Signed-off-by: NAmador Pahim <apahim@redhat.com>