Support for spell checking had been added to avocado recently, let's
make that mandatory step of manual testplan.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Now users can execute 'avocado run --replay latest' to have the latest
job replayed. No need to remember the job id.

Reference: https://trello.com/c/C0YCTT6dSigned-off-by: NAmador Pahim <apahim@redhat.com>

* https://github.com/avocado-framework/avocado:
  Add spell checker as Makefile target.
  Yet another spellcheck.

This patch adds the `make spell` command so developers can easily
check the spelling on docstrings and comments. False positives
words should be added to spell.ignore file.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

* https://github.com/avocado-framework/avocado:
  Massive spelling correction

Signed-off-by: NAmador Pahim <apahim@redhat.com>

* https://github.com/avocado-framework/avocado:
  avocado/core/tree.py: replace get_ascii() for tree_view()

* https://github.com/avocado-framework/avocado:
  Multiplex doc: try to be clearer about mandatory space and colon

We have a warning about the mandatory space when using the `!include
:` construct.  Since the warning has an exclamation mark (for
punctuation purposes) it can make it a bit confusing since the
example given begins with an exclamation mark (for syntactic
purposes).

Also, in reStructured Text markup, double underscores do not add
emphasis, as it seems to be the original intention.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit 19cb82ce removed the `get_ascii()` method and added the utility
function `tree_view()`.  But there is a leftover using the old method.
Let's replace them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

selftests: Few pre-release unittest fixes

The superusers default permission is 0o644 while other users is 0o664.
This is not handled by zipfile yet so adjust the unittest for now and
see what we can do about this in our utils.archive later.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This test requires mkfs binary in order to run, while it's not really
essential for avocado testing. Let's skip it when it's not available.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

selftests: Few pre-release unittest fixes

This test requires mkfs binary in order to run, while it's not really
essential for avocado testing. Let's skip it when it's not available.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The superusers default permission is 0o644 while other users is 0o664.
This is not handled by zipfile yet so adjust the unittest for now and
see what we can do about this in our utils.archive later.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Use the stacktrace.str_unpickable_objects to get more information on why
the status was not send through queue.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The stacktrace.str_unpickable_object() walks the object and tries to
identify all the pieces which are unpickable and reports them in a human
readable form.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

contrib: Add run-kvm-unit-test script [v2]

This script runs kvm-unit-test tests as individual tests in avocado.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Zip files are stored with permissions, but python's zipfile does not
reflect that. This patch adjusts the symlink fix to also update file
permissions.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado.utils: Add "partition" utility [v3]

Currently when something bad happens in app init(), STD_OUTPUT is left
open, causing output misbehaviour, like disabling echo.

This patch captures the exceptions from capp init() and tries to handle
them nicely. Also, it turns the pagiator off, so the error and help
messages will not be paginated.

Referece: https://trello.com/c/F1x0ZUyeSigned-off-by: NAmador Pahim <apahim@redhat.com>

Add options --env-keep to run command so users can make
available in remote executions of Avocado some environment
variables that are available locally.

Reference: https://trello.com/c/Ddcly0oGSigned-off-by: NAmador Pahim <apahim@redhat.com>

avocado.plugins.run: Fix job-timeout documentation

The --job-timeout now accepts values <= zero and treats them as no
timeout, let's reflect that in help msg.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Add expire time for asset fetcher
  Move _validate_job_timeout() to utils

Now users can invalidate a local copy of the asset file if
it has more than a given time since created.

Reference: https://trello.com/c/JLk01wOlSigned-off-by: NAmador Pahim <apahim@redhat.com>

Let's make this function available for others.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The plugin base import location changed to `avocado.core`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Plugin interfaces: proposal for a better module name and location

avocado.utils.lv_utils: Two bugfixes

The "vgremove" is interactive and it asks if it should remove used vg.
Use "-f" to avoid this prompt.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>