Signed-off-by: NRyan Goodfellow <rgoodfel@isi.edu>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Based on the discussion, it makes sense to have individual tests for
bad and good requests, and also one that shares the state among bad
and good requests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables loads of pylint checks that do not require big code
changes.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This addition to the utilities library facilitates the use of the
cloudinit features inside Linux OSs images for the cloud.

For now, it eases the creation of "cidata" ISOs, containing
configuration to cloud-init, and also a simple "phone home"
server.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change introduce AVOCADO_PARALLEL_LINT variable to
selftest/checkall script to make possible set the parallel lint
execution per environment.

Since currently the Travis CI is failing due lint parallel execution,
this change already sets AVOCADO_PARALLEL_LINT to 1 in Travis CI.

Reference: https://trello.com/c/LQ0szonHSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

There's a case where PyLint cannot deal well with raise without explicit
exception.  This change update one of this kind of occurence in Avocado
code base so lint can run successfully again.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

lsof is not an Avocado dependency, and is much harder to find on base
systems than mount, kill, etc.  Since this module pretty much revolves
around those utilities this does not propose major changes, trying to
adapt to the lack of mount, kill, etc.

This change makes it clear, through a PartitionError, when it's not
possible to run a forceful unmount due to the lack (or error) of lsof.
While at it, it refactors the methods that returns the list of PIDs
using lsof.

To be completely honest, there is still a broken expectation here: one
cannot assume that by sending a signal the process will be killed.
But, at least it is signalled by another PartitionError exception.

https://trello.com/c/DDUNPCBxSigned-off-by: NCleber Rosa <crosa@redhat.com>

There's a lot of common steps among the tests, and most of the
partition tests (there's only one exception so far) assume a
filesystem and mounted partition.

Let's consolidate the code into common classes and reuse that code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Using the builtin assertIsNone() method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables W0150 (lost-exception) and W1645 (Exception.message
removed in Python 3) related to exception heandling.

This change also enables other checks that didn't require code changes
W0122, W0123, W0124, W0125.

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

This method allows the creation of files inside a newly created ISO
file.

For now, the API is kept as simple as possible, and as such, there are
limitations involving creating directories (and files in other
directories than the root dir), mode for files, etc.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This method allows the creation of brand new ISO files, written to
disk at close() time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The goal is to make the opening of files separate from the
instantiation, because that will allow for the different "open"
approach of opening a new ISO file in write mode.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So that users of the `iso9660` utility function can choose a backend
that matches specific requirements.

This is intended to be used to add create/write features to some
backends, that will allow the creation of ISO files, without mandating
all backends to be implement those.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The tests was done mocking the real output of `/proc/buddyinfo`. To make
it easier the process to get the buddy info content was extracted for a
specific function that actually only wraps the open call. This way we
can mock this function return only instead of try mock the builtin open
function.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

PyYAML is the first failure on Travis' Python Nightly jobs.  The
version we're using is ancient, dating from Mar 27, 2014.  Let's
update that and see how the nightly job goes.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The standard library platform.dist function has been deprecated since
2.6, and has now been removed in 3.8.  Since we used as mostly a
fallback probe (other more specific ones are present), it seems safe
to remove this one, and probably wiser to remove it "sooner" than
"even later".

Reference: https://trello.com/c/f2g8BUSt
Reference: https://docs.python.org/2/library/platform.html#platform.distSigned-off-by: NCleber Rosa <crosa@redhat.com>

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

There was an else on while without break. That has no meaning because
since while has no break, the else block will be always executed. This
change removes the else statement and keeps the block.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This started as a hunt for "foo" doesn't exist in module "bar" errors
in "inspekt lint" checks.  It looks like it fixes those issues, but
even if it doesn't, it's a valid change in itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Sometimes the URL used is a link to the content that gets updated
between jobs.  When comparing jobs, it's unclear if we're downloading
the same file or another one.

Let's print the available information we have, such as the content
length, and the creation/modification dates.

Reference: https://trello.com/c/wQ8ir7xASigned-off-by: NCleber Rosa <crosa@redhat.com>