Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Basically, trying to encode information of the variants themselves
in the tag name is a lost battle, since:

1) We need unique test ids, and sometimes only the last part of
   the name of each variant combined is not going to cut it
2) Coding the entire path of each variant combined would create
   in many cases enormous tags and the point would be lost

So go back and use sequential numbers that match the output
of the multiplex plugin. This way it'll be easy to correlate
variants and tag numbers.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Multiplex refinements: filters

In the current state of the code, the local filters are broken, so it's
better to keep it disable for now.

When getting leaves, if the node is root and alone, ignore it.
This situation is possible if filtering just preserves the root node,
so the root node will be leaf and returned.

That makes things a bit weird to get the variants,
because it will become one. So, we are going to ignore it.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Introduce function apply_filters(), which will prune
the tree that we use to multiplex and create variants,
by using rules for filter only and filter out, passed by
the command line (aka global filters).

It works for the test runner and for the multiplex plugin,
or anything that uses the TreeNode data structure with filters.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Adopt function path_parent() from the module avocado.multiplexer.
We will need this when we move the filtering to the level of
the tree.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Add method to detach a node from the tree.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Expand the list comprehension that handles filtering.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Tidy up options

So that we won't need to use sequential numbers in
multiplexed tests anymore.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

It was an option that didn't work properly, and made
more sense to the run subcommand anyway. Now, you can
provide one of the valid logging levels in the python
logging level translated to a lowercase string
('debug', 'info', 'warning', 'error', 'critical') and
that will be the level used for the job log in both
disk and --show-job-log.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This option has been replaced with option --show-job-log,
specific to the test runner.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Logging refactor - Sprint 14 deliverables

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Take throbber update logic out of View into its own
Throbber class, and use that class as one attribute
of View. Makes up for a cleaner separation of attributions.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Moving forward, we want users of the view API to use
only the notify methods. Therefore, turn all of them
to private.

In this process, we discovered one place that wasn't
using .notify (datadir plugin) and updated it.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

And replace the last usage of the .log_ui methods in the
app code.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Enable a mode where instead of the UI, only the job log
shows up in the avocado output. Also, clarify the meaning
of --silent on the command line help.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add a helper method on TestResultProxy() to get information
of output plugins using stdout, making up for a cleaner
way of letting the user know about the conflict.

Also, rephrase the error messages and update functional
tests to reflect the new status quo.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The stdout fd could be inadvertedly closed when doing
that. Besides, it's good practice to not initialize
something that will not be used.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

That was a wrong behavior of our application. When providing
a command line such as:

scripts/avocado run sleeptest --json /tmp/json

This command should display human output. This patch fixes this
issue, and corrects the functional test for this behavior.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When passing --silent to the avocado command line,
stop emiting messages to the logging system altogether.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Now, introducing .notify() methods that do not reference
the UI directly, and migrate all plugins to use it.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Updates the docs with all behavior changes and comments
on text structure/phrasing.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

As pointed out during code review by Rudá.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>