Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Some typos found during automated inspection of the code.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Clean up imports inside the avocado code tree. This
does not bring any functional changes to avocado.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

PEP8 fixes: W503

The new pep8 adds W503 line break before %s check. This is mass style
update of avocado framework without any actual changes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit aims to keep the debian changelog file
as up to date as possible.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

requirements-travis.txt: Require the latest version of inspektor

It'll be necessary so that we can start ignoring error E402
during pylint checking.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

GDB fixes

The path of the binary that is fed into the GDB commands file can be
a relative path, which can cause the behavior described in issue #412.

CC: Lukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The reason is that runtime GDB settings are set by the GDB plugin, and
when running the test in standalone mode, there's no plugin activation
whatsoever.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's a very frequent code pattern to look for a binary in the system
using find_command(), and, if no command is found, trap the exception
generated and return a fallback.

This adds a `default` parameter that makes it possible to follow that
pattern without code outside the function itself.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.utils.process.find_command(): move from avocado.utils.process to avocado.utils.path

The reasons for the proposed move include:

1) Even though find_command() looks for executables, it doesn't really
   try to execute them as a living process.

2) The implementation looks for it in a $PATH like list, so, out of a
   possibly better choice, avocado.utils.path was chosen.

3) Other modules can use that functionality, but not the execution of
   process.

4) Avoid circular dependencies: this is actually the first motivation
   of the proposed change, and a true story with the GDB plugin/test.
   Since avocado.utils.process depends on avocado.gdb, this module
   can not use find_command() to look for gdb/gdbserver binaries.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

process.find_command() raises process.CmdNotFoundError, and not ValueError.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Introduce sysinfo profilers (journalctl & vmstat) [v5]

Sysinfo module now allows to define profilers, which are programs
defined in command line, to start as a background processes and log
the output in a proper directory. Example: vmstat 1.

The profilers are started before a job execution and then, stopped at
the end of the job. The output is stored inside `sysinfo/profile/*`
subdirectory, in job result directory.

The profilers can be customized in `avocado.conf`, section
`sysinfo.collect`.  The default configuration define
profilers as the following: `journalctl -f` and `vmstat 1`.

This feature is turned off by default.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Signed-off-by: NRudá Moura <rmoura@redhat.com>

Set _DEFAULT_COMMANDS_END_JOB as the same as DEFAULT_COMMANDS_START_JOB.
Set _DEFAULT_FILES_END_JOB as the same as _DEFAULT_FILES_END_JOB.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Define attributes .pre_dir and .post_dir (and for future usage, .profile_dir)
inside Sysinfo class, to handle the paths of those directories at the initialization.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Don't ignore stderr, redirect its output to stdout, in order to catch
commands not installed or malformed command line options.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Detect output to stdout as invalid at the beginning of execution
of the plugin, and not at the end of the html result execution.

Fix problem detected on test_output_incompatible_setup_3 when
sysinfo profile daemons are started and then left running, after
plugin exits with code 2.
Signed-off-by: NRudá Moura <rmoura@redhat.com>

Job standalone mode

Sometimes, exception classes might be written in a funky way,
and upon unserialization their __init__ methods might be
called. In this case, if the __init__ gets called, the
needed arguments won't be passed and then avocado will crash.

As we don't really need the actual class, just pick the
string representation of it.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The _DebugJob object was using '.' as the logdir, which meant
creating log files in the avocado source tree. Let's make
something more proper by setting the logdir to a tmpdir, and
by deleting the tmpdir at the end of the test.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Having avocado_loader_unittest as the prefix here was
basically a copy/paste mistake.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Some plugins don't really need to be started in paginator
mode (such as the test runner). Only plugins that need to
list things as opposed to execute test operations will
need it. Therefore:

1) Remove use_paginator=True from test runner, remote
   and vm plugins
2) Add use_paginator=True for the test lister plugin
3) Fix bug in paginator use that will make echo to
   be turned off if you use the paginator (causing
   input to not be displayed in your terminal after
   you use 'avocado list', for example).

The problem with the paginator bug is that it is
explicitly necessary to close the paginator once
we are done with it, as opposed to let it get
garbage collected. For that, we introduced the method
View.cleanup().
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This makes avocado output a little easier in the eyes,
by adding appropriate padding for the messages in the
remote/vm plugins.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

It is easy to tell when avocado is simply not installed
in the remote machine. So instead of giving the generic
crash message to the user, present a better, specific
error that will help the user to proceed on fixing
the root cause.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The idea of the standalone mode is to be able to have a avocado test to
behave like a regular script, outputing to STDOUT the basic log (the
same as --show-job-log would) and return an meaningful status code). This
should help avocado tests to be run along any other test code or framework.

In this mode, a job will still be created, and the basic output files will
also be created, but will be hidden from the user, and removed after the
job finishes running.

This is a partial solution to the so called "jobless" mode, which would
allow a test to run without a job.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Since we provide an utility library, let's make use of it. This is not
only for the sake of consistency, but to eventually allow the framework
to run in a non-writable mode.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.plugins.wrapper: Don't activate when not enabled

When no wrappers are activated this plugin still checks for
the compatibility with --gdb. Skip activate when no --wrapper set.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Better handling of docs/build