Since the pystache project seems to be dead, without recent updates and
has not support planned for Python 3.7+, this change replace it by jinja
template engine.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The new template structure is based on Jinja template engine. Besides
the template statements itself it was also split the js and css code in
proper separated files. This way the results template keeps simpler.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

It's a common use case to want to make sure a file can be read, or if
not fail as early as possible with a relevant error message.

The avocado.utils.iso9600 is doing that itself, but for the sake of
being useful to a wider audience, let's make that a utility itself.

As always, the benefits are also increased test coverage and
documentation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Currently to generate the HTML report the success rate of a test result
is computed by the plugin itself. Since this is an information about the
test result it should be calculated by the Result object and no anywhere
else.

This change adds the rate property to Result class according with the
code (method) already in place in HTML plugin. This new property will be
used soon when the new template engine be added to HTML plugin.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The try/except block around the execution of apt-file to update
is pointless if we're ignoring the status of the apt-file command.

I'll defer to a later moment the discussion on whether this failure
should be fatal, and not just log its failure.  That is currently
covered by the fact that the "apt-file search <path>" execution
will fail with non-zero status when the cache is empty (that is,
when apt-file update was not executed successfully).

Also, add a test that checks the behavior of the affected method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This fixes the backends usage on Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

While testing on a "debian:latest" (9.6) container, I've found that
detection was broken, because the "debian version" file slightly
changed names.  While at it, let's get the version from that file.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

In an effort to make jobs more self contained, and given that dry-run
jobs created temporary content that is not supposed to be kept after
the job is run, this introduces the following changes:

 * Jobs with "dry-run" enabled will now, by default, cleanup their
   own data.  Basically, this means that the "base log directory"
   created during job initialization, and that for non "dry-run"
   jobs is usually "~/avocado/job-results", will also be removed
   at the job's "cleanup()" phase.

 * A new "--dry-run-no-cleanup" command line option, that only makes
   sense when jobs with dry-run enabled start to clean up data for
   themselves

 * Because some result plugins will, by default, write to the job
   results directory, results plugins are now run before a job cleanup
   is done.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

By making it inherit from object instead, now that all children classes
are boiler-plate free and all setup a "iso" attribute, we can remove
the check and make only them (children classes) inherit from
unittest.TestCase.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

As per the last change, let's move the test into the base class, and
just check if the ISO has been setup for this test to work with, and
if not, skip it.  This removes a lot of the boiler plate code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The division of responsiblities in the ISO9660 test classes is one that,
because the children classes need to setup the "iso" instance, the
"mnt_dir_worflow" is not named as a method that is considered a test
in the base class.

The problems with that are:

 1) a lot of boiler plate code in the children classes just to call
    the "mnt_dir_workflow" method.
 2) skip*() decorators do not work in generic methods.

To simplify issue 1, and fix 2, let's rename that method to become
a test method, and just add a condition that, unless "self.iso" is
prepared, the test is going to be skipped.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

When using the "process.kill_process_tree" it might be useful to wait
for all of the pids to die.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

In particular, add parameter types, exceptions, and fixes. Also,
single line docstrings are recommended to be one liners in terms
of quotation as well.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

lvconvert instructs the kernel to do the LVM volume merge
and then polls every fifteen seconds if the conversion finished.

Using a ramdisk, the merge is usually done below one second,
so we wait 14 seconds for nothing.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Since we're running unittests, let's keep it honest and use the true
list of tests for both the parallel and non-parallel checks.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So that external users can pick and choose which components
of the test suite to include.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It will be useful to choose which tests to put into the suite we'll
run.  For instance, when running tests in parallel, we pick tests
from each of the directories at a time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which can be used elsewhere (such as in parallel testing code).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There are at least two places in which the same functionality is
present.  Let's make it a single utility function instead.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

According to the references given below, Travis workers now run
on VMs that are sudo capable, and the sudo configuration should
now be removed.

Reference: https://docs.travis-ci.com/user/reference/overview/
Reference: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migrationSigned-off-by: NCleber Rosa <crosa@redhat.com>

There are a number of backends and requirements for iso9660 tests
to run.  Let's add those as build requirements to that as many
as possible tests and code paths get executed during the checks
in the RPM build.  With this, two other test cases get executed:

Before:
 - (Python 2): Ran 600 tests in 198.076s OK (skipped=42)
 - (Python 3): Ran 600 tests in 196.489s OK (skipped=45)

After:
 - (Python 2): Ran 600 tests in 180.514s OK (skipped=40)
 - (Python 3): Ran 600 tests in 188.545s OK (skipped=43)
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently RHEL provides function accepts just filename, absolute
path of file is not required to be passed. But provides function
for Ubuntu expects users to send the absolute path. This commit
makes changes to Ubuntu provides code to make it generic. So
the consumers just can call provides function with filename.
Signed-off-by: NSrikanth Aithal <sraithal@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

On a number of situations, sudo is being missed as a parameter for
command executions that need to run privileged.  Examples include when
writing to mountpoint, using a Python interpreter, and when trying to
listing open files during a forceful unmount of the disk.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>