The ExternalLoader uses collections.namedtuple to create class fitting
it's purpose. This class is intended for dynamic coding while here we
always know the interface. Let's create ExternalLoaderSpec class to wrap
the details.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `_make_avocado_tests` does not actually produce avocado tests, it
only processes existing file into the most suitable test definition,
which can be INSTRUMENTED, SIMPLE but also MISSING test. Let's rename
that function as well as the tests variable.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Utility to provide Qcow VM Images acquired from distro repositories.

Usage:

    >>> from avocado.utils import vmimage

    >>> image = vmimage.get()
    >>> image
    <Image name=Fedora version=26 arch=x86_64>
    >>> image.name
    'Fedora'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-d369c285.qcow2'
    >>> image.get()
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-e887c743.qcow2'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-e887c743.qcow2'
    >>> image.version
    26
    >>> image.base_image
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64.qcow2'

    >>> image = vmimage.get(arch='aarch64')
    >>> image
    <Image name=FedoraSecondary version=26 arch=aarch64>
    >>> image.name
    'FedoraSecondary'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.aarch64-07b8fbda.qcow2'

    >>> image = vmimage.get(version=7)
    >>> image
    <Image name=CentOS version=7 arch=x86_64>
    >>> image.path
    '/tmp/CentOS-7-x86_64-GenericCloud-1708-dd8139c5.qcow2'

    >>> i1 = vmimage.get()
    >>> i2 = vmimage.get()
    >>> i1.path == i2.path
    False
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  test: flag that test is being skipped

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Removal of "import magic" for avocado and avocado-rest-client
  scripts/avocado: remove duplicate conditional '__main__' section

Currently it might not be easy to determine what version of the test
source was executed (eg. when test-repo is used). Let's log the filename
entry which is the location of the source file of the test class.

In the future we or users should be able to extend the concept of test
metadata of other useful details like mentioned in

    https://trello.com/c/XvaiS4UV/1063-introduce-test-repo-concept-to-
    make-test-names-more-relevant

for example "test_tainted, test_version (sha), etc.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This patch prevents the use of `~` for data and settings purposes to
avoid polluting of the main system while we are in python virtual
environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Now that the teardown() is always called, we have to explicitly flag
when it should be skipped. That's the case when someone decorates the
setUp() with a skip decorator or when someone calls self.skip() in
setUp().

Reference: https://trello.com/c/B6DJe0JSSigned-off-by: NAmador Pahim <apahim@redhat.com>

The variant-id is defined as string defining the variant name, but it
can also contain value `None` to mark the variant as "without name".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some tests that rely on output check may also rely on the combined
generated output (stdout+stderr).  The first step is to record that
in the same order it was generated.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Added a method to get near real physical memory

The current state of this comment is the result of a mechanical change
replacing `urls` with `references`.

The source for references given on the command line is working as
intended, that is, if test references are given on the command line
they are taken and will override the ones on the replay args.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The recording of Avocado version, when running from a GIT repo has
been broken for a long time (since the SPEC file was renamed).  This
could be a simple fix to just match the new SPEC file named, but I
think we can do better.  Besides this fix, the changes here include:

 - Print a short commit instead (8 chars)
 - Omit branch name, commit is authoritative enough and developers can
   tell the name of a branch if it's really necessary

But, let me say that this is still broken.  The GIT version
information is only printed if the current work directory is inside
the GIT repo directory.  A better (and way more complex) fix would be
one that looks where the avocado script and Python libraries were
loaded from, and check if that location is a GIT repo.  Instead of
doing that, though, it'd make more sense to use a semantic version
approach (and possibly a library).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

These scripts rely on some Python library path manipulation to be
able to load from the source tree.  But, in fact that are a few
reasons for not having those, including:

 * All functionality in `avocado` relies on plugins, which will not be
   available from the source tree unless a `$ setup.py develop` is
   executed, which automatically makes the "import magic" unnecessary.

 * Most users will end up using a setuptools generated "entry point"
   instead.

For the sake of less code, I propose this (and all other?) magic to be
removed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Simple syntatic fix removing one of the (duplicate) conditional
`__name__ == '__main__'` section.

To preserve the functionality of the exception hook
(`handle_exception`) the import of Avocado libraries are moved closed
to their usage (inside the condition `__main__` block).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently, the signal handler for SIGTSTP (which implements the test
pause/resume) is installed before the test process is created, and
thus, is inherited by it.

There's a clean up of the signal handler in the test process, but this
clean up can be prevented by installing the signal handler on the test
runner alone (after the test process is created).

The ramifications of this proposal are such that, in the chance that a
SIGTSTP is received after the test process is created and before the
signal handler is installed in the test runner process, nothing will
happen.  In contrast, the current approach may have the signal handler
action being executed, and attempting to send SIGSTOP or SIGCONT to
the test process, but not doing so because there's no test process
yet.

In the end, it seems that the two approaches are pretty safe, and the
biggest benefit here is that the test process never has the handler
installed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

New functions added for memory offline and online, check if memory is
hotpluggable, check if kernel supports memory hotplug.

These functions will be used more often by memory testcases in avocado-misc-tests

Implemented review comments from #2114, #2116
Signed-off-by: NAbdul Haleem <abdhalee@linux.vnet.ibm.com>

The current TestName class records more than a test name (according
to the Avocado specification).  It records, and by default, presents
the Test ID (__str__() and __repr__()).

The Test Name, again according to the Avocado specifications, is
contained within a Test ID, so it's not necessary to have two
different classes IMO.

Finally, the str_filesystem() method was adapted to be coherent with
the fact that it returns a file system representation of the Test ID,
not the Test Name.  It also became a property, to match the same use
of str_uid and str_variant.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's a clear difference about of what a test file, and a test
itself, is in Avocado.  The datadir attribute though, has not been
created with such a difference in mind.

The best solution would be to renamed it to something like
"file_datadir", but since it's test a public (and stable) API, it's
not going to be changed anytime soon.

So, for now, let's clarify the meaning of the datadir property.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current assignment of variant and str_variant attributes of a
TestName have two extra conditional blocks that are unnecessary.

Besides that, IMO, the proposed code is easier to follow.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python code should not be doing type check/enforcement.

This bit was here temporarily, when the name parameter to
avocado.core.test.Test got changed.  Now it's way past time to remove
it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current example, on Test Names, where being given on the Test ID
section.  Let's move them closer to the Test Name section, and while
at it, also give Test ID examples.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

A number of example files are not currently being packaged.  Let's
install and package them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current SPEC file changelog is getting really long.  I think
we can do better with a shorter version.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>