Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change makes possible to call kill_process_tree() function with
pid of sudo enabled processes and it also makes possible handle timeout of
subprocesses called with sudo=True.

Both cases now use a new function created in process module to return
the user owner id of a pid (get_owner_id).

For the case of subprocesses run with sudo=True it was necessary adjust
the send_signal() method of SubProcess class so it can send the signal
for sudo process child.

Reference: https://trello.com/c/ROPWdFFrSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Currently there is a typo and a bug. Let's fix the typo, add selftest to
document the current behavior and deal with the bug (should detect 4
classes) later.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows a public key to be set as an authorized key for the
default user, and consequently, the matching private key to be used
for authentication.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

If the username is "root", let's also allow it to be used for network
based logins such as SSH.  When this is set to True (the default),
any attempt to connect via SSH will result in a message similar to:

"Please login as user root rather than user root".

Which only makes sense for when another user is configured.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because other authentication mechanisms may be used, it makes sense
to allow for username *only* configuration.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Seems that is important have a default way to get a process owner id in
process utils module. This function will be useful soon when we have to
deal with timeout of sudo enabled processes.

Reference: https://trello.com/c/ROPWdFFrSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

To non-parallel execution script.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There was a functional test on avocado that depended on html plugin.
This change moves this test to proper plugin instead of run the test
only if the plugin is available during test execution.

Reference: https://trello.com/c/EVggIZzjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There was a functional test on avocado that depended on remote plugin.
This change moves this test to proper plugin instead of run the test
only if the plugin is available during test execution.

Reference: https://trello.com/c/NPEUj0wZSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Similar to the approach taken on the previous commits, let's
unwind apply_using and improve its docstrings.

This also new tests for this specific unit of code, and a functional
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.

I've timed the performance changes caused by this, and on most
trials they presented similar performance.

This also adds new tests for this specific unit of code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.

I've timed the performance changes caused by this, and on most
trials they presented similar performance.

This also adds new tests for this specific unit of code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The action is the same, only the condition changes, so let's use a
membership test for the type of the control tag.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The function where this utility method lives is really big and
complex.  Let's break it down for the sake of code readability,
while adding better docstrings.  At the same time, this allows
us to write tests for those smaller units.

I've timed the performance changes caused by this, and on all
trials they presented slightly better (but overall insignifcant)
improvements.  This is just mentioned to assert that there are
no performance downsides to this change.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The changes in this commit are causing intermittent failures in our CI
environment under Python 3.x.

This reverts commit 55f420f7.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The HTMLParser class on Python 3 expects to receive text, and urlopen
returns bytes.  To convert bytes into text, an encoding is needed.

Most providers utf-8 encoding on the responses, but Fedora's servers
use ISO-8859-1:

   HTTP/1.1 200 OK
   Date: Wed, 19 Sep 2018 00:46:43 GMT
   Server: Apache/2.4.6 (Red Hat Enterprise Linux) OpenSSL/1.0.2k-fips
   ...
   Content-Type: text/html;charset=ISO-8859-1
   ...

We could get away with utf-8, but let's be thorough here.  This fixes
a "must be str, not bytes" error on Python 3.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which doesn't depend on running `ps`, but is still Linux specific.  In
the future, it'd be nice to have a multi-platform abstraction.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That returns the parent PID for the given process.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Let's provide the "__str__" method for "CmdError" to be able to see the
actual content on print(error).
Signed-off-by: NJunxiang Li <junli@redhat.com>
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The use of "deepcopy" should not be necessary as we only use it here to
override certain keys with our values, not to modify their value.

Even if (theoretically) modified those mutable values later in the
code, it'd have been done even without "deepcopy" for cases where we
didn't forced the "args".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This commit makes sure all inputs in yaml2mux plugin are decoded and
passed as unicodes to variants. As a consequence this allows to actually
use this plugin on python3 environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The fingerprint might contain unicode characters, let's use
"astring.ENCODING" to avoid EncodeErrors.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>