This check is redundant since we have a @unittest.skipIf() already
checking sudo.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

There were several implementations of can_sudo methods in selftests,
most of them broken as eg. "mount" can run without sudo, which is what
happens if sudo is not available.

This patch replaces those custom methods with the one recently
introduced in `avocado.utils.process`.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some users configure only certain commands to be available with sudo.
Let's reflect this and improve the "can_sudo" to accept "cmd", which it
tries to run under sudo.

Additionally as avocado ignores "sudo" (with warning) when "sudo" cmd
not available, this checks for it's presence.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

typo fix, ouput -> output

The utils.build prepares the env to run make inside avocado process. The
avocado.process supports various extra arguments, but to build they are
just an unrelated options. Let's avoid duplicating of process's
arguments in build and simply allow custom process_kwargs (key word
arguments) instead.

In order to keep compatibility with 36lts the original hardcoded
arguments were kept and they override the process_kwargs values, but we
should remove them as soon as the 36lts is discontinued. This will
require some changes to tests where the individual args are used.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some processes fork daemons and not finish them. This works fine as far
as the daemons close the stdout/stderr, but there are daemons which keep
the stdout/stderr opened preventing the `process.run` to finish.

The correct response is to wait till the stdout/stderr is closed,
because otherwise we miss the produced messages of the forked processes.
On the other hand there are processes where we don't want the output and
we do want the process to finish even though the daemons spawned by the
process still run. In such cases one can use the `ignore_bg_processes`
which ignores the opened stdout/stderr and finishes as soon as the main
process finished.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Result: remove old reference to output
  Result: change the name of the attribute to better identify the proxy
  Result: do not keep track of all of the application processed arguments
  Job: prepare for the removal of old style result plugins

The `output` attribute was, at some point, meant to hold the information
about where the result data should be sent to.  Then, the processed
arguments started to be used.

In the end, it has no purpose, so let's remove it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is simple name change.  The goal is to make it clear that the
current "result" attribute is a ResultProxy (old style result plugin)
instance.  The idea is that a new attribute called "result" will really
be a Result instance.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's been a common pattern in Avocado to expose the complete set of
processed arguments to a lot of core components.  This makes the
dependencies and interfaces between these components much less clear.

As we clean up the Result class to make it just a result data container,
let's remove the reference to the processed arguments and keep track
of only the information that's relevant to a given Result implementation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change combines the activation of all old style result plugins
into a single method.  It also names it accordingly, so it's easier
to spot it when it's finally removed.

Another reason for this change is that the old docstring was outdated
and inaccurate.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.utils.data_structures: add author

The loop that waits for the early test status has a call to sleep(0), which
turns it into an almost busy-loop. Changing it to sleep(0.01) consumes less CPU
without performance degradation (might actually make things run faster according
to my tests).

This change also makes it more consistent with the similar loop
for the actual test status.

On my machine, before this change running "passtest.py" 100 times would result
in almost 250000 calls to time.sleep(). After the change, the number gets down
to 600 (tracked via python cProfile module).
Signed-off-by: NAdemar de Souza Reis Jr <areis@redhat.com>

We have a loop to check for the test status which works
like this:

 status = check_status()
 while not timeout or status:
     status = check_status()
     sleep(step)
     ...

And step was defined as 0.1 (sec). At least on my machine, this was making
avocado quite slow, as it was introducing a 0.1 sec sleep between each test
execution.

This commit changes step to 0.01 secs, making Avocado respond much faster.
Notice there's no significant performance penalty with this change. sleep(0.01)
is a long time for modern CPUs and schedulers.

Benchmark is quite straighforward:

TESTS=$(for i in $(seq 1 100); do echo passtest.py; done)

BEFORE:
    $ time ./scripts/avocado run $TESTS --silent
    real    0m14.007s
    user    0m3.376s
    sys     0m3.112s

AFTER:
    $ time ./scripts/avocado run $TESTS --silent
    real    0m4.741s
    user    0m2.994s
    sys     0m2.953s
Signed-off-by: NAdemar de Souza Reis Jr <areis@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Since the test logger is not yet enabled when plugins are in action, we
should use avocado.app logger to warn user about the deprecated option
--multiplex.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The --multiplex option was renamed to mux-yaml, making the former
parameter args.multiplex be now known as mux_yaml internally.
This patch changes the option name in remote.runner so it can work with
the new option.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Docs: document optional packages installation

Some pieces of Avocado are distributed as optional packages, let's
document that fact and how to install them using both RPM and source
based installs.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Recently I fixed a bug where test which asks for input hangs for
infinity but I forgot to add unittest for it. Let's add it now.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Sysinfo: make journalctl quiet on cursor acquisition
  Functional Tests: sysinfo collection may trigger unexpected messages
  spell.ignore: add words to ignore list

On environments where there are no journals available, journalctl may
output error messages such as "No journal files were found", unless
`--quiet` is given as an option.  The other call to journalctl already
does that, but we missed in the first call (that does the cursor
acquisition).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It turns out that, due to other issues, sysinfo collection may trigger
unwanted output.

Since these changed tests are really about the jobscripts plugin
execution, and accordingly to the vast majority of other functional
tests, let's disable sysinfo to speed them up and avoid these noises.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.utils.git: Don't produce check output

avocado.utils.iso9660: Several improvements and cleanups [v3]

Docker improvements [v3]

Docs: describe OpenSUSE support in Avocado

This works great to hosts wich many containers

Example:
avocado run --docker debian-avocado-test /bin/true
DOCKER     : Container id '0f9ebae391183937fb6e98c50cc10f4927963140caf6e63fd108876a6ac7270f'
DOCKER     : Container name 'job-2016-10-02T07.14-a404c72.avocado'
..

Let's add dockefile example. This greatly simplify avocado test development because
allow to create hermetic devel images w/o breaking system instalation
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Docker run enviroments mostly configured by extra run options.
Let's allow runnter to pass it.
#Example:
Run test in remote docker with privileged commands allowed(mount, kvm, etc)
and bindmount local directory '/vol' to '/v' inside container
$ avocado run --docker-options="-H=tcp://remote:2375 --privileged -v /vol:/v" \
	      --docker dmonakhov/debian-avocado passtest.py

The OpenSUSE project ships the LTS versions of Avocado.  Let's
document that so users on that distro can get a head start using
official distro packages if they choose to do so.
Signed-off-by: NSergey Bronnikov <sergeyb@openvz.org>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

No actual changes, just style fixes and docstring updates.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>