This commit allows setting custom LANG for sysinfo collection to
simplify `avocado diff` comparison between different machines. One can
disable this by setting no/empty value.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently we fail silently when sysinfo configuration files
are not present. This patch adds a log.debug message so the user
will have a chance to understand why sysinfo is not being
collected.

Reference: https://trello.com/c/5rvvdH8lSigned-off-by: NAmador Pahim <apahim@redhat.com>

The current method of IP probe is unreliable, as the IP can change between
reboots and we will still use the previous IP. This patch changes the IP
probe method to use the libvirt's domifaddr feature. We try to use the
AGENT method, which relies on a qemu-guest-agent query.

Reference: https://trello.com/c/y9nKJwfnSigned-off-by: NAmador Pahim <apahim@redhat.com>

avocado/core/settings.py: allow settings to use the home dir notation [v4]

VIRTUAL_ENV variable might not be always present. That's the
case for ReadTheDocs. On the other hand, sys.real_prefix seems to
be a more reliable way to detect we are under a virtualenv.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Some settings refer to paths on the filesystem, and the use may want
to set them as `~/something`.  Let's use the type `path` on known
configuration keys.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's common to use the tilde notation (`~/foo`) to refer to locations
inside the user directory.  Let's introduce a new settings key type,
called `path`, that will automatically expand the tilde notation
if one is found.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

* https://github.com/avocado-framework/avocado:
  Makefile: limit clean/link to possible plugin directories
  selftests/unit/test_utils_partition.py: also treat raised OSError
  Makefile: add explicit config to all mock commands
  Makefile: RPM repos are not hosted on COPR anymore
  Makefile: move Debian package related rules to contrib
  Makefile: add target that shows general configuration
  Makefile: silence possible setuptools warnings

The current wildcard expansion will look list every file (no matter
what type) as a plugin candidate.  It may be just my setup, but I have
a few files on the same common directory that shouldn't be treated as
plugin dirs.

While at it, also limit to directories that actually have a Makefile.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When skipping tests due to the lack of sudo permissions, OSError
can be raised when the asked binary does not exist and can not be
executed.

In an ideal world, only one "skip" decorator would have to run, and
this extra treatment wouldn't be necessary since there's already a
`missing_binary` being used.  Unfortunately, that's not how they work.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When generating RPM packages for different distros, it makes sense
to override the chosen mock config (the target distro) in the command
line, such as:

 $ make MOCK_CONFIG=epel-6-x86_64 rpm

So let's add the default value ("default" itself) to every mock command
and let the user running make to override it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The support for Debian packages have already been moved to a contrib
dir, their Makefile rules were kept but not even updated.  Let's
move those to the contrib dir.

Notice: the status of these rules are equal to the other Debian package
files, that is, they're unsupported and we do not guarantee they're
actually working.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

As the Makefile gets more complex and has more variables, I found it
useful to display how it's being driven.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Some warnings may be generated by setuptools code when running
`setup.py --version`.  Let's silence those.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The PyYAML by default replaces any value with object. This could be
confusing as:

on:
    true: true

becomes:

    /True/True:True

This patch modifies the constructor so only values and tags are
converted.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently the tree_view can't cope with non-string values and crashes.
Let's show the string representation.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

avocado/utils/partition.py: test related improvements

avocado.core: Cleanup runner->multiplexer API

This adds more specific checks for the conditions necessary to run the
Partition tests.  A specific check for the needed binaries (mkfs.ext2,
sudo) and the sudo configuration for running those.

The individual and extended checks make it easier to understand why
the tests could have been skipped.

The decision for not checking the existence of mount and umount is
because they are amount the most basic utilities on a Linux/UNIX
system.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

When not given one specific filesystem types, the Partition utility
class defaults to ext2.  Let's document that properly and reinforce
that in the accompanying unittests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

* https://github.com/avocado-framework/avocado:
  lv_utils lvcreate fixup.

lvcreate command warns about filesystem signature detected, on
RedHat. Needs a parameter '-y' to continue.
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

* https://github.com/avocado-framework/avocado:
  Sysinfo: do not force package collection

I noticed during a `make check` that my system was collecting the list
of installed packages.  Initially, I thought it was some explicit
check performed by a sysinfo related test, but it turned out that,
whenever avocado is run with the `sysinfo` command, it forces the
package collection.

That behavior is wrong, because it disregards the configuration key
`installed_packages` under `sysinfo.collect` that defaults to False.
If users intend to collect installed packages, than they should change
the appropriate configuration key.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.core.html: Show link to file which failed to processed

* https://github.com/avocado-framework/avocado:
  avocado.core.jobdata remove sys.exit() from core module
  avocado.core.jobdata rename the job data directory
  avocado.code.jodata cleanup and refactoring
  Rename avocado.core.replay to avocado.core.jobdata
  avocado.plugins.replay fix author

Raise an exception instead of sys.exit() inside the module and let
callers deal with the exception.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The module name changed from 'replay' to 'jobdata'. Let's use a directory
name that reflects the new module name.

This patch renames the job data directory from 'replay' to 'jobdata'.
To keep the compatibility, we try to retrieve the data from the 'replay'
directory when the 'jobdata' directory is not available.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

This patch makes the avocado.core.jobdata code more clean and
efficient.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The core part of the replay feature is in charge for record and retrieve
the job information. Record/retrieve information is not a replay-only
task, so this patch renames the avocado.core.replay module to
avocado.core.jobdata.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The licensing was copied from another module and the author was not
updated at that point. Let's update the information to reflect the
actual author of this module.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

The sysinfo collection can sometimes fail. Let's log a link along with
reason instead of an empty line.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>