Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The testIdentity changed here was using assertTrue with a constant
instead of a conditional. So, to make lint pass it was updated to a more
appropriate assert.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows user to ask for a image for a "fedora" image on a "ppc64"
or "ppc64le" arch, without being exposed to the fact that Fedora hosts
those images in a different location (and treats them as secondary
arches).  Those images are still "Fedora", and that's what users need
to know.

The better fix here would be one that only determines the location of
the images (`url_versions`) based on the architecture.  It would be
possible to do this here, maybe, by using a property for
`url_versions` instead.  But this breaks the general design of the
code and maybe some expectations.

This change chooses to defer that to a possibly more coprehensive
change in the ImageProviderBase class, making the more dynamic
evaluation standard or common.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's use a base class to avoid some of the duplicated code.  There's
the opportunity to clean up a lot more, but the way I see it, it'd
require changes to the base class interface.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Those distros provide images for aarch64, but call them arm64 instead.
Let's allow the use of either name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables checks for use of global statement (W0603).

There are some specific points using global currently. However, since
refactor these places is not simple enough, they was allower
specifically. This way we can isolate them and stop using global in
other future implementations.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NRyan Goodfellow <rgoodfel@isi.edu>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Based on the discussion, it makes sense to have individual tests for
bad and good requests, and also one that shares the state among bad
and good requests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables loads of pylint checks that do not require big code
changes.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

avocado crashed if user provide non exsting profiler
this patch address that , if profiler not avilable than
framework  handle gracefully handle
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

a instance variable

1-Rename pipe variable  to meaningful name
2-Above variable moved as in __init as it should
  instance variable
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Add __init__ constructor that can be hold instance variable
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

1-fixed pep8 issue
2- cleanup : changed compress_logf to compress_log in
Daemon and Command class as actual read param is compress_log
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

This addition to the utilities library facilitates the use of the
cloudinit features inside Linux OSs images for the cloud.

For now, it eases the creation of "cidata" ISOs, containing
configuration to cloud-init, and also a simple "phone home"
server.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change introduce AVOCADO_PARALLEL_LINT variable to
selftest/checkall script to make possible set the parallel lint
execution per environment.

Since currently the Travis CI is failing due lint parallel execution,
this change already sets AVOCADO_PARALLEL_LINT to 1 in Travis CI.

Reference: https://trello.com/c/LQ0szonHSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

There's a case where PyLint cannot deal well with raise without explicit
exception.  This change update one of this kind of occurence in Avocado
code base so lint can run successfully again.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

lsof is not an Avocado dependency, and is much harder to find on base
systems than mount, kill, etc.  Since this module pretty much revolves
around those utilities this does not propose major changes, trying to
adapt to the lack of mount, kill, etc.

This change makes it clear, through a PartitionError, when it's not
possible to run a forceful unmount due to the lack (or error) of lsof.
While at it, it refactors the methods that returns the list of PIDs
using lsof.

To be completely honest, there is still a broken expectation here: one
cannot assume that by sending a signal the process will be killed.
But, at least it is signalled by another PartitionError exception.

https://trello.com/c/DDUNPCBxSigned-off-by: NCleber Rosa <crosa@redhat.com>

There's a lot of common steps among the tests, and most of the
partition tests (there's only one exception so far) assume a
filesystem and mounted partition.

Let's consolidate the code into common classes and reuse that code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Using the builtin assertIsNone() method.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

This change enables W0150 (lost-exception) and W1645 (Exception.message
removed in Python 3) related to exception heandling.

This change also enables other checks that didn't require code changes
W0122, W0123, W0124, W0125.

Reference: https://trello.com/c/Ohh7Q6qjSigned-off-by: NCaio Carrara <ccarrara@redhat.com>

This method allows the creation of files inside a newly created ISO
file.

For now, the API is kept as simple as possible, and as such, there are
limitations involving creating directories (and files in other
directories than the root dir), mode for files, etc.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This method allows the creation of brand new ISO files, written to
disk at close() time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The goal is to make the opening of files separate from the
instantiation, because that will allow for the different "open"
approach of opening a new ISO file in write mode.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

So that users of the `iso9660` utility function can choose a backend
that matches specific requirements.

This is intended to be used to add create/write features to some
backends, that will allow the creation of ISO files, without mandating
all backends to be implement those.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The tests was done mocking the real output of `/proc/buddyinfo`. To make
it easier the process to get the buddy info content was extracted for a
specific function that actually only wraps the open call. This way we
can mock this function return only instead of try mock the builtin open
function.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>