The W0613 check for unnused arguments. The most of the current cases
seems legitmate so the proper flag was added in each line so pylint can
ignore it.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This pylint check makes sure the log message is not built in log
statement itself, but uses the proper argument from logger to do it
lazy.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The dependencies for selftests and CI execution was split in two
requirements files. It causes issues with libs being in different
versions when tests are executed locally and in CI environment. To
reduce theses issues and others the changes bellow was done.

All dependencies listed in requirements.txt are now specified only in
setup.py properly. This way we avoid duplications or missing
requirements that are necessary for avocado.

It also could be done keeping only requirements.txt file and loading it
in setup.py module. However, since avocado-framework have not clear use
case of requirements being installed via `pip install requirements.txt`,
it's better keep the dependencies only in setup module.

It was removed the requirements file only for CI purpose and
updates the requirements for selftest. This way we can have proper
dependencies installed when run selftests both in local or CI
environements.

The requirements-selftest was updated: Setuptools was removed since it's
already a dependency from avocado itself. Pep8 was removes since it's
already a dependecy from inspektor. Since we run lint checks by
inspektor it's better let it manage de pep8 (or pycodestyle) dependency
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

First of all, a disclaimer: this is hackish.  But, it's the simplest
and thus best fix I could think of.

What happens here is that this module makes no distintcion between
what is a base class "abstract" class, and a concrete class.  With the
goal of reducing code duplication, a goal that will remain valid here
and in other modules, it made sense to create a common Fedora class.

Now, because only being a ImageProviderBase suffices, the
FedoraImageProviderBase class, which is not intended to be used as a
concrete (final) class, is being carried along and its "name" is
checked, causing crashes.

This introduces the ad-hoc, hackish, notion, that a concrete
ImageProvider is one that contains a name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

While running avocado in ubuntu system distro.detect().name has output
"unknown".  This is probably due to the removal of StdLibProbe.  Let's
add a proper Ubuntu probe.  Before this:

    >>> distro.detect().version and distro.detect().release
    0
    >>> from avocado.utils import distro
    >>> distro.detect().name
    unknown
    >>> distro.detect().version
    0
    >>> distro.detect().release
    0

After this patch:

    >>> from avocado.utils import distro
    >>> print distro.detect().name
    Ubuntu
    >>> print distro.detect().version
    18
    >>> print distro.detect().release
    04
Reported-by: NKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The reason for this to exist was supposedly identify (inheritance)
checks, but none of these actually exist.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

To decode into the correct encoding and work properly across different
Python versions.

While at it, improve the docstring.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

To the relevant code block that can, for a reason we expect, raise
such exception.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current sysinfo end_test() hook is badly positioned, in a way that
it only gets called if no exception is raised (that is, tests end with
PASS).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Commit 5cb976a9 attempted to remove avocado-server from release test
plan, but forgot this one.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

If the AVOCADO variable starts with the Python interpreter, the
command that will be logged by Avocado needs to be adjusted.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

For upcoming release 64.0
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The MAKEFILE variable name is misleading, given that it holds the
location of a possible PLUGIN directory.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The testIdentity changed here was using assertTrue with a constant
instead of a conditional. So, to make lint pass it was updated to a more
appropriate assert.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This allows user to ask for a image for a "fedora" image on a "ppc64"
or "ppc64le" arch, without being exposed to the fact that Fedora hosts
those images in a different location (and treats them as secondary
arches).  Those images are still "Fedora", and that's what users need
to know.

The better fix here would be one that only determines the location of
the images (`url_versions`) based on the architecture.  It would be
possible to do this here, maybe, by using a property for
`url_versions` instead.  But this breaks the general design of the
code and maybe some expectations.

This change chooses to defer that to a possibly more coprehensive
change in the ImageProviderBase class, making the more dynamic
evaluation standard or common.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Let's use a base class to avoid some of the duplicated code.  There's
the opportunity to clean up a lot more, but the way I see it, it'd
require changes to the base class interface.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Those distros provide images for aarch64, but call them arm64 instead.
Let's allow the use of either name.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables checks for use of global statement (W0603).

There are some specific points using global currently. However, since
refactor these places is not simple enough, they was allower
specifically. This way we can isolate them and stop using global in
other future implementations.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NRyan Goodfellow <rgoodfel@isi.edu>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Based on the discussion, it makes sense to have individual tests for
bad and good requests, and also one that shares the state among bad
and good requests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This change enables loads of pylint checks that do not require big code
changes.
Signed-off-by: NCaio Carrara <ccarrara@redhat.com>