pep8 v2.3.0 introduced the check for bare except clause (E722). Until
now, we don't explicitly disable the pep8 check we don't want because
inspect has a default exclude list (E501, E265, W601 and E402).

Let's make explicit the exclude list for the checks we don't want in our
selftests, adding to the list the new E722 check.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The "make link" feature goes through subdirs trying to either use
`setup.py` or `Makefile` to install all plugins. The problem is that
even when `Makefile` is present it might not support `make link` target
which results in failure. This patch instead of failure in this case
just lists "FAIL" followed by the module name.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

contrib: Add script which helps bisecting avocado execution
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

This makes sure we setup and clean the environment before/after the
executed check. It comes from simple script I have been using for ages
and finally I took the time to add colors and some UI to allow running
on unstable environment.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Added '-' to regex which searches for pv name from the output
of 'pvs' command.
Signed-off-by: NNarasimhan V <sim@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Spelling fixes for the 45th release [v4]
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

This is a collection of docstring, literal string and the spelling
ignore list fixes for the 45th release.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Result returned by process.system_output() contains trailing
newline. To make it's functionality similar to Popen.communicate()
or commands.get_output() , the trailing newline needs to be stripped.
Added keyword parameter strip_trail_nl to preserve the trailing
newline if needed.

Also added comments in docstring for parameters sudo and
ignore_bg_processes
Signed-off-by: NGreeshma Gopinath <ggopinat@redhat.com>

The external runner tests currently do not support the extended API for
simple tests. This patch moves the extended API into the
`SimpleTest.execute_cmd` in order to run this from inherited tests like
ExternalRunner.

Note this version affects all tests which share the
`SimpleTest.execute_cmd`. I think it's a good think, but I'd be also
fine with implementing it as another SimpleTest method and call this
method from inherited tests where it makes sense (like ExternalRunner).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Those should really be ":param <parameter_name:".  The rendered text
for "parm" is readable, but it's not properly recognized as a
parameter.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The `avocado.utils.pci` library incorporates many functions related to
pcis and some functions accept only full pci address, some partial and
some only special format (domain+bus, ...). Let's explicitly distinguish
by using:

* pci_address - for any segment of pci address
* full_pci_address - for full pci address only
* dom_pci_address - for special usecase where domain is required
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `get_num_devices_in_domain` function reports all matches in
`/sys/class/*/$PCI`, which is not really a list of devices handled by
the $PCI, but it's a list of interfaces available to given device's
function.

This function supports partial matches, so it allows listing not just
one function's interfaces, but also one device/bus or even all
interfaces associated to pci domain, so let's be a bit more explicit
about the usage.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Makefile: adjust PyPI packaging/upload

Since we favor the creation of a tarball with "git archive", PyPI gets
sensitive every now and then with our uploads.  Since the 42.0
release, pushing the new packages to PyPI would result in Server
Errors.

This adds the PKG-INFO to the tarball that will be uploaded, which
seems to fix the current errors.  Also, since it's now a single file,
it can be pushed with the "twine" command line application.

Alternatively, we could double check our file manifest, and rely
entirely on setuptools to generate the tarball.  But, I'm not a big
fan of adding files to version control, and then to a manifest of any
sort.

Note: in the past, this was also necessary because of the tweaks to
the information inside the PKG-INFO file, namely the package name
(avocado -> avocado-framework).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Remove argument support for SIMPLE tests

To provide support for passing arguments for simple tests in command
line, we were creating some cases where the test reference could not be
properly handled. Also, for test references with white-spaces, we have
an inconsistent behavior. See reference.

This patch removes the support for arguments in test references,
restoring the proper behavior, which is expected to be shell-like.

As consequence, we now handle correctly white-spaces in tests references
as well as Unicode characters.

Reference: https://www.redhat.com/archives/avocado-devel/2016-November/msg00011.html
Reference: https://trello.com/c/bfE9NBblSigned-off-by: NAmador Pahim <apahim@redhat.com>

The signed-off-by check makes sure the latest commit contains correct
"Signed-off-by" message. As this check is executed per each commit in
travis, it should make sure all new commits contain this message which
is quite important as it states that the author agrees with the terms
from our contribution guide.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently we check the first commit differently, then all the other
commits. It was better as individual failures were distinguished by
colors. We added the support for colors to our "checkall" script making
the "make check" similarly synoptic so there is no need to treat the
first commit differently anymore.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  docs: make contribution licensing terms (DCO style) more explicit

Let's add the recommended (legal) language that will let our
contributors know what a "Signed-off-by" line means when sending
contributions to Avocado.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The default exception of `subprocess.Popen` does not contain any useful
info. We already replace the original exception for "File not found"
exception, this patch always modifies the exception's message to include
the executed command.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Let's add a check that teststmpdir is shared across different jobs when
set manually via environment variables. This also contains a little
improvement in one of the used tests.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "AVOCADO_TESTS_COMMON_TMPDIR" is an environmental variable name used
to store the location of a common tmpdir. To avoid issues with
typos/name changes let's use the variable in `avocado.core.test` to
share the env variable name everywhere.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The filtering is not useful for basic params, let's move it to mux and
while on it also remove the avocado arguments (options) to the
yaml_to_mux plugin.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `avocado.core.tree` contains multiplex/mux-related features like
multiplex and ctrl, which are not really useful for basic params. Let's
simplify the base tree object and put the extracted features in
`avocado.core.mux`.

This is a first step and the `avocado.core.mux` should contain most of
the generic parts useful for creating varianter plugins.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `_create_from_yaml` function allows specifying custom tree node
object, but it only works properly with `tree.TreeNode` inherited ones.
Let's use the custom class instead to make the code cope with different
use cases.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

For speed optimization we used to override the "data_inject" and
"data_merge" methods after parsing. Let's stop doing that as the check
should not be that costly and add a support for
`Varianter.ignore_new_data` attribute to allow ignoring new data on
parsed Varianter.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>