The reason being that `datadir` can then be properly documented as
first class citizens so that Test class users (test writers) can rely
on it.

Other reason is that that it can be overloaded by inherited classes
such as `SimpleTest`, without the need to (re-)set other attributes
that depend on it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The methods `record_reference_stdout`, `record_reference_stderr`
`check_reference_stdout` and `check_reference_stderr` are publicly
visible, but are not intended to be used by test writers and are
not intended to have API stability.

Let's rename them so that they're hidden from the Avocado test
writer.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Turns out that setting the argument value directly does not suit most
of our code. Let's revert back to the old way of setting the remote/vm
result/runner until we implement proper runner and result plugin interfaces.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

For parity of features with the remote plugin, let's add the SSH
port as an option of the VM plugin as well.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

the replay_parser is only needed during __init__, it does not need to
be stored in self.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When using replay, one can think of the replay_multiplex as of the
normal multiplex files, only it's already processed. This patch
stores the retrieved multiplex file (if not overridden) directly in
multiplex_files and adds support in avocado.core.job to handle this
situation.

Actually some future plugins might benefit from this and create their
own inherited Mux class instead of our multiplexer.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The replay_chdir is not useful for avocado.core, therefor it should
live within the replay plugin. Unless the user uses some incompatible
plugin which also changes the dir it should work.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "make link" target purpose is to help avocado developers to prepare
environment to run avocado from sources including all subprojects.
Nowadays it requires to run "setup.py develop" manually, but let's
assume wast majority of users of "make link" feature use "setup.py
develop --user" and call it automatically for each subproject (if they
support that).

This way simple "make link" prepares the environment to run avocado from
sources. It can also be used when new targets (plugins) are added
without the need to think which subproject needs to be updated.

NOTE: The subprojects are responsible to add the "python setup.py
develop --user" into the "link" and "unlink" targets.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

selftests/test_interrupt.py: Handle timing problems

avocado.tests Remove tests moved to avocado-misc-tests repo

In InterruptTest.test_well_behaved, sometimes it
takes a bit extra time for avocado to end, causing
a psutil.NoSuchProcess exception by the time the test
tries to access .cmdline() in the Process() object.

That condition means the process is already out of
the process list, which means the test passed. Let's
handle the NoSuchProcess exception accordingly.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

These tests were moved to
https://github.com/avocado-framework/avocado-misc-testsSigned-off-by: NAmador Pahim <apahim@redhat.com>

[V2] avocado.core.runner: Fix problems with exceptions that can't be pickled

I've noticed this when writing tests using the boto3 (Amazon
AWS) API - for some exceptions, not all the arguments of the
exception can be pickled, leading to the following crash:

    (1/2) scylla_longevity.py:LongevityTest.test_20_minutes: -
    Avocado crashed: TypeError: ('__init__() takes exactly 3 arguments (2 given)', <class 'botocore.exceptions.ClientError'>, ("An error occurred (InvalidAMIID.NotFound) when calling the RunInstances operation: The image id 'ami-20776841' does not exist",))
    Traceback (most recent call last):

     File "/home/lmr/Code/avocado.lmr/avocado/core/job.py", line 451, in _run
       timeout=self.timeout)

     File "/home/lmr/Code/avocado.lmr/avocado/core/runner.py", line 368, in run_suite
       deadline)

     File "/home/lmr/Code/avocado.lmr/avocado/core/runner.py", line 284, in run_test
       if test_status.interrupt:

     File "/home/lmr/Code/avocado.lmr/avocado/core/runner.py", line 82, in __getattribute__
       self._tick()

     File "/home/lmr/Code/avocado.lmr/avocado/core/runner.py", line 111, in _tick
       msg = self.queue.get()

     File "/usr/lib/python2.7/multiprocessing/queues.py", line 378, in get
       return recv()

    TypeError: ('__init__() takes exactly 3 arguments (2 given)', <class 'botocore.exceptions.ClientError'>, ("An error occurred (InvalidAMIID.NotFound) when calling the RunInstances operation: The image id 'ami-20776841' does not exist",))

    Please include the traceback info and command line used on your bug report
    Report bugs visiting https://github.com/avocado-framework/avocado/issues/new

Since we can't restore all the arguments of this exception
upon recv, we have to handle any exception that happens
here and break out from the _tick() loop.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Doccument the --replay option for the run command.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Basic functional tests for the job replay feature.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

job replay support using the run option "--replay "
implements the job replay, retrieving the original job urls, multiplex and
configuration.

The option "--replay-test-status " is fully functional,
allowing users to replay only the variants that faced a given status in
the original job.

To ignore some original job information, the option
"--replay-job-ignore " can be used.

Notice if can inform the urls and/or the multiplex using the command line.
The options informed in the command line will be used, making the replay job ignore
that information from the source job.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

avocado.plugins.wrapper: Check the --gdb-run-bin value

Make loader registration unique and make dispatcher propagate exceptions

The dispatcher classes weren't propagating exceptions when running
`map_method`, which is basically how the command line plugins methods
`configure` and `run` are called.

The dispatcher should not be silent about possible exceptions thrown
by plugin's `configure` and `run` methods, so let's fix that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

--gdb-run-bin is incompatible with --wrapper option. The original code
checked presence of "gdb_run_bin" in args, but it's always present with
default value `[]`. This patch changes the check to gettattr.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Long story short, after taking a look at:

https://github.com/avocado-framework/avocado-vt/issues/322

I noticed that, on purpose, the VirtTestLoader class would be registered
both by `avocado_vt/plugins/vt.py` and avocado_vt/plugins/vt_list.py`.
The reasoning is simply to keep plugins independent, without depending
on each other.

But, it turns out the registering the loader on both places doubles the
time it takes to find VT tests. Without this patch:

$ /usr/bin/time ./scripts/avocado list > /dev/null
9.52user 0.17system 0:09.68elapsed 100%CPU (0avgtext+0avgdata 189528maxresident)k
0inputs+3744outputs (0major+63564minor)pagefaults 0swaps

With this patch:

$ /usr/bin/time ./scripts/avocado list > /dev/null
5.47user 0.13system 0:05.60elapsed 100%CPU (0avgtext+0avgdata 145716maxresident)k
0inputs+1920outputs (0major+51958minor)pagefaults 0swaps
Signed-off-by: NCleber Rosa <crosa@redhat.com>

loader: make test methods unique when discovering tests [v2]

avocado.core.loader: Use sys.path.remove instead of pop

As per report on issue #952, Avocado currently finds multiple tests
when multiple test names exist in a given Python class. When the
test code itself is loaded and the test class instantiated, only
one test method will remain (others will have been overloaded by
that one).

So, to mimic this in the static, AST based, test discovery, let's
make the test methods unique and try to keep the order in which the
AST parser found them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's safer to use "remove" in case someone adjusted "sys.path".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

HTML output support: behave when the plugin is not installed

We're still pointing to the old repo location. Let's update that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

avocado.tests: Port aiostress from autotest [v2]

It looks like a lot of our users are also hackers and want to run
Avocado from source. Since version 0.31.0 this requires one additional
step. Let's properly and permanently document it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The previous text "please adapt to your platform" is enough.
Signed-off-by: NCleber Rosa <crosa@redhat.com>