And not a directory.  Tests were being always skipped becaused of that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The directory check is being performed, but without value to the test.
Let's turn it into an assertion.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  SIMPLE tests: improve status API

Currently simple tests have a limited status API, being able to set only
the WARN status by generating an output string in a very specific and
hard-coded format.

This patch, while respects the current behaviour, creates configuration
keys, allowing users to provide regular expressions to search for in the
test outputs, aiming to set the final test status to either WARN or SKIP
when the test finishes with exit code 0.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Success rate to use the following formula:

    ( PASS + WARN ) / ( TOTAL - SKIP - CANCEL ) * 100
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The commit 3a66bcbf is causing the
"selftests.functional.test_basic.RunnerOperationTest.test_read" selftest
to fail.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Whiteboard was (probably accidentally) removed from the test attributes.
This patch recreates the whiteboard.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's a difference on how Python 2 and 3 represents a set(), which is true
for the set derived FilterSet.  It just happens the a tree fingerprint
depends on its environment, which depends on the FilterSet representation.

Let's provide a predictive __repr__ implementation, and consequently, a
predictive fingerprint for Trees across Python versions.

This fixes the following unittest failure on Python 3:

   FAIL: test_fingerprint (selftests.unit.test_tree.TreeNode)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/home/cleber/src/avocado/avocado/selftests/unit/test_tree.py", line 63, in test_fingerprint
       "/foo{},{},FilterSet([]),FilterSet([])")
   AssertionError: '/foo{},{},FilterSet(),FilterSet()' != '/foo{},{},FilterSet([]),FilterSet([])'
   - /foo{},{},FilterSet(),FilterSet()
   + /foo{},{},FilterSet([]),FilterSet([])
   ?                     ++            ++
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The YAML Test Loader is sending the messages for the UI. They
should go to the Job Log instead.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Count WARN in to calculate the success rate in the HTML report.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Add support to provide input with subprocess.Popen's stdin.write
method. Optionally flush the input buffer.
Signed-off-by: NHarish <harish@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Recently we introduced "in-package-config" which is packaged by default
with Avocado and in the original version if exists the system-wide
config is not used at all. I think this is unexpected behavior as users
are used to set configs in /etc so this patch changes it to first use
in-package-config, then in-etc-config and last the user-config.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Unless a lower version is set as a requirement, the RPM building
process will attempt to download from PyPI, which is not allowed.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

In case no suitable jobdir location can be created (user basically can't
write anywhere) Avocado crashes without a meaningful message, let's
provide one.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The user-config location ("~/.config/avocado.conf") might not be
writable by users (usually when executing in docker without user
home-dir). Let's use the file if available, but don't fail in case we
fail to produce it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Some tweaks here and there found during the upkeep.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The remote execution is an optional plugin, let's just mention the ways
and link the description to the remote_runners there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Add the description of the recent changes of Avocado packaging to
LTS.next documentation.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

With the recent changes the "libexec" dir is only available when
installed via RPM. In order to have "libexec" files available
as standard package we have to include it in  the package_files
dir (avocado/). The benefit is that we can actually use package
resources to get the location in "avocado exec-path" command.

For packaging purposes let's simply symlink $libexec/avocado to the
packaged $avocado/libexec location so there is the usual location, but
keep using the python-location by default.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

With the python3 patches we have another core dependency on six. Let's
include it in setup.py as without it Avocado is unusable.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In case on of the first cleanups fails the following ones are not
performed, leaving uncleaned files. Lets perform always all steps and
then check for occurred errors.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

PEP461 is only available on Python 3.5.  Our CI (Travis) is set to run
on Python 3.4, and there's no reason not to be compatible with those
older Python versions IMO.

Let's then use a syntax that will produce the same content, but will
work on all Python 3.x versions.

Reference: https://docs.python.org/3.5/whatsnew/3.5.htmlSigned-off-by: NCleber Rosa <crosa@redhat.com>